Attention is currently required from: Nick Vaccaro, Subrata Banik, Weimin Wu.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79730?usp=email )
Change subject: mb/google/nissa/var/anraggar: add hook for WiFi SAR table
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/google/brya/variants/anraggar/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/79730/comment/055c62b4_992ac7ae :
PS3, Line 8: ramstage-y += variant.c
Check that files end with a single newline (lint-extended-015-final-newlines): src/mainboard/google/brya/variants/anraggar/Makefile.inc has no final newline.
test failed
--
To view, visit https://review.coreboot.org/c/coreboot/+/79730?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Idb200699bb8c8581b9512ec8ec9442f65f8822b3
Gerrit-Change-Number: 79730
Gerrit-PatchSet: 3
Gerrit-Owner: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com>
Gerrit-CC: Tao Yang <yangtao6(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Comment-Date: Tue, 26 Dec 2023 10:57:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Eric Lai, Nick Vaccaro, Subrata Banik, Weimin Wu.
Jianeng Ceng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79730?usp=email )
Change subject: mb/google/nissa/var/anraggar: add hook for WiFi SAR table
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/79730/comment/5f24b66d_f9646c9d :
PS2, Line 7: brya
> your reference is nissa right? please check with Weimin Wu
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/79730?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Idb200699bb8c8581b9512ec8ec9442f65f8822b3
Gerrit-Change-Number: 79730
Gerrit-PatchSet: 3
Gerrit-Owner: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com>
Gerrit-CC: Tao Yang <yangtao6(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Comment-Date: Tue, 26 Dec 2023 09:18:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai <ericllai(a)google.com>
Comment-In-Reply-To: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com>
Gerrit-MessageType: comment
Attention is currently required from: Nick Vaccaro, Subrata Banik, Weimin Wu.
Hello Eric Lai, Jianeng Ceng, Nick Vaccaro, Subrata Banik, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/79730?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Code-Review+1 by Jianeng Ceng, Verified-1 by build bot (Jenkins)
Change subject: mb/google/nissa/var/anraggar: add hook for WiFi SAR table
......................................................................
mb/google/nissa/var/anraggar: add hook for WiFi SAR table
As a preparation for WiFi SAR table addition, adding hook for it.
BRANCH=nissa
BUG=b:315418153
TEST=emerge-nissa coreboot
Change-Id: Idb200699bb8c8581b9512ec8ec9442f65f8822b3
Signed-off-by: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com>
---
M src/mainboard/google/brya/Kconfig
M src/mainboard/google/brya/variants/anraggar/Makefile.inc
A src/mainboard/google/brya/variants/anraggar/variant.c
3 files changed, 11 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/79730/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/79730?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Idb200699bb8c8581b9512ec8ec9442f65f8822b3
Gerrit-Change-Number: 79730
Gerrit-PatchSet: 3
Gerrit-Owner: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com>
Gerrit-CC: Tao Yang <yangtao6(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Jianeng Ceng, Nick Vaccaro, Subrata Banik, Weimin Wu.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79730?usp=email )
Change subject: mb/google/brya/var/anraggar: add hook for WiFi SAR table
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/79730/comment/a26d454b_c58272ba :
PS2, Line 7: brya
> `brya` should be correct, please double check.
your reference is nissa right? please check with Weimin Wu
--
To view, visit https://review.coreboot.org/c/coreboot/+/79730?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Idb200699bb8c8581b9512ec8ec9442f65f8822b3
Gerrit-Change-Number: 79730
Gerrit-PatchSet: 2
Gerrit-Owner: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Tao Yang <yangtao6(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com>
Gerrit-Comment-Date: Tue, 26 Dec 2023 09:13:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai <ericllai(a)google.com>
Comment-In-Reply-To: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com>
Gerrit-MessageType: comment
Attention is currently required from: Eric Lai, Nick Vaccaro, Subrata Banik, Weimin Wu.
Jianeng Ceng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79730?usp=email )
Change subject: mb/google/brya/var/anraggar: add hook for WiFi SAR table
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/79730/comment/edae5fea_a1b31824 :
PS2, Line 7: brya
> nissa
`brya` should be correct, please double check.
--
To view, visit https://review.coreboot.org/c/coreboot/+/79730?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Idb200699bb8c8581b9512ec8ec9442f65f8822b3
Gerrit-Change-Number: 79730
Gerrit-PatchSet: 2
Gerrit-Owner: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Tao Yang <yangtao6(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Comment-Date: Tue, 26 Dec 2023 09:12:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai <ericllai(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Nick Vaccaro, Subrata Banik, Weimin Wu.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79730?usp=email )
Change subject: mb/google/brya/var/anraggar: add hook for WiFi SAR table
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/79730/comment/73f6b8a1_c5ddcc37 :
PS2, Line 7: brya
nissa
--
To view, visit https://review.coreboot.org/c/coreboot/+/79730?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Idb200699bb8c8581b9512ec8ec9442f65f8822b3
Gerrit-Change-Number: 79730
Gerrit-PatchSet: 2
Gerrit-Owner: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Tao Yang <yangtao6(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Comment-Date: Tue, 26 Dec 2023 08:54:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Nick Vaccaro, Subrata Banik, Weimin Wu.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79730?usp=email )
Change subject: mb/google/brya/var/anraggar: add hook for WiFi SAR table
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/brya/variants/anraggar/variant.c:
https://review.coreboot.org/c/coreboot/+/79730/comment/9aad31cb_f23985d1 :
PS2, Line 7: return "wifi_sar_2.hex";
add tab
--
To view, visit https://review.coreboot.org/c/coreboot/+/79730?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Idb200699bb8c8581b9512ec8ec9442f65f8822b3
Gerrit-Change-Number: 79730
Gerrit-PatchSet: 2
Gerrit-Owner: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Tao Yang <yangtao6(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Comment-Date: Tue, 26 Dec 2023 08:53:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Eric Lai, Nick Vaccaro, Subrata Banik, Weimin Wu.
Jianeng Ceng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79730?usp=email )
Change subject: mb/google/brya/var/anraggar: add hook for WiFi SAR table
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/79730?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Idb200699bb8c8581b9512ec8ec9442f65f8822b3
Gerrit-Change-Number: 79730
Gerrit-PatchSet: 2
Gerrit-Owner: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Tao Yang <yangtao6(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Comment-Date: Tue, 26 Dec 2023 08:47:46 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Eric Lai, Nick Vaccaro, Subrata Banik, Weimin Wu.
Hello Eric Lai, Jianeng Ceng, Nick Vaccaro, Subrata Banik, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/79730?usp=email
to look at the new patch set (#2).
Change subject: mb/google/brya/var/anraggar: add hook for WiFi SAR table
......................................................................
mb/google/brya/var/anraggar: add hook for WiFi SAR table
As a preparation for WiFi SAR table addition, adding hook for it.
BRANCH=nissa
BUG=b:315418153
TEST=emerge-nissa coreboot
Change-Id: Idb200699bb8c8581b9512ec8ec9442f65f8822b3
Signed-off-by: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com>
---
M src/mainboard/google/brya/Kconfig
M src/mainboard/google/brya/variants/anraggar/Makefile.inc
A src/mainboard/google/brya/variants/anraggar/variant.c
3 files changed, 11 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/79730/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/79730?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Idb200699bb8c8581b9512ec8ec9442f65f8822b3
Gerrit-Change-Number: 79730
Gerrit-PatchSet: 2
Gerrit-Owner: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com>
Gerrit-CC: Tao Yang <yangtao6(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-MessageType: newpatchset