coreboot-gerrit December 2023

coreboot-gerrit@coreboot.org

1 participants
2354 discussions

[XS] Change in coreboot[main]: inteltool/gpio_names/cannonlake.h: Add SPDX license header
by Nicholas Chin (Code Review) 02 Dec '23

02 Dec '23

Nicholas Chin has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/78629?usp=email ) Change subject: inteltool/gpio_names/cannonlake.h: Add SPDX license header ...................................................................... Abandoned Squashed into CB:78628 -- To view, visit https://review.coreboot.org/c/coreboot/+/78629?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I71410bc592edf9b1098041feaced6744b24136e8 Gerrit-Change-Number: 78629 Gerrit-PatchSet: 1 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[S] Change in coreboot[main]: inteltool/gpio_names/*.h: Add GPL-2.0-only SPDX license header
by Nicholas Chin (Code Review) 02 Dec '23

02 Dec '23

Attention is currently required from: Alexander Couzens, Felix Singer, Martin L Roth, Pratikkumar V Prajapati, Stefan Reinauer. Nicholas Chin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78628?usp=email ) Change subject: inteltool/gpio_names/*.h: Add GPL-2.0-only SPDX license header ...................................................................... Patch Set 2: (2 comments) Patchset: PS1: > In that case I probably could add the rest of the header files? This patch train (which I'll squash) […] Done PS1: > These header files were each added in separate commits originally, and I had made a commit for each […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/78628?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie897cb238c0c9e89fe677c999cbf1803f5f4609a Gerrit-Change-Number: 78628 Gerrit-PatchSet: 2 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Attention: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Comment-Date: Sat, 02 Dec 2023 05:37:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Comment-In-Reply-To: Martin L Roth <gaumless(a)gmail.com> Comment-In-Reply-To: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: inteltool/gpio_names/*.h: Add GPL-2.0-only SPDX license header
by Nicholas Chin (Code Review) 02 Dec '23

02 Dec '23

Attention is currently required from: Alexander Couzens, Felix Singer, Martin L Roth, Stefan Reinauer. Hello Alexander Couzens, Felix Singer, Martin L Roth, Stefan Reinauer, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/78628?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by Alexander Couzens, Code-Review+1 by Felix Singer, Code-Review+1 by Martin L Roth, Verified+1 by build bot (Jenkins) Change subject: inteltool/gpio_names/*.h: Add GPL-2.0-only SPDX license header ...................................................................... inteltool/gpio_names/*.h: Add GPL-2.0-only SPDX license header Inteltool is GPLv2 licensed so all files that link to it should be GPLv2 by default. In addition, the contents of several of these headers were originally moved directly from gpio_groups.c, which is explicitly marked as GPL-2.0-only. Change-Id: Ie897cb238c0c9e89fe677c999cbf1803f5f4609a Signed-off-by: Nicholas Chin <nic.c3.14(a)gmail.com> --- M util/inteltool/gpio_names/alderlake_h.h M util/inteltool/gpio_names/alderlake_p.h M util/inteltool/gpio_names/apollolake.h M util/inteltool/gpio_names/cannonlake.h M util/inteltool/gpio_names/cannonlake_lp.h M util/inteltool/gpio_names/denverton.h M util/inteltool/gpio_names/elkhartlake.h M util/inteltool/gpio_names/emmitsburg.h M util/inteltool/gpio_names/geminilake.h M util/inteltool/gpio_names/gpio_groups.h M util/inteltool/gpio_names/icelake.h M util/inteltool/gpio_names/lewisburg.h M util/inteltool/gpio_names/sunrise.h 13 files changed, 39 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/78628/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/78628?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie897cb238c0c9e89fe677c999cbf1803f5f4609a Gerrit-Change-Number: 78628 Gerrit-PatchSet: 2 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-MessageType: newpatchset

1 0

[NoOp] Change in coreboot[main]: util/docker/alpine: Rename Dockerfile to Dockerfile.base
by Felix Singer (Code Review) 02 Dec '23

02 Dec '23

Attention is currently required from: Martin L Roth. Hello Martin L Roth, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/79362?usp=email to look at the new patch set (#3). Change subject: util/docker/alpine: Rename Dockerfile to Dockerfile.base ...................................................................... util/docker/alpine: Rename Dockerfile to Dockerfile.base Rename Dockerfile to Dockerfile.base since additional Dockerfiles basing on this one will be added later. Change-Id: I611feca234ae7600f9c17ae397f9f3903879c057 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- R util/docker/alpine/Dockerfile.base 1 file changed, 0 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/79362/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/79362?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I611feca234ae7600f9c17ae397f9f3903879c057 Gerrit-Change-Number: 79362 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[main]: util/docker/fedora: Add Dockerfile.base
by Felix Singer (Code Review) 02 Dec '23

02 Dec '23

Attention is currently required from: Martin L Roth. Hello Martin L Roth, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/79316?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: util/docker/fedora: Add Dockerfile.base ...................................................................... util/docker/fedora: Add Dockerfile.base Following commands were used to test if everything builds: * make crossgcc * make clang * make what-jenkins-does Change-Id: I8d04c570f91215f534f173db2ae559b64b58012f Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- A util/docker/fedora/Dockerfile.base 1 file changed, 41 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/79316/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/79316?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8d04c570f91215f534f173db2ae559b64b58012f Gerrit-Change-Number: 79316 Gerrit-PatchSet: 5 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[main]: util/docker/rocky: Add Dockerfile.base
by Felix Singer (Code Review) 02 Dec '23

02 Dec '23

Attention is currently required from: Martin L Roth. Hello Martin L Roth, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/79384?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: util/docker/rocky: Add Dockerfile.base ...................................................................... util/docker/rocky: Add Dockerfile.base Following commands were used to test if everything builds: * make crossgcc * make clang * make what-jenkins-does Change-Id: I60e00932332801c0f62d88b7860afb330d9469e4 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- A util/docker/rocky/Dockerfile.9.base 1 file changed, 47 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/79384/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/79384?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I60e00932332801c0f62d88b7860afb330d9469e4 Gerrit-Change-Number: 79384 Gerrit-PatchSet: 5 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[main]: util/docker/rocky: Add Dockerfile.base
by Felix Singer (Code Review) 02 Dec '23

02 Dec '23

Attention is currently required from: Martin L Roth. Hello Martin L Roth, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/79384?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: util/docker/rocky: Add Dockerfile.base ...................................................................... util/docker/rocky: Add Dockerfile.base Following commands were used to test if everything builds: * make crossgcc * make clang * make what-jenkins-does Change-Id: I60e00932332801c0f62d88b7860afb330d9469e4 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- A util/docker/rocky/Dockerfile.9.base 1 file changed, 44 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/79384/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/79384?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I60e00932332801c0f62d88b7860afb330d9469e4 Gerrit-Change-Number: 79384 Gerrit-PatchSet: 4 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[main]: mb/google/rex: Set EPP to 45%
by Bora Guvendik (Code Review) 02 Dec '23

02 Dec '23

Bora Guvendik has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/79204?usp=email ) Change subject: mb/google/rex: Set EPP to 45% ...................................................................... Abandoned Sukumar pushed https://review.coreboot.org/c/coreboot/+/79386 -- To view, visit https://review.coreboot.org/c/coreboot/+/79204?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia420e8b6bed252a8a1f59d36a4a71c2b8ec9524e Gerrit-Change-Number: 79204 Gerrit-PatchSet: 1 Gerrit-Owner: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: abandon

1 0

[XS] Change in coreboot[main]: mb/google/{rex,ovis}: epp set to 45% for mtl performance expectation
by Sukumar Ghorai (Code Review) 01 Dec '23

01 Dec '23

Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Kapil Porwal, Subrata Banik, Tarun. Hello Dinesh Gehlot, Eran Mitrani, Kapil Porwal, Subrata Banik, Tarun, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/79386?usp=email to look at the new patch set (#2). Change subject: mb/google/{rex,ovis}: epp set to 45% for mtl performance expectation ...................................................................... mb/google/{rex,ovis}: epp set to 45% for mtl performance expectation The default EPP is set at 50%, which is deemed insufficiently aggressive for meeting the MTL performance expectations in balance_performance mode. #cat /sys/devices/system/cpu/cpu0/cpufreq/energy_performance_preference balance_performance # iotools rdmsr 0 0x774 0x0000000080003f06 EPP=45% is giving the required performance in MTL. Change-Id: I1953994cdb4e9363fdd4b4728e3e5236276c06c8 Signed-off-by: Sukumar Ghorai <sukumar.ghorai(a)intel.com> --- M src/mainboard/google/rex/variants/baseboard/ovis/devicetree.cb M src/mainboard/google/rex/variants/baseboard/rex/devicetree.cb 2 files changed, 8 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/79386/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/79386?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1953994cdb4e9363fdd4b4728e3e5236276c06c8 Gerrit-Change-Number: 79386 Gerrit-PatchSet: 2 Gerrit-Owner: Sukumar Ghorai <sukumar.ghorai(a)intel.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[main]: mb/google/{rex,ovis}: epp set to 45% for mtl performance expectation
by Sukumar Ghorai (Code Review) 01 Dec '23

01 Dec '23

Sukumar Ghorai has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/79386?usp=email ) Change subject: mb/google/{rex,ovis}: epp set to 45% for mtl performance expectation ...................................................................... mb/google/{rex,ovis}: epp set to 45% for mtl performance expectation Default EPP is 50% and is not aggressive enough for MTL performance expectation in balance_performance mode. /sys/devices/system/cpu/cpu0/cpufreq/energy_performance_preference balance_performance # iotools rdmsr 0 0x774 0x0000000080003f06 EPP=45% is giving the required performance in MTL. Change-Id: I1953994cdb4e9363fdd4b4728e3e5236276c06c8 Signed-off-by: Sukumar Ghorai <sukumar.ghorai(a)intel.com> --- M src/mainboard/google/rex/variants/baseboard/ovis/devicetree.cb M src/mainboard/google/rex/variants/baseboard/rex/devicetree.cb 2 files changed, 8 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/79386/1 diff --git a/src/mainboard/google/rex/variants/baseboard/ovis/devicetree.cb b/src/mainboard/google/rex/variants/baseboard/ovis/devicetree.cb index 3f75b70..aace5ad 100644 --- a/src/mainboard/google/rex/variants/baseboard/ovis/devicetree.cb +++ b/src/mainboard/google/rex/variants/baseboard/ovis/devicetree.cb @@ -65,6 +65,10 @@ register "sagv_freq_mhz[3]" = "6400" register "sagv_gear[3]" = "4" + # set EPP to 45%: 45 * 256/100 = 115 = 0x73 + register "enable_energy_perf_pref" = "true" + register "energy_perf_pref_value" = "0x73" + # Set on-board graphics as primary display register "skip_ext_gfx_scan" = "1" diff --git a/src/mainboard/google/rex/variants/baseboard/rex/devicetree.cb b/src/mainboard/google/rex/variants/baseboard/rex/devicetree.cb index 162bb64..9f86840 100644 --- a/src/mainboard/google/rex/variants/baseboard/rex/devicetree.cb +++ b/src/mainboard/google/rex/variants/baseboard/rex/devicetree.cb @@ -62,6 +62,10 @@ register "sagv_freq_mhz[3]" = "6400" register "sagv_gear[3]" = "4" + # set EPP to 45%: 45 * 256/100 = 115 = 0x73 + register "enable_energy_perf_pref" = "true" + register "energy_perf_pref_value" = "0x73" + # Set on-board graphics as primary display register "skip_ext_gfx_scan" = "1" -- To view, visit https://review.coreboot.org/c/coreboot/+/79386?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1953994cdb4e9363fdd4b4728e3e5236276c06c8 Gerrit-Change-Number: 79386 Gerrit-PatchSet: 1 Gerrit-Owner: Sukumar Ghorai <sukumar.ghorai(a)intel.com> Gerrit-MessageType: newchange

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2023