coreboot-gerrit December 2023

coreboot-gerrit@coreboot.org

1 participants
2354 discussions

[XS] Change in coreboot[main]: mb/google/{rex,ovis}: epp set to 45% for mtl performance expectation
by Sukumar Ghorai (Code Review) 02 Dec '23

02 Dec '23

Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Kapil Porwal, Paul Menzel, Subrata Banik, Tarun. Sukumar Ghorai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79386?usp=email ) Change subject: mb/google/{rex,ovis}: epp set to 45% for mtl performance expectation ...................................................................... Patch Set 3: (5 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/79386/comment/08baf12b_d772c50c : PS3, Line 7: epp set to 45% for mtl performance expectation > Maybe: […] Acknowledged https://review.coreboot.org/c/coreboot/+/79386/comment/fddaad2c_504b0f3e : PS3, Line 9: which is deemed insufficiently : aggressive for meeting the MTL performance expectations in : balance_performance mode. > According to whom? Also, what does that mean exactly? It’s drawing too much power? EPP=45% is giving the required performance with very minimum power impact. This is revirewd internally. https://review.coreboot.org/c/coreboot/+/79386/comment/3815807a_5033ee73 : PS3, Line 12: #cat > Please add a space after #. Acknowledged https://review.coreboot.org/c/coreboot/+/79386/comment/308705b4_9600c9ef : PS3, Line 11: balance_performance mode. : #cat /sys/devices/system/cpu/cpu0/cpufreq/energy_performance_preference : balance_performance : # iotools rdmsr 0 0x774 : 0x0000000080003f06 : EPP=45% is giving the required performance in MTL. > I’d follow Markdown and intend code blocks with four spaces. […] Acknowledged https://review.coreboot.org/c/coreboot/+/79386/comment/4f2258ce_9360fa47 : PS3, Line 20: # iotools rdmsr 0 0x774 : 0x0000000073003d06 > How can the value be interpreted? Details as in Intel® 64 and IA-32 Architectures Software Developer’s Manual Volume 4: Model-Specific Registers. Also mentioned in patch - here is snapshot: set EPP to 45%: 45 * 256/100 = 115 = 0x73 MSR 0x774 IA32_HWP_REQUEST [31:24] Energy/Performance Preference (R/W) -- To view, visit https://review.coreboot.org/c/coreboot/+/79386?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1953994cdb4e9363fdd4b4728e3e5236276c06c8 Gerrit-Change-Number: 79386 Gerrit-PatchSet: 3 Gerrit-Owner: Sukumar Ghorai <sukumar.ghorai(a)intel.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Sat, 02 Dec 2023 08:09:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: inteltool/gpio_names/*.h: Add GPL-2.0-only SPDX license header
by Felix Singer (Code Review) 02 Dec '23

02 Dec '23

Attention is currently required from: Alexander Couzens, Martin L Roth, Nicholas Chin, Pratikkumar V Prajapati, Stefan Reinauer. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78628?usp=email ) Change subject: inteltool/gpio_names/*.h: Add GPL-2.0-only SPDX license header ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/78628?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie897cb238c0c9e89fe677c999cbf1803f5f4609a Gerrit-Change-Number: 78628 Gerrit-PatchSet: 4 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Attention: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Comment-Date: Sat, 02 Dec 2023 07:59:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: inteltool/gpio_names/*.h: Add GPL-2.0-only SPDX license header
by Nicholas Chin (Code Review) 02 Dec '23

02 Dec '23

Attention is currently required from: Alexander Couzens, Felix Singer, Martin L Roth, Pratikkumar V Prajapati, Stefan Reinauer. Nicholas Chin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78628?usp=email ) Change subject: inteltool/gpio_names/*.h: Add GPL-2.0-only SPDX license header ...................................................................... Patch Set 4: (3 comments) File util/inteltool/gpio_names/icelake.h: https://review.coreboot.org/c/coreboot/+/78628/comment/88cd8c3b_30689e10 : PS3, Line 1: /* inteltool - dump all registers on an Intel CPU + chipset based system */ > here as well Done File util/inteltool/gpio_names/lewisburg.h: https://review.coreboot.org/c/coreboot/+/78628/comment/5a9abd15_e2f5ee3a : PS3, Line 1: /* inteltool - dump all registers on an Intel CPU + chipset based system */ > here as well Done File util/inteltool/gpio_names/sunrise.h: https://review.coreboot.org/c/coreboot/+/78628/comment/400c50b1_27dabae6 : PS3, Line 1: /* inteltool - dump all registers on an Intel CPU + chipset based system */ > missed that Seems like `vim -p *.h` hit a tab limit when I removed those from the other files. I also seemed to have missed adding a header to a few files for the same reason. Fixed. -- To view, visit https://review.coreboot.org/c/coreboot/+/78628?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie897cb238c0c9e89fe677c999cbf1803f5f4609a Gerrit-Change-Number: 78628 Gerrit-PatchSet: 4 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Attention: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Comment-Date: Sat, 02 Dec 2023 07:57:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: inteltool/gpio_names/*.h: Add GPL-2.0-only SPDX license header
by Nicholas Chin (Code Review) 02 Dec '23

02 Dec '23

Attention is currently required from: Alexander Couzens, Felix Singer, Martin L Roth, Nicholas Chin, Pratikkumar V Prajapati, Stefan Reinauer. Hello Alexander Couzens, Felix Singer, Martin L Roth, Pratikkumar V Prajapati, Stefan Reinauer, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/78628?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Code-Review+2 by Felix Singer, Verified+1 by build bot (Jenkins) Change subject: inteltool/gpio_names/*.h: Add GPL-2.0-only SPDX license header ...................................................................... inteltool/gpio_names/*.h: Add GPL-2.0-only SPDX license header Inteltool is GPLv2 licensed so all files that link to it should be GPLv2 by default. In addition, the contents of several of these headers were originally moved directly from gpio_groups.c, which is explicitly marked as GPL-2.0-only. Change-Id: Ie897cb238c0c9e89fe677c999cbf1803f5f4609a Signed-off-by: Nicholas Chin <nic.c3.14(a)gmail.com> --- M util/inteltool/gpio_names/alderlake_h.h M util/inteltool/gpio_names/alderlake_p.h M util/inteltool/gpio_names/apollolake.h M util/inteltool/gpio_names/cannonlake.h M util/inteltool/gpio_names/cannonlake_lp.h M util/inteltool/gpio_names/denverton.h M util/inteltool/gpio_names/elkhartlake.h M util/inteltool/gpio_names/emmitsburg.h M util/inteltool/gpio_names/geminilake.h M util/inteltool/gpio_names/gpio_groups.h M util/inteltool/gpio_names/icelake.h M util/inteltool/gpio_names/jasperlake.h M util/inteltool/gpio_names/lewisburg.h M util/inteltool/gpio_names/sunrise.h M util/inteltool/gpio_names/tigerlake.h 15 files changed, 30 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/78628/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/78628?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie897cb238c0c9e89fe677c999cbf1803f5f4609a Gerrit-Change-Number: 78628 Gerrit-PatchSet: 4 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Attention: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[main]: mb/google/rex/var/ovis: Add power limit support for MCH ID 0x7d14
by Stefan Reinauer (Code Review) 02 Dec '23

02 Dec '23

Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Paul Menzel, Subrata Banik, Tarun. Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79332?usp=email ) Change subject: mb/google/rex/var/ovis: Add power limit support for MCH ID 0x7d14 ...................................................................... Patch Set 4: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/79332/comment/879d5223_ba5fc0cd : PS4, Line 10: 0x7d14 DID. > Maybe mention it’s identical to PCI_DID_INTEL_MTL_P_ID_1. . -- To view, visit https://review.coreboot.org/c/coreboot/+/79332?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iff71adb4e26d18970b5947927c258419f751de32 Gerrit-Change-Number: 79332 Gerrit-PatchSet: 4 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Sat, 02 Dec 2023 07:51:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/google/rex/var/ovis: Add power limit support for MCH ID 0x7d14
by Stefan Reinauer (Code Review) 02 Dec '23

02 Dec '23

Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Subrata Banik, Tarun. Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79332?usp=email ) Change subject: mb/google/rex/var/ovis: Add power limit support for MCH ID 0x7d14 ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/79332?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iff71adb4e26d18970b5947927c258419f751de32 Gerrit-Change-Number: 79332 Gerrit-PatchSet: 4 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Sat, 02 Dec 2023 07:49:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/google/nissa/var/anraggar: Fix the GPP_D6 for LTE power.
by Felix Singer (Code Review) 02 Dec '23

02 Dec '23

Attention is currently required from: Weimin Wu. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79166?usp=email ) Change subject: mb/google/nissa/var/anraggar: Fix the GPP_D6 for LTE power. ...................................................................... Patch Set 9: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/79166/comment/625f7427_a8b0e996 : PS8, Line 6: > Please do not ignore such comments next time. […] Didn't we have a linter for that? -- To view, visit https://review.coreboot.org/c/coreboot/+/79166?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2996fd35c2897269997bc0290e0ce93bbbaa1bf8 Gerrit-Change-Number: 79166 Gerrit-PatchSet: 9 Gerrit-Owner: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Sat, 02 Dec 2023 07:48:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/google/{rex,ovis}: epp set to 45% for mtl performance expectation
by Paul Menzel (Code Review) 02 Dec '23

02 Dec '23

Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Kapil Porwal, Subrata Banik, Sukumar Ghorai, Tarun. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79386?usp=email ) Change subject: mb/google/{rex,ovis}: epp set to 45% for mtl performance expectation ...................................................................... Patch Set 3: (5 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/79386/comment/2b429b5b_d96c5573 : PS3, Line 7: epp set to 45% for mtl performance expectation Maybe: > Decrease EPP to 45 % for MTL performance expectation https://review.coreboot.org/c/coreboot/+/79386/comment/e51023fb_a398e364 : PS3, Line 9: which is deemed insufficiently : aggressive for meeting the MTL performance expectations in : balance_performance mode. According to whom? Also, what does that mean exactly? It’s drawing too much power? https://review.coreboot.org/c/coreboot/+/79386/comment/46909162_acee6072 : PS3, Line 12: #cat Please add a space after #. https://review.coreboot.org/c/coreboot/+/79386/comment/18ffa3d2_a755e492 : PS3, Line 11: balance_performance mode. : #cat /sys/devices/system/cpu/cpu0/cpufreq/energy_performance_preference : balance_performance : # iotools rdmsr 0 0x774 : 0x0000000080003f06 : EPP=45% is giving the required performance in MTL. I’d follow Markdown and intend code blocks with four spaces. (And also add blank lines around the block.) https://review.coreboot.org/c/coreboot/+/79386/comment/f3d5ff83_f9f51e09 : PS3, Line 20: # iotools rdmsr 0 0x774 : 0x0000000073003d06 How can the value be interpreted? -- To view, visit https://review.coreboot.org/c/coreboot/+/79386?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1953994cdb4e9363fdd4b4728e3e5236276c06c8 Gerrit-Change-Number: 79386 Gerrit-PatchSet: 3 Gerrit-Owner: Sukumar Ghorai <sukumar.ghorai(a)intel.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Sukumar Ghorai <sukumar.ghorai(a)intel.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Sat, 02 Dec 2023 07:47:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/google/nissa/var/anraggar: Fix the GPP_D6 for LTE power.
by Paul Menzel (Code Review) 02 Dec '23

02 Dec '23

Attention is currently required from: Weimin Wu. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79166?usp=email ) Change subject: mb/google/nissa/var/anraggar: Fix the GPP_D6 for LTE power. ...................................................................... Patch Set 9: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/79166/comment/00af2d65_80e955b1 : PS8, Line 6: Please do not ignore such comments next time. > `Subject line should not end with a period.` Please fix. -- To view, visit https://review.coreboot.org/c/coreboot/+/79166?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2996fd35c2897269997bc0290e0ce93bbbaa1bf8 Gerrit-Change-Number: 79166 Gerrit-PatchSet: 9 Gerrit-Owner: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Sat, 02 Dec 2023 07:43:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: inteltool/gpio_names/*.h: Add GPL-2.0-only SPDX license header
by Felix Singer (Code Review) 02 Dec '23

02 Dec '23

Attention is currently required from: Alexander Couzens, Martin L Roth, Nicholas Chin, Pratikkumar V Prajapati, Stefan Reinauer. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78628?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: inteltool/gpio_names/*.h: Add GPL-2.0-only SPDX license header ...................................................................... Patch Set 3: (3 comments) File util/inteltool/gpio_names/icelake.h: https://review.coreboot.org/c/coreboot/+/78628/comment/d44e147d_96aebd26 : PS3, Line 1: /* inteltool - dump all registers on an Intel CPU + chipset based system */ here as well File util/inteltool/gpio_names/lewisburg.h: https://review.coreboot.org/c/coreboot/+/78628/comment/5c76f90c_3b5a04df : PS3, Line 1: /* inteltool - dump all registers on an Intel CPU + chipset based system */ here as well File util/inteltool/gpio_names/sunrise.h: https://review.coreboot.org/c/coreboot/+/78628/comment/738f21be_a4378f57 : PS3, Line 1: /* inteltool - dump all registers on an Intel CPU + chipset based system */ missed that -- To view, visit https://review.coreboot.org/c/coreboot/+/78628?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie897cb238c0c9e89fe677c999cbf1803f5f4609a Gerrit-Change-Number: 78628 Gerrit-PatchSet: 3 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Attention: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Comment-Date: Sat, 02 Dec 2023 07:42:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2023