coreboot-gerrit December 2023

coreboot-gerrit@coreboot.org

1 participants
2354 discussions

[S] Change in coreboot[main]: vendorcode/google/chromeos: API to read factory config
by Tim Van Patten (Code Review) 27 Dec '23

27 Dec '23

Attention is currently required from: Eric Lai, Kapil Porwal, Nick Vaccaro, Shelley Chen, Subrata Banik. Tim Van Patten has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79737?usp=email ) Change subject: vendorcode/google/chromeos: API to read factory config ...................................................................... Patch Set 4: Code-Review+1 (1 comment) File src/vendorcode/google/chromeos/branding.c: PS4: nit: While we're currently getting the factory config to determine if CBX branding is enabled or not, the factory config value may contain other information in the future. I suggest re-naming this file to `tpm_factory_config.c` (or something similar) to generalize things a bit more in case additional bits are added in the future un-related to CBX. -- To view, visit https://review.coreboot.org/c/coreboot/+/79737?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I34f47c9a94972534cda656ef624ef12ed5ddeb06 Gerrit-Change-Number: 79737 Gerrit-PatchSet: 4 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Wed, 27 Dec 2023 21:25:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: security/tpm: Retrieve factory configuration for device w/ Google TPM
by Tim Van Patten (Code Review) 27 Dec '23

27 Dec '23

Attention is currently required from: Christian Walter, Eric Lai, Kapil Porwal, Nick Vaccaro, Paz Zcharya, Shelley Chen, Subrata Banik. Tim Van Patten has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79736?usp=email ) Change subject: security/tpm: Retrieve factory configuration for device w/ Google TPM ...................................................................... Patch Set 3: Code-Review+1 (1 comment) File src/security/tpm/tss/tcg-2.0/tss_structures.h: https://review.coreboot.org/c/coreboot/+/79736/comment/b7d4b5d2_12cbc0c7 : PS3, Line 360: uint64_t factory_config; I'm not sure if we're concerned about gaps in these structs, but it's probably best to make sure they're filled in. In this case, there's a 5-byte gap between the union and `factory_config`, which can be filled with padding: ``` struct vendor_command_response { uint16_t vc_subcommand; union { uint8_t num_restored_headers; uint8_t recovery_button_state; uint8_t tpm_mode; uint8_t boot_mode; }; uint8_t padding[5]; /* * bits 63..8 : reserved * bits 7..0 : factory config */ uint64_t factory_config; } ``` -- To view, visit https://review.coreboot.org/c/coreboot/+/79736?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ifd0e850770152a03aa46d7f8bbb76f7520a59081 Gerrit-Change-Number: 79736 Gerrit-PatchSet: 3 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Paz Zcharya <pazz(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Paz Zcharya <pazz(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Wed, 27 Dec 2023 21:22:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: smmstorev2: Load the communication buffer at SMM setup
by Arthur Heymans (Code Review) 27 Dec '23

27 Dec '23

Attention is currently required from: Jérémy Compostella. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79738?usp=email ) Change subject: smmstorev2: Load the communication buffer at SMM setup ...................................................................... Patch Set 2: (1 comment) File src/cpu/x86/smm/smm_module_loader.c: https://review.coreboot.org/c/coreboot/+/79738/comment/4f4940ba_693567ee : PS2, Line 13: #include <stdint.h> not needed. -- To view, visit https://review.coreboot.org/c/coreboot/+/79738?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I94dce77711f37f87033530f5ae48cb850a39341b Gerrit-Change-Number: 79738 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Comment-Date: Wed, 27 Dec 2023 20:27:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: smmstorev2: Load the communication buffer at SMM setup
by Arthur Heymans (Code Review) 27 Dec '23

27 Dec '23

Attention is currently required from: Jérémy Compostella. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79738?usp=email ) Change subject: smmstorev2: Load the communication buffer at SMM setup ...................................................................... Patch Set 1: (1 comment) File src/drivers/smmstore/smi.c: https://review.coreboot.org/c/coreboot/+/79738/comment/75ecbb46_43626169 : PS1, Line 88: if (base == 0 || size == 0) : return SMMSTORE_RET_FAILURE; This check is not needed as smmstore_init does something similar. -- To view, visit https://review.coreboot.org/c/coreboot/+/79738?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I94dce77711f37f87033530f5ae48cb850a39341b Gerrit-Change-Number: 79738 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Comment-Date: Wed, 27 Dec 2023 20:25:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: smmstorev2: Load the communication buffer at SMM setup
by Arthur Heymans (Code Review) 27 Dec '23

27 Dec '23

Attention is currently required from: Arthur Heymans, Jérémy Compostella. Hello Jérémy Compostella, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/79738?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by build bot (Jenkins) Change subject: smmstorev2: Load the communication buffer at SMM setup ...................................................................... smmstorev2: Load the communication buffer at SMM setup This removes the runtime SMI call to set up the communication buffer for SMMSTORE in favor of setting this buffer up during the installation of the smihandler. The reason is that it's less code in the handler and a time costly SMI is also avoided in ramstage. Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> Change-Id: I94dce77711f37f87033530f5ae48cb850a39341b --- M Documentation/drivers/smmstorev2.md M src/cpu/x86/smm/smm_module_handler.c M src/cpu/x86/smm/smm_module_loader.c M src/drivers/smmstore/ramstage.c M src/drivers/smmstore/smi.c M src/drivers/smmstore/store.c M src/include/cpu/x86/smm.h M src/include/smmstore.h 8 files changed, 55 insertions(+), 87 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/79738/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/79738?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I94dce77711f37f87033530f5ae48cb850a39341b Gerrit-Change-Number: 79738 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[main]: smm_module_handler.c: Align data to pointer size
by Arthur Heymans (Code Review) 27 Dec '23

27 Dec '23

Attention is currently required from: Jérémy Compostella. Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/79739?usp=email ) Change subject: smm_module_handler.c: Align data to pointer size ...................................................................... smm_module_handler.c: Align data to pointer size Align to pointer size rather than an arbitrary '4'. Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> Change-Id: Ibdfaf982c70b71191ac476616d769f2228b995b8 --- M src/cpu/x86/smm/smm_module_handler.c 1 file changed, 3 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/79739/1 diff --git a/src/cpu/x86/smm/smm_module_handler.c b/src/cpu/x86/smm/smm_module_handler.c index b16fa81..ba60548 100644 --- a/src/cpu/x86/smm/smm_module_handler.c +++ b/src/cpu/x86/smm/smm_module_handler.c @@ -7,6 +7,7 @@ #include <console/console.h> #include <cpu/cpu.h> #include <cpu/x86/smm.h> +#include <memlayout.h> #include <rmodule.h> #include <types.h> #include <security/intel/stm/SmmStm.h> @@ -21,10 +22,10 @@ /* SMI multiprocessing semaphore */ static volatile -__attribute__((aligned(4))) smi_semaphore smi_handler_status = SMI_UNLOCKED; +__attribute__((aligned(ARCH_POINTER_ALIGN_SIZE))) smi_semaphore smi_handler_status = SMI_UNLOCKED; static const volatile -__attribute((aligned(4), __section__(".module_parameters"))) struct smm_runtime smm_runtime; +__attribute((aligned(ARCH_POINTER_ALIGN_SIZE), __section__(".module_parameters"))) struct smm_runtime smm_runtime; static int smi_obtain_lock(void) { -- To view, visit https://review.coreboot.org/c/coreboot/+/79739?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ibdfaf982c70b71191ac476616d769f2228b995b8 Gerrit-Change-Number: 79739 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-MessageType: newchange

1 0

[M] Change in coreboot[main]: smmstorev2: Load the communication buffer at SMM setup
by Arthur Heymans (Code Review) 27 Dec '23

27 Dec '23

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/79738?usp=email ) Change subject: smmstorev2: Load the communication buffer at SMM setup ...................................................................... smmstorev2: Load the communication buffer at SMM setup This removes the runtime SMI call to set up the communication buffer for SMMSTORE in favor of setting this buffer up during the installation of the smihandler. The reason is that it's less code in the handler and a time costly SMI is also avoided in ramstage. Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> Change-Id: I94dce77711f37f87033530f5ae48cb850a39341b --- M Documentation/drivers/smmstorev2.md M src/cpu/x86/smm/smm_module_handler.c M src/cpu/x86/smm/smm_module_loader.c M src/drivers/smmstore/ramstage.c M src/drivers/smmstore/smi.c M src/drivers/smmstore/store.c M src/include/cpu/x86/smm.h M src/include/smmstore.h 8 files changed, 55 insertions(+), 87 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/79738/1 diff --git a/Documentation/drivers/smmstorev2.md b/Documentation/drivers/smmstorev2.md index 70aa60d..40fba612 100644 --- a/Documentation/drivers/smmstorev2.md +++ b/Documentation/drivers/smmstorev2.md @@ -124,25 +124,9 @@ **NOTE**: The size of the struct entries are in the native word size of smihandler. This means 32 bits in almost all cases. -#### - SMMSTORE_CMD_INIT = 4 +#### - SMMSTORE_CMD_INIT_DEPRECATED = 4 -This installs the communication buffer to use and thus enables the -SMMSTORE handler. This command can only be executed once and is done -by the firmware. Calling this function at runtime has no effect. - -The additional parameter buffer `%ebx` contains a pointer to the -following struct: - -```C -struct smmstore_params_init { - uint32_t com_buffer; - uint32_t com_buffer_size; -} __packed; -``` - -INPUT: -- `com_buffer`: Physical address of the communication buffer (CBMEM) -- `com_buffer_size`: Size in bytes of the communication buffer +Unused, returns SMMSTORE_REG_UNSUPPORTED. #### - SMMSTORE_CMD_RAW_READ = 5 diff --git a/src/cpu/x86/smm/smm_module_handler.c b/src/cpu/x86/smm/smm_module_handler.c index 0daae00..b16fa81 100644 --- a/src/cpu/x86/smm/smm_module_handler.c +++ b/src/cpu/x86/smm/smm_module_handler.c @@ -60,6 +60,14 @@ } #endif +#if CONFIG(SMMSTORE_V2) +void smm_get_smmstore_com_buffer(uintptr_t *base, size_t *size) +{ + *base = smm_runtime.smmstore_com_buffer_base; + *size = smm_runtime.smmstore_com_buffer_size; +} +#endif + void smm_get_cbmemc_buffer(void **buffer_out, size_t *size_out) { *buffer_out = smm_runtime.cbmemc; diff --git a/src/cpu/x86/smm/smm_module_loader.c b/src/cpu/x86/smm/smm_module_loader.c index f827e7b..8179cbc 100644 --- a/src/cpu/x86/smm/smm_module_loader.c +++ b/src/cpu/x86/smm/smm_module_loader.c @@ -8,7 +8,9 @@ #include <cpu/cpu.h> #include <cpu/x86/smm.h> #include <device/device.h> +#include <smmstore.h> #include <rmodule.h> +#include <stdint.h> #include <stdio.h> #include <string.h> #include <types.h> @@ -345,6 +347,22 @@ if (CONFIG(SMM_PCI_RESOURCE_STORE)) smm_pci_resource_store_init(mod_params); + + if (CONFIG(SMMSTORE_V2)) { + struct smmstore_params_info info; + if (smmstore_get_info(&info) < 0) { + printk(BIOS_INFO, "SMMSTORE: Failed to get meta data\n"); + return; + } + + void *ptr = cbmem_add(CBMEM_ID_SMM_COMBUFFER, info.block_size); + if (!ptr) { + printk(BIOS_ERR, "SMMSTORE: Failed to add com buffer\n"); + return; + } + mod_params->smmstore_com_buffer_base = (uintptr_t)ptr; + mod_params->smmstore_com_buffer_size = info.block_size; + } } static void print_region(const char *name, const struct region region) diff --git a/src/drivers/smmstore/ramstage.c b/src/drivers/smmstore/ramstage.c index ef80e22..5a81d48 100644 --- a/src/drivers/smmstore/ramstage.c +++ b/src/drivers/smmstore/ramstage.c @@ -9,8 +9,6 @@ #include <types.h> #include <cbmem.h> -static struct smmstore_params_info info; - void lb_smmstorev2(struct lb_header *header) { struct lb_record *rec; @@ -21,6 +19,9 @@ if (!e) return; + struct smmstore_params_info info; + smmstore_get_info(&info); + rec = lb_new_record(header); store = (struct lb_smmstorev2 *)rec; @@ -33,44 +34,3 @@ store->block_size = info.block_size; store->apm_cmd = APM_CNT_SMMSTORE; } - -static void init_store(void *unused) -{ - struct smmstore_params_init args; - uint32_t eax = ~0; - uint32_t ebx; - - if (smmstore_get_info(&info) < 0) { - printk(BIOS_INFO, "SMMSTORE: Failed to get meta data\n"); - return; - } - - void *ptr = cbmem_add(CBMEM_ID_SMM_COMBUFFER, info.block_size); - if (!ptr) { - printk(BIOS_ERR, "SMMSTORE: Failed to add com buffer\n"); - return; - } - - args.com_buffer = (uintptr_t)ptr; - args.com_buffer_size = info.block_size; - ebx = (uintptr_t)&args; - - printk(BIOS_INFO, "SMMSTORE: Setting up SMI handler\n"); - - /* Issue SMI using APM to update the com buffer and to lock the SMMSTORE */ - __asm__ __volatile__ ( - "outb %%al, %%dx" - : "=a" (eax) - : "a" ((SMMSTORE_CMD_INIT << 8) | APM_CNT_SMMSTORE), - "b" (ebx), - "d" (APM_CNT) - : "memory"); - - if (eax != SMMSTORE_RET_SUCCESS) { - printk(BIOS_ERR, "SMMSTORE: Failed to install com buffer\n"); - return; - } -} - -/* The SMI APM handler is installed at DEV_INIT phase */ -BOOT_STATE_INIT_ENTRY(BS_DEV_INIT, BS_ON_EXIT, init_store, NULL); diff --git a/src/drivers/smmstore/smi.c b/src/drivers/smmstore/smi.c index 6ea447f..f0f5390 100644 --- a/src/drivers/smmstore/smi.c +++ b/src/drivers/smmstore/smi.c @@ -78,24 +78,25 @@ static uint32_t smmstorev2_exec(uint8_t command, void *param) { uint32_t ret = SMMSTORE_RET_FAILURE; + static bool initialized = false; + + if (!initialized) { + uintptr_t base; + size_t size; + smm_get_smmstore_com_buffer(&base, &size); + + if (base == 0 || size == 0) + return SMMSTORE_RET_FAILURE; + + if (range_check((void *)base, size)) + return SMMSTORE_RET_FAILURE; + + if (smmstore_init((void *)base, size)) + return SMMSTORE_RET_FAILURE; + initialized = true; + } switch (command) { - case SMMSTORE_CMD_INIT: { - printk(BIOS_DEBUG, "Init SMM store\n"); - struct smmstore_params_init *params = param; - - if (range_check(params, sizeof(*params)) != 0) - break; - - void *buf = (void *)(uintptr_t)params->com_buffer; - - if (range_check(buf, params->com_buffer_size) != 0) - break; - - if (smmstore_init(buf, params->com_buffer_size) == 0) - ret = SMMSTORE_RET_SUCCESS; - break; - } case SMMSTORE_CMD_RAW_READ: { printk(BIOS_DEBUG, "Raw read from SMM store, param = %p\n", param); struct smmstore_params_raw_read *params = param; diff --git a/src/drivers/smmstore/store.c b/src/drivers/smmstore/store.c index bc3dcdc..3fca45b 100644 --- a/src/drivers/smmstore/store.c +++ b/src/drivers/smmstore/store.c @@ -283,14 +283,10 @@ /* Implementation of Version 2 */ -static bool store_initialized; static struct region_device mdev_com_buf; static int smmstore_rdev_chain(struct region_device *rdev) { - if (!store_initialized) - return -1; - return rdev_chain_full(rdev, &mdev_com_buf); } @@ -303,13 +299,8 @@ if (!buf || len < SMM_BLOCK_SIZE) return -1; - if (store_initialized) - return -1; - rdev_chain_mem_rw(&mdev_com_buf, buf, len); - store_initialized = true; - return 0; } diff --git a/src/include/cpu/x86/smm.h b/src/include/cpu/x86/smm.h index a240ac2..e94fb59 100644 --- a/src/include/cpu/x86/smm.h +++ b/src/include/cpu/x86/smm.h @@ -91,6 +91,10 @@ #endif uintptr_t save_state_top[CONFIG_MAX_CPUS]; int smm_log_level; +#if CONFIG(SMMSTORE_V2) + uintptr_t smmstore_com_buffer_base; + size_t smmstore_com_buffer_size; +#endif } __packed; struct smm_module_params { @@ -227,4 +231,6 @@ void smm_pci_resource_store_init(struct smm_runtime *smm_runtime); +void smm_get_smmstore_com_buffer(uintptr_t *base, size_t *size); + #endif /* CPU_X86_SMM_H */ diff --git a/src/include/smmstore.h b/src/include/smmstore.h index d3940ab..6805cbc 100644 --- a/src/include/smmstore.h +++ b/src/include/smmstore.h @@ -16,7 +16,7 @@ #define SMMSTORE_CMD_APPEND 3 /* Version 2 */ -#define SMMSTORE_CMD_INIT 4 +#define SMMSTORE_CMD_INIT_DEPRECATED 4 #define SMMSTORE_CMD_RAW_READ 5 #define SMMSTORE_CMD_RAW_WRITE 6 #define SMMSTORE_CMD_RAW_CLEAR 7 -- To view, visit https://review.coreboot.org/c/coreboot/+/79738?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I94dce77711f37f87033530f5ae48cb850a39341b Gerrit-Change-Number: 79738 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[main]: vendorcode/google/chromeos: API to read factory config
by Subrata Banik (Code Review) 27 Dec '23

27 Dec '23

Attention is currently required from: Tim Van Patten. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/79737?usp=email to look at the new patch set (#4). Change subject: vendorcode/google/chromeos: API to read factory config ...................................................................... vendorcode/google/chromeos: API to read factory config This code leverages the TPM vendor-specific function tlcl_cr50_get_factory_config() to fetch the device's factory configuration. BUG=b:317880956 TEST=Able to retrieve the factory config from google/screebo. Change-Id: I34f47c9a94972534cda656ef624ef12ed5ddeb06 Signed-off-by: Subrata Banik <subratabanik(a)google.com> --- M src/vendorcode/google/chromeos/Makefile.inc A src/vendorcode/google/chromeos/branding.c M src/vendorcode/google/chromeos/chromeos.h 3 files changed, 32 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/79737/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/79737?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I34f47c9a94972534cda656ef624ef12ed5ddeb06 Gerrit-Change-Number: 79737 Gerrit-PatchSet: 4 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Tim Van Patten <timvp(a)google.com> Gerrit-Attention: Tim Van Patten <timvp(a)google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[main]: vendorcode/google/chromeos: API to read factory config
by Subrata Banik (Code Review) 27 Dec '23

27 Dec '23

Attention is currently required from: Tim Van Patten. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79737?usp=email ) Change subject: vendorcode/google/chromeos: API to read factory config ...................................................................... Patch Set 3: (2 comments) File src/vendorcode/google/chromeos/ti50_misc_cmd.c: https://review.coreboot.org/c/coreboot/+/79737/comment/a6b59805_77b07c9a : PS1, Line 20: if (rc == TPM_CB_NO_SUCH_COMMAND) { > `TPM_CB_NO_SUCH_COMMAND` is not the only value `tlcl_ti50_get_factory_config()` can return, so the o […] Acknowledged https://review.coreboot.org/c/coreboot/+/79737/comment/5da17b4f_7dcf7334 : PS1, Line 26: return factory_config; > `factory_config` is a `uint64_t`, while this function returns a `uint8_t`. […] Acknowledged -- To view, visit https://review.coreboot.org/c/coreboot/+/79737?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I34f47c9a94972534cda656ef624ef12ed5ddeb06 Gerrit-Change-Number: 79737 Gerrit-PatchSet: 3 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Tim Van Patten <timvp(a)google.com> Gerrit-Attention: Tim Van Patten <timvp(a)google.com> Gerrit-Comment-Date: Wed, 27 Dec 2023 18:28:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Van Patten <timvp(a)google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: vendorcode/google/chromeos: API to read factory config
by Subrata Banik (Code Review) 27 Dec '23

27 Dec '23

Attention is currently required from: Subrata Banik. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/79737?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: vendorcode/google/chromeos: API to read factory config ...................................................................... vendorcode/google/chromeos: API to read factory config This code leverages the TPM vendor-specific function tlcl_cr50_get_factory_config() to fetch the device's factory configuration. BUG=b:317880956 TEST=Able to retrieve the factory config from google/screebo. Change-Id: I34f47c9a94972534cda656ef624ef12ed5ddeb06 Signed-off-by: Subrata Banik <subratabanik(a)google.com> --- M src/vendorcode/google/chromeos/chromeos.h M src/vendorcode/google/chromeos/cr50_enable_update.c 2 files changed, 26 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/79737/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/79737?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I34f47c9a94972534cda656ef624ef12ed5ddeb06 Gerrit-Change-Number: 79737 Gerrit-PatchSet: 3 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Tim Van Patten <timvp(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2023