Attention is currently required from: Ivy Jian, Nick Vaccaro.
Hello Karthik Ramasubramanian, Nick Vaccaro, Shelley Chen, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/79391?usp=email
to look at the new patch set (#3).
Change subject: mb/google/brox: Update configuration for USB ports
......................................................................
mb/google/brox: Update configuration for USB ports
Update brox devicetree based on the latest schematics.
- Configure typeC to EC mux ports settings.
- Configure USB2/USB3 ports settings.
- Configure TCSS ports settings.
BUG=b:311450057
BRANCH=None
TEST=emerge-brox coreboot
Change-Id: Iac5a2e8be6cea64f107d267d4cf71529f08bb63d
Signed-off-by: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com>
---
M src/mainboard/google/brox/variants/baseboard/brox/devicetree.cb
M src/mainboard/google/brox/variants/brox/overridetree.cb
2 files changed, 133 insertions(+), 18 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/79391/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/79391?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iac5a2e8be6cea64f107d267d4cf71529f08bb63d
Gerrit-Change-Number: 79391
Gerrit-PatchSet: 3
Gerrit-Owner: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Karthik Ramasubramanian, Paul Menzel.
Hello Karthik Ramasubramanian, Shelley Chen, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/79392?usp=email
to look at the new patch set (#5).
Change subject: mb/google/brox: Generate RAM IDs for two modules
......................................................................
mb/google/brox: Generate RAM IDs for two modules
Add the support LP5 RAM parts for brox:
1. HYNIX LPDDR5 6400 2GB H9JCNNNBK3MLYR-N6E
2. MICRON LPDDR5 6400 4GB MT62F1G32D4DR-031 WT:B
DRAM Part Name ID to assign
H9JCNNNBK3MLYR-N6E 0 (0000)
MT62F1G32D4DR-031 WT:B 1 (0001)
BUG=b:311450057
BRANCH=None
TEST=Run part_id_gen tool without any errors
Change-Id: Ib17f26a310435e37088191594863a645aa751440
Signed-off-by: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com>
---
M src/mainboard/google/brox/variants/brox/memory/Makefile.inc
M src/mainboard/google/brox/variants/brox/memory/dram_id.generated.txt
M src/mainboard/google/brox/variants/brox/memory/mem_parts_used.txt
3 files changed, 6 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/79392/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/79392?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib17f26a310435e37088191594863a645aa751440
Gerrit-Change-Number: 79392
Gerrit-PatchSet: 5
Gerrit-Owner: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Ivy Jian, Nick Vaccaro.
Hello Karthik Ramasubramanian, Nick Vaccaro, Shelley Chen, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/79391?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: mb/google/brox: Update configuration for USB ports
......................................................................
mb/google/brox: Update configuration for USB ports
Update brox devicetree based on schematics.
- Configure typeC to EC mux ports settings.
- Configure USB2/USB3 ports settings.
- Configure TCSS ports settings.
BUG=b:311450057
BRANCH=None
TEST=emerge-brox coreboot
Change-Id: Iac5a2e8be6cea64f107d267d4cf71529f08bb63d
Signed-off-by: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com>
---
M src/mainboard/google/brox/variants/baseboard/brox/devicetree.cb
M src/mainboard/google/brox/variants/brox/overridetree.cb
2 files changed, 133 insertions(+), 18 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/79391/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/79391?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iac5a2e8be6cea64f107d267d4cf71529f08bb63d
Gerrit-Change-Number: 79391
Gerrit-PatchSet: 2
Gerrit-Owner: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Benjamin Doron, Martin L Roth, Patrick Rudolph, Simon Glass.
Maximilian Brune has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78913?usp=email )
Change subject: payloads: Add uefistub payload
......................................................................
Patch Set 4:
(3 comments)
Patchset:
PS4:
> For 64-bit SMBIOS (I suppose the SMBIOS3 header) there is a patch[1] but it needs a bit of work, or perhaps that has already been done. In any case, I can help, or Heinrich / others on the ML.
>
> For ACPI, can you share your working code? The ACPI code is now fairly generic so enabling it on ARM should not be difficult. Of course any new thing has challenges.
I will see that I sort out and clean up my patches, but its gonna take a while. My TODO list is a bit full currently.
> We have enough forking going on in private projects. I would really like to see more collaboration between coreboot and U-Boot.
I am all for enhancing the coreboot support in u-boot but that doesn't mean I will decide against this payload. There is no harm in alternative (open source) solutions. It is not tied/integrated into coreboot. No one needs to use it if they don't want to.
> I did do some fiddling on U-Boot as a library a while back. It is a big effort though...so using the existing payload seems a lot easier.
I didn't mean u-boot to be library. I meant only the UEFI implementation part to be a library or separate executable. Similar to EDK2Payload or efistub in Linux (just the other way around). Or like this uefistub. It does one specific task and that is providing a UEFI interface to payload. It is very small, fast and simple (as simple as UEFI can be...).
File payloads/uefistub/src/efi_boot_services.c:
https://review.coreboot.org/c/coreboot/+/78913/comment/94bc6353_8df6a007 :
PS4, Line 134: .get_next_monotonic_count = (void *)efi_unimplemented,
must return EFI_DEVICE_ERROR instead of EFI_UNSUPPORTED
https://github.com/ARM-software/ebbr/blob/main/source/chapter2-uefi.rst#mon…
File payloads/uefistub/src/efi_table.c:
https://review.coreboot.org/c/coreboot/+/78913/comment/20b06d4e_5b52069f :
PS4, Line 25: .reset = (void *)efi_unimplemented,
must return EFI_DEVICE_ERROR instead of EFI_UNSUPPORTED
https://uefi.org/specs/UEFI/2.10/12_Protocols_Console_Support.html#efi-simp…
--
To view, visit https://review.coreboot.org/c/coreboot/+/78913?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4093378e89c3cb43fb0846666de80a7da36b03f1
Gerrit-Change-Number: 78913
Gerrit-PatchSet: 4
Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: David Milosevic <David.Milosevic(a)9elements.com>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Simon Glass <sjg(a)chromium.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Attention: Simon Glass <sjg(a)chromium.org>
Gerrit-Comment-Date: Wed, 06 Dec 2023 00:40:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Maximilian Brune <maximilian.brune(a)9elements.com>
Comment-In-Reply-To: Simon Glass <sjg(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Ivy Jian, Nick Vaccaro.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79391?usp=email )
Change subject: mb/google/brox: Update configuration for USB ports
......................................................................
Patch Set 1:
(3 comments)
File src/mainboard/google/brox/variants/brox/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/79391/comment/07cd0238_8ed7992a :
PS1, Line 81: end
Missing port A0 config
https://review.coreboot.org/c/coreboot/+/79391/comment/6aecac68_5e737189 :
PS1, Line 84: register "type" = "UPC_TYPE_INTERNAL"
has_power_resource = 1?
https://review.coreboot.org/c/coreboot/+/79391/comment/b0a94e30_174d8aeb :
PS1, Line 87: end
Similarly missing USB3 config for port A0.
--
To view, visit https://review.coreboot.org/c/coreboot/+/79391?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iac5a2e8be6cea64f107d267d4cf71529f08bb63d
Gerrit-Change-Number: 79391
Gerrit-PatchSet: 1
Gerrit-Owner: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Comment-Date: Tue, 05 Dec 2023 23:49:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Ivy Jian, Karthik Ramasubramanian, Nick Vaccaro.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79391?usp=email )
Change subject: mb/google/brox: Update configuration for USB ports
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/brox/variants/brox/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/79391/comment/8193f4ec_469a5bb0 :
PS1, Line 3: device ref pch_espi on
: chip ec/google/chromeec
: use conn0 as mux_conn[0]
: use conn1 as mux_conn[1]
: device pnp 0c09.0 on end
: end
: end
Mention that in the commit message?
--
To view, visit https://review.coreboot.org/c/coreboot/+/79391?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iac5a2e8be6cea64f107d267d4cf71529f08bb63d
Gerrit-Change-Number: 79391
Gerrit-PatchSet: 1
Gerrit-Owner: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Tue, 05 Dec 2023 22:29:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Ivy Jian, Karthik Ramasubramanian, Nick Vaccaro.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79391?usp=email )
Change subject: mb/google/brox: Update configuration for USB ports
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/79391/comment/d5a4cd7e_46bb792b :
PS1, Line 9: Update brox USB2/3 and TCP ports based on schematics.
Please mention the version.
https://review.coreboot.org/c/coreboot/+/79391/comment/7b0fd8b8_105f10b2 :
PS1, Line 9: and TCP
Also mention in the summary?
--
To view, visit https://review.coreboot.org/c/coreboot/+/79391?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iac5a2e8be6cea64f107d267d4cf71529f08bb63d
Gerrit-Change-Number: 79391
Gerrit-PatchSet: 1
Gerrit-Owner: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Tue, 05 Dec 2023 22:28:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Ivy Jian, Karthik Ramasubramanian, Nick Vaccaro.
Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79391?usp=email )
Change subject: mb/google/brox: Update configuration for USB ports
......................................................................
Patch Set 1:
(3 comments)
File src/mainboard/google/brox/variants/baseboard/brox/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/79391/comment/aeb2e0f8_90bfe2c8 :
PS1, Line 31: OC_SKIP
OC2 here as well?
https://review.coreboot.org/c/coreboot/+/79391/comment/d4a782e2_2d06da1a :
PS1, Line 33: OC_SKIP
Is this supposed to be OC1? I see that in the schematics USB_OC1_L is attached to USB_A0_OC_ODL.
https://review.coreboot.org/c/coreboot/+/79391/comment/859c1c9c_7a36642b :
PS1, Line 36: DCI
Is this Type A port A0? Also should it be OC1 like previous comment above?
--
To view, visit https://review.coreboot.org/c/coreboot/+/79391?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iac5a2e8be6cea64f107d267d4cf71529f08bb63d
Gerrit-Change-Number: 79391
Gerrit-PatchSet: 1
Gerrit-Owner: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Tue, 05 Dec 2023 22:08:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment