coreboot-gerrit October 2023

coreboot-gerrit@coreboot.org

1 participants
3353 discussions

[S] Change in coreboot[main]: soc/intel/meteorlake: Adjust Power State Current 2 threshold
by Jérémy Compostella (Code Review) 30 Oct '23

30 Oct '23

Attention is currently required from: Eran Mitrani, Kapil Porwal, Shelley Chen, Subrata Banik, Tarun. Jérémy Compostella has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78653?usp=email ) Change subject: soc/intel/meteorlake: Adjust Power State Current 2 threshold ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: @subrata, Should we merge this one or are we waiting for something ? -- To view, visit https://review.coreboot.org/c/coreboot/+/78653?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2da2b05de8a04f91dacaa55062165c4351422865 Gerrit-Change-Number: 78653 Gerrit-PatchSet: 2 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Mon, 30 Oct 2023 22:43:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: arch/x86/memcpy.c: Optimize code for 64bit
by Jérémy Compostella (Code Review) 30 Oct '23

30 Oct '23

Attention is currently required from: Arthur Heymans. Jérémy Compostella has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78646?usp=email ) Change subject: arch/x86/memcpy.c: Optimize code for 64bit ...................................................................... Patch Set 2: (1 comment) File src/arch/x86/memcpy.c: https://review.coreboot.org/c/coreboot/+/78646/comment/b0e37991_82a5f6af : PS2, Line 30: : "=&c" (d0), "=&D" (d1), "=&S" (d2) > I noticed the copy of the remaining byte is missing. […] BTW, the code in the kernel is: ``` static __always_inline void *__memcpy(void *to, const void *from, size_t n) { int d0, d1, d2; asm volatile("rep ; movsl\n\t" "movl %4,%%ecx\n\t" "andl $3,%%ecx\n\t" "jz 1f\n\t" "rep ; movsb\n\t" "1:" : "=&c" (d0), "=&D" (d1), "=&S" (d2) : "0" (n / 4), "g" (n), "1" ((long)to), "2" ((long)from) : "memory"); return to; } ``` And it does pass the test above. -- To view, visit https://review.coreboot.org/c/coreboot/+/78646?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I65f178d2ed3aae54b0c1ce739c2b4af8738b9fcc Gerrit-Change-Number: 78646 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Mon, 30 Oct 2023 22:38:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: cpu/x86: Support SMBASE relocation-only use-case
by Felix Held (Code Review) 30 Oct '23

30 Oct '23

Attention is currently required from: Angel Pons, Benjamin Doron, Dinesh Gehlot, Eran Mitrani, Fred Reitberger, Jason Glenesk, Kapil Porwal, Martin L Roth, Matt DeVillier, Matt DeVillier, Maulik Vaghela, Raul Rangel, Subrata Banik, Tarun, Tarun Tuli, ron minnich. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70376?usp=email ) Change subject: cpu/x86: Support SMBASE relocation-only use-case ...................................................................... Patch Set 7: (1 comment) Patchset: PS7: > It's a fair concern, but if we want to use payload SMI handlers, the payload must put code in SMM. […] ah, ok, that special hob being within smram/tseg and not just being a regular hob makes me a bit less concerned about the security aspects of that part. i still don't see why a payload should install the smi handler which should only contain the small amount of smm code needed to make the hardware work; putting more code than necessary into the smi handler increases the chance of possible attack surfaces. another thing i'm concerned about there is the possibility to use that to put proprietary code into smm which i consider a rather bad idea in terms of security and reviewability of the code that stays active after the handoff from the firmware to the os. might be worth discussing this at a leadership meeting; not sure though if i'll manage to attend the one in two days -- To view, visit https://review.coreboot.org/c/coreboot/+/70376?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iec96bab19cdcf80622756f02a3dae49b42036c8d Gerrit-Change-Number: 70376 Gerrit-PatchSet: 7 Gerrit-Owner: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Maulik Vaghela <maulikvaghela(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-CC: ron minnich <rminnich(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Maulik Vaghela <maulikvaghela(a)google.com> Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: ron minnich <rminnich(a)gmail.com> Gerrit-Comment-Date: Mon, 30 Oct 2023 22:35:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Benjamin Doron <benjamin.doron00(a)gmail.com> Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: arch/x86/memcpy.c: Optimize code for 64bit
by Jérémy Compostella (Code Review) 30 Oct '23

30 Oct '23

Attention is currently required from: Arthur Heymans. Jérémy Compostella has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78646?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: arch/x86/memcpy.c: Optimize code for 64bit ...................................................................... Patch Set 2: Code-Review-1 (1 comment) File src/arch/x86/memcpy.c: https://review.coreboot.org/c/coreboot/+/78646/comment/0df66a96_651f4b14 : PS2, Line 30: : "=&c" (d0), "=&D" (d1), "=&S" (d2) I noticed the copy of the remaining byte is missing. the following test program shows the failure when compiled for 32 bits: ``` #include <stdio.h> #include <stdlib.h> #include <stdint.h> #include <string.h> void *my_memcpy(void *dest, const void *src, size_t n) { unsigned long d0, d1, d2; #if ENV_X86_64 asm volatile( "rep ; movsq\n\t" "mov %4,%%rcx\n\t" "rep ; movsb\n\t" : "=&c" (d0), "=&D" (d1), "=&S" (d2) : "0" (n >> 3), "g" (n & 7), "1" (dest), "2" (src) : "memory" ); #else asm volatile( "rep ; movsl\n\t" "movl %4,%%ecx\n\t" : "=&c" (d0), "=&D" (d1), "=&S" (d2) : "0" (n >> 2), "g" (n & 3), "1" (dest), "2" (src) : "memory" ); #endif } int main(int argc, const char **argv) { #define SIZE 13 static unsigned char dest[SIZE], src[SIZE]; memset(src, 0xaa, sizeof(src)); my_memcpy(dest, src, sizeof(src)); for (size_t i = 0; i < sizeof(src); i++) if (dest[i] != src[i]) { printf("FAIL\n"); return EXIT_FAILURE; } printf("PASS\n"); return EXIT_SUCCESS; } ``` -- To view, visit https://review.coreboot.org/c/coreboot/+/78646?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I65f178d2ed3aae54b0c1ce739c2b4af8738b9fcc Gerrit-Change-Number: 78646 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Mon, 30 Oct 2023 22:26:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: soc/amd/mendocino: Update FSP-S UPD to pass boot logo
by Karthik Ramasubramanian (Code Review) 30 Oct '23

30 Oct '23

Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Matt DeVillier. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78817?usp=email ) Change subject: soc/amd/mendocino: Update FSP-S UPD to pass boot logo ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > didn't mean for this to be resolved Yes, it is coming next. I am setting up the individual pieces for this feature before enabling it. -- To view, visit https://review.coreboot.org/c/coreboot/+/78817?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie522956b6dfe2400ef91d43c80f2adc6d52c8415 Gerrit-Change-Number: 78817 Gerrit-PatchSet: 1 Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 30 Oct 2023 21:52:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: arch/x86/memcpy: Change unrecognized instruction movsd to movsl
by Martin L Roth (Code Review) 30 Oct '23

30 Oct '23

Martin L Roth has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/78819?usp=email ) Change subject: arch/x86/memcpy: Change unrecognized instruction movsd to movsl ...................................................................... Abandoned CB:78646 is better -- To view, visit https://review.coreboot.org/c/coreboot/+/78819?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib3f55f50da74a9c24d2fdd0fa45bd0019b2fdc0a Gerrit-Change-Number: 78819 Gerrit-PatchSet: 3 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-MessageType: abandon

1 0

[S] Change in coreboot[main]: arch/x86/memcpy.c: Optimize code for 64bit
by Martin L Roth (Code Review) 30 Oct '23

30 Oct '23

Attention is currently required from: Arthur Heymans. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78646?usp=email ) Change subject: arch/x86/memcpy.c: Optimize code for 64bit ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/78646?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I65f178d2ed3aae54b0c1ce739c2b4af8738b9fcc Gerrit-Change-Number: 78646 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Mon, 30 Oct 2023 21:51:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: soc/amd/mendocino: Update FSP-S UPD to pass boot logo
by Matt DeVillier (Code Review) 30 Oct '23

30 Oct '23

Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Karthik Ramasubramanian. Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78817?usp=email ) Change subject: soc/amd/mendocino: Update FSP-S UPD to pass boot logo ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > don't we also need the SoC to select `HAVE_FSP_LOGO_SUPPORT if RUN_FSP_GOP` as well in order for thi […] didn't mean for this to be resolved -- To view, visit https://review.coreboot.org/c/coreboot/+/78817?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie522956b6dfe2400ef91d43c80f2adc6d52c8415 Gerrit-Change-Number: 78817 Gerrit-PatchSet: 1 Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 30 Oct 2023 21:51:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: soc/amd/mendocino: Update FSP-S UPD to pass boot logo
by Matt DeVillier (Code Review) 30 Oct '23

30 Oct '23

Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Karthik Ramasubramanian. Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78817?usp=email ) Change subject: soc/amd/mendocino: Update FSP-S UPD to pass boot logo ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: don't we also need the SoC to select `HAVE_FSP_LOGO_SUPPORT if RUN_FSP_GOP` as well in order for this to be utilized? -- To view, visit https://review.coreboot.org/c/coreboot/+/78817?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie522956b6dfe2400ef91d43c80f2adc6d52c8415 Gerrit-Change-Number: 78817 Gerrit-PatchSet: 1 Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 30 Oct 2023 21:50:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: vendorcode/amd: Hook up opensil
by Martin L Roth (Code Review) 30 Oct '23

30 Oct '23

Attention is currently required from: Arthur Heymans, Martin Roth. Martin L Roth has uploaded a new patch set (#10) to the change originally created by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/76511?usp=email ) The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: vendorcode/amd: Hook up opensil ...................................................................... vendorcode/amd: Hook up opensil OpenSIL has a native buildsystem using meson and configuration mechanism using kconfiglib. To be able to use the coreboot toolchain with opensil, meson crossfiles are used, which get generated by coreboot makefiles. Configuration of opensil is done in a similar fashion with a template defconfig after which kconfiglib is called to generate headers. Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: Ide2d181914116119dfd37b1511d89ea965729141 --- M src/vendorcode/amd/Kconfig M src/vendorcode/amd/Makefile.inc A src/vendorcode/amd/opensil/Kconfig A src/vendorcode/amd/opensil/Kconfig.debug A src/vendorcode/amd/opensil/Makefile.inc A src/vendorcode/amd/opensil/genoa_poc/meson_cross.template A src/vendorcode/amd/opensil/genoa_poc/opensil_config.template 7 files changed, 218 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/76511/10 -- To view, visit https://review.coreboot.org/c/coreboot/+/76511?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ide2d181914116119dfd37b1511d89ea965729141 Gerrit-Change-Number: 76511 Gerrit-PatchSet: 10 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2023