coreboot-gerrit January 2023

coreboot-gerrit@coreboot.org

1 participants
5879 discussions

[S] Change in coreboot[master]: soc/intel/xeon_sp/Kconfig: select configs for skx/cpx
by Elyes Haouas (Code Review) 06 Jan '23

06 Jan '23

Attention is currently required from: Jonathan Zhang, Johnny Lin, Christian Walter, Arthur Heymans, Tim Chu. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71140 ) Change subject: soc/intel/xeon_sp/Kconfig: select configs for skx/cpx ...................................................................... Patch Set 1: (2 comments) File src/soc/intel/xeon_sp/Kconfig: https://review.coreboot.org/c/coreboot/+/71140/comment/08ecea12_73fdf630 PS1, Line 13: PLATFORM_USES_FSP2_0 this is also duplicated https://review.coreboot.org/c/coreboot/+/71140/comment/571a76fc_88e6bccc PS1, Line 24: PLATFORM_USES_FSP2_2 this is also duplicated -- To view, visit https://review.coreboot.org/c/coreboot/+/71140 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3256c3c6a4ea331efae00d78192355a1fd78d6d2 Gerrit-Change-Number: 71140 Gerrit-PatchSet: 1 Gerrit-Owner: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Fri, 06 Jan 2023 21:41:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/xeon_sp/Kconfig: select configs for skx/cpx
by Elyes Haouas (Code Review) 06 Jan '23

06 Jan '23

Attention is currently required from: Jonathan Zhang, Johnny Lin, Christian Walter, Arthur Heymans, Tim Chu. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71140 ) Change subject: soc/intel/xeon_sp/Kconfig: select configs for skx/cpx ...................................................................... Patch Set 1: (1 comment) File src/soc/intel/xeon_sp/Kconfig: https://review.coreboot.org/c/coreboot/+/71140/comment/d60856f4_d72b4b4c PS1, Line 26: CPU_INTEL_COMMON_SMM this is already selected here src/cpu/intel/common/Kconfig: config CPU_INTEL_COMMON_SMM bool default y if CPU_INTEL_COMMON -- To view, visit https://review.coreboot.org/c/coreboot/+/71140 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3256c3c6a4ea331efae00d78192355a1fd78d6d2 Gerrit-Change-Number: 71140 Gerrit-PatchSet: 1 Gerrit-Owner: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Fri, 06 Jan 2023 21:37:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/intel/: Rename small and big cores references
by Felix Held (Code Review) 06 Jan '23

06 Jan '23

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/71639 ) Change subject: soc/intel/: Rename small and big cores references ...................................................................... soc/intel/: Rename small and big cores references The patch addresses Intel heterogeneous cores as `Efficient` and `Performance` cores instead of `small` and `big` cores. It is to ensure coreboot code has uniform reference to the heterogeneous cores. So, the patch renames all `small` and `big` core references to `efficient` (eff) and `performance` (perf) cores respectively. TEST=Build the code for Brya and Rex boards Signed-off-by: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Change-Id: I98c9c0ed86b211d736a0a1738b47410faa13a39f Reviewed-on: https://review.coreboot.org/c/coreboot/+/71639 Reviewed-by: Kapil Porwal <kapilporwal(a)google.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/soc/intel/alderlake/cpu.c M src/soc/intel/common/block/acpi/cpu_hybrid.c M src/soc/intel/common/block/include/intelblocks/acpi.h M src/soc/intel/meteorlake/cpu.c 4 files changed, 48 insertions(+), 26 deletions(-) Approvals: build bot (Jenkins): Verified Arthur Heymans: Looks good to me, approved Kapil Porwal: Looks good to me, approved diff --git a/src/soc/intel/alderlake/cpu.c b/src/soc/intel/alderlake/cpu.c index 4bc0af7..768f2d5 100644 --- a/src/soc/intel/alderlake/cpu.c +++ b/src/soc/intel/alderlake/cpu.c @@ -99,10 +99,10 @@ return CPUID_CORE_TYPE_INTEL_CORE; } -void soc_get_scaling_factor(u16 *big_core_scal_factor, u16 *small_core_scal_factor) +void soc_get_scaling_factor(u16 *perf_core_scal_factor, u16 *eff_core_scal_factor) { - *big_core_scal_factor = 127; - *small_core_scal_factor = 100; + *perf_core_scal_factor = 127; + *eff_core_scal_factor = 100; } bool soc_is_nominal_freq_supported(void) diff --git a/src/soc/intel/common/block/acpi/cpu_hybrid.c b/src/soc/intel/common/block/acpi/cpu_hybrid.c index 4335a46..e5ccf46 100644 --- a/src/soc/intel/common/block/acpi/cpu_hybrid.c +++ b/src/soc/intel/common/block/acpi/cpu_hybrid.c @@ -12,14 +12,14 @@ #define CPPC_NOM_PERF_IDX 3 enum cpu_perf_eff_type { - CPU_TYPE_SMALL, - CPU_TYPE_BIG, + CPU_TYPE_EFF, + CPU_TYPE_PERF, }; DECLARE_SPIN_LOCK(cpu_lock); static u8 global_cpu_type[CONFIG_MAX_CPUS]; -static bool is_big_core(void) +static bool is_perf_core(void) { return get_soc_cpu_type() == CPUID_CORE_TYPE_INTEL_CORE; } @@ -39,9 +39,9 @@ } /* - * This function determines the type (big or small) of the CPU that is executing - * it and stores the information (in a thread-safe manner) in an global_cpu_type - * array. + * This function determines the type (performance or efficient) of the CPU that + * is executing it and stores the information (in a thread-safe manner) in an + * global_cpu_type array. * It requires the SoC to implement a function `get_soc_cpu_type()` which will be * called in a critical section to determine the type of the executing CPU. */ @@ -50,8 +50,8 @@ spin_lock(&cpu_lock); u8 cpu_index = get_cpu_index(); - if (is_big_core()) - global_cpu_type[cpu_index] = CPU_TYPE_BIG; + if (is_perf_core()) + global_cpu_type[cpu_index] = CPU_TYPE_PERF; spin_unlock(&cpu_lock); } @@ -64,16 +64,16 @@ } } -static void acpi_get_cpu_nomi_perf(u16 *small_core_nom_perf, u16 *big_core_nom_perf) +static void acpi_get_cpu_nomi_perf(u16 *eff_core_nom_perf, u16 *perf_core_nom_perf) { - u16 big_core_scal_factor, small_core_scal_factor; + u16 perf_core_scal_factor, eff_core_scal_factor; u8 max_non_turbo_ratio = cpu_get_max_non_turbo_ratio(); - soc_get_scaling_factor(&big_core_scal_factor, &small_core_scal_factor); + soc_get_scaling_factor(&perf_core_scal_factor, &eff_core_scal_factor); - *big_core_nom_perf = (u16)((max_non_turbo_ratio * big_core_scal_factor) / 100); + *perf_core_nom_perf = (u16)((max_non_turbo_ratio * perf_core_scal_factor) / 100); - *small_core_nom_perf = (u16)((max_non_turbo_ratio * small_core_scal_factor) / 100); + *eff_core_nom_perf = (u16)((max_non_turbo_ratio * eff_core_scal_factor) / 100); } static u16 acpi_get_cpu_nominal_freq(void) @@ -84,18 +84,18 @@ /* Updates Nominal Frequency and Nominal Performance */ static void acpigen_cppc_update_nominal_freq_perf(const char *pkg_path, s32 core_id) { - u16 small_core_nom_perf, big_core_nom_perf; + u16 eff_core_nom_perf, perf_core_nom_perf; if (!soc_is_nominal_freq_supported()) return; - acpi_get_cpu_nomi_perf(&small_core_nom_perf, &big_core_nom_perf); + acpi_get_cpu_nomi_perf(&eff_core_nom_perf, &perf_core_nom_perf); - if (global_cpu_type[core_id] == CPU_TYPE_BIG) - acpigen_set_package_element_int(pkg_path, CPPC_NOM_PERF_IDX, big_core_nom_perf); + if (global_cpu_type[core_id] == CPU_TYPE_PERF) + acpigen_set_package_element_int(pkg_path, CPPC_NOM_PERF_IDX, perf_core_nom_perf); else acpigen_set_package_element_int(pkg_path, CPPC_NOM_PERF_IDX, - small_core_nom_perf); + eff_core_nom_perf); /* Update CPU's nominal frequency */ acpigen_set_package_element_int(pkg_path, CPPC_NOM_FREQ_IDX, diff --git a/src/soc/intel/common/block/include/intelblocks/acpi.h b/src/soc/intel/common/block/include/intelblocks/acpi.h index c149c69..63f38bf 100644 --- a/src/soc/intel/common/block/include/intelblocks/acpi.h +++ b/src/soc/intel/common/block/include/intelblocks/acpi.h @@ -18,8 +18,8 @@ CPUID_UNKNOWN = 0xff, }; -/* Gets the scaling factor for small and big core */ -void soc_get_scaling_factor(u16 *big_core_scal_factor, u16 *small_core_scal_factor); +/* Gets the scaling factor for Efficient and Performance core */ +void soc_get_scaling_factor(u16 *perf_core_scal_factor, u16 *eff_core_scal_factor); /* Generates ACPI code to define _CPC control method */ void acpigen_write_CPPC_hybrid_method(int core_id); diff --git a/src/soc/intel/meteorlake/cpu.c b/src/soc/intel/meteorlake/cpu.c index e0ac726..b299cc8 100644 --- a/src/soc/intel/meteorlake/cpu.c +++ b/src/soc/intel/meteorlake/cpu.c @@ -87,10 +87,10 @@ return CPUID_CORE_TYPE_INTEL_CORE; } -void soc_get_scaling_factor(u16 *big_core_scal_factor, u16 *small_core_scal_factor) +void soc_get_scaling_factor(u16 *perf_core_scal_factor, u16 *eff_core_scal_factor) { - *big_core_scal_factor = 125; - *small_core_scal_factor = 100; + *perf_core_scal_factor = 125; + *eff_core_scal_factor = 100; } bool soc_is_nominal_freq_supported(void) -- To view, visit https://review.coreboot.org/c/coreboot/+/71639 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I98c9c0ed86b211d736a0a1738b47410faa13a39f Gerrit-Change-Number: 71639 Gerrit-PatchSet: 4 Gerrit-Owner: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[master]: soc/intel/xeon_sp/Kconfig: select configs for skx/cpx
by Elyes Haouas (Code Review) 06 Jan '23

06 Jan '23

Attention is currently required from: Jonathan Zhang, Johnny Lin, Christian Walter, Arthur Heymans, Tim Chu. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71140 ) Change subject: soc/intel/xeon_sp/Kconfig: select configs for skx/cpx ...................................................................... Patch Set 1: (2 comments) File src/soc/intel/xeon_sp/Kconfig: https://review.coreboot.org/c/coreboot/+/71140/comment/289782d1_d81eb4db PS1, Line 28: HAVE_SMI_HANDLER line #46 https://review.coreboot.org/c/coreboot/+/71140/comment/26872797_c3f1de25 PS1, Line 29: NO_FSP_TEMP_RAM_EXIT line #49 -- To view, visit https://review.coreboot.org/c/coreboot/+/71140 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3256c3c6a4ea331efae00d78192355a1fd78d6d2 Gerrit-Change-Number: 71140 Gerrit-PatchSet: 1 Gerrit-Owner: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Fri, 06 Jan 2023 21:33:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/xeon_sp/Kconfig: select configs for skx/cpx
by Elyes Haouas (Code Review) 06 Jan '23

06 Jan '23

Attention is currently required from: Jonathan Zhang, Johnny Lin, Christian Walter, Arthur Heymans, Tim Chu. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71140 ) Change subject: soc/intel/xeon_sp/Kconfig: select configs for skx/cpx ...................................................................... Patch Set 1: (1 comment) File src/soc/intel/xeon_sp/Kconfig: https://review.coreboot.org/c/coreboot/+/71140/comment/b14f70cd_ca15d45e PS1, Line 27: SOC_INTEL_COMMON_BLOCK_SMM see line #62 -- To view, visit https://review.coreboot.org/c/coreboot/+/71140 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3256c3c6a4ea331efae00d78192355a1fd78d6d2 Gerrit-Change-Number: 71140 Gerrit-PatchSet: 1 Gerrit-Owner: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Fri, 06 Jan 2023 21:31:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/xeon_sp/Kconfig: select configs for skx/cpx
by Marc Jones (Code Review) 06 Jan '23

06 Jan '23

Attention is currently required from: Jonathan Zhang, Johnny Lin, Christian Walter, Arthur Heymans, Tim Chu. Marc Jones has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71140 ) Change subject: soc/intel/xeon_sp/Kconfig: select configs for skx/cpx ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/71140 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3256c3c6a4ea331efae00d78192355a1fd78d6d2 Gerrit-Change-Number: 71140 Gerrit-PatchSet: 1 Gerrit-Owner: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Fri, 06 Jan 2023 21:28:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/intel/xeon_sp: lock MSR_PPIN_CTL at BS_PAYLOAD_LOAD
by Marc Jones (Code Review) 06 Jan '23

06 Jan '23

Attention is currently required from: Patrick Rudolph, Jonathan Zhang, Johnny Lin, Christian Walter, Arthur Heymans. Marc Jones has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71144 ) Change subject: soc/intel/xeon_sp: lock MSR_PPIN_CTL at BS_PAYLOAD_LOAD ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/71144 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8deb086339267cf36e41e16f189e1378f20b82f1 Gerrit-Change-Number: 71144 Gerrit-PatchSet: 1 Gerrit-Owner: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Fri, 06 Jan 2023 21:27:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/brya: Add romstage early graphics for brya
by Jérémy Compostella (Code Review) 06 Jan '23

06 Jan '23

Attention is currently required from: Tarun Tuli. Jérémy Compostella has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71696 ) Change subject: mb/google/brya: Add romstage early graphics for brya ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/71696 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I41c9cccb09dea52e2318f8f9ebeeda3697a7b514 Gerrit-Change-Number: 71696 Gerrit-PatchSet: 1 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Comment-Date: Fri, 06 Jan 2023 21:22:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/xeon_sp: select SCO_INTEL_COMMON_BLOCK_TCO
by Marc Jones (Code Review) 06 Jan '23

06 Jan '23

Attention is currently required from: Jonathan Zhang, Christian Walter, Arthur Heymans, Tim Chu. Marc Jones has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71141 ) Change subject: soc/intel/xeon_sp: select SCO_INTEL_COMMON_BLOCK_TCO ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/71141 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2d307ad16109ae11862dd5e5acc0f12f47b22582 Gerrit-Change-Number: 71141 Gerrit-PatchSet: 1 Gerrit-Owner: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Fri, 06 Jan 2023 21:21:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/intel/xeon_sp: Improve final MTRR solution
by Marc Jones (Code Review) 06 Jan '23

06 Jan '23

Attention is currently required from: Arthur Heymans, Jonathan Zhang, Johnny Lin, Christian Walter, Tim Chu. Marc Jones has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71142 ) Change subject: soc/intel/xeon_sp: Improve final MTRR solution ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/71142 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I198f8d83bcfcdca3a770bd7f9a7060d5782a49fe Gerrit-Change-Number: 71142 Gerrit-PatchSet: 3 Gerrit-Owner: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Fri, 06 Jan 2023 21:20:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2023