coreboot-gerrit January 2023

coreboot-gerrit@coreboot.org

1 participants
5879 discussions

[S] Change in coreboot[master]: src/sbom/Makefile.inc: Fix quotes on CONFIG paths
by Maximilian Brune (Code Review) 07 Jan '23

07 Jan '23

Attention is currently required from: Felix Singer. Maximilian Brune has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71519 ) Change subject: src/sbom/Makefile.inc: Fix quotes on CONFIG paths ...................................................................... Patch Set 3: Code-Review+1 (1 comment) Patchset: PS3: Sry I accidently removed you from reviewers list -- To view, visit https://review.coreboot.org/c/coreboot/+/71519 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iddf4e0cd8a11eaf327d6f55baf38a30c566d0f28 Gerrit-Change-Number: 71519 Gerrit-PatchSet: 3 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Comment-Date: Sat, 07 Jan 2023 00:30:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: src/sbom/Makefile.inc: Fix quotes on CONFIG paths
by Maximilian Brune (Code Review) 07 Jan '23

07 Jan '23

Maximilian Brune has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71519 ) Change subject: src/sbom/Makefile.inc: Fix quotes on CONFIG paths ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/71519/comment/c7bf8518_8252049d PS2, Line 9: Make will not find the build targets unless quotes are removed > Missing dot. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/71519 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iddf4e0cd8a11eaf327d6f55baf38a30c566d0f28 Gerrit-Change-Number: 71519 Gerrit-PatchSet: 3 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Comment-Date: Sat, 07 Jan 2023 00:28:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: src/sbom/Makefile.inc: Fix quotes on CONFIG paths
by Maximilian Brune (Code Review) 07 Jan '23

07 Jan '23

Attention is currently required from: Maximilian Brune. Hello Felix Singer, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/71519 to look at the new patch set (#3). Change subject: src/sbom/Makefile.inc: Fix quotes on CONFIG paths ...................................................................... src/sbom/Makefile.inc: Fix quotes on CONFIG paths Make will not find the build targets unless quotes are removed. Change-Id: Iddf4e0cd8a11eaf327d6f55baf38a30c566d0f28 Signed-off-by: Maximilian Brune <maximilian.brune(a)9elements.com> --- M src/sbom/Makefile.inc 1 file changed, 24 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/71519/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/71519 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iddf4e0cd8a11eaf327d6f55baf38a30c566d0f28 Gerrit-Change-Number: 71519 Gerrit-PatchSet: 3 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: ec/google/chromeec: Add retimer flag for mux device
by Prashant Malani (Code Review) 07 Jan '23

07 Jan '23

Attention is currently required from: Boris Mittelberg. Prashant Malani has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71663 ) Change subject: ec/google/chromeec: Add retimer flag for mux device ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Hmm. What are the next steps here. When does this get merged? IIRC a coreboot maintainer would cherry-pick this into the source right? -- To view, visit https://review.coreboot.org/c/coreboot/+/71663 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I754323236d2912777b63cede0fce2ccf7882cfea Gerrit-Change-Number: 71663 Gerrit-PatchSet: 1 Gerrit-Owner: Prashant Malani <pmalani(a)chromium.org> Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Robert Zieba <robertzieba(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com> Gerrit-Comment-Date: Sat, 07 Jan 2023 00:27:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/xeon_sp/Kconfig: update configs
by Jonathan Zhang (Code Review) 06 Jan '23

06 Jan '23

Attention is currently required from: Johnny Lin, Christian Walter, Arthur Heymans, Elyes Haouas. Hello Marc Jones, build bot (Jenkins), Johnny Lin, Christian Walter, Arthur Heymans, Tim Chu, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/71140 to look at the new patch set (#2). Change subject: soc/intel/xeon_sp/Kconfig: update configs ...................................................................... soc/intel/xeon_sp/Kconfig: update configs select SMM_TSEG. set up HPET_MIN_TICKS. Signed-off-by: Tim Chu <Tim.Chu(a)quantatw.com> Change-Id: I3256c3c6a4ea331efae00d78192355a1fd78d6d2 --- M src/soc/intel/xeon_sp/Kconfig 1 file changed, 20 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/71140/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/71140 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3256c3c6a4ea331efae00d78192355a1fd78d6d2 Gerrit-Change-Number: 71140 Gerrit-PatchSet: 2 Gerrit-Owner: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-CC: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: soc/intel/xeon_sp/Kconfig: select configs for skx/cpx
by Jonathan Zhang (Code Review) 06 Jan '23

06 Jan '23

Attention is currently required from: Johnny Lin, Christian Walter, Arthur Heymans, Elyes Haouas, Tim Chu. Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71140 ) Change subject: soc/intel/xeon_sp/Kconfig: select configs for skx/cpx ...................................................................... Patch Set 1: (4 comments) File src/soc/intel/xeon_sp/Kconfig: https://review.coreboot.org/c/coreboot/+/71140/comment/9f0271e7_94765866 PS1, Line 26: CPU_INTEL_COMMON_SMM > this is already selected here src/cpu/intel/common/Kconfig: […] Done https://review.coreboot.org/c/coreboot/+/71140/comment/1e8f4273_b56c2d3d PS1, Line 27: SOC_INTEL_COMMON_BLOCK_SMM > see line #62 Done https://review.coreboot.org/c/coreboot/+/71140/comment/eb324117_b486274a PS1, Line 28: HAVE_SMI_HANDLER > line #46 Done https://review.coreboot.org/c/coreboot/+/71140/comment/2f9bfb62_b9016e96 PS1, Line 29: NO_FSP_TEMP_RAM_EXIT > line #49 Done -- To view, visit https://review.coreboot.org/c/coreboot/+/71140 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3256c3c6a4ea331efae00d78192355a1fd78d6d2 Gerrit-Change-Number: 71140 Gerrit-PatchSet: 1 Gerrit-Owner: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Fri, 06 Jan 2023 22:40:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/brya: Add romstage early graphics for brya
by Tarun Tuli (Code Review) 06 Jan '23

06 Jan '23

Attention is currently required from: Jérémy Compostella. Tarun Tuli has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71696 ) Change subject: mb/google/brya: Add romstage early graphics for brya ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/71696 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I41c9cccb09dea52e2318f8f9ebeeda3697a7b514 Gerrit-Change-Number: 71696 Gerrit-PatchSet: 1 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Comment-Date: Fri, 06 Jan 2023 22:24:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: Revert "Revert "mb/google/brya: Add romstage early graphics for brya""
by Jérémy Compostella (Code Review) 06 Jan '23

06 Jan '23

Attention is currently required from: Jakub Czapiga, Jeremy Compostella. Jérémy Compostella has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71705 ) Change subject: Revert "Revert "mb/google/brya: Add romstage early graphics for brya"" ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I would prefer that we merge : https://review.coreboot.org/c/coreboot/+/71696 -- To view, visit https://review.coreboot.org/c/coreboot/+/71705 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I356af2b5289beed0a0f38d939f2df7242f65c345 Gerrit-Change-Number: 71705 Gerrit-PatchSet: 1 Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Jeremy Compostella <jeremy.compostella(a)gmail.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Jeremy Compostella <jeremy.compostella(a)gmail.com> Gerrit-Comment-Date: Fri, 06 Jan 2023 22:20:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: Revert "Revert "mb/google/brya: Add romstage early graphics for brya""
by Paul Menzel (Code Review) 06 Jan '23

06 Jan '23

Attention is currently required from: Jakub Czapiga, Jeremy Compostella. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71705 ) Change subject: Revert "Revert "mb/google/brya: Add romstage early graphics for brya"" ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/71705/comment/aeb090fd_dbe47f05 PS1, Line 7: Revert "Revert "mb/google/brya: Add romstage early graphics for brya"" Please remove the *Revert* words, and just copy the whole commit message from the original commit. -- To view, visit https://review.coreboot.org/c/coreboot/+/71705 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I356af2b5289beed0a0f38d939f2df7242f65c345 Gerrit-Change-Number: 71705 Gerrit-PatchSet: 1 Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Jeremy Compostella <jeremy.compostella(a)gmail.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Jeremy Compostella <jeremy.compostella(a)gmail.com> Gerrit-Comment-Date: Fri, 06 Jan 2023 22:07:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: include/memory_info.h: Add soc_num to dimm_info struct
by Marc Jones (Code Review) 06 Jan '23

06 Jan '23

Attention is currently required from: Patrick Rudolph, Johnny Lin, Angel Pons, Shuming Chu (Shuming), Tim Chu. Marc Jones has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70662 ) Change subject: include/memory_info.h: Add soc_num to dimm_info struct ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/70662 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1b9e2b87fda2d7c32ecb8ce9d989795c8b869cea Gerrit-Change-Number: 70662 Gerrit-PatchSet: 1 Gerrit-Owner: Shuming Chu (Shuming) <s1218944(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Shuming Chu (Shuming) <s1218944(a)gmail.com> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Fri, 06 Jan 2023 21:41:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2023