coreboot-gerrit January 2023

coreboot-gerrit@coreboot.org

1 participants
5879 discussions

[S] Change in coreboot[master]: mb/google/nissa/var/xivu: Update DPTF parameters
by Dtrain Hsu (Code Review) 07 Jan '23

07 Jan '23

Attention is currently required from: Tarun Tuli, Ian Feng, Kangheui Won, Vidya Gopalakrishnan. Dtrain Hsu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71658 ) Change subject: mb/google/nissa/var/xivu: Update DPTF parameters ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/71658 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia1fcaee15a8b58b755ce0a48a1978e795b66efd7 Gerrit-Change-Number: 71658 Gerrit-PatchSet: 2 Gerrit-Owner: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Reviewer: AlanKY Lee <alanky_lee(a)compal.corp-partner.google.com> Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Vidya Gopalakrishnan <vidya.gopalakrishnan(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Attention: Kangheui Won <khwon(a)chromium.org> Gerrit-Attention: Vidya Gopalakrishnan <vidya.gopalakrishnan(a)intel.com> Gerrit-Comment-Date: Sat, 07 Jan 2023 01:38:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/brya/var/lisbon: Update LAN LED config
by Robert Chen (Code Review) 07 Jan '23

07 Jan '23

Robert Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/71698 ) Change subject: mb/google/brya/var/lisbon: Update LAN LED config ...................................................................... mb/google/brya/var/lisbon: Update LAN LED config Adjust LAN LED config to 0x060f. BUG=b:246657849 TEST=emerge-brask coreboot Change-Id: Idd5ed2bf7eb4ee5990f2a842cba43f967ae3825e Signed-off-by: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> --- M src/mainboard/google/brya/variants/lisbon/overridetree.cb 1 file changed, 16 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/71698/1 diff --git a/src/mainboard/google/brya/variants/lisbon/overridetree.cb b/src/mainboard/google/brya/variants/lisbon/overridetree.cb index 86e4b69..6a21f2a 100644 --- a/src/mainboard/google/brya/variants/lisbon/overridetree.cb +++ b/src/mainboard/google/brya/variants/lisbon/overridetree.cb @@ -187,9 +187,7 @@ device ref pcie_rp7 on chip drivers/net register "wake" = "GPE0_DW0_07" - register "led_feature" = "0xe0" - register "customized_led0" = "0x23f" - register "customized_led2" = "0x028" + register "customized_leds" = "0x060f" register "enable_aspm_l1_2" = "1" register "add_acpi_dma_property" = "true" device pci 00.0 on end -- To view, visit https://review.coreboot.org/c/coreboot/+/71698 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idd5ed2bf7eb4ee5990f2a842cba43f967ae3825e Gerrit-Change-Number: 71698 Gerrit-PatchSet: 1 Gerrit-Owner: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: mb/google/brya/var/gladios: Update LAN LED config
by Robert Chen (Code Review) 07 Jan '23

07 Jan '23

Attention is currently required from: Kevin Chiu, Tarun Tuli. Robert Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71697 ) Change subject: mb/google/brya/var/gladios: Update LAN LED config ...................................................................... Patch Set 4: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/71697/comment/52819f7f_10ddb4a8 PS2, Line 11: None > b:239513596 Done -- To view, visit https://review.coreboot.org/c/coreboot/+/71697 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I17b844b89569fb7653454fd08782fc961c715817 Gerrit-Change-Number: 71697 Gerrit-PatchSet: 4 Gerrit-Owner: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Comment-Date: Sat, 07 Jan 2023 01:33:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/brya/var/gladios: Update LAN LED config
by Robert Chen (Code Review) 07 Jan '23

07 Jan '23

Attention is currently required from: Kevin Chiu, Tarun Tuli, Robert Chen. Hello Kevin Chiu, build bot (Jenkins), Tarun Tuli, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/71697 to look at the new patch set (#4). Change subject: mb/google/brya/var/gladios: Update LAN LED config ...................................................................... mb/google/brya/var/gladios: Update LAN LED config Adjust LAN LED config to 0x060f. BUG=b:239513596 TEST=emerge-brask coreboot Change-Id: I17b844b89569fb7653454fd08782fc961c715817 Signed-off-by: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> --- M src/mainboard/google/brya/variants/gladios/overridetree.cb 1 file changed, 17 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/71697/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/71697 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I17b844b89569fb7653454fd08782fc961c715817 Gerrit-Change-Number: 71697 Gerrit-PatchSet: 4 Gerrit-Owner: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: soc/intel/common: Fix cpu index calculation
by Sukumar Ghorai (Code Review) 07 Jan '23

07 Jan '23

Attention is currently required from: Subrata Banik, Ravishankar Sarawadi, Sridhar Siricilla, Angel Pons, Lean Sheng Tan, Werner Zeh, Raj Astekar. Sukumar Ghorai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70751 ) Change subject: soc/intel/common: Fix cpu index calculation ...................................................................... Patch Set 8: (1 comment) Patchset: PS8: > Yes, basically it fixes the _CPC3 method generation correctly. Pls verify following output and confirm if everything looks good? # for c in {0..21}; do cat /sys/devices/system/cpu/cpu$c/acpi_cppc/nominal_perf; done -- To view, visit https://review.coreboot.org/c/coreboot/+/70751 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I69e5e6231dd18b43d439340aaed50eb9edeca3b7 Gerrit-Change-Number: 70751 Gerrit-PatchSet: 8 Gerrit-Owner: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Raj Astekar <raj.astekar(a)intel.com> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Sukumar Ghorai <sukumar.ghorai(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Attention: Raj Astekar <raj.astekar(a)intel.com> Gerrit-Comment-Date: Sat, 07 Jan 2023 01:31:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Kapil Porwal <kapilporwal(a)google.com> Comment-In-Reply-To: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/brya/var/gladios: Update LAN LED config
by Kevin Chiu (Code Review) 07 Jan '23

07 Jan '23

Attention is currently required from: Tarun Tuli, Robert Chen. Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71697 ) Change subject: mb/google/brya/var/gladios: Update LAN LED config ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/71697/comment/d7c68b05_2b1665ed PS2, Line 11: None b:239513596 -- To view, visit https://review.coreboot.org/c/coreboot/+/71697 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I17b844b89569fb7653454fd08782fc961c715817 Gerrit-Change-Number: 71697 Gerrit-PatchSet: 2 Gerrit-Owner: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Sat, 07 Jan 2023 01:27:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/brya/var/gladios: Update LAN LED config
by Robert Chen (Code Review) 07 Jan '23

07 Jan '23

Attention is currently required from: Tarun Tuli, Robert Chen. Hello build bot (Jenkins), Tarun Tuli, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/71697 to look at the new patch set (#3). Change subject: mb/google/brya/var/gladios: Update LAN LED config ...................................................................... mb/google/brya/var/gladios: Update LAN LED config Adjust LAN LED config to 0x060f. BUG=None TEST=emerge-brask coreboot Change-Id: I17b844b89569fb7653454fd08782fc961c715817 --- M src/mainboard/google/brya/variants/gladios/overridetree.cb 1 file changed, 16 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/71697/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/71697 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I17b844b89569fb7653454fd08782fc961c715817 Gerrit-Change-Number: 71697 Gerrit-PatchSet: 3 Gerrit-Owner: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: mb/google/brya/var/gladios: Update LAN LED config
by Robert Chen (Code Review) 07 Jan '23

07 Jan '23

Attention is currently required from: Tarun Tuli. Hello Tarun Tuli, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/71697 to look at the new patch set (#2). Change subject: mb/google/brya/var/gladios: Update LAN LED config ...................................................................... mb/google/brya/var/gladios: Update LAN LED config Adjust LAN LED config to 0x060f. BUG=None TEST=emerge-brask coreboot Change-Id: I17b844b89569fb7653454fd08782fc961c715817 --- M src/mainboard/google/brya/variants/gladios/overridetree.cb 1 file changed, 15 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/71697/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/71697 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I17b844b89569fb7653454fd08782fc961c715817 Gerrit-Change-Number: 71697 Gerrit-PatchSet: 2 Gerrit-Owner: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: mb/google/brya/var/gladios: Update LAN LED config
by Robert Chen (Code Review) 07 Jan '23

07 Jan '23

Robert Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/71697 ) Change subject: mb/google/brya/var/gladios: Update LAN LED config ...................................................................... mb/google/brya/var/gladios: Update LAN LED config Adjust LAN LED config to 0x060f. BUG=None TEST=emerge coreboot Change-Id: I17b844b89569fb7653454fd08782fc961c715817 --- M src/mainboard/google/brya/variants/gladios/overridetree.cb 1 file changed, 15 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/71697/1 diff --git a/src/mainboard/google/brya/variants/gladios/overridetree.cb b/src/mainboard/google/brya/variants/gladios/overridetree.cb index 67b39fa..213923f 100644 --- a/src/mainboard/google/brya/variants/gladios/overridetree.cb +++ b/src/mainboard/google/brya/variants/gladios/overridetree.cb @@ -187,9 +187,7 @@ device ref pcie_rp7 on chip drivers/net register "wake" = "GPE0_DW0_07" - register "led_feature" = "0xe0" - register "customized_led0" = "0x23f" - register "customized_led2" = "0x028" + register "customized_leds" = "0x060f" register "enable_aspm_l1_2" = "1" device pci 00.0 on end end -- To view, visit https://review.coreboot.org/c/coreboot/+/71697 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I17b844b89569fb7653454fd08782fc961c715817 Gerrit-Change-Number: 71697 Gerrit-PatchSet: 1 Gerrit-Owner: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: mb/google/nissa/var/xivu: Update DPTF parameters
by AlanKY Lee (Code Review) 07 Jan '23

07 Jan '23

Attention is currently required from: Tarun Tuli, Ian Feng, Kangheui Won, Vidya Gopalakrishnan. AlanKY Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71658 ) Change subject: mb/google/nissa/var/xivu: Update DPTF parameters ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/71658 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia1fcaee15a8b58b755ce0a48a1978e795b66efd7 Gerrit-Change-Number: 71658 Gerrit-PatchSet: 2 Gerrit-Owner: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Reviewer: AlanKY Lee <alanky_lee(a)compal.corp-partner.google.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Vidya Gopalakrishnan <vidya.gopalakrishnan(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Attention: Kangheui Won <khwon(a)chromium.org> Gerrit-Attention: Vidya Gopalakrishnan <vidya.gopalakrishnan(a)intel.com> Gerrit-Comment-Date: Sat, 07 Jan 2023 01:10:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2023