coreboot-gerrit January 2023

coreboot-gerrit@coreboot.org

1 participants
5879 discussions

[M] Change in coreboot[master]: mb/google/brya/var/gladios: Add ACPI DmaProperty for RTL8168 ethernet
by Robert Chen (Code Review) 07 Jan '23

07 Jan '23

Attention is currently required from: Kevin Chiu, Tarun Tuli. Robert Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71699 ) Change subject: mb/google/brya/var/gladios: Add ACPI DmaProperty for RTL8168 ethernet ...................................................................... Patch Set 3: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/71699/comment/629ff79d_b5782e2f PS1, Line 7: mb/google/brya/var/gladios: Add ACPI DmaProperty for gladios > Add ACPI DmaProperty for RTL8168 ethernet Done https://review.coreboot.org/c/coreboot/+/71699/comment/1837d43d_4d2abf27 PS1, Line 12: TEST=emerge-brask coreboot. > please also check SSDT Done -- To view, visit https://review.coreboot.org/c/coreboot/+/71699 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1c4f6ff7b3eda114f4f365a963c089fe584d8aee Gerrit-Change-Number: 71699 Gerrit-PatchSet: 3 Gerrit-Owner: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-CC: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> Gerrit-Attention: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Comment-Date: Sat, 07 Jan 2023 04:02:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/brya/var/gladios: Add ACPI DmaProperty for RTL8168 ethernet
by Robert Chen (Code Review) 07 Jan '23

07 Jan '23

Attention is currently required from: Tarun Tuli, Robert Chen. Hello Kevin Chiu, Tarun Tuli, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/71699 to look at the new patch set (#3). Change subject: mb/google/brya/var/gladios: Add ACPI DmaProperty for RTL8168 ethernet ...................................................................... mb/google/brya/var/gladios: Add ACPI DmaProperty for RTL8168 ethernet Add ACPI DmaProperty for gladios. BUG=b:239513596 TEST=Verified SSDT on gladios unit. Before: Scope (\_SB.PCI0.RP01) { Device (RLTK) { Name (_HID, "R8168") // _HID: Hardware ID Name (_UID, 0xD0E889DD) // _UID: Unique ID Name (_DDN, "Realtek r8168") // _DDN: DOS Device Name Name (_ADR, 0x00000000) // _ADR: Address Name (_PRW, Package (0x02) // _PRW: Power Resources for Wake { 0x07, 0x03 }) } } After: Scope (\_SB.PCI0.RP01) { Device (RLTK) { Name (_HID, "R8168") // _HID: Hardware ID Name (_UID, 0xD0E889DD) // _UID: Unique ID Name (_DDN, "Realtek r8168") // _DDN: DOS Device Name Name (_ADR, 0x00000000) // _ADR: Address Name (_PRW, Package (0x02) // _PRW: Power Resources for Wake { 0x07, 0x03 }) Name (_DSD, Package (0x02) // _DSD: Device-Specific Data { ToUUID ("70d24161-6dd5-4c9e-8070-705531292865"), Package (0x01) { Package (0x02) { "DmaProperty", One } } }) } } Change-Id: I1c4f6ff7b3eda114f4f365a963c089fe584d8aee Signed-off-by: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> --- M src/mainboard/google/brya/variants/gladios/overridetree.cb 1 file changed, 62 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/71699/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/71699 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1c4f6ff7b3eda114f4f365a963c089fe584d8aee Gerrit-Change-Number: 71699 Gerrit-PatchSet: 3 Gerrit-Owner: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-CC: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: mb/google/brya/var/gladios: Add ACPI DmaProperty for RTL8168 ethernet
by Robert Chen (Code Review) 07 Jan '23

07 Jan '23

Attention is currently required from: Tarun Tuli, Robert Chen. Hello Kevin Chiu, Tarun Tuli, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/71699 to look at the new patch set (#2). Change subject: mb/google/brya/var/gladios: Add ACPI DmaProperty for RTL8168 ethernet ...................................................................... mb/google/brya/var/gladios: Add ACPI DmaProperty for RTL8168 ethernet Add ACPI DmaProperty for gladios. BUG=b:239513596 TEST=Verified SSDT on gladios. Before: Scope (\_SB.PCI0.RP01) { Device (RLTK) { Name (_HID, "R8168") // _HID: Hardware ID Name (_UID, 0xD0E889DD) // _UID: Unique ID Name (_DDN, "Realtek r8168") // _DDN: DOS Device Name Name (_ADR, 0x00000000) // _ADR: Address Name (_PRW, Package (0x02) // _PRW: Power Resources for Wake { 0x07, 0x03 }) } } After: Scope (\_SB.PCI0.RP01) { Device (RLTK) { Name (_HID, "R8168") // _HID: Hardware ID Name (_UID, 0xD0E889DD) // _UID: Unique ID Name (_DDN, "Realtek r8168") // _DDN: DOS Device Name Name (_ADR, 0x00000000) // _ADR: Address Name (_PRW, Package (0x02) // _PRW: Power Resources for Wake { 0x07, 0x03 }) Name (_DSD, Package (0x02) // _DSD: Device-Specific Data { ToUUID ("70d24161-6dd5-4c9e-8070-705531292865"), Package (0x01) { Package (0x02) { "DmaProperty", One } } }) } } Change-Id: I1c4f6ff7b3eda114f4f365a963c089fe584d8aee Signed-off-by: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> --- M src/mainboard/google/brya/variants/gladios/overridetree.cb 1 file changed, 62 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/71699/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/71699 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1c4f6ff7b3eda114f4f365a963c089fe584d8aee Gerrit-Change-Number: 71699 Gerrit-PatchSet: 2 Gerrit-Owner: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-CC: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: mb/google/brya/var/kano: Set the ov2740 to 0 and the hi556 to 1 for SSFC
by Martin L Roth (Code Review) 07 Jan '23

07 Jan '23

Attention is currently required from: David Wu, Tarun Tuli, Nick Vaccaro. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71628 ) Change subject: mb/google/brya/var/kano: Set the ov2740 to 0 and the hi556 to 1 for SSFC ...................................................................... Patch Set 1: (1 comment) File src/mainboard/google/brya/variants/kano/overridetree.cb: https://review.coreboot.org/c/coreboot/+/71628/comment/b781b62f_70778936 PS1, Line 20: option UFC_MIPI_OVTI2740 0 > You can use ec command (ectool cbi get 8) to get the SSFC data to know whether or not to use SSFC. […] I still don't understand why UFC_MIPI_HI556 can't just be value 3 in the UFC field, and why the SSFC fields can't just be used to extend the UFC field if more bits are needed. It seems very odd that we'd need a completely new field here, with one of the options being the same as one of the options in the existing field. I'm not objecting - but it seems strange that this is needed at all. I think that being able to extend the existing fields using the SSFC is kind of the point of SSFC returning 0 instead of an error when it's not initialized. -- To view, visit https://review.coreboot.org/c/coreboot/+/71628 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I46fac6c820d6006956680a07198db82225630905 Gerrit-Change-Number: 71628 Gerrit-PatchSet: 1 Gerrit-Owner: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Sat, 07 Jan 2023 03:53:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: David Wu <david_wu(a)quanta.corp-partner.google.com> Comment-In-Reply-To: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/starlabs: Remove the bios_version function
by Martin L Roth (Code Review) 07 Jan '23

07 Jan '23

Martin L Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/70855 ) Change subject: mb/starlabs: Remove the bios_version function ...................................................................... mb/starlabs: Remove the bios_version function Remove smbios_mainboard_bios_version so that the default CONFIG_LOCALVERSION can be used. Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Change-Id: Ia94f8683a54a98f4e3b1f51521db7e3ccb56ba48 Reviewed-on: https://review.coreboot.org/c/coreboot/+/70855 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M src/mainboard/starlabs/Kconfig M src/mainboard/starlabs/lite/smbios.c M src/mainboard/starlabs/starbook/smbios.c 3 files changed, 16 insertions(+), 14 deletions(-) Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved diff --git a/src/mainboard/starlabs/Kconfig b/src/mainboard/starlabs/Kconfig index 4295ef4..4df0588 100644 --- a/src/mainboard/starlabs/Kconfig +++ b/src/mainboard/starlabs/Kconfig @@ -12,8 +12,4 @@ config MAINBOARD_VENDOR default "Star Labs" -config LOCAL_VERSION - string - default "8.18" - endif # VENDOR_STARLABS diff --git a/src/mainboard/starlabs/lite/smbios.c b/src/mainboard/starlabs/lite/smbios.c index 511b28f..d9ae270 100644 --- a/src/mainboard/starlabs/lite/smbios.c +++ b/src/mainboard/starlabs/lite/smbios.c @@ -9,11 +9,6 @@ #include <uuid.h> #include <variants.h> -const char *smbios_mainboard_bios_version(void) -{ - return CONFIG_LOCAL_VERSION; -} - /* Get the Embedded Controller firmware version */ void smbios_ec_revision(uint8_t *ec_major_revision, uint8_t *ec_minor_revision) { diff --git a/src/mainboard/starlabs/starbook/smbios.c b/src/mainboard/starlabs/starbook/smbios.c index 47280ce..ab2c211 100644 --- a/src/mainboard/starlabs/starbook/smbios.c +++ b/src/mainboard/starlabs/starbook/smbios.c @@ -9,11 +9,6 @@ #include <uuid.h> #include <variants.h> -const char *smbios_mainboard_bios_version(void) -{ - return CONFIG_LOCAL_VERSION; -} - /* Get the Embedded Controller firmware version */ void smbios_ec_revision(uint8_t *ec_major_revision, uint8_t *ec_minor_revision) { -- To view, visit https://review.coreboot.org/c/coreboot/+/70855 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia94f8683a54a98f4e3b1f51521db7e3ccb56ba48 Gerrit-Change-Number: 70855 Gerrit-PatchSet: 5 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[master]: vc/google: Add and use POST_CODE_CLEAR definition
by Martin L Roth (Code Review) 07 Jan '23

07 Jan '23

Martin L Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/71592 ) Change subject: vc/google: Add and use POST_CODE_CLEAR definition ...................................................................... vc/google: Add and use POST_CODE_CLEAR definition The CR50 code clears the post code value. Add this as a #define. Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: If3b73a3159ac8ac9ab08c6ff705b0ca289ab453c Reviewed-on: https://review.coreboot.org/c/coreboot/+/71592 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Jon Murphy <jpmurphy(a)google.com> Reviewed-by: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> --- M src/commonlib/include/commonlib/console/post_codes.h M src/vendorcode/google/chromeos/cr50_enable_update.c 2 files changed, 24 insertions(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Jon Murphy: Looks good to me, approved Eric Lai: Looks good to me, approved diff --git a/src/commonlib/include/commonlib/console/post_codes.h b/src/commonlib/include/commonlib/console/post_codes.h index d838815..ef296bd 100644 --- a/src/commonlib/include/commonlib/console/post_codes.h +++ b/src/commonlib/include/commonlib/console/post_codes.h @@ -28,6 +28,12 @@ #define POST_CODES_H /** + * \brief Not an actual post-code - used to clear port80h + * + */ +#define POST_CODE_CLEAR 0x00 + +/** * \brief Entry into 'crt0.s'. reset code jumps to here * * First instruction that gets executed after the reset vector jumps. diff --git a/src/vendorcode/google/chromeos/cr50_enable_update.c b/src/vendorcode/google/chromeos/cr50_enable_update.c index 9ac33a5..6beea91 100644 --- a/src/vendorcode/google/chromeos/cr50_enable_update.c +++ b/src/vendorcode/google/chromeos/cr50_enable_update.c @@ -1,6 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <bootstate.h> +#include <commonlib/console/post_codes.h> #include <console/console.h> #include <ec/google/chromeec/ec.h> #include <elog.h> @@ -133,7 +134,7 @@ mainboard_prepare_cr50_reset(); /* clear current post code avoid chatty eventlog on subsequent boot*/ - post_code(0); + post_code(POST_CODE_CLEAR); /* * Older Cr50 firmware doesn't support the timeout parameter for the -- To view, visit https://review.coreboot.org/c/coreboot/+/71592 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If3b73a3159ac8ac9ab08c6ff705b0ca289ab453c Gerrit-Change-Number: 71592 Gerrit-PatchSet: 2 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[M] Change in coreboot[master]: soc/intel/common: Fix cpu index calculation
by Sukumar Ghorai (Code Review) 07 Jan '23

07 Jan '23

Attention is currently required from: Subrata Banik, Ravishankar Sarawadi, Sridhar Siricilla, Angel Pons, Lean Sheng Tan, Werner Zeh, Raj Astekar. Sukumar Ghorai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70751 ) Change subject: soc/intel/common: Fix cpu index calculation ...................................................................... Patch Set 8: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/70751 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I69e5e6231dd18b43d439340aaed50eb9edeca3b7 Gerrit-Change-Number: 70751 Gerrit-PatchSet: 8 Gerrit-Owner: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Raj Astekar <raj.astekar(a)intel.com> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Sukumar Ghorai <sukumar.ghorai(a)intel.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Attention: Raj Astekar <raj.astekar(a)intel.com> Gerrit-Comment-Date: Sat, 07 Jan 2023 03:00:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/intel/common: Fix cpu index calculation
by Sukumar Ghorai (Code Review) 07 Jan '23

07 Jan '23

Attention is currently required from: Subrata Banik, Ravishankar Sarawadi, Sridhar Siricilla, Angel Pons, Lean Sheng Tan, Werner Zeh, Raj Astekar. Sukumar Ghorai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70751 ) Change subject: soc/intel/common: Fix cpu index calculation ...................................................................... Patch Set 8: (1 comment) Patchset: PS8: > Pls verify following output and confirm if everything looks good? […] I do see the values are correct: #for c in {0..21}; do echo -e `cat /sys/devices/system/cpu/cpu$c/acpi_cppc/nominal_perf` '\c'; done 15 12 12 12 12 12 12 12 12 15 15 15 15 15 15 15 15 15 15 15 -- To view, visit https://review.coreboot.org/c/coreboot/+/70751 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I69e5e6231dd18b43d439340aaed50eb9edeca3b7 Gerrit-Change-Number: 70751 Gerrit-PatchSet: 8 Gerrit-Owner: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Raj Astekar <raj.astekar(a)intel.com> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Sukumar Ghorai <sukumar.ghorai(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Attention: Raj Astekar <raj.astekar(a)intel.com> Gerrit-Comment-Date: Sat, 07 Jan 2023 03:00:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Kapil Porwal <kapilporwal(a)google.com> Comment-In-Reply-To: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Comment-In-Reply-To: Sukumar Ghorai <sukumar.ghorai(a)intel.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/brya/var/gladios: Add ACPI DmaProperty for gladios
by Kevin Chiu (Code Review) 07 Jan '23

07 Jan '23

Attention is currently required from: Tarun Tuli, Robert Chen. Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71699 ) Change subject: mb/google/brya/var/gladios: Add ACPI DmaProperty for gladios ...................................................................... Patch Set 1: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/71699/comment/57e47deb_0e338f2d PS1, Line 7: mb/google/brya/var/gladios: Add ACPI DmaProperty for gladios Add ACPI DmaProperty for RTL8168 ethernet https://review.coreboot.org/c/coreboot/+/71699/comment/e080e92f_8b8c0255 PS1, Line 12: TEST=emerge-brask coreboot. please also check SSDT -- To view, visit https://review.coreboot.org/c/coreboot/+/71699 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1c4f6ff7b3eda114f4f365a963c089fe584d8aee Gerrit-Change-Number: 71699 Gerrit-PatchSet: 1 Gerrit-Owner: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-CC: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Sat, 07 Jan 2023 02:03:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/brya/var/gladios: Update RTL8168 LAN LED config
by Kevin Chiu (Code Review) 07 Jan '23

07 Jan '23

Attention is currently required from: Tarun Tuli, Robert Chen, Nick Vaccaro, Ricky Chang. Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71697 ) Change subject: mb/google/brya/var/gladios: Update RTL8168 LAN LED config ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/71697 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I17b844b89569fb7653454fd08782fc961c715817 Gerrit-Change-Number: 71697 Gerrit-PatchSet: 6 Gerrit-Owner: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Ricky Chang <rickytlchang(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Ricky Chang <rickytlchang(a)google.com> Gerrit-Comment-Date: Sat, 07 Jan 2023 01:59:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2023