coreboot-gerrit January 2023

coreboot-gerrit@coreboot.org

1 participants
5879 discussions

[S] Change in coreboot[master]: soc/intel/meteorlake: Add support to configure package c-state demotion
by Subrata Banik (Code Review) 07 Jan '23

07 Jan '23

Attention is currently required from: Tarun Tuli, Kapil Porwal, Sukumar Ghorai. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71654 ) Change subject: soc/intel/meteorlake: Add support to configure package c-state demotion ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: > PKGC demotion is suported/enabled in MTL. Thanks then we don't need device tree override. -- To view, visit https://review.coreboot.org/c/coreboot/+/71654 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0a4b0b181349ce41035524482add4336cf83a68b Gerrit-Change-Number: 71654 Gerrit-PatchSet: 1 Gerrit-Owner: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Sukumar Ghorai <sukumar.ghorai(a)intel.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Sukumar Ghorai <sukumar.ghorai(a)intel.com> Gerrit-Comment-Date: Sat, 07 Jan 2023 07:09:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Sukumar Ghorai <sukumar.ghorai(a)intel.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/brya: Increase Resizable BAR address space limit to 33 bits
by Subrata Banik (Code Review) 07 Jan '23

07 Jan '23

Attention is currently required from: Tarun Tuli. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71282 ) Change subject: mb/google/brya: Increase Resizable BAR address space limit to 33 bits ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/71282 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia791be5108fb07a256ae62fc2aee2f057909ef12 Gerrit-Change-Number: 71282 Gerrit-PatchSet: 4 Gerrit-Owner: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Comment-Date: Sat, 07 Jan 2023 07:07:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/brya/var/lisbon: Update RTL8168 LAN LED config
by Ricky Chang (Code Review) 07 Jan '23

07 Jan '23

Attention is currently required from: Tarun Tuli, Robert Chen, Nick Vaccaro. Ricky Chang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71698 ) Change subject: mb/google/brya/var/lisbon: Update RTL8168 LAN LED config ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/71698 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idd5ed2bf7eb4ee5990f2a842cba43f967ae3825e Gerrit-Change-Number: 71698 Gerrit-PatchSet: 2 Gerrit-Owner: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Ricky Chang <rickytlchang(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Sat, 07 Jan 2023 07:02:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/brya/var/gladios: Update RTL8168 LAN LED config
by Ricky Chang (Code Review) 07 Jan '23

07 Jan '23

Attention is currently required from: Tarun Tuli, Robert Chen, Nick Vaccaro. Ricky Chang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71697 ) Change subject: mb/google/brya/var/gladios: Update RTL8168 LAN LED config ...................................................................... Patch Set 6: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/71697 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I17b844b89569fb7653454fd08782fc961c715817 Gerrit-Change-Number: 71697 Gerrit-PatchSet: 6 Gerrit-Owner: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Ricky Chang <rickytlchang(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Sat, 07 Jan 2023 07:02:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/brya/var/gladios: Update RTL8168 LAN LED config
by Kevin Chiu (Code Review) 07 Jan '23

07 Jan '23

Attention is currently required from: Tarun Tuli, Robert Chen, Nick Vaccaro, Ricky Chang. Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71697 ) Change subject: mb/google/brya/var/gladios: Update RTL8168 LAN LED config ...................................................................... Patch Set 6: (1 comment) Patchset: PS6: > Hi Ricky, […] sorry, I misuse "CMD_LED0_LED1" meaning, 0x060f means: 1) LED0 is Active LED 2) LED1 have no function 3) LED2 need to always light up when speed at 100M or 1000M thanks. -- To view, visit https://review.coreboot.org/c/coreboot/+/71697 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I17b844b89569fb7653454fd08782fc961c715817 Gerrit-Change-Number: 71697 Gerrit-PatchSet: 6 Gerrit-Owner: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Ricky Chang <rickytlchang(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Ricky Chang <rickytlchang(a)google.com> Gerrit-Comment-Date: Sat, 07 Jan 2023 07:01:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Comment-In-Reply-To: Ricky Chang <rickytlchang(a)google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/brya/var/gladios: Update RTL8168 LAN LED config
by Kevin Chiu (Code Review) 07 Jan '23

07 Jan '23

Attention is currently required from: Tarun Tuli, Robert Chen, Nick Vaccaro, Ricky Chang. Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71697 ) Change subject: mb/google/brya/var/gladios: Update RTL8168 LAN LED config ...................................................................... Patch Set 6: (1 comment) Patchset: PS6: > Hi Robert, […] Hi Ricky, for RTL8168, it applies the "customized_leds" here: https://source.chromium.org/chromiumos/chromiumos/codesearch/+/main:src/thi… so only config LED0/1, thanks. -- To view, visit https://review.coreboot.org/c/coreboot/+/71697 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I17b844b89569fb7653454fd08782fc961c715817 Gerrit-Change-Number: 71697 Gerrit-PatchSet: 6 Gerrit-Owner: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Ricky Chang <rickytlchang(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Ricky Chang <rickytlchang(a)google.com> Gerrit-Comment-Date: Sat, 07 Jan 2023 06:48:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Ricky Chang <rickytlchang(a)google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/brya/var/gladios: Update RTL8168 LAN LED config
by Ricky Chang (Code Review) 07 Jan '23

07 Jan '23

Attention is currently required from: Tarun Tuli, Robert Chen, Nick Vaccaro. Ricky Chang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71697 ) Change subject: mb/google/brya/var/gladios: Update RTL8168 LAN LED config ...................................................................... Patch Set 6: (1 comment) Patchset: PS6: Hi Robert, based on the b/239513596#comment112, does this cl means 1) LED0 is Active LED 2) LED1 have no function 3) LED2 need to always light up when speed at 100M or 1000M -- To view, visit https://review.coreboot.org/c/coreboot/+/71697 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I17b844b89569fb7653454fd08782fc961c715817 Gerrit-Change-Number: 71697 Gerrit-PatchSet: 6 Gerrit-Owner: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Ricky Chang <rickytlchang(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Sat, 07 Jan 2023 06:42:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/amd: Update pademelon to eval board
by Elyes Haouas (Code Review) 07 Jan '23

07 Jan '23

Elyes Haouas has submitted this change. ( https://review.coreboot.org/c/coreboot/+/71580 ) Change subject: mb/amd: Update pademelon to eval board ...................................................................... mb/amd: Update pademelon to eval board While pademelon may be a desktop board, it's not available for purchase, which means it should be presented here as an eval board. Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: I5038935bb6f2ba530ea6e16ac84c1746efec8e48 Reviewed-on: https://review.coreboot.org/c/coreboot/+/71580 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Felix Held <felix-coreboot(a)felixheld.de> --- M src/mainboard/amd/pademelon/board_info.txt 1 file changed, 17 insertions(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, approved diff --git a/src/mainboard/amd/pademelon/board_info.txt b/src/mainboard/amd/pademelon/board_info.txt index 845e211..e82c669 100644 --- a/src/mainboard/amd/pademelon/board_info.txt +++ b/src/mainboard/amd/pademelon/board_info.txt @@ -1,6 +1,6 @@ Vendor name: AMD Board name: Pademelon -Category: desktop +Category: eval ROM package: SOIC-8 ROM protocol: SPI ROM socketed: n -- To view, visit https://review.coreboot.org/c/coreboot/+/71580 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5038935bb6f2ba530ea6e16ac84c1746efec8e48 Gerrit-Change-Number: 71580 Gerrit-PatchSet: 2 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[master]: mb/google/brya/var/kano: Set the ov2740 to 0 and the hi556 to 1 for SSFC
by David Wu (Code Review) 07 Jan '23

07 Jan '23

Attention is currently required from: Tarun Tuli, Martin L Roth, Nick Vaccaro. David Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71628 ) Change subject: mb/google/brya/var/kano: Set the ov2740 to 0 and the hi556 to 1 for SSFC ...................................................................... Patch Set 1: (1 comment) File src/mainboard/google/brya/variants/kano/overridetree.cb: https://review.coreboot.org/c/coreboot/+/71628/comment/d3744236_bad33c4f PS1, Line 20: option UFC_MIPI_OVTI2740 0 > I still don't understand why UFC_MIPI_HI556 can't just be value 3 in the UFC field, and why the SSFC […] If set UFC_MIPI_HI556 to value 3 in the UFC field, it needs to follow SKU ID to replace mipi camera, which is inconvenient for the factory side, so the factory suggests using SSFC. Kano is a mass production device and does not use SSFC (only one mipi camera ov2740), so we keep the original UFC filed for kano, and then add SSFC for two mipi camera for zydron. -- To view, visit https://review.coreboot.org/c/coreboot/+/71628 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I46fac6c820d6006956680a07198db82225630905 Gerrit-Change-Number: 71628 Gerrit-PatchSet: 1 Gerrit-Owner: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Sat, 07 Jan 2023 05:39:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: David Wu <david_wu(a)quanta.corp-partner.google.com> Comment-In-Reply-To: Martin L Roth <gaumless(a)gmail.com> Comment-In-Reply-To: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/brya/var/gladios: Add ACPI DmaProperty for RTL8168 ethernet
by Kevin Chiu (Code Review) 07 Jan '23

07 Jan '23

Attention is currently required from: Tarun Tuli, Robert Chen, Nick Vaccaro, Ricky Chang. Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71699 ) Change subject: mb/google/brya/var/gladios: Add ACPI DmaProperty for RTL8168 ethernet ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/71699 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1c4f6ff7b3eda114f4f365a963c089fe584d8aee Gerrit-Change-Number: 71699 Gerrit-PatchSet: 3 Gerrit-Owner: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Ricky Chang <rickytlchang(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-CC: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Ricky Chang <rickytlchang(a)google.com> Gerrit-Comment-Date: Sat, 07 Jan 2023 04:34:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2023