Evgeny Zinoviev has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42450 )
Change subject: nb/intel/sandybridge/gma.c: Add Kconfig options for RC6 and RC6p
......................................................................
nb/intel/sandybridge/gma.c: Add Kconfig options for RC6 and RC6p
Add Kconfig options to enable or disable RC6 and RC6p.
TODO
- Not sure if it's OK to allow to enable RC6p alone without RC6p.
If yes then I'll update the patch.
Change-Id: I6166d04b3bcb7a55f1d03c397d87eaa62c64b48b
Signed-off-by: Evgeny Zinoviev <me(a)ch1p.io>
---
M src/northbridge/intel/sandybridge/Kconfig
M src/northbridge/intel/sandybridge/gma.c
2 files changed, 26 insertions(+), 10 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/42450/1
diff --git a/src/northbridge/intel/sandybridge/Kconfig b/src/northbridge/intel/sandybridge/Kconfig
index ef6dc3d..95f1deb 100644
--- a/src/northbridge/intel/sandybridge/Kconfig
+++ b/src/northbridge/intel/sandybridge/Kconfig
@@ -129,4 +129,18 @@
config INTEL_GMA_BCLV_OFFSET
default 0x48254
+config ENABLE_RC6
+ bool "Enable RC6 (Render Standby)"
+ default y
+ help
+ Select this if you want to enable RC6 (Render Standby).
+
+config ENABLE_RC6P
+ depends on ENABLE_RC6
+ bool "Enable RC6p (Deep Render Standby)"
+ default n
+ help
+ Select this if you want to enable RC6p (Deep Render Standby).
+ This should only be selected on Ivy Bridge.
+
endif
diff --git a/src/northbridge/intel/sandybridge/gma.c b/src/northbridge/intel/sandybridge/gma.c
index 8fe2de8..d976530 100644
--- a/src/northbridge/intel/sandybridge/gma.c
+++ b/src/northbridge/intel/sandybridge/gma.c
@@ -450,15 +450,15 @@
gtt_write(0xa06c, 0x000493e0); /* RP Down EI */
gtt_write(0xa070, 0x0000000a); /* RP Idle Hysteresis */
- /*
- * 10a: Enable Render Standby (RC6)
- *
- * IvyBridge should also support DeepRenderStandby.
- *
- * Unfortunately it does not work reliably on all SKUs so
- * disable it here and it can be enabled by the kernel.
- */
- gtt_write(0xa090, 0x88040000); /* HW RC Control */
+ /* 10a: Enable Render Standby (RC6) and Deep Render Standby (RC6p) */
+ reg32 = 0;
+#if CONFIG(ENABLE_RC6)
+ reg32 |= 0x88040000;
+#if CONFIG(ENABLE_RC6P)
+ reg32 |= 0x00020000;
+#endif
+#endif
+ gtt_write(0xa090, reg32);
/* 11: Normal Frequency Request */
/* RPNFREQ_VAL comes from MCHBAR 0x5998 23:16 */
@@ -516,8 +516,10 @@
gtt_write(0xa188, gtt_read(0xa188) | 1);
}
- /* 16: SW RC Control */
+ /* 16: SW RC state: RC6 deepest */
+#if CONFIG(ENABLE_RC6) || CONFIG(ENABLE_RC6P)
gtt_write(0xa094, 0x00060000);
+#endif
/* Setup Digital Port Hotplug */
reg32 = gtt_read(0xc4030);
--
To view, visit https://review.coreboot.org/c/coreboot/+/42450
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6166d04b3bcb7a55f1d03c397d87eaa62c64b48b
Gerrit-Change-Number: 42450
Gerrit-PatchSet: 1
Gerrit-Owner: Evgeny Zinoviev <me(a)ch1p.io>
Gerrit-MessageType: newchange
Michał Żygowski has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43399 )
Change subject: security/intel/bootguard/Kconfig: Select FSP CAR when Boot Guard is enabled
......................................................................
security/intel/bootguard/Kconfig: Select FSP CAR when Boot Guard is enabled
For the time being we do not have a working open-source CAR setup when
Boot Guard is enabled on the platform. Rely on the FSP CAR for now until
we implement a working open solution.
Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Change-Id: I60d04ccae7fd837e6207f384644544130e8dd590
---
M src/security/intel/bootguard/Kconfig
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/43399/1
diff --git a/src/security/intel/bootguard/Kconfig b/src/security/intel/bootguard/Kconfig
index d1d6c3c..6b0b27d 100644
--- a/src/security/intel/bootguard/Kconfig
+++ b/src/security/intel/bootguard/Kconfig
@@ -3,6 +3,7 @@
config INTEL_BOOTGUARD
bool "Intel Boot Guard"
depends on CPU_INTEL_FIRMWARE_INTERFACE_TABLE
+ select FSP_CAR
default n
if INTEL_BOOTGUARD
--
To view, visit https://review.coreboot.org/c/coreboot/+/43399
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I60d04ccae7fd837e6207f384644544130e8dd590
Gerrit-Change-Number: 43399
Gerrit-PatchSet: 1
Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-MessageType: newchange
Hello Usha P,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/40379
to review the following change.
Change subject: soc/intel/common/block/systemagent: Add choice option for PCIEX_LENGTH
......................................................................
soc/intel/common/block/systemagent: Add choice option for PCIEX_LENGTH
This patch adds choice option for PCIEX_LENGTH related Kconfig to avoid
multiple selection from SoC Kconfig.
Change-Id: Icb61e9a0263c058726cc07442af1985a96bf37c2
Signed-off-by: Usha P <usha.p(a)intel.com>
---
M src/soc/intel/common/block/systemagent/Kconfig
1 file changed, 12 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/40379/1
diff --git a/src/soc/intel/common/block/systemagent/Kconfig b/src/soc/intel/common/block/systemagent/Kconfig
index 6dd1f3b..ea75d5b 100644
--- a/src/soc/intel/common/block/systemagent/Kconfig
+++ b/src/soc/intel/common/block/systemagent/Kconfig
@@ -18,14 +18,23 @@
help
This option allows you to select length of PCIEX region.
+choice
+ prompt "Length of PCI Express Base Address Region"
+ default PCIEX_LENGTH_256MB
+ help
+ This is to provide new kconfig option that can be used to
+ select PCI Express Base Address Length.
+
config PCIEX_LENGTH_256MB
- bool
+ bool "256 MiB"
config PCIEX_LENGTH_128MB
- bool
+ bool "128 MiB"
config PCIEX_LENGTH_64MB
- bool
+ bool "64 MiB"
+
+endchoice
config SA_ENABLE_IMR
bool
--
To view, visit https://review.coreboot.org/c/coreboot/+/40379
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icb61e9a0263c058726cc07442af1985a96bf37c2
Gerrit-Change-Number: 40379
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Usha P <usha.p(a)intel.com>
Gerrit-MessageType: newchange