coreboot-gerrit May 2022

coreboot-gerrit@coreboot.org

1 participants
6166 discussions

Change in coreboot[master]: mb/clevo/tgl-u: Add Clevo NV4x Tiger Lake laptop support
by Michał Kopeć (Code Review) 05 May '22

05 May '22

Attention is currently required from: Felix Singer, Michał Żygowski, Angel Pons, Michael Niewöhner. Hello Felix Singer, build bot (Jenkins), Michał Żygowski, Angel Pons, Michael Niewöhner, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/62498 to look at the new patch set (#8). Change subject: mb/clevo/tgl-u: Add Clevo NV4x Tiger Lake laptop support ...................................................................... mb/clevo/tgl-u: Add Clevo NV4x Tiger Lake laptop support Change-Id: Ib373d62d9d18bafdfde2e1acb4e00e3a20ae09bc Signed-off-by: Michał Kopeć <michal.kopec(a)3mdeb.com> --- M src/mainboard/clevo/tgl-u/Kconfig M src/mainboard/clevo/tgl-u/Kconfig.name A src/mainboard/clevo/tgl-u/acpi/mainboard.asl A src/mainboard/clevo/tgl-u/acpi/sleep.asl M src/mainboard/clevo/tgl-u/dsdt.asl A src/mainboard/clevo/tgl-u/mainboard.asl A src/mainboard/clevo/tgl-u/variants/nv40mz/board_info.txt A src/mainboard/clevo/tgl-u/variants/nv40mz/data.vbt A src/mainboard/clevo/tgl-u/variants/nv40mz/devicetree.cb A src/mainboard/clevo/tgl-u/variants/nv40mz/gpio.c A src/mainboard/clevo/tgl-u/variants/nv40mz/gpio_early.c A src/mainboard/clevo/tgl-u/variants/nv40mz/hda_verb.c A src/mainboard/clevo/tgl-u/variants/nv40mz/ramstage.c A src/mainboard/clevo/tgl-u/variants/nv40mz/romstage.c 14 files changed, 783 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/62498/8 -- To view, visit https://review.coreboot.org/c/coreboot/+/62498 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib373d62d9d18bafdfde2e1acb4e00e3a20ae09bc Gerrit-Change-Number: 62498 Gerrit-PatchSet: 8 Gerrit-Owner: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/clevo/tgl-u: Add Clevo NV4x Tiger Lake laptop support
by Michał Kopeć (Code Review) 05 May '22

05 May '22

1 0

Change in coreboot[master]: mb/clevo/tgl-u: Add Clevo NV4x Tiger Lake laptop support
by Michał Kopeć (Code Review) 05 May '22

05 May '22

1 0

Change in coreboot[master]: mb/clevo/tgl-u: Add Clevo NV4x Tiger Lake laptop support
by Michał Kopeć (Code Review) 05 May '22

05 May '22

Attention is currently required from: Felix Singer, Michał Żygowski, Angel Pons, Michael Niewöhner. Michał Kopeć has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62498 ) Change subject: mb/clevo/tgl-u: Add Clevo NV4x Tiger Lake laptop support ...................................................................... Patch Set 7: (14 comments) File src/mainboard/clevo/tgl-u/Kconfig: https://review.coreboot.org/c/coreboot/+/62498/comment/0ebb6fcf_903ccb4e PS6, Line 60: GPP_C14 > GPP_C14_IRQ Done File src/mainboard/clevo/tgl-u/variants/baseboard/devicetree.cb: https://review.coreboot.org/c/coreboot/+/62498/comment/3993ad45_a8ced969 PS3, Line 13: # Disable DPTF : register "dptf_enable" = "0" > Just omit it then? Removed https://review.coreboot.org/c/coreboot/+/62498/comment/5b4648cf_19e4a6d8 PS3, Line 26: # Enable C6 DRAM > Please don't restate the obvious Comment removed https://review.coreboot.org/c/coreboot/+/62498/comment/c9c4a342_03eec4a2 PS3, Line 33: # Acoustic settings > This is not useful, please drop. Comment removed File src/mainboard/clevo/tgl-u/variants/nv40mz/Makefile.inc: https://review.coreboot.org/c/coreboot/+/62498/comment/1b354a20_1db45f3a PS6, Line 3: bootblock-y += gpio.c : : romstage-y += romstage.c : : ramstage-y += gpio.c : ramstage-y += hda_verb.c : > not needed. covered by tgl-u/Makefile. […] File removed File src/mainboard/clevo/tgl-u/variants/nv40mz/devicetree.cb: https://review.coreboot.org/c/coreboot/+/62498/comment/b135ea1a_fb8a4416 PS6, Line 13: # Disable DPTF : register "dptf_enable" = "0" > This can be dropped, default is 0 Removed https://review.coreboot.org/c/coreboot/+/62498/comment/cda55770_08a15890 PS6, Line 83: register "CnviBtCore" = "true" > move down to cnvi dev Moved https://review.coreboot.org/c/coreboot/+/62498/comment/8af45b5d_c1b344f5 PS6, Line 86: GPE configuration : register "pmc_gpe0_dw0" = "PMC_GPP_C" : register "pmc_gpe0_dw1" = "PMC_GPP_E" : register "pmc_gpe0_dw2" = "PMC_GPD" : > move down to pmc dev? Moved File src/mainboard/clevo/tgl-u/variants/nv40mz/gpio.c: https://review.coreboot.org/c/coreboot/+/62498/comment/89a9ac3c_73a6d19b PS6, Line 210: PAD_CFG_GPI_SMI(GPP_E7, NONE, PLTRST, EDGE_SINGLE, INVERT), > board uses espi vwire -> don't configure the gpio Changed to `PAD_NC` File src/mainboard/clevo/tgl-u/variants/nv40mz/ramstage.c: https://review.coreboot.org/c/coreboot/+/62498/comment/23dc3f95_cf1e8005 PS6, Line 12: params->CpuPcieRpAdvancedErrorReporting[0] = 0; > also params->CpuPcieRpLtrEnable[0] = 1; Added both params File src/mainboard/clevo/tgl-u/variants/nv4x/gpio_early.c: https://review.coreboot.org/c/coreboot/+/62498/comment/9f5a70f4_3d63770b PS3, Line 11: PAD_CFG_TERM_GPO(GPP_U4, 0, NONE, DEEP), /* DGPU_RST#_PCH */ : PAD_CFG_TERM_GPO(GPP_U5, 0, NONE, DEEP), /* DGPU_PWR_EN */ > Why not use `PAD_CFG_GPO` instead? […] Switched to `PAD_CFG_GPO` File src/mainboard/clevo/tgl-u/variants/nv4x/overridetree.cb: https://review.coreboot.org/c/coreboot/+/62498/comment/217bb035_a6605c76 PS3, Line 4: # TODO: Check if this is correct > it's not wrong, but the fans should be powerful enough to handle way more power Right, removed the entire power limit config https://review.coreboot.org/c/coreboot/+/62498/comment/ab01096d_f31977a1 PS3, Line 3: # Power limits : # TODO: Check if this is correct : register "power_limits_config[POWER_LIMITS_U_4_CORE]" = "{ : .tdp_pl1_override = 10, : .tdp_pl2_override = 20, : }" : register "power_limits_config[POWER_LIMITS_U_2_CORE]" = "{ : .tdp_pl1_override = 10, : .tdp_pl2_override = 20, : }" > Why not just drop it? Dropped https://review.coreboot.org/c/coreboot/+/62498/comment/87241d61_03f54579 PS3, Line 42: register "HybridStorageMode" = "0" > not needed, 0 is the default Removed -- To view, visit https://review.coreboot.org/c/coreboot/+/62498 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib373d62d9d18bafdfde2e1acb4e00e3a20ae09bc Gerrit-Change-Number: 62498 Gerrit-PatchSet: 7 Gerrit-Owner: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Comment-Date: Thu, 05 May 2022 09:47:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/clevo/tgl-u: Add Clevo NV4x Tiger Lake laptop support
by Michał Kopeć (Code Review) 05 May '22

05 May '22

Attention is currently required from: Felix Singer, Michał Żygowski, Angel Pons, Michael Niewöhner. Hello Felix Singer, build bot (Jenkins), Michał Żygowski, Angel Pons, Michael Niewöhner, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/62498 to look at the new patch set (#7). Change subject: mb/clevo/tgl-u: Add Clevo NV4x Tiger Lake laptop support ...................................................................... mb/clevo/tgl-u: Add Clevo NV4x Tiger Lake laptop support Change-Id: Ib373d62d9d18bafdfde2e1acb4e00e3a20ae09bc Signed-off-by: Michał Kopeć <michal.kopec(a)3mdeb.com> --- M src/mainboard/clevo/tgl-u/Kconfig M src/mainboard/clevo/tgl-u/Kconfig.name A src/mainboard/clevo/tgl-u/variants/nv40mz/board_info.txt A src/mainboard/clevo/tgl-u/variants/nv40mz/data.vbt A src/mainboard/clevo/tgl-u/variants/nv40mz/devicetree.cb A src/mainboard/clevo/tgl-u/variants/nv40mz/gpio.c A src/mainboard/clevo/tgl-u/variants/nv40mz/gpio_early.c A src/mainboard/clevo/tgl-u/variants/nv40mz/hda_verb.c A src/mainboard/clevo/tgl-u/variants/nv40mz/ramstage.c A src/mainboard/clevo/tgl-u/variants/nv40mz/romstage.c 10 files changed, 656 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/62498/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/62498 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib373d62d9d18bafdfde2e1acb4e00e3a20ae09bc Gerrit-Change-Number: 62498 Gerrit-PatchSet: 7 Gerrit-Owner: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/nissa/var/craask: Add supported touchpad
by Tyler Wang (Code Review) 05 May '22

05 May '22

Attention is currently required from: Kangheui Won, Tim Wawrzynczak, Reka Norman, Nick Vaccaro. Hello build bot (Jenkins), Kangheui Won, Reka Norman, Tim Wawrzynczak, Nick Vaccaro, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/64071 to look at the new patch set (#3). Change subject: mb/google/nissa/var/craask: Add supported touchpad ...................................................................... mb/google/nissa/var/craask: Add supported touchpad Add related settings for synaptics touchpad. BUG=b:229938024 TEST=emerge-nissa coreboot Signed-off-by: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Change-Id: I3b3bb5cec56901dadaaa1c5699781df45c237257 --- M src/mainboard/google/brya/variants/craask/overridetree.cb 1 file changed, 9 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/64071/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/64071 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3b3bb5cec56901dadaaa1c5699781df45c237257 Gerrit-Change-Number: 64071 Gerrit-PatchSet: 3 Gerrit-Owner: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Cathy Chen <cathy_chen(a)quanta.corp-partner.google.com> Gerrit-CC: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-CC: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Attention: Kangheui Won <khwon(a)chromium.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/nissa/var/craask: Add support touchpad
by Tyler Wang (Code Review) 05 May '22

05 May '22

Attention is currently required from: Kangheui Won, Tim Wawrzynczak, Reka Norman, Nick Vaccaro. Tyler Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64071 ) Change subject: mb/google/nissa/var/craask: Add support touchpad ...................................................................... Patch Set 2: This change is ready for review. -- To view, visit https://review.coreboot.org/c/coreboot/+/64071 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3b3bb5cec56901dadaaa1c5699781df45c237257 Gerrit-Change-Number: 64071 Gerrit-PatchSet: 2 Gerrit-Owner: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Cathy Chen <cathy_chen(a)quanta.corp-partner.google.com> Gerrit-CC: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-CC: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Attention: Kangheui Won <khwon(a)chromium.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Thu, 05 May 2022 08:59:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/clevo/tgl-u: Add Clevo NV4x Tiger Lake laptop support
by Michał Kopeć (Code Review) 05 May '22

05 May '22

1 0

Change in coreboot[master]: mb/google/nissa/var/craask: Add Synaptics touchpad
by Tyler Wang (Code Review) 05 May '22

05 May '22

Tyler Wang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/64071 ) Change subject: mb/google/nissa/var/craask: Add Synaptics touchpad ...................................................................... mb/google/nissa/var/craask: Add Synaptics touchpad Add related setting for synaptics touchpad. BUG=b:229938024 TEST=emerge-nissa coreboot Signed-off-by: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Change-Id: I3b3bb5cec56901dadaaa1c5699781df45c237257 --- M src/mainboard/google/brya/variants/craask/overridetree.cb 1 file changed, 9 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/64071/1 diff --git a/src/mainboard/google/brya/variants/craask/overridetree.cb b/src/mainboard/google/brya/variants/craask/overridetree.cb index 610e990..997ec2d 100644 --- a/src/mainboard/google/brya/variants/craask/overridetree.cb +++ b/src/mainboard/google/brya/variants/craask/overridetree.cb @@ -222,6 +222,15 @@ register "probed" = "1" device i2c 15 on end end + chip drivers/i2c/hid + register "generic.hid" = ""PNP0C50"" + register "generic.desc" = ""Synaptics Touchpad"" + register "generic.irq" = "ACPI_IRQ_WAKE_LEVEL_LOW(GPP_F14_IRQ)" + register "generic.wake" = "GPE0_DW2_14" + register "generic.probed" = "1" + register "hid_desc_reg_offset" = "0x20" + device i2c 0x2c on end + end end device ref hda on chip drivers/generic/max98357a -- To view, visit https://review.coreboot.org/c/coreboot/+/64071 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3b3bb5cec56901dadaaa1c5699781df45c237257 Gerrit-Change-Number: 64071 Gerrit-PatchSet: 1 Gerrit-Owner: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: cpu/x86/mp_init.c: Add wait_finished_mp_run_on_all_cpus
by Kane Chen (Code Review) 05 May '22

05 May '22

Attention is currently required from: Arthur Heymans, Subrata Banik, Tim Wawrzynczak. Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63566 ) Change subject: cpu/x86/mp_init.c: Add wait_finished_mp_run_on_all_cpus ...................................................................... Patch Set 5: (4 comments) Patchset: PS5: Hi all, File src/cpu/x86/mp_init.c: https://review.coreboot.org/c/coreboot/+/63566/comment/7ec44671_d3ca38f0 PS4, Line 882: : : static void store_ap_busy(bool *ap_busy_flag, bool val) : { : asm volatile ("mov %1, %0\n" : : "=m" (*ap_busy_flag) : : "r" (val) : : "memory" : ); : } : : static bool read_ap_busy(bool *ap_busy_flag) : { : bool ret; : asm volatile ("mov %1, %0\n" : : "=r" (ret) : : "m" (*ap_busy_flag) : : "memory" : ); : return ret; : } > Since bool == int compiler-wise I think the atomic_t type & ops will work fine. done https://review.coreboot.org/c/coreboot/+/63566/comment/a16ed0b8_6290d8b2 PS4, Line 994: if (lcb.logical_cpu_number && (cur_cpu != : lcb.logical_cpu_number)) : continue; > +1 done File src/cpu/x86/mp_init.c: https://review.coreboot.org/c/coreboot/+/63566/comment/8c6aee1f_92b7f908 PS5, Line 932: if (atomic_read(&ap_busy[i]) == -1) : cpus_finish++; Instead of using 0/1 for busy/not busy, this patchset use 1 and -1 to indicate busy/not busy because of the below reason. size of ap_busy array is CONFIG_MAX_CPUS however the actual running cpu could be less than CONFIG_MAX_CPUS That means when all AP takes the jobs, some elements of ap_busy are always 0 since actual running cpu could be less than CONFIG_MAX_CPUS ex: Assume we have 4 cpus, and CONFIG_MAX_CPUS = 8 when APs take jobs, ap_busy is like [1,1,1,1,0,0,0,0] when APs finishes all the task, ap_busy is like [0,0,0,0,0,0,0,0] the last four elements is always 0 since the dut doesn't have that many CPUs. in this case cpus_finish will be 8 and never equal to global_num_aps (4 in this case) This is why i can't simply use 0/1 to judge it's busy/not busy. hope this explains. -- To view, visit https://review.coreboot.org/c/coreboot/+/63566 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8d1d49bca410c821a3ad0347548afc42eb860594 Gerrit-Change-Number: 63566 Gerrit-PatchSet: 5 Gerrit-Owner: Kane Chen <kane.chen(a)intel.corp-partner.google.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Thu, 05 May 2022 07:33:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Arthur Heymans <arthur.heymans(a)9elements.com> Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2022