coreboot-gerrit December 2022

coreboot-gerrit@coreboot.org

1 participants
6828 discussions

[S] Change in coreboot[master]: util/crossgcc: Update GCC from 11.2 to 11.3
by Elyes Haouas (Code Review) 01 Dec '22

01 Dec '22

Attention is currently required from: Felix Singer, Martin L Roth, Arthur Heymans. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70221 ) Change subject: util/crossgcc: Update GCC from 11.2 to 11.3 ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Should we go through all of gcc versions? maybe we can wait "arm-trusted-firmware" for binutils fix and upgrade to latest binutils, solve the issues we have with gnat & lib/gnat, then upgrade GCC? -- To view, visit https://review.coreboot.org/c/coreboot/+/70221 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8810bbb238b01985774ff8da1e246ab1b192e663 Gerrit-Change-Number: 70221 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Thu, 01 Dec 2022 11:50:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/cmn/tcss: Skip sending CONN IPC command during S3 resume
by Subrata Banik (Code Review) 01 Dec '22

01 Dec '22

Subrata Banik has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/70222 ) Change subject: soc/intel/cmn/tcss: Skip sending CONN IPC command during S3 resume ...................................................................... soc/intel/cmn/tcss: Skip sending CONN IPC command during S3 resume This patch skips sending CONN IPC command to PMC if system is resuming from S3. Sending CONN IPC command as part of `tcss_configure_dp_mode()` function results into ERROR while system is resuming from S3. BUG=b:260984500 TEST=Able to test on Google/Rex. Without this patch: [ERROR] pmc_send_ipc_cmd status: fatal [ERROR] Port 1 connect request failed [SPEW ] [TCSS] TcssInit() - End With this patch: No error seen during S3 resume. Signed-off-by: Subrata Banik <subratabanik(a)google.com> Change-Id: I1dab7dc8b4ad76ca0c9630456803c1b9a320fe40 --- M src/soc/intel/common/block/tcss/tcss.c 1 file changed, 28 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/70222/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/70222 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1dab7dc8b4ad76ca0c9630456803c1b9a320fe40 Gerrit-Change-Number: 70222 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: util/crossgcc: Update GCC from 11.2 to 11.3
by Elyes Haouas (Code Review) 01 Dec '22

01 Dec '22

Attention is currently required from: Felix Singer. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70221 ) Change subject: util/crossgcc: Update GCC from 11.2 to 11.3 ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: patches are missing -- To view, visit https://review.coreboot.org/c/coreboot/+/70221 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8810bbb238b01985774ff8da1e246ab1b192e663 Gerrit-Change-Number: 70221 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Comment-Date: Thu, 01 Dec 2022 11:43:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: cpu/intel/speedstep: Have nb and sb code provide c5/c6/slfm
by Werner Zeh (Code Review) 01 Dec '22

01 Dec '22

Attention is currently required from: Stefan Ott, Angel Pons, Arthur Heymans, Alexander Couzens. Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69297 ) Change subject: cpu/intel/speedstep: Have nb and sb code provide c5/c6/slfm ...................................................................... Patch Set 18: Code-Review+1 (2 comments) File src/northbridge/intel/gm45/northbridge.c: https://review.coreboot.org/c/coreboot/+/69297/comment/7ab44db5_5290f895 PS18, Line 264: __pci_0_00_0 Shall this better be 'pcidev_on_root(0, 0);'? File src/southbridge/intel/i82801ix/lpc.c: https://review.coreboot.org/c/coreboot/+/69297/comment/f2f52bb4_99b44bb3 PS18, Line 143: __pci_0_1f_0 pcidev_on_root(0x1f, 0)? -- To view, visit https://review.coreboot.org/c/coreboot/+/69297 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4a9b1e684a7927259adae9b1d42a67e907722109 Gerrit-Change-Number: 69297 Gerrit-PatchSet: 18 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Stefan Ott <coreboot(a)desire.ch> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Ott <coreboot(a)desire.ch> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 01 Dec 2022 11:43:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/cmn/tcss: Skip sending CONN IPC command during S3 resume
by Subrata Banik (Code Review) 01 Dec '22

01 Dec '22

Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/70222 ) Change subject: soc/intel/cmn/tcss: Skip sending CONN IPC command during S3 resume ...................................................................... soc/intel/cmn/tcss: Skip sending CONN IPC command during S3 resume This patch skips sending CONN IPC command to PMC if system is resuming from S3. Sending CONN IPC command as part of `tcss_configure_dp_mode()` function results into ERROR while system is resuming from S3. Without this patch: [ERROR] pmc_send_ipc_cmd status: fatal [ERROR] Port 1 connect request failed [SPEW ] [TCSS] TcssInit() - End With this patch: No error seen during S3 resume. Signed-off-by: Subrata Banik <subratabanik(a)google.com> Change-Id: I1dab7dc8b4ad76ca0c9630456803c1b9a320fe40 --- M src/soc/intel/common/block/tcss/tcss.c 1 file changed, 26 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/70222/1 diff --git a/src/soc/intel/common/block/tcss/tcss.c b/src/soc/intel/common/block/tcss/tcss.c index b4a5a0e..5896b93 100644 --- a/src/soc/intel/common/block/tcss/tcss.c +++ b/src/soc/intel/common/block/tcss/tcss.c @@ -415,7 +415,7 @@ if (tcss_ops.configure_aux_bias_pads) tcss_ops.configure_aux_bias_pads(aux_bias_pads); - if (CONFIG(ENABLE_TCSS_DISPLAY_DETECTION)) + if (CONFIG(ENABLE_TCSS_DISPLAY_DETECTION) && !platform_is_resuming()) tcss_configure_dp_mode(port_map, num_ports); } -- To view, visit https://review.coreboot.org/c/coreboot/+/70222 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1dab7dc8b4ad76ca0c9630456803c1b9a320fe40 Gerrit-Change-Number: 70222 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: util/crossgcc: Update GCC from 11.2 to 11.3
by Felix Singer (Code Review) 01 Dec '22

01 Dec '22

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/70221 ) Change subject: util/crossgcc: Update GCC from 11.2 to 11.3 ...................................................................... util/crossgcc: Update GCC from 11.2 to 11.3 While the work on updating GCC to version 12 is still WIP, update it to the latest minor release 11.3. Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Change-Id: I8810bbb238b01985774ff8da1e246ab1b192e663 --- M util/crossgcc/buildgcc D util/crossgcc/sum/gcc-11.2.0.tar.xz.cksum A util/crossgcc/sum/gcc-11.3.0.tar.xz.cksum 3 files changed, 15 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/70221/1 diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc index 5b26922..76ec454a 100755 --- a/util/crossgcc/buildgcc +++ b/util/crossgcc/buildgcc @@ -35,7 +35,7 @@ GMP_VERSION=6.2.1 MPFR_VERSION=4.1.1 MPC_VERSION=1.2.1 -GCC_VERSION=11.2.0 +GCC_VERSION=11.3.0 BINUTILS_VERSION=2.37 IASL_VERSION="R10_20_22" # CLANG version number diff --git a/util/crossgcc/sum/gcc-11.2.0.tar.xz.cksum b/util/crossgcc/sum/gcc-11.2.0.tar.xz.cksum deleted file mode 100644 index 071c352..0000000 --- a/util/crossgcc/sum/gcc-11.2.0.tar.xz.cksum +++ /dev/null @@ -1 +0,0 @@ -f902ccacecf8949978d6261e9f1d034cff73ffdb tarballs/gcc-11.2.0.tar.xz diff --git a/util/crossgcc/sum/gcc-11.3.0.tar.xz.cksum b/util/crossgcc/sum/gcc-11.3.0.tar.xz.cksum new file mode 100644 index 0000000..a4d2bd5 --- /dev/null +++ b/util/crossgcc/sum/gcc-11.3.0.tar.xz.cksum @@ -0,0 +1 @@ +cf86a48278f9a6f4b03d4390550577b20353b4e9 tarballs/gcc-11.3.0.tar.xz -- To view, visit https://review.coreboot.org/c/coreboot/+/70221 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8810bbb238b01985774ff8da1e246ab1b192e663 Gerrit-Change-Number: 70221 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: drivers/generic/nau8315: Allow custom _HID from config
by David Lin (Code Review) 01 Dec '22

01 Dec '22

Attention is currently required from: Van Chen, Frank Wu, Alan Lee, Dtrain Hsu, Ian Feng, John Hsu, Eric Lai, Amanda Hwang. David Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69965 ) Change subject: drivers/generic/nau8315: Allow custom _HID from config ...................................................................... Patch Set 1: (1 comment) File src/drivers/generic/nau8315/nau8315.c: https://review.coreboot.org/c/coreboot/+/69965/comment/6d2fc7ae_f0b61f80 PS1, Line 29: acpigen_write_name_string("_HID", config->hid); > We can do it in the same patch or you can submit new one. […] Hi Eric, Since NAU8825 don't use same driver, I will ignore it, just focus on NAU8315/NAU8318. So this style is like as kernel driver with compatible id. I will check with you by mail. -- To view, visit https://review.coreboot.org/c/coreboot/+/69965 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia6f02e495eeb06290947edc9e44fa25a4ce18956 Gerrit-Change-Number: 69965 Gerrit-PatchSet: 1 Gerrit-Owner: David Lin <CTLIN0(a)nuvoton.com> Gerrit-Reviewer: Alan Lee <alan_lee(a)compal.corp-partner.google.com> Gerrit-Reviewer: AlanKY Lee <alanky_lee(a)compal.corp-partner.google.com> Gerrit-Reviewer: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Reviewer: John Hsu <KCHSU0(a)nuvoton.com> Gerrit-Reviewer: Mac Chiang <mac.chiang(a)intel.corp-partner.google.com> Gerrit-Reviewer: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: CT Lin <ctlin0(a)nuvoton.corp-partner.google.com> Gerrit-Attention: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-Attention: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-Attention: Alan Lee <alan_lee(a)compal.corp-partner.google.com> Gerrit-Attention: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Attention: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Attention: John Hsu <KCHSU0(a)nuvoton.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-Comment-Date: Thu, 01 Dec 2022 11:39:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Comment-In-Reply-To: David Lin <CTLIN0(a)nuvoton.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/brya/var/lisbon: Update fw_config STORAGE field
by Kevin Chiu (Code Review) 01 Dec '22

01 Dec '22

Kevin Chiu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/70220 ) Change subject: mb/google/brya/var/lisbon: Update fw_config STORAGE field ...................................................................... mb/google/brya/var/lisbon: Update fw_config STORAGE field option STORAGE_EMMC 0 option STORAGE_NVME 1 BUG=b:246657849 TEST=FW_NAME=lisbon emerge-brask coreboot Signed-off-by: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Change-Id: Idd52112743ee0d64aca630e54511503607770d71 --- M src/mainboard/google/brya/variants/lisbon/overridetree.cb 1 file changed, 23 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/70220/1 diff --git a/src/mainboard/google/brya/variants/lisbon/overridetree.cb b/src/mainboard/google/brya/variants/lisbon/overridetree.cb index 6c471b3..7524b67 100644 --- a/src/mainboard/google/brya/variants/lisbon/overridetree.cb +++ b/src/mainboard/google/brya/variants/lisbon/overridetree.cb @@ -1,7 +1,7 @@ fw_config - field AUDIO 0 2 - option AUDIO_UNKNOWN 0 - option ALC5682IVS_I2S 1 + field STORAGE 1 1 + option STORAGE_EMMC 0 + option STORAGE_NVME 1 end end @@ -149,7 +149,8 @@ .clk_src = 0, .flags = PCIE_RP_LTR | PCIE_RP_AER, }" - end + probe STORAGE STORAGE_NVME + end #NVMe device ref tbt_pcie_rp0 off end device ref tbt_pcie_rp1 off end device ref tbt_pcie_rp2 off end @@ -173,9 +174,7 @@ register "property_list[0].type" = "ACPI_DP_TYPE_INTEGER" register "property_list[0].name" = ""realtek,jd-src"" register "property_list[0].integer" = "1" - device i2c 1a on - probe AUDIO ALC5682IVS_I2S - end + device i2c 1a on end end end #I2C0 device ref i2c1 on @@ -211,6 +210,7 @@ .clk_req = 4, .flags = PCIE_RP_HOTPLUG | PCIE_RP_AER, }" + probe STORAGE STORAGE_EMMC end #PCIE12 EMMC device ref gspi1 off end device ref pch_espi on -- To view, visit https://review.coreboot.org/c/coreboot/+/70220 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idd52112743ee0d64aca630e54511503607770d71 Gerrit-Change-Number: 70220 Gerrit-PatchSet: 1 Gerrit-Owner: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: google/veyron: Fix add type to function definition
by Elyes Haouas (Code Review) 01 Dec '22

01 Dec '22

Attention is currently required from: Arthur Heymans. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70138 ) Change subject: google/veyron: Fix add type to function definition ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: "-Wold-style-definition" gcc flag will warn I think. (CB:70205) -- To view, visit https://review.coreboot.org/c/coreboot/+/70138 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2efb42e653b0deb56ba6b0c9789764a9cabc552e Gerrit-Change-Number: 70138 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Thu, 01 Dec 2022 11:20:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: [test]Makefile.inc: Use 'Wold-style-definition'
by Elyes Haouas (Code Review) 01 Dec '22

01 Dec '22

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/70205 ) Change subject: [test]Makefile.inc: Use 'Wold-style-definition' ...................................................................... [test]Makefile.inc: Use 'Wold-style-definition' Change-Id: I734cfffe3e89996ab13e846cc08e13753f24f742 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M Makefile.inc 1 file changed, 11 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/70205/1 diff --git a/Makefile.inc b/Makefile.inc index ef565c2..3eaabaf 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -414,7 +414,7 @@ CFLAGS_common += -pipe -g -nostdinc -std=gnu11 CFLAGS_common += -nostdlib -Wall -Wundef -Wstrict-prototypes -Wmissing-prototypes CFLAGS_common += -Wwrite-strings -Wredundant-decls -Wno-trigraphs -Wimplicit-fallthrough -CFLAGS_common += -Wshadow -Wdate-time -Wtype-limits -Wvla +CFLAGS_common += -Wshadow -Wdate-time -Wtype-limits -Wvla -Wold-style-definition CFLAGS_common += -Wdangling-else CFLAGS_common += -fno-common -ffreestanding -fno-builtin -fomit-frame-pointer CFLAGS_common += -fstrict-aliasing -ffunction-sections -fdata-sections -fno-pie -- To view, visit https://review.coreboot.org/c/coreboot/+/70205 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I734cfffe3e89996ab13e846cc08e13753f24f742 Gerrit-Change-Number: 70205 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2022