Attention is currently required from: Jeff Daly, Sean Rhodes, Vanessa Eusebio, Kyösti Mälkki.
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70050 )
Change subject: soc/intel: Adopt new common/pmbase
......................................................................
Patch Set 5:
(1 comment)
File src/soc/intel/common/block/pmc/pmclib.c:
https://review.coreboot.org/c/coreboot/+/70050/comment/db2063b0_775b560c
PS5, Line 563:
There was a patch to get rind of this extra space (CB:69806)
--
To view, visit https://review.coreboot.org/c/coreboot/+/70050
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I473ebefcf8e0c929f6cbf6b5c0d7e8f5af72856d
Gerrit-Change-Number: 70050
Gerrit-PatchSet: 5
Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Jeff Daly <jeffd(a)silicom-usa.com>
Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Attention: Jeff Daly <jeffd(a)silicom-usa.com>
Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Attention: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com>
Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Comment-Date: Thu, 01 Dec 2022 12:43:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Kyösti Mälkki.
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70049 )
Change subject: sb/intel/common: Rename and inline {read,write}_pmbaseX()
......................................................................
Patch Set 4:
(1 comment)
File src/southbridge/intel/common/pmbase.h:
https://review.coreboot.org/c/coreboot/+/70049/comment/0b9bbcdc_80c45895
PS4, Line 14: #elif CONFIG(TCO_SPACE_NOT_YET_SPLIT)
: /* Must let TCO registers 0x60..0x80 through. */
: #define PMSIZE 0x80
: #elif CONFIG(SOC_INTEL_COMMON_BLOCK_TCO_ENABLE_THROUGH_SMBUS)
: /* TCO registers 0x60..0x80 moved, these are now GPEs. */
: #define PMSIZE 0x80
What about
#elif CONFIG(TCO_SPACE_NOT_YET_SPLIT) || CONFIG(SOC_INTEL_COMMON_BLOCK_TCO_ENABLE_THROUGH_SMBUS)
Or do you expect the second path become a different value in future?
--
To view, visit https://review.coreboot.org/c/coreboot/+/70049
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia3b88e93b9dca298585e6906f92842f4cafab2e2
Gerrit-Change-Number: 70049
Gerrit-PatchSet: 4
Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Comment-Date: Thu, 01 Dec 2022 12:37:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Angel Pons, Kyösti Mälkki.
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70041 )
Change subject: arch/x86: Add bitwise operations for IO space
......................................................................
Patch Set 2:
(1 comment)
File src/arch/x86/include/arch/io_bitops.h:
https://review.coreboot.org/c/coreboot/+/70041/comment/a69d945c_2b1a549a
PS2, Line 1: /* SPDX-License-Identifier: GPL-2.0-only */
Do we really want this file to be called 'io_bitops.h'? It provides general read/write functions as well and I find it a bit misleading. How about io_ops.h instead?
--
To view, visit https://review.coreboot.org/c/coreboot/+/70041
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia3e1146f062dced1b75195846ea65a44e2bd4482
Gerrit-Change-Number: 70041
Gerrit-PatchSet: 2
Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Comment-Date: Thu, 01 Dec 2022 12:32:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Jeff Daly, Jonathan Zhang, Angel Pons, Arthur Heymans, Kyösti Mälkki, Tarun Tuli, Sean Rhodes, Subrata Banik, Johnny Lin, Kapil Porwal, Christian Walter, Vanessa Eusebio, Lean Sheng Tan, Tim Chu.
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70048 )
Change subject: [WIP] sb,soc/intel/common: Add common get_pmbase()
......................................................................
Patch Set 4:
(9 comments)
File src/soc/intel/apollolake/acpi.c:
https://review.coreboot.org/c/coreboot/+/70048/comment/b8e09d2d_7bdbcf73
PS4, Line 80:
There was a patch recently removing all the spaces after type casts.
https://review.coreboot.org/c/coreboot/+/70048/comment/9809d6d8_e825ac3f
PS4, Line 219:
same here
https://review.coreboot.org/c/coreboot/+/70048/comment/1681fd97_52e58df6
PS4, Line 243:
same here
File src/soc/intel/braswell/pmutil.c:
https://review.coreboot.org/c/coreboot/+/70048/comment/fa57011f_a7473380
PS4, Line 14: include <security/vboot/vbnv.h>
Once you start sorting the includes in this patch you could move console/console.h, too.
File src/soc/intel/broadwell/pch/pmutil.c:
https://review.coreboot.org/c/coreboot/+/70048/comment/04ede38d_1b8b6376
PS4, Line 15: #include <console/console.h>
Move this line in the right order as well?
File src/soc/intel/skylake/pmutil.c:
https://review.coreboot.org/c/coreboot/+/70048/comment/0a0e7a06_e4870643
PS4, Line 139:
extra space
https://review.coreboot.org/c/coreboot/+/70048/comment/78e80630_8a181ffc
PS4, Line 144:
extra space
File src/soc/intel/xeon_sp/pmutil.c:
https://review.coreboot.org/c/coreboot/+/70048/comment/ce5cc877_eb9838eb
PS4, Line 95:
extra space
https://review.coreboot.org/c/coreboot/+/70048/comment/ef000d0d_a6c4a906
PS4, Line 100:
extra space
--
To view, visit https://review.coreboot.org/c/coreboot/+/70048
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idda34aa376caef94383699e6c17ed1f588bca37e
Gerrit-Change-Number: 70048
Gerrit-PatchSet: 4
Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Jeff Daly <jeffd(a)silicom-usa.com>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jeff Daly <jeffd(a)silicom-usa.com>
Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com>
Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Comment-Date: Thu, 01 Dec 2022 12:23:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer, Frans Hendriks, Patrick Rudolph, Jonathan Zhang, Jeremy Soller, Arthur Heymans, Michael Niewöhner, Piotr Król, Tim Crawford, Tarun Tuli, Nico Huber, Michał Żygowski, Maxim Polyakov, Johnny Lin, Christian Walter, Morgan Jang, Werner Zeh, Tim Chu.
Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69303 )
Change subject: mb/*: Remove lapic from devicetree
......................................................................
Patch Set 13:
(1 comment)
File src/mainboard/gigabyte/ga-945gcm-s2l/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/69303/comment/fb60602b_6bbb565d
PS13, Line 6: ops i945_cpu_bus_ops
: chip cpu/intel/socket_LGA775
: device lapic 0 on end
: end
I think this is related to https://review.coreboot.org/c/coreboot/+/69299
--
To view, visit https://review.coreboot.org/c/coreboot/+/69303
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5258a769c0f0ee4bbc4facc19737eed187b68c73
Gerrit-Change-Number: 69303
Gerrit-PatchSet: 13
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Erik van den Bogaert <ebogaert(a)eltan.com>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com>
Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Reviewer: Jonathon Hall <jonathon.hall(a)puri.sm>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Maxim Polyakov <max.senia.poliak(a)gmail.com>
Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Morgan Jang <Morgan_Jang(a)wiwynn.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com>
Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Frans Hendriks <fhendriks(a)eltan.com>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Attention: Piotr Król <piotr.krol(a)3mdeb.com>
Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Maxim Polyakov <max.senia.poliak(a)gmail.com>
Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Morgan Jang <Morgan_Jang(a)wiwynn.com>
Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Comment-Date: Thu, 01 Dec 2022 12:01:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Lean Sheng Tan, Kyösti Mälkki.
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70151 )
Change subject: soc/intel/elkhartlake: Move TCO_NO_REBOOT flag support
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Is this bit really generic enough across all platforms? I remember back than that it is not, see CB:61177 (at least Apollo Lake does not have it in the docs).
--
To view, visit https://review.coreboot.org/c/coreboot/+/70151
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifa08e99761eb735eb2f733b86527867d74ced7d8
Gerrit-Change-Number: 70151
Gerrit-PatchSet: 1
Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Comment-Date: Thu, 01 Dec 2022 11:55:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer, Martin L Roth, Julius Werner, Arthur Heymans.
Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70221 )
Change subject: util/crossgcc: Update GCC from 11.2 to 11.3
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS1:
> Should we go through all of gcc versions? […]
While on it, should we also define the minimum required (supported) GCC version?
--
To view, visit https://review.coreboot.org/c/coreboot/+/70221
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8810bbb238b01985774ff8da1e246ab1b192e663
Gerrit-Change-Number: 70221
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Thu, 01 Dec 2022 11:54:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-MessageType: comment
Attention is currently required from: Martin L Roth, Arthur Heymans, Elyes Haouas.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70221 )
Change subject: util/crossgcc: Update GCC from 11.2 to 11.3
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS1:
> patches are missing
Thanks!
--
To view, visit https://review.coreboot.org/c/coreboot/+/70221
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8810bbb238b01985774ff8da1e246ab1b192e663
Gerrit-Change-Number: 70221
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Thu, 01 Dec 2022 11:51:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer, Martin L Roth, Arthur Heymans.
Hello Martin L Roth, Arthur Heymans, Elyes Haouas,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/70221
to look at the new patch set (#2).
Change subject: util/crossgcc: Update GCC from 11.2 to 11.3
......................................................................
util/crossgcc: Update GCC from 11.2 to 11.3
While the work on updating GCC to version 12 is still WIP, update it
to the latest minor release 11.3.
Signed-off-by: Felix Singer <felixsinger(a)posteo.net>
Change-Id: I8810bbb238b01985774ff8da1e246ab1b192e663
---
M util/crossgcc/buildgcc
R util/crossgcc/patches/gcc-11.3.0_ada-musl_workaround.patch
R util/crossgcc/patches/gcc-11.3.0_asan_shadow_offset_callback.patch
R util/crossgcc/patches/gcc-11.3.0_gnat.patch
R util/crossgcc/patches/gcc-11.3.0_libcpp.patch
R util/crossgcc/patches/gcc-11.3.0_libgcc.patch
D util/crossgcc/sum/gcc-11.2.0.tar.xz.cksum
A util/crossgcc/sum/gcc-11.3.0.tar.xz.cksum
8 files changed, 15 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/70221/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/70221
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8810bbb238b01985774ff8da1e246ab1b192e663
Gerrit-Change-Number: 70221
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-MessageType: newpatchset