Attention is currently required from: Stefan Ott, Arthur Heymans, Alexander Couzens.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69297 )
Change subject: cpu/intel/speedstep: Have nb and sb code provide c5/c6/slfm
......................................................................
Patch Set 18: Code-Review+1
(4 comments)
File src/mainboard/lenovo/t400/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/69297/comment/928c7c8d_ad4384de
PS18, Line 23: # Enable C5, C6
: register "c5" = "1"
: register "c6" = "1"
Where did this go?
File src/mainboard/lenovo/x200/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/69297/comment/8bf14350_e8c20e66
PS18, Line 23: # Enable C5, C6
: register "c5" = "1"
: register "c6" = "1"
Where did this go?
File src/mainboard/roda/rk9/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/69297/comment/9bbc109f_be056391
PS18, Line 16: # Enable C5, C6
: register "c5" = "1"
: register "c6" = "1"
Where did this go?
File src/northbridge/intel/gm45/northbridge.c:
https://review.coreboot.org/c/coreboot/+/69297/comment/93f6dec4_75c997d6
PS18, Line 264: __pci_0_00_0
> OK, fine with me. I just was wondering since when we have started to use entries from static. […]
`config_of_soc()` would also work.
--
To view, visit https://review.coreboot.org/c/coreboot/+/69297
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4a9b1e684a7927259adae9b1d42a67e907722109
Gerrit-Change-Number: 69297
Gerrit-PatchSet: 18
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Stefan Ott <coreboot(a)desire.ch>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Stefan Ott <coreboot(a)desire.ch>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Thu, 01 Dec 2022 15:01:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz>
Comment-In-Reply-To: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-MessageType: comment
Attention is currently required from: Paul Menzel, Christian Walter, Maximilian Brune, David Milosevic.
Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67553 )
Change subject: mb/prodrive/atlas: Enable GPP_B14 buzzer support
......................................................................
Patch Set 13:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/67553/comment/d600b263_5daef7d6
PS12, Line 16: disable
> disable*s*
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/67553
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib5e7787a47509ed09818d8515d21a80196fb1ec6
Gerrit-Change-Number: 67553
Gerrit-PatchSet: 13
Gerrit-Owner: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: David Milosevic <David.Milosevic(a)9elements.com>
Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Attention: David Milosevic <David.Milosevic(a)9elements.com>
Gerrit-Comment-Date: Thu, 01 Dec 2022 14:58:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Paul Menzel, Christian Walter, Maximilian Brune, Lean Sheng Tan, David Milosevic.
Hello build bot (Jenkins), Christian Walter, Angel Pons, Maximilian Brune, David Milosevic,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/67553
to look at the new patch set (#13).
Change subject: mb/prodrive/atlas: Enable GPP_B14 buzzer support
......................................................................
mb/prodrive/atlas: Enable GPP_B14 buzzer support
Per Intel doc 621483, 26.1.1 - NMI_STS_CNT, 8254 timer is required
for Speaker Data output (buzzer) at GPP_B14 NF1, as it is using
8254 timer counter 2 output. However when 8254 timer is used, S0ix
will not work as 8254 has to be gated instead. For further info on
s0ix requirements, refer to Intel doc 610002 (Modern Standby Unified
Checklist).
This CL also disables s0ix because it is not required by the
platform.
Signed-off-by: Lean Sheng Tan <sheng.tan(a)9elements.com>
Change-Id: Ib5e7787a47509ed09818d8515d21a80196fb1ec6
---
M src/mainboard/prodrive/atlas/Kconfig
M src/mainboard/prodrive/atlas/devicetree.cb
2 files changed, 32 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/67553/13
--
To view, visit https://review.coreboot.org/c/coreboot/+/67553
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib5e7787a47509ed09818d8515d21a80196fb1ec6
Gerrit-Change-Number: 67553
Gerrit-PatchSet: 13
Gerrit-Owner: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: David Milosevic <David.Milosevic(a)9elements.com>
Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Attention: David Milosevic <David.Milosevic(a)9elements.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Paul Menzel, Christian Walter, Maximilian Brune, Lean Sheng Tan, David Milosevic.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67553 )
Change subject: mb/prodrive/atlas: Enable GPP_B14 buzzer support
......................................................................
Patch Set 12: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/67553/comment/b7b515d0_1786d2cd
PS12, Line 16: disable
disable*s*
--
To view, visit https://review.coreboot.org/c/coreboot/+/67553
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib5e7787a47509ed09818d8515d21a80196fb1ec6
Gerrit-Change-Number: 67553
Gerrit-PatchSet: 12
Gerrit-Owner: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: David Milosevic <David.Milosevic(a)9elements.com>
Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Attention: David Milosevic <David.Milosevic(a)9elements.com>
Gerrit-Comment-Date: Thu, 01 Dec 2022 14:57:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Jeff Daly.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60829 )
Change subject: util/ifdtool: Add additional regions for platforms that support them
......................................................................
Patch Set 13:
(1 comment)
File util/ifdtool/ifdtool.c:
https://review.coreboot.org/c/coreboot/+/60829/comment/48a3267b_8c98d090
PS13, Line 47: Device Exp2
> What is device exp? Is there any documents about it?
Device Expansion, no clue.
--
To view, visit https://review.coreboot.org/c/coreboot/+/60829
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia5a450e5002e9f8edee76ca7c2eede9906df36c5
Gerrit-Change-Number: 60829
Gerrit-PatchSet: 13
Gerrit-Owner: Jeff Daly <jeffd(a)silicom-usa.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Attention: Jeff Daly <jeffd(a)silicom-usa.com>
Gerrit-Comment-Date: Thu, 01 Dec 2022 14:56:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-MessageType: comment
Attention is currently required from: Stefan Ott, Angel Pons, Arthur Heymans, Alexander Couzens.
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69297 )
Change subject: cpu/intel/speedstep: Have nb and sb code provide c5/c6/slfm
......................................................................
Patch Set 18: Code-Review+2
(1 comment)
File src/northbridge/intel/gm45/northbridge.c:
https://review.coreboot.org/c/coreboot/+/69297/comment/5bac4673_1e79684a
PS18, Line 264: __pci_0_00_0
> > Shall this better be 'pcidev_on_root(0, 0);'? […]
OK, fine with me. I just was wondering since when we have started to use entries from static.c directly.
--
To view, visit https://review.coreboot.org/c/coreboot/+/69297
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4a9b1e684a7927259adae9b1d42a67e907722109
Gerrit-Change-Number: 69297
Gerrit-PatchSet: 18
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Stefan Ott <coreboot(a)desire.ch>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Stefan Ott <coreboot(a)desire.ch>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Thu, 01 Dec 2022 14:53:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz>
Comment-In-Reply-To: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-MessageType: comment
Attention is currently required from: Jeff Daly.
Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60829 )
Change subject: util/ifdtool: Add additional regions for platforms that support them
......................................................................
Patch Set 13:
(1 comment)
File util/ifdtool/ifdtool.c:
https://review.coreboot.org/c/coreboot/+/60829/comment/c8e33936_5f23ef8f
PS13, Line 47: Device Exp2
What is device exp? Is there any documents about it?
--
To view, visit https://review.coreboot.org/c/coreboot/+/60829
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia5a450e5002e9f8edee76ca7c2eede9906df36c5
Gerrit-Change-Number: 60829
Gerrit-PatchSet: 13
Gerrit-Owner: Jeff Daly <jeffd(a)silicom-usa.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Attention: Jeff Daly <jeffd(a)silicom-usa.com>
Gerrit-Comment-Date: Thu, 01 Dec 2022 14:38:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment