Attention is currently required from: Jason Nien, Martin Roth, Tim Van Patten.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70215 )
Change subject: google/skyrim/Kconfig: Enable DPTC for Frostflow
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
I'm assuming the STT params are all set?
--
To view, visit https://review.coreboot.org/c/coreboot/+/70215
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2fb5c711a01a995c805eb4509f7b04bb41588365
Gerrit-Change-Number: 70215
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Van Patten <timvp(a)google.com>
Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Attention: Tim Van Patten <timvp(a)google.com>
Gerrit-Comment-Date: Thu, 01 Dec 2022 18:47:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: David Wu, Tarun Tuli, Nick Vaccaro, Tyler Wang.
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70194 )
Change subject: mb/google/brya/var/zydron: Set touchpads to use probed flag
......................................................................
Patch Set 1: -Code-Review
(1 comment)
Patchset:
PS1:
According to the error, this CL needs to switch to using "detect" instead of "probed".
--
To view, visit https://review.coreboot.org/c/coreboot/+/70194
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib9a5ad5dc97cfaf1c10e7ff1e68b72af6add64c6
Gerrit-Change-Number: 70194
Gerrit-PatchSet: 1
Gerrit-Owner: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com>
Gerrit-Comment-Date: Thu, 01 Dec 2022 18:16:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Martin L Roth, Subrata Banik, Rizwan Qureshi, Krishna P Bhat D, Ronak Kanabar.
Harsha B R has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70227 )
Change subject: src/ec/intel: Create common code for board_id implementation
......................................................................
Patch Set 2:
(2 comments)
File Makefile.inc:
https://review.coreboot.org/c/coreboot/+/70227/comment/8c192e8b_23b425fe
PS1, Line 83: y
> CONFIG(EC_ACPI)
Done
File src/ec/intel/board_id.h:
https://review.coreboot.org/c/coreboot/+/70227/comment/38376606_28c388d7
PS1, Line 6: /*
: * Returns board_id
: */
> use single line commenting style
Ack
--
To view, visit https://review.coreboot.org/c/coreboot/+/70227
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If133f6a72b8c3e1d8811a11f91e4556beb8c16e0
Gerrit-Change-Number: 70227
Gerrit-PatchSet: 2
Gerrit-Owner: Harsha B R <harsha.b.r(a)intel.com>
Gerrit-Reviewer: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-CC: Balaji Manigandan <balaji.manigandan(a)intel.com>
Gerrit-CC: Haribalaraman Ramasubramanian <haribalaraman.r(a)intel.com>
Gerrit-CC: Usha P <usha.p(a)intel.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Attention: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com>
Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com>
Gerrit-Comment-Date: Thu, 01 Dec 2022 17:46:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Martin L Roth, Harsha B R, Rizwan Qureshi, Krishna P Bhat D, Ronak Kanabar.
Hello Martin L Roth, Subrata Banik, Rizwan Qureshi, Krishna P Bhat D, Ronak Kanabar,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/70227
to look at the new patch set (#2).
Change subject: src/ec/intel: Create common code for board_id implementation
......................................................................
src/ec/intel: Create common code for board_id implementation
This patch creates initial common code structure for board_id
implementation for intel rvp platforms. Board_id helps in
identifying the platform with respect to CHROME_EC and INTEL_EC
(Windows_EC). Changes include
1. Create initial board_id.c and board_id.h
2. Modify the Makefile to include src/ec/intel directory
BUG=b:260654043
TEST=Able to build with the patch and boot the mtlrvp platform with the
subsequent patches in the train
Signed-off-by: Harsha B R <harsha.b.r(a)intel.com>
Change-Id: If133f6a72b8c3e1d8811a11f91e4556beb8c16e0
---
M Makefile.inc
A src/ec/intel/Makefile.inc
A src/ec/intel/board_id.c
A src/ec/intel/board_id.h
4 files changed, 48 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/70227/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/70227
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If133f6a72b8c3e1d8811a11f91e4556beb8c16e0
Gerrit-Change-Number: 70227
Gerrit-PatchSet: 2
Gerrit-Owner: Harsha B R <harsha.b.r(a)intel.com>
Gerrit-Reviewer: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-CC: Balaji Manigandan <balaji.manigandan(a)intel.com>
Gerrit-CC: Haribalaraman Ramasubramanian <haribalaraman.r(a)intel.com>
Gerrit-CC: Usha P <usha.p(a)intel.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Harsha B R <harsha.b.r(a)intel.com>
Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Attention: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com>
Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Christian Walter, Angel Pons, Lean Sheng Tan.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67415 )
Change subject: [do not merge] mb/prodrive/atlas: for testing
......................................................................
Patch Set 13: Verified+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/67415
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I37c686aacea130c99e8ab2fe984b150a7ad6f82d
Gerrit-Change-Number: 67415
Gerrit-PatchSet: 13
Gerrit-Owner: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Comment-Date: Thu, 01 Dec 2022 17:03:03 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment