coreboot-gerrit October 2022

coreboot-gerrit@coreboot.org

1 participants
5881 discussions

[S] Change in coreboot[master]: util/amdfwtiil: Add Mendocino to usage
by Fred Reitberger (Code Review) 07 Oct '22

07 Oct '22

Fred Reitberger has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/68226 ) Change subject: util/amdfwtiil: Add Mendocino to usage ...................................................................... util/amdfwtiil: Add Mendocino to usage Add missing Mendocino soc to usage print. Signed-off-by: Fred Reitberger <reitbergerfred(a)gmail.com> Change-Id: I8b995fccc23dcca87d45cc13fbb1ebbc1f0e2add --- M util/amdfwtool/amdfwtool.c 1 file changed, 13 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/68226/1 diff --git a/util/amdfwtool/amdfwtool.c b/util/amdfwtool/amdfwtool.c index b9c36a5..288cd88 100644 --- a/util/amdfwtool/amdfwtool.c +++ b/util/amdfwtool/amdfwtool.c @@ -204,7 +204,7 @@ printf(" area\n"); printf("--soc-name <socname> Specify SOC name. Supported names are\n"); printf(" Stoneyridge, Raven, Picasso, Renoir, Cezanne\n"); - printf(" Morgana, Glinda, or Lucienne\n"); + printf(" Mendocino, Morgana, Glinda, or Lucienne\n"); printf("\nEmbedded Firmware Structure options used by the PSP:\n"); printf("--spi-speed <HEX_VAL> SPI fast speed to place in EFS Table\n"); printf(" 0x0 66.66Mhz\n"); -- To view, visit https://review.coreboot.org/c/coreboot/+/68226 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8b995fccc23dcca87d45cc13fbb1ebbc1f0e2add Gerrit-Change-Number: 68226 Gerrit-PatchSet: 1 Gerrit-Owner: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: util/amdfwtool: Add preliminary code for morgana & glinda SOCs
by Fred Reitberger (Code Review) 07 Oct '22

07 Oct '22

Attention is currently required from: Martin L Roth. Fred Reitberger has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68193 ) Change subject: util/amdfwtool: Add preliminary code for morgana & glinda SOCs ...................................................................... Patch Set 2: (1 comment) File util/amdfwtool/amdfwtool.c: https://review.coreboot.org/c/coreboot/+/68193/comment/92912c28_0053d8b0 PS2, Line 1940: return PLATFORM_GLENDA; This should be PLATFORM_GLINDA to fix the build error -- To view, visit https://review.coreboot.org/c/coreboot/+/68193 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I766ce4a5863c55cbc4bef074ac5219b498c48c7f Gerrit-Change-Number: 68193 Gerrit-PatchSet: 2 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Fri, 07 Oct 2022 17:57:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: util/lint/lint-stable-003-whitespace: Fix shell variable name
by Fred Reitberger (Code Review) 07 Oct '22

07 Oct '22

Fred Reitberger has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/68225 ) Change subject: util/lint/lint-stable-003-whitespace: Fix shell variable name ...................................................................... util/lint/lint-stable-003-whitespace: Fix shell variable name Fix shell variable "LINTDIR" so that helper_functions.sh can be found. TEST=`./util/lint/lint lint-stable --junit` no longer prints "cannot open /helper_functions.sh: No such file" Signed-off-by: Fred Reitberger <reitbergerfred(a)gmail.com> Change-Id: I68f2e65fa1c9297ad6b58b77576deaeef8bd76e3 --- M util/lint/lint-stable-003-whitespace 1 file changed, 16 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/68225/1 diff --git a/util/lint/lint-stable-003-whitespace b/util/lint/lint-stable-003-whitespace index e46d93e..0611f25 100755 --- a/util/lint/lint-stable-003-whitespace +++ b/util/lint/lint-stable-003-whitespace @@ -4,7 +4,7 @@ # DESCR: Check for superfluous whitespace in the tree -INTDIR="$( +LINTDIR="$( cd -- "$(dirname "$0")" > /dev/null 2>&1 || return pwd -P )" -- To view, visit https://review.coreboot.org/c/coreboot/+/68225 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I68f2e65fa1c9297ad6b58b77576deaeef8bd76e3 Gerrit-Change-Number: 68225 Gerrit-PatchSet: 1 Gerrit-Owner: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: soc/amd/common: Add morgana SoC to psp_efs.h
by Marshall Dawson (Code Review) 07 Oct '22

07 Oct '22

Attention is currently required from: Jason Glenesk, Raul Rangel, Martin L Roth, Matt DeVillier, Fred Reitberger, Felix Held. Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68194 ) Change subject: soc/amd/common: Add morgana SoC to psp_efs.h ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/68194 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I17d9bda1b6010e44c188b134ee17cbfff5071c7a Gerrit-Change-Number: 68194 Gerrit-PatchSet: 2 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Fri, 07 Oct 2022 17:32:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: util/amdfwtool: Add preliminary code for morgana & glinda SOCs
by Marshall Dawson (Code Review) 07 Oct '22

07 Oct '22

Attention is currently required from: Martin L Roth, Fred Reitberger. Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68193 ) Change subject: util/amdfwtool: Add preliminary code for morgana & glinda SOCs ...................................................................... Patch Set 2: Code-Review+2 (1 comment) File util/amdfwtool/amdfwtool.c: https://review.coreboot.org/c/coreboot/+/68193/comment/77695eec_8db221b3 PS2, Line 207: printf(" Morgana, Glinda, or Lucienne\n"); > Should Mendocindo be in here too? Ack. Fred, that's an easy opportunity for you to boost your CL count 😄 Easier to do it as a follow-on to this one IMO. -- To view, visit https://review.coreboot.org/c/coreboot/+/68193 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I766ce4a5863c55cbc4bef074ac5219b498c48c7f Gerrit-Change-Number: 68193 Gerrit-PatchSet: 2 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Comment-Date: Fri, 07 Oct 2022 17:31:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: vc/amd/fsp: Add Morgana FSP vendorcode
by Marshall Dawson (Code Review) 07 Oct '22

07 Oct '22

Attention is currently required from: Martin L Roth, Martin Roth. Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68192 ) Change subject: vc/amd/fsp: Add Morgana FSP vendorcode ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/68192 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic53c59404f96c73c55eb2648113c5ced26d6e20c Gerrit-Change-Number: 68192 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Comment-Date: Fri, 07 Oct 2022 17:27:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: vc/amd/fsp: Make common directory
by Marshall Dawson (Code Review) 07 Oct '22

07 Oct '22

Attention is currently required from: Martin L Roth, Martin Roth. Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68191 ) Change subject: vc/amd/fsp: Make common directory ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/68191 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I37ed98a67b066598fdebcc5b034e64dc639fda7f Gerrit-Change-Number: 68191 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Comment-Date: Fri, 07 Oct 2022 17:24:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: util/amdfwtool: Add preliminary code for morgana & glinda SOCs
by Fred Reitberger (Code Review) 07 Oct '22

07 Oct '22

Attention is currently required from: Martin L Roth. Fred Reitberger has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68193 ) Change subject: util/amdfwtool: Add preliminary code for morgana & glinda SOCs ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File util/amdfwtool/amdfwtool.c: https://review.coreboot.org/c/coreboot/+/68193/comment/38b131b1_dd879d9d PS2, Line 207: printf(" Morgana, Glinda, or Lucienne\n"); Should Mendocindo be in here too? -- To view, visit https://review.coreboot.org/c/coreboot/+/68193 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I766ce4a5863c55cbc4bef074ac5219b498c48c7f Gerrit-Change-Number: 68193 Gerrit-PatchSet: 2 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Fri, 07 Oct 2022 17:23:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: vc/amd/fsp: Add Morgana FSP vendorcode
by Fred Reitberger (Code Review) 07 Oct '22

07 Oct '22

Attention is currently required from: Martin L Roth, Martin Roth. Fred Reitberger has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68192 ) Change subject: vc/amd/fsp: Add Morgana FSP vendorcode ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/68192 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic53c59404f96c73c55eb2648113c5ced26d6e20c Gerrit-Change-Number: 68192 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Comment-Date: Fri, 07 Oct 2022 17:16:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: vc/amd/fsp: Make common directory
by Fred Reitberger (Code Review) 07 Oct '22

07 Oct '22

Attention is currently required from: Martin L Roth, Martin Roth. Fred Reitberger has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68191 ) Change subject: vc/amd/fsp: Make common directory ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/68191 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I37ed98a67b066598fdebcc5b034e64dc639fda7f Gerrit-Change-Number: 68191 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Comment-Date: Fri, 07 Oct 2022 17:15:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2022