Attention is currently required from: Paul Menzel, Nick Vaccaro, Scott Chao.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60270 )
Change subject: mb/google/brya/var/gimble: Decrease touchscreen T3 timing to 200ms
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60270/comment/cb6de46d_b1451af0
PS3, Line 9: We set T3 as 300ms to meet Elan's spec, but the resume/suspend times are greater than 500ms, which is the spec for Chromebooks. The actual kernel timing has been measured, and given the ACPI delay after deasserting reset in addition to
: the delay until the kernel driver accesses the device, delaying
: only 200ms in the ACPI method is also sufficient to meet the 300ms
: requirement.
reflow text for 72 characters wide please
--
To view, visit https://review.coreboot.org/c/coreboot/+/60270
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4bb4eda09686cb59b6e19c741aa2b78d84332d2a
Gerrit-Change-Number: 60270
Gerrit-PatchSet: 3
Gerrit-Owner: Scott Chao <scott_chao(a)wistron.corp-partner.google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Anfernee Chen <anfernee_chen(a)wistron.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Attention: Scott Chao <scott_chao(a)wistron.corp-partner.google.com>
Gerrit-Comment-Date: Wed, 05 Jan 2022 02:44:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: shkim, Henry Sun, SH Kim, Paul Menzel, Karthik Ramasubramanian.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60273 )
Change subject: mb/google/dedede/var/bugzzy: Increase reset_delay_ms for touch screen
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
Patchset:
PS2:
What is the spec for post-reset delay?
--
To view, visit https://review.coreboot.org/c/coreboot/+/60273
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I34cbc82e2d691266389d498e77d8389cdee23efe
Gerrit-Change-Number: 60273
Gerrit-PatchSet: 2
Gerrit-Owner: shkim <sh_.kim(a)samsung.com>
Gerrit-Reviewer: Edward Doan <edoan(a)chromium.org>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: SH Kim <sh_.kim(a)samsung.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: shkim <sh_.kim(a)samsung.com>
Gerrit-Attention: Henry Sun <henrysun(a)google.com>
Gerrit-Attention: SH Kim <sh_.kim(a)samsung.corp-partner.google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Wed, 05 Jan 2022 02:41:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Anson Tseng, Frank Chu, Nick Vaccaro, Zhuohao Lee.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59557 )
Change subject: mb/google/volteer/var/delbin: Add fw_config probe for ALC5682-VD & VS
......................................................................
Patch Set 7:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/59557/comment/3466d9c0_626f89fc
PS7, Line 18: TEST=ALC5682-VD/ALC5682I-VS audio codec can work
BRANCH=volteer
--
To view, visit https://review.coreboot.org/c/coreboot/+/59557
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ieef638f78edd3428e572a76f06fb9c8757278971
Gerrit-Change-Number: 59557
Gerrit-PatchSet: 7
Gerrit-Owner: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Anson Tseng <ansontseng(a)google.com>
Gerrit-Reviewer: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Hank Lin <hank2_lin(a)pegatron.corp-partner.google.com>
Gerrit-CC: Kane Chen <kane_chen(a)pegatron.corp-partner.google.com>
Gerrit-CC: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com>
Gerrit-Attention: Anson Tseng <ansontseng(a)google.com>
Gerrit-Attention: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Attention: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Comment-Date: Wed, 05 Jan 2022 02:40:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Anson Tseng, Frank Chu, Nick Vaccaro, Zhuohao Lee.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59557 )
Change subject: mb/google/volteer/var/delbin: Add fw_config probe for ALC5682-VD & VS
......................................................................
Patch Set 7:
(1 comment)
File src/mainboard/google/volteer/variants/delbin/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/59557/comment/79be6f30_2a6da169
PS6, Line 148: device i2c 1a on end
> suggestion: if you add an alias here, you can simplify the variant. […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/59557
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ieef638f78edd3428e572a76f06fb9c8757278971
Gerrit-Change-Number: 59557
Gerrit-PatchSet: 7
Gerrit-Owner: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Anson Tseng <ansontseng(a)google.com>
Gerrit-Reviewer: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Hank Lin <hank2_lin(a)pegatron.corp-partner.google.com>
Gerrit-CC: Kane Chen <kane_chen(a)pegatron.corp-partner.google.com>
Gerrit-CC: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com>
Gerrit-Attention: Anson Tseng <ansontseng(a)google.com>
Gerrit-Attention: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Attention: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Comment-Date: Wed, 05 Jan 2022 02:40:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: David Wu, Tim Wawrzynczak, Kane Chen, Curtis Chen.
David Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59762 )
Change subject: mb/google/brya/{kano,taeko}: Change reset type of CPU PCIe vGPIOs
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Kano and Taeko have changed reset type of CPU PCIe vGPIOs. Thanks.
https://review.coreboot.org/c/coreboot/+/59749 --> Teako
https://review.coreboot.org/c/coreboot/+/60334 --> Kano
--
To view, visit https://review.coreboot.org/c/coreboot/+/59762
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I599b6b50f1a71923dd3acc9c16ef1d6b62c9f8fb
Gerrit-Change-Number: 59762
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Curtis Chen <curtis.chen(a)intel.com>
Gerrit-Reviewer: David Wu <david_wu(a)quantatw.com>
Gerrit-Reviewer: Kane Chen <kane.chen(a)intel.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-CC: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: YH Lin <yueherngl(a)google.com>
Gerrit-Attention: David Wu <david_wu(a)quantatw.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Kane Chen <kane.chen(a)intel.com>
Gerrit-Attention: Curtis Chen <curtis.chen(a)intel.com>
Gerrit-Comment-Date: Wed, 05 Jan 2022 02:39:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Ravi kumar, Paul Menzel, Ravi Kumar Bokka, Sudheer Amrabadi.
mturney mturney has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56642 )
Change subject: google/herobrine: configure gpio to detect board ID
......................................................................
Patch Set 38:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56642/comment/6ca51ff1_cf34688d
PS37, Line 7: google/herobrine: configure gpio to detect board ID.
> Please remove the dot/period at the end of the commit message summary.
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/56642
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6de2a7e7b11ecce8325e0fd44dc7221d73729390
Gerrit-Change-Number: 56642
Gerrit-PatchSet: 38
Gerrit-Owner: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Ravi Kumar Bokka <c_rbokka(a)qualcomm.corp-partner.google.com>
Gerrit-CC: Sudheer Amrabadi <samrabad(a)codeaurora.org>
Gerrit-CC: mturney mturney <quic_mturney(a)quicinc.com>
Gerrit-Attention: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Ravi Kumar Bokka <c_rbokka(a)qualcomm.corp-partner.google.com>
Gerrit-Attention: Sudheer Amrabadi <samrabad(a)codeaurora.org>
Gerrit-Comment-Date: Wed, 05 Jan 2022 02:34:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Ravi kumar, Ravi Kumar Bokka, Sudheer Amrabadi.
mturney mturney has uploaded a new patch set (#38) to the change originally created by Ravi kumar. ( https://review.coreboot.org/c/coreboot/+/56642 )
Change subject: google/herobrine: configure gpio to detect board ID
......................................................................
google/herobrine: configure gpio to detect board ID
BUG=b:182963902, b:193807794
TEST=Validated on qualcomm sc7280 development board
Signed-off-by: Ravi Kumar Bokka <rbokka(a)codeaurora.org>
Change-Id: I6de2a7e7b11ecce8325e0fd44dc7221d73729390
---
M src/mainboard/google/herobrine/board.h
M src/mainboard/google/herobrine/boardid.c
2 files changed, 13 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/56642/38
--
To view, visit https://review.coreboot.org/c/coreboot/+/56642
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6de2a7e7b11ecce8325e0fd44dc7221d73729390
Gerrit-Change-Number: 56642
Gerrit-PatchSet: 38
Gerrit-Owner: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Ravi Kumar Bokka <c_rbokka(a)qualcomm.corp-partner.google.com>
Gerrit-CC: Sudheer Amrabadi <samrabad(a)codeaurora.org>
Gerrit-Attention: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Attention: Ravi Kumar Bokka <c_rbokka(a)qualcomm.corp-partner.google.com>
Gerrit-Attention: Sudheer Amrabadi <samrabad(a)codeaurora.org>
Gerrit-MessageType: newpatchset