coreboot-gerrit January 2022

coreboot-gerrit@coreboot.org

1 participants
6716 discussions

Change in coreboot[master]: mb/google/brya: Use PAD config macro to add lock support
by Meera Ravindranath (Code Review) 05 Jan '22

05 Jan '22

Attention is currently required from: Subrata Banik, Maulik V Vaghela, Tim Wawrzynczak, Nick Vaccaro, EricR Lai. Hello build bot (Jenkins), Subrata Banik, Maulik V Vaghela, Tim Wawrzynczak, Nick Vaccaro, EricR Lai, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/60320 to look at the new patch set (#5). Change subject: mb/google/brya: Use PAD config macro to add lock support ...................................................................... mb/google/brya: Use PAD config macro to add lock support Use PAD config macro to add lock support for SD Card and Touch pad GPIOs. BUG=b:211573253 TEST=Boot to OS, issue warm reboot and see SD card and Touch pad enumerating. Signed-off-by: Meera Ravindranath <meera.ravindranath(a)intel.com> Change-Id: I558bab39f935ab31a89541c6498a73af70cbf9ee --- M src/mainboard/google/brya/variants/baseboard/brya/gpio.c 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/60320/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/60320 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I558bab39f935ab31a89541c6498a73af70cbf9ee Gerrit-Change-Number: 60320 Gerrit-PatchSet: 5 Gerrit-Owner: Meera Ravindranath <meera.ravindranath(a)intel.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/brya: Enable CNVi DDR RFIM for base board brya
by Ronak Kanabar (Code Review) 05 Jan '22

05 Jan '22

Attention is currently required from: Tim Wawrzynczak, Paul Menzel, Sumeet R Pawnikar. Ronak Kanabar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60740 ) Change subject: mb/google/brya: Enable CNVi DDR RFIM for base board brya ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: > My understanding is we are letting each OEM decide if they want this feature enabled or not, and typ […] this request came from sumeet let me check with him. -- To view, visit https://review.coreboot.org/c/coreboot/+/60740 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6ad826d0039e400f219c2d407c51762c1751a909 Gerrit-Change-Number: 60740 Gerrit-PatchSet: 4 Gerrit-Owner: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Comment-Date: Wed, 05 Jan 2022 05:45:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/guybrush/var/dewatt: Update unused GPIO pins
by Kenneth Chan (Code Review) 05 Jan '22

05 Jan '22

Kenneth Chan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60782 ) Change subject: mb/google/guybrush/var/dewatt: Update unused GPIO pins ...................................................................... Patch Set 2: (64 comments) File src/mainboard/google/guybrush/variants/dewatt/gpio.c: https://review.coreboot.org/c/coreboot/+/60782/comment/0c1ae1ae_f4fbee62 PS1, Line 16: /* Unused TP245*/ > > code indent should use tabs where possible […] Done https://review.coreboot.org/c/coreboot/+/60782/comment/97dacbf3_6556bdc1 PS1, Line 17: PAD_NC(GPIO_8), > > please, no spaces at the start of a line […] Done https://review.coreboot.org/c/coreboot/+/60782/comment/37930a4c_d74ca838 PS1, Line 17: PAD_NC(GPIO_8), > > code indent should use tabs where possible […] Done https://review.coreboot.org/c/coreboot/+/60782/comment/3b4a304b_f8b43e6a PS1, Line 18: /* Unused TP244*/ > > code indent should use tabs where possible […] Done https://review.coreboot.org/c/coreboot/+/60782/comment/2d4c206c_e824e1cb PS1, Line 19: PAD_NC(GPIO_11), > > code indent should use tabs where possible […] Done https://review.coreboot.org/c/coreboot/+/60782/comment/db483215_9de3f355 PS1, Line 19: PAD_NC(GPIO_11), > > please, no spaces at the start of a line […] Done https://review.coreboot.org/c/coreboot/+/60782/comment/89645b24_e2561f07 PS1, Line 20: /* Unused TP194*/ > > code indent should use tabs where possible […] Done https://review.coreboot.org/c/coreboot/+/60782/comment/8505c08a_a6d1539e PS1, Line 21: PAD_NC(GPIO_17), > > please, no spaces at the start of a line […] Done https://review.coreboot.org/c/coreboot/+/60782/comment/77cbcdd9_84886b95 PS1, Line 21: PAD_NC(GPIO_17), > > code indent should use tabs where possible […] Done https://review.coreboot.org/c/coreboot/+/60782/comment/2f057311_1423f76c PS1, Line 22: /* Unused TP195*/ > > code indent should use tabs where possible […] Done https://review.coreboot.org/c/coreboot/+/60782/comment/774f9cd7_7493ea60 PS1, Line 23: PAD_NC(GPIO_18), > > code indent should use tabs where possible […] Done https://review.coreboot.org/c/coreboot/+/60782/comment/ca15b2a1_487908f7 PS1, Line 23: PAD_NC(GPIO_18), > > please, no spaces at the start of a line […] Done https://review.coreboot.org/c/coreboot/+/60782/comment/1d0864c8_5cb5fa06 PS1, Line 24: /* Unused TP243*/ > > code indent should use tabs where possible […] Done https://review.coreboot.org/c/coreboot/+/60782/comment/5522053c_e2b17aca PS1, Line 25: PAD_NC(GPIO_21), > > please, no spaces at the start of a line […] Done https://review.coreboot.org/c/coreboot/+/60782/comment/5f939db1_101f3b27 PS1, Line 25: PAD_NC(GPIO_21), > > code indent should use tabs where possible […] Done https://review.coreboot.org/c/coreboot/+/60782/comment/d7a5953b_5b268998 PS1, Line 26: /* Unused TP196*/ > > code indent should use tabs where possible […] Done https://review.coreboot.org/c/coreboot/+/60782/comment/e7864499_b4c17eef PS1, Line 27: PAD_NC(GPIO_24), > > code indent should use tabs where possible […] Done https://review.coreboot.org/c/coreboot/+/60782/comment/a4f6541e_bb7b99e6 PS1, Line 27: PAD_NC(GPIO_24), > > please, no spaces at the start of a line […] Done https://review.coreboot.org/c/coreboot/+/60782/comment/b1aef25c_77ac0834 PS1, Line 28: /* Unused TP219*/ > > code indent should use tabs where possible […] Done https://review.coreboot.org/c/coreboot/+/60782/comment/f409f828_d0af27f9 PS1, Line 29: PAD_NC(GPIO_42), > > please, no spaces at the start of a line […] Done https://review.coreboot.org/c/coreboot/+/60782/comment/5a632a98_86a0f9f9 PS1, Line 29: PAD_NC(GPIO_42), > > code indent should use tabs where possible […] Done https://review.coreboot.org/c/coreboot/+/60782/comment/e4fb4950_fa838b45 PS1, Line 30: /* Unused TP217*/ > > code indent should use tabs where possible […] Done https://review.coreboot.org/c/coreboot/+/60782/comment/b57a9630_5bf39ed0 PS1, Line 31: PAD_NC(GPIO_69), > > code indent should use tabs where possible […] Done https://review.coreboot.org/c/coreboot/+/60782/comment/8219a924_ad24258a PS1, Line 31: PAD_NC(GPIO_69), > > please, no spaces at the start of a line […] Done https://review.coreboot.org/c/coreboot/+/60782/comment/59054798_2d98642c PS1, Line 32: /* Unused TP235*/ > > code indent should use tabs where possible […] Done https://review.coreboot.org/c/coreboot/+/60782/comment/9246e425_ebb1f5a5 PS1, Line 33: PAD_NC(GPIO_115), > > please, no spaces at the start of a line […] Done https://review.coreboot.org/c/coreboot/+/60782/comment/02a2bbbd_56e888b5 PS1, Line 33: PAD_NC(GPIO_115), > > code indent should use tabs where possible […] Done https://review.coreboot.org/c/coreboot/+/60782/comment/36a985b7_411ef653 PS1, Line 34: /* Unused TP205*/ > > code indent should use tabs where possible […] Done https://review.coreboot.org/c/coreboot/+/60782/comment/e942a9a9_cdb2bb75 PS1, Line 35: PAD_NC(GPIO_116), > > code indent should use tabs where possible […] Done https://review.coreboot.org/c/coreboot/+/60782/comment/b3334fb4_80f8206b PS1, Line 35: PAD_NC(GPIO_116), > > please, no spaces at the start of a line […] Done https://review.coreboot.org/c/coreboot/+/60782/comment/f4027013_3265d7e6 PS1, Line 36: /* Unused TP226*/ > > code indent should use tabs where possible […] Done https://review.coreboot.org/c/coreboot/+/60782/comment/061f0b7d_849f9004 PS1, Line 37: PAD_NC(GPIO_140), > > code indent should use tabs where possible […] Done https://review.coreboot.org/c/coreboot/+/60782/comment/a5de0f43_0f980862 PS1, Line 37: PAD_NC(GPIO_140), > > please, no spaces at the start of a line […] Done https://review.coreboot.org/c/coreboot/+/60782/comment/65a9ba6d_a0b6b9e9 PS1, Line 38: /* Unused TP225*/ > > code indent should use tabs where possible […] Done https://review.coreboot.org/c/coreboot/+/60782/comment/be55c60f_3a967da8 PS1, Line 39: PAD_NC(GPIO_142), > > please, no spaces at the start of a line […] Done https://review.coreboot.org/c/coreboot/+/60782/comment/4c847b04_5ea15583 PS1, Line 39: PAD_NC(GPIO_142), > > code indent should use tabs where possible […] Done https://review.coreboot.org/c/coreboot/+/60782/comment/0c53c188_163dcb0f PS1, Line 40: /* Unused TP227*/ > > code indent should use tabs where possible […] Done https://review.coreboot.org/c/coreboot/+/60782/comment/da6e2658_d09c8f51 PS1, Line 41: PAD_NC(GPIO_144), > > code indent should use tabs where possible […] Done https://review.coreboot.org/c/coreboot/+/60782/comment/cb93b784_99e3a0ba PS1, Line 41: PAD_NC(GPIO_144), > > please, no spaces at the start of a line […] Done https://review.coreboot.org/c/coreboot/+/60782/comment/bf11b3fa_7230d1c8 PS1, Line 45: /* Unused TP245*/ > > code indent should use tabs where possible […] Done https://review.coreboot.org/c/coreboot/+/60782/comment/7fa1062e_4bfb5cfa PS1, Line 46: PAD_NC(GPIO_8), > > code indent should use tabs where possible […] Done https://review.coreboot.org/c/coreboot/+/60782/comment/e334935e_e791e472 PS1, Line 46: PAD_NC(GPIO_8), > > please, no spaces at the start of a line […] Done https://review.coreboot.org/c/coreboot/+/60782/comment/bbb5c30d_cda557c5 PS1, Line 47: /* Unused TP195*/ > > code indent should use tabs where possible […] Done https://review.coreboot.org/c/coreboot/+/60782/comment/226bff16_7bd541ff PS1, Line 48: PAD_NC(GPIO_18), > > code indent should use tabs where possible […] Done https://review.coreboot.org/c/coreboot/+/60782/comment/917740a1_8a12d8f6 PS1, Line 48: PAD_NC(GPIO_18), > > please, no spaces at the start of a line […] Done https://review.coreboot.org/c/coreboot/+/60782/comment/acb7241e_cb121b18 PS1, Line 49: /* Unused TP196*/ > > code indent should use tabs where possible […] Done https://review.coreboot.org/c/coreboot/+/60782/comment/b5581167_960623f0 PS1, Line 50: PAD_NC(GPIO_24), > > code indent should use tabs where possible […] Done https://review.coreboot.org/c/coreboot/+/60782/comment/fea301ea_eb06361d PS1, Line 50: PAD_NC(GPIO_24), > > please, no spaces at the start of a line […] Done https://review.coreboot.org/c/coreboot/+/60782/comment/2f3a648e_e0bd1f79 PS1, Line 51: /* Unused TP217*/ > > code indent should use tabs where possible […] Done https://review.coreboot.org/c/coreboot/+/60782/comment/3d321c1d_7d420fb9 PS1, Line 52: PAD_NC(GPIO_69), > > please, no spaces at the start of a line […] Done https://review.coreboot.org/c/coreboot/+/60782/comment/87899ad4_e7878c6e PS1, Line 52: PAD_NC(GPIO_69), > > code indent should use tabs where possible […] Done https://review.coreboot.org/c/coreboot/+/60782/comment/a5138804_1cbf8e88 PS1, Line 57: /* Unused TP195*/ > > code indent should use tabs where possible […] Done https://review.coreboot.org/c/coreboot/+/60782/comment/1f3c47fa_c511463a PS1, Line 58: PAD_NC(GPIO_18), > > please, no spaces at the start of a line […] Done https://review.coreboot.org/c/coreboot/+/60782/comment/4a127b8b_f5e6036a PS1, Line 58: PAD_NC(GPIO_18), > > code indent should use tabs where possible […] Done https://review.coreboot.org/c/coreboot/+/60782/comment/84758194_323ef924 PS1, Line 59: /* Unused TP217*/ > > code indent should use tabs where possible […] Done https://review.coreboot.org/c/coreboot/+/60782/comment/f8600a80_6eb18f5a PS1, Line 60: PAD_NC(GPIO_69), > > please, no spaces at the start of a line […] Done https://review.coreboot.org/c/coreboot/+/60782/comment/fa13dbe3_14e7a007 PS1, Line 60: PAD_NC(GPIO_69), > > code indent should use tabs where possible […] Done https://review.coreboot.org/c/coreboot/+/60782/comment/692438b9_6bee5974 PS1, Line 65: /* Unused TP196*/ > > code indent should use tabs where possible […] Done https://review.coreboot.org/c/coreboot/+/60782/comment/b5e7973f_255f9d1e PS1, Line 66: PAD_NC(GPIO_24), > > please, no spaces at the start of a line […] Done https://review.coreboot.org/c/coreboot/+/60782/comment/a26a9e85_5c8eff75 PS1, Line 66: PAD_NC(GPIO_24), > > code indent should use tabs where possible […] Done https://review.coreboot.org/c/coreboot/+/60782/comment/625cac89_6b108fc9 PS1, Line 89: *size = ARRAY_SIZE(bootblock_gpio_table); > > code indent should use tabs where possible […] Done https://review.coreboot.org/c/coreboot/+/60782/comment/12b3f508_0ff6b668 PS1, Line 89: *size = ARRAY_SIZE(bootblock_gpio_table); > > please, no spaces at the start of a line […] Done https://review.coreboot.org/c/coreboot/+/60782/comment/3c828006_41c7ee6f PS1, Line 90: return override_bootblock_gpio_table; > > code indent should use tabs where possible […] Done https://review.coreboot.org/c/coreboot/+/60782/comment/ac4885c6_870b2c12 PS1, Line 90: return override_bootblock_gpio_table; > > please, no spaces at the start of a line […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/60782 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I552fd6af1cd827e4e41be1a954bf95c3afbb6a86 Gerrit-Change-Number: 60782 Gerrit-PatchSet: 2 Gerrit-Owner: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 05 Jan 2022 04:56:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/guybrush/var/dewatt: Update unused GPIO pins
by Kenneth Chan (Code Review) 05 Jan '22

05 Jan '22

Kenneth Chan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60782 ) Change subject: mb/google/guybrush/var/dewatt: Update unused GPIO pins ...................................................................... Patch Set 2: (64 comments) File src/mainboard/google/guybrush/variants/dewatt/gpio.c: https://review.coreboot.org/c/coreboot/+/60782/comment/aba81323_b449ad84 PS1, Line 16: /* Unused TP245*/ > code indent should use tabs where possible Please fix. https://review.coreboot.org/c/coreboot/+/60782/comment/38c5f0b8_c25912c0 PS1, Line 17: PAD_NC(GPIO_8), > code indent should use tabs where possible Please fix. https://review.coreboot.org/c/coreboot/+/60782/comment/38e952e9_06b0724b PS1, Line 17: PAD_NC(GPIO_8), > please, no spaces at the start of a line Please fix. https://review.coreboot.org/c/coreboot/+/60782/comment/440606b6_0eca28a1 PS1, Line 18: /* Unused TP244*/ > code indent should use tabs where possible Please fix. https://review.coreboot.org/c/coreboot/+/60782/comment/00cb2a99_ca044a3e PS1, Line 19: PAD_NC(GPIO_11), > please, no spaces at the start of a line Please fix. https://review.coreboot.org/c/coreboot/+/60782/comment/59df1b3c_75793b94 PS1, Line 19: PAD_NC(GPIO_11), > code indent should use tabs where possible Please fix. https://review.coreboot.org/c/coreboot/+/60782/comment/603c8ad1_9d4c8b2a PS1, Line 20: /* Unused TP194*/ > code indent should use tabs where possible Please fix. https://review.coreboot.org/c/coreboot/+/60782/comment/673e1a82_32518038 PS1, Line 21: PAD_NC(GPIO_17), > code indent should use tabs where possible Please fix. https://review.coreboot.org/c/coreboot/+/60782/comment/0f9b89dd_a8e39432 PS1, Line 21: PAD_NC(GPIO_17), > please, no spaces at the start of a line Please fix. https://review.coreboot.org/c/coreboot/+/60782/comment/40055289_a7e0653a PS1, Line 22: /* Unused TP195*/ > code indent should use tabs where possible Please fix. https://review.coreboot.org/c/coreboot/+/60782/comment/1235ce09_d55a575c PS1, Line 23: PAD_NC(GPIO_18), > code indent should use tabs where possible Please fix. https://review.coreboot.org/c/coreboot/+/60782/comment/5528d417_9d14db19 PS1, Line 23: PAD_NC(GPIO_18), > please, no spaces at the start of a line Please fix. https://review.coreboot.org/c/coreboot/+/60782/comment/9ea0cbe1_7173aa91 PS1, Line 24: /* Unused TP243*/ > code indent should use tabs where possible Please fix. https://review.coreboot.org/c/coreboot/+/60782/comment/c8f053b9_01e3bca6 PS1, Line 25: PAD_NC(GPIO_21), > please, no spaces at the start of a line Please fix. https://review.coreboot.org/c/coreboot/+/60782/comment/4d5720ef_37f35022 PS1, Line 25: PAD_NC(GPIO_21), > code indent should use tabs where possible Please fix. https://review.coreboot.org/c/coreboot/+/60782/comment/6249636d_6b42c787 PS1, Line 26: /* Unused TP196*/ > code indent should use tabs where possible Please fix. https://review.coreboot.org/c/coreboot/+/60782/comment/20366341_ce872022 PS1, Line 27: PAD_NC(GPIO_24), > please, no spaces at the start of a line Please fix. https://review.coreboot.org/c/coreboot/+/60782/comment/2a244ebc_60f8d6b9 PS1, Line 27: PAD_NC(GPIO_24), > code indent should use tabs where possible Please fix. https://review.coreboot.org/c/coreboot/+/60782/comment/8d7036d2_d31dfde9 PS1, Line 28: /* Unused TP219*/ > code indent should use tabs where possible Please fix. https://review.coreboot.org/c/coreboot/+/60782/comment/f716ce4a_e383695b PS1, Line 29: PAD_NC(GPIO_42), > please, no spaces at the start of a line Please fix. https://review.coreboot.org/c/coreboot/+/60782/comment/e065382f_7b218949 PS1, Line 29: PAD_NC(GPIO_42), > code indent should use tabs where possible Please fix. https://review.coreboot.org/c/coreboot/+/60782/comment/1efde437_0defa7db PS1, Line 30: /* Unused TP217*/ > code indent should use tabs where possible Please fix. https://review.coreboot.org/c/coreboot/+/60782/comment/46e0cda5_5fbd09ef PS1, Line 31: PAD_NC(GPIO_69), > code indent should use tabs where possible Please fix. https://review.coreboot.org/c/coreboot/+/60782/comment/649288d9_6ee20abd PS1, Line 31: PAD_NC(GPIO_69), > please, no spaces at the start of a line Please fix. https://review.coreboot.org/c/coreboot/+/60782/comment/56ea35a7_b6544a38 PS1, Line 32: /* Unused TP235*/ > code indent should use tabs where possible Please fix. https://review.coreboot.org/c/coreboot/+/60782/comment/35305bb5_1fe06245 PS1, Line 33: PAD_NC(GPIO_115), > code indent should use tabs where possible Please fix. https://review.coreboot.org/c/coreboot/+/60782/comment/16089475_c2f3709e PS1, Line 33: PAD_NC(GPIO_115), > please, no spaces at the start of a line Please fix. https://review.coreboot.org/c/coreboot/+/60782/comment/bb135a4c_eedf714a PS1, Line 34: /* Unused TP205*/ > code indent should use tabs where possible Please fix. https://review.coreboot.org/c/coreboot/+/60782/comment/c7cd7386_76a7f3d6 PS1, Line 35: PAD_NC(GPIO_116), > please, no spaces at the start of a line Please fix. https://review.coreboot.org/c/coreboot/+/60782/comment/c37a1b17_93f0fcf1 PS1, Line 35: PAD_NC(GPIO_116), > code indent should use tabs where possible Please fix. https://review.coreboot.org/c/coreboot/+/60782/comment/d7e2157c_5b1fd77e PS1, Line 36: /* Unused TP226*/ > code indent should use tabs where possible Please fix. https://review.coreboot.org/c/coreboot/+/60782/comment/7f7184ea_d8e171f6 PS1, Line 37: PAD_NC(GPIO_140), > code indent should use tabs where possible Please fix. https://review.coreboot.org/c/coreboot/+/60782/comment/992f6863_440b1343 PS1, Line 37: PAD_NC(GPIO_140), > please, no spaces at the start of a line Please fix. https://review.coreboot.org/c/coreboot/+/60782/comment/b9aa93c4_1ae4c891 PS1, Line 38: /* Unused TP225*/ > code indent should use tabs where possible Please fix. https://review.coreboot.org/c/coreboot/+/60782/comment/0b84673b_8129936e PS1, Line 39: PAD_NC(GPIO_142), > please, no spaces at the start of a line Please fix. https://review.coreboot.org/c/coreboot/+/60782/comment/08ad8169_22eca89b PS1, Line 39: PAD_NC(GPIO_142), > code indent should use tabs where possible Please fix. https://review.coreboot.org/c/coreboot/+/60782/comment/7533c4f1_db53254e PS1, Line 40: /* Unused TP227*/ > code indent should use tabs where possible Please fix. https://review.coreboot.org/c/coreboot/+/60782/comment/d166d108_277bc97e PS1, Line 41: PAD_NC(GPIO_144), > please, no spaces at the start of a line Please fix. https://review.coreboot.org/c/coreboot/+/60782/comment/889d0250_8f4097fe PS1, Line 41: PAD_NC(GPIO_144), > code indent should use tabs where possible Please fix. https://review.coreboot.org/c/coreboot/+/60782/comment/27cd37e5_edb45f89 PS1, Line 45: /* Unused TP245*/ > code indent should use tabs where possible Please fix. https://review.coreboot.org/c/coreboot/+/60782/comment/ac4d68db_40835a5e PS1, Line 46: PAD_NC(GPIO_8), > code indent should use tabs where possible Please fix. https://review.coreboot.org/c/coreboot/+/60782/comment/bef1131f_ce244594 PS1, Line 46: PAD_NC(GPIO_8), > please, no spaces at the start of a line Please fix. https://review.coreboot.org/c/coreboot/+/60782/comment/6dcac36d_8d037905 PS1, Line 47: /* Unused TP195*/ > code indent should use tabs where possible Please fix. https://review.coreboot.org/c/coreboot/+/60782/comment/ba7916cb_4bf52ef3 PS1, Line 48: PAD_NC(GPIO_18), > please, no spaces at the start of a line Please fix. https://review.coreboot.org/c/coreboot/+/60782/comment/33f73698_8c5a0bd7 PS1, Line 48: PAD_NC(GPIO_18), > code indent should use tabs where possible Please fix. https://review.coreboot.org/c/coreboot/+/60782/comment/d776a184_af230b90 PS1, Line 49: /* Unused TP196*/ > code indent should use tabs where possible Please fix. https://review.coreboot.org/c/coreboot/+/60782/comment/11640c4c_5053374e PS1, Line 50: PAD_NC(GPIO_24), > code indent should use tabs where possible Please fix. https://review.coreboot.org/c/coreboot/+/60782/comment/8b4aef39_b4372b46 PS1, Line 50: PAD_NC(GPIO_24), > please, no spaces at the start of a line Please fix. https://review.coreboot.org/c/coreboot/+/60782/comment/9ff835f3_2aa920ee PS1, Line 51: /* Unused TP217*/ > code indent should use tabs where possible Please fix. https://review.coreboot.org/c/coreboot/+/60782/comment/a6923f9d_3e7ad572 PS1, Line 52: PAD_NC(GPIO_69), > please, no spaces at the start of a line Please fix. https://review.coreboot.org/c/coreboot/+/60782/comment/c381ae1a_bd939a67 PS1, Line 52: PAD_NC(GPIO_69), > code indent should use tabs where possible Please fix. https://review.coreboot.org/c/coreboot/+/60782/comment/8330522b_d5eac492 PS1, Line 57: /* Unused TP195*/ > code indent should use tabs where possible Please fix. https://review.coreboot.org/c/coreboot/+/60782/comment/d663a849_84b71c5b PS1, Line 58: PAD_NC(GPIO_18), > please, no spaces at the start of a line Please fix. https://review.coreboot.org/c/coreboot/+/60782/comment/01f12365_8c2e7aaa PS1, Line 58: PAD_NC(GPIO_18), > code indent should use tabs where possible Please fix. https://review.coreboot.org/c/coreboot/+/60782/comment/7bf30ac9_2bae8551 PS1, Line 59: /* Unused TP217*/ > code indent should use tabs where possible Please fix. https://review.coreboot.org/c/coreboot/+/60782/comment/3e905ad0_94a9af9e PS1, Line 60: PAD_NC(GPIO_69), > please, no spaces at the start of a line Please fix. https://review.coreboot.org/c/coreboot/+/60782/comment/cf8472a4_557beb66 PS1, Line 60: PAD_NC(GPIO_69), > code indent should use tabs where possible Please fix. https://review.coreboot.org/c/coreboot/+/60782/comment/704c92f2_63b9ec48 PS1, Line 65: /* Unused TP196*/ > code indent should use tabs where possible Please fix. https://review.coreboot.org/c/coreboot/+/60782/comment/ddb661d3_09ef3346 PS1, Line 66: PAD_NC(GPIO_24), > please, no spaces at the start of a line Please fix. https://review.coreboot.org/c/coreboot/+/60782/comment/aba9b5cc_9f679880 PS1, Line 66: PAD_NC(GPIO_24), > code indent should use tabs where possible Please fix. https://review.coreboot.org/c/coreboot/+/60782/comment/c123b4f7_3c40c82f PS1, Line 89: *size = ARRAY_SIZE(bootblock_gpio_table); > code indent should use tabs where possible Please fix. https://review.coreboot.org/c/coreboot/+/60782/comment/ad870406_232cf98a PS1, Line 89: *size = ARRAY_SIZE(bootblock_gpio_table); > please, no spaces at the start of a line Please fix. https://review.coreboot.org/c/coreboot/+/60782/comment/da39c7e0_6d931824 PS1, Line 90: return override_bootblock_gpio_table; > please, no spaces at the start of a line Please fix. https://review.coreboot.org/c/coreboot/+/60782/comment/92854845_c9fa3096 PS1, Line 90: return override_bootblock_gpio_table; > code indent should use tabs where possible Please fix. -- To view, visit https://review.coreboot.org/c/coreboot/+/60782 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I552fd6af1cd827e4e41be1a954bf95c3afbb6a86 Gerrit-Change-Number: 60782 Gerrit-PatchSet: 2 Gerrit-Owner: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 05 Jan 2022 04:53:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/common/gpio: Skip GPP pad lock config if config is not set
by EricR Lai (Code Review) 05 Jan '22

05 Jan '22

Attention is currently required from: Subrata Banik, Maulik V Vaghela, Tim Wawrzynczak, Nick Vaccaro, Meera Ravindranath, Patrick Rudolph. EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60776 ) Change subject: soc/intel/common/gpio: Skip GPP pad lock config if config is not set ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > do you mean to guard the entire function #ifdef/#endif? yes -- To view, visit https://review.coreboot.org/c/coreboot/+/60776 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I392dc2007dba8169e480f82b58b7f0a1578bb09f Gerrit-Change-Number: 60776 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Meera Ravindranath <meera.ravindranath(a)intel.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Meera Ravindranath <meera.ravindranath(a)intel.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Wed, 05 Jan 2022 04:35:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/corsola: Configure audio
by Hung-Te Lin (Code Review) 05 Jan '22

05 Jan '22

Attention is currently required from: Rex-BC Chen, Paul Menzel, yu jiaxin, Yu-Ping Wu. Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60738 ) Change subject: mb/google/corsola: Configure audio ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60738 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia6374d0e5535b7cff4df8759312786fef8b94b6b Gerrit-Change-Number: 60738 Gerrit-PatchSet: 6 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: yu jiaxin <jiaxin.yu(a)mediatek.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: yu jiaxin <jiaxin.yu(a)mediatek.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Wed, 05 Jan 2022 04:32:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/common/gpio: Skip GPP pad lock config if config is not set
by Subrata Banik (Code Review) 05 Jan '22

05 Jan '22

Attention is currently required from: Maulik V Vaghela, Tim Wawrzynczak, Nick Vaccaro, Meera Ravindranath, Patrick Rudolph, EricR Lai. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60776 ) Change subject: soc/intel/common/gpio: Skip GPP pad lock config if config is not set ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > If we don't want this, maybe use the ifdef to drop the compile this and we can save the code size? do you mean to guard the entire function #ifdef/#endif? -- To view, visit https://review.coreboot.org/c/coreboot/+/60776 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I392dc2007dba8169e480f82b58b7f0a1578bb09f Gerrit-Change-Number: 60776 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Meera Ravindranath <meera.ravindranath(a)intel.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Meera Ravindranath <meera.ravindranath(a)intel.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Comment-Date: Wed, 05 Jan 2022 04:08:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/common/gpio: Rework PAD config macro to add lock support
by EricR Lai (Code Review) 05 Jan '22

05 Jan '22

Attention is currently required from: Subrata Banik, Maulik V Vaghela, Tim Wawrzynczak, Nick Vaccaro, Angel Pons, Meera Ravindranath, Patrick Rudolph. EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60774 ) Change subject: soc/intel/common/gpio: Rework PAD config macro to add lock support ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/60774 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibf8b0a845005ad545266d995449d0aa711f45a61 Gerrit-Change-Number: 60774 Gerrit-PatchSet: 3 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Meera Ravindranath <meera.ravindranath(a)intel.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Meera Ravindranath <meera.ravindranath(a)intel.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Wed, 05 Jan 2022 03:56:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/common/gpio: Rework PAD config macro to add lock support
by EricR Lai (Code Review) 05 Jan '22

05 Jan '22

Attention is currently required from: Subrata Banik, Maulik V Vaghela, Tim Wawrzynczak, Nick Vaccaro, Angel Pons, Meera Ravindranath, Patrick Rudolph. EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60774 ) Change subject: soc/intel/common/gpio: Rework PAD config macro to add lock support ...................................................................... Patch Set 3: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/60774/comment/8787f6e8_7458a711 PS3, Line 10: to space File src/soc/intel/common/block/include/intelblocks/gpio.h: https://review.coreboot.org/c/coreboot/+/60774/comment/13d85054_332313ed PS3, Line 79: gpio_lock_action action use tab to align this -- To view, visit https://review.coreboot.org/c/coreboot/+/60774 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibf8b0a845005ad545266d995449d0aa711f45a61 Gerrit-Change-Number: 60774 Gerrit-PatchSet: 3 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Meera Ravindranath <meera.ravindranath(a)intel.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Meera Ravindranath <meera.ravindranath(a)intel.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Wed, 05 Jan 2022 03:56:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/common/gpio: Skip GPP pad lock config if config is not set
by EricR Lai (Code Review) 05 Jan '22

05 Jan '22

Attention is currently required from: Subrata Banik, Maulik V Vaghela, Tim Wawrzynczak, Nick Vaccaro, Meera Ravindranath, Patrick Rudolph. EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60776 ) Change subject: soc/intel/common/gpio: Skip GPP pad lock config if config is not set ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: If we don't want this, maybe use the ifdef to drop the compile this and we can save the code size? -- To view, visit https://review.coreboot.org/c/coreboot/+/60776 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I392dc2007dba8169e480f82b58b7f0a1578bb09f Gerrit-Change-Number: 60776 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Meera Ravindranath <meera.ravindranath(a)intel.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Meera Ravindranath <meera.ravindranath(a)intel.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Wed, 05 Jan 2022 03:54:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2022