coreboot-gerrit January 2022

coreboot-gerrit@coreboot.org

1 participants
6716 discussions

Change in coreboot[master]: util/cbfstool: Port elogtool to libflashrom
by Edward O'Callaghan (Code Review) 05 Jan '22

05 Jan '22

Attention is currently required from: Felix Singer, Jack Rosenthal, Nikolai Artemiev. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59714 ) Change subject: util/cbfstool: Port elogtool to libflashrom ...................................................................... Patch Set 7: (1 comment) File util/cbfstool/uflashrom.c: https://review.coreboot.org/c/coreboot/+/59714/comment/809e14a8_001299e7 PS2, Line 17: ? stderr : stdout > stdout or stdout? :) Done? Done -- To view, visit https://review.coreboot.org/c/coreboot/+/59714 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I79df2934b9b0492a554a4fecdd533a0abe1df231 Gerrit-Change-Number: 59714 Gerrit-PatchSet: 7 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Jack Rosenthal <jrosenth(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Sam McNally <sammc(a)google.com> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Jack Rosenthal <jrosenth(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Wed, 05 Jan 2022 07:57:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jack Rosenthal <jrosenth(a)chromium.org> Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/cbfstool: Port elogtool to libflashrom
by build bot (Jenkins) (Code Review) 05 Jan '22

05 Jan '22

Attention is currently required from: Felix Singer, Jack Rosenthal, Nikolai Artemiev. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59714 ) Change subject: util/cbfstool: Port elogtool to libflashrom ...................................................................... Patch Set 7: (2 comments) File util/cbfstool/uflashrom.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137325): https://review.coreboot.org/c/coreboot/+/59714/comment/e30634b9_1df2c438 PS7, Line 33: unsigned offset = 0; Prefer 'unsigned int' to bare use of 'unsigned' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137325): https://review.coreboot.org/c/coreboot/+/59714/comment/47a033a0_2b777e2f PS7, Line 91: * at the offset from the set layout rather than at the begining of the 'begining' may be misspelled - perhaps 'beginning'? -- To view, visit https://review.coreboot.org/c/coreboot/+/59714 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I79df2934b9b0492a554a4fecdd533a0abe1df231 Gerrit-Change-Number: 59714 Gerrit-PatchSet: 7 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Jack Rosenthal <jrosenth(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Sam McNally <sammc(a)google.com> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Jack Rosenthal <jrosenth(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Wed, 05 Jan 2022 07:56:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/cbfstool: Port elogtool to libflashrom
by Edward O'Callaghan (Code Review) 05 Jan '22

05 Jan '22

Attention is currently required from: Felix Singer, Jack Rosenthal, Nikolai Artemiev. Hello build bot (Jenkins), Jack Rosenthal, Nikolai Artemiev, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/59714 to look at the new patch set (#7). Change subject: util/cbfstool: Port elogtool to libflashrom ...................................................................... util/cbfstool: Port elogtool to libflashrom This also uncouples cbfstool from being overly Chromium specific. However the main objective is to not subprocess flashrom any more and instead use the programmatic API. BUG=b:207808292 TEST=built and ran `elogtool list`. Change-Id: I79df2934b9b0492a554a4fecdd533a0abe1df231 Signed-off-by: Edward O'Callaghan <quasisec(a)google.com> --- M util/cbfstool/Makefile.inc M util/cbfstool/elogtool.c A util/cbfstool/uflashrom.c A util/cbfstool/uflashrom.h 4 files changed, 202 insertions(+), 11 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/59714/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/59714 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I79df2934b9b0492a554a4fecdd533a0abe1df231 Gerrit-Change-Number: 59714 Gerrit-PatchSet: 7 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Jack Rosenthal <jrosenth(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Sam McNally <sammc(a)google.com> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Jack Rosenthal <jrosenth(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/brya/var/vell: Add AMP driver setting
by Robert Chen (Code Review) 05 Jan '22

05 Jan '22

Attention is currently required from: Robert Chen. Robert Chen has uploaded a new patch set (#10) to the change originally created by Shon Wang. ( https://review.coreboot.org/c/coreboot/+/60331 ) Change subject: mb/google/brya/var/vell: Add AMP driver setting ...................................................................... mb/google/brya/var/vell: Add AMP driver setting update gpio.c update overridetree.cb update Kconfig.name Signed-off-by: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> Change-Id: I96d49bd1a2ba061c4fd52b450b31d0885f49552c --- M src/mainboard/google/brya/Kconfig.name M src/mainboard/google/brya/variants/vell/gpio.c M src/mainboard/google/brya/variants/vell/overridetree.cb 3 files changed, 23 insertions(+), 30 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/60331/10 -- To view, visit https://review.coreboot.org/c/coreboot/+/60331 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I96d49bd1a2ba061c4fd52b450b31d0885f49552c Gerrit-Change-Number: 60331 Gerrit-PatchSet: 10 Gerrit-Owner: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-Attention: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/brya/var/vell: Correct MIPI camera info
by Robert Chen (Code Review) 05 Jan '22

05 Jan '22

Attention is currently required from: Kevin Chiu, Jimmy Su, Robert Chen, Wisley Chen, Shon Wang. Robert Chen has uploaded a new patch set (#13) to the change originally created by Shon Wang. ( https://review.coreboot.org/c/coreboot/+/60276 ) Change subject: mb/google/brya/var/vell: Correct MIPI camera info ...................................................................... mb/google/brya/var/vell: Correct MIPI camera info Correct OVTI8856 information for vell: BUG=b:210801553 TEST=Build and boot on vell Change-Id: I43de859cd0cdd9fe21c16cabfad511ed0b368ee3 Signed-off-by: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> --- M src/mainboard/google/brya/Kconfig.name M src/mainboard/google/brya/variants/vell/gpio.c M src/mainboard/google/brya/variants/vell/overridetree.cb 3 files changed, 73 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/60276/13 -- To view, visit https://review.coreboot.org/c/coreboot/+/60276 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I43de859cd0cdd9fe21c16cabfad511ed0b368ee3 Gerrit-Change-Number: 60276 Gerrit-PatchSet: 13 Gerrit-Owner: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kevin Chiu <Kevin.Chiu(a)quantatw.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jimmy Su <jimmy.su(a)intel.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-Attention: Kevin Chiu <Kevin.Chiu(a)quantatw.com> Gerrit-Attention: Jimmy Su <jimmy.su(a)intel.corp-partner.google.com> Gerrit-Attention: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-Attention: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-Attention: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/brya/var/vell: Add AMP driver setting
by Shon Wang (Code Review) 05 Jan '22

05 Jan '22

Shon Wang has restored this change. ( https://review.coreboot.org/c/coreboot/+/60331 ) Change subject: mb/google/brya/var/vell: Add AMP driver setting ...................................................................... Restored -- To view, visit https://review.coreboot.org/c/coreboot/+/60331 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I96d49bd1a2ba061c4fd52b450b31d0885f49552c Gerrit-Change-Number: 60331 Gerrit-PatchSet: 9 Gerrit-Owner: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-MessageType: restore

1 0

Change in coreboot[master]: mb/google/brya: Use PAD config macro to add lock support
by Meera Ravindranath (Code Review) 05 Jan '22

05 Jan '22

Attention is currently required from: Subrata Banik, Maulik V Vaghela, Tim Wawrzynczak, Nick Vaccaro, EricR Lai. Hello build bot (Jenkins), Subrata Banik, Maulik V Vaghela, Tim Wawrzynczak, Nick Vaccaro, EricR Lai, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/60320 to look at the new patch set (#7). Change subject: mb/google/brya: Use PAD config macro to add lock support ...................................................................... mb/google/brya: Use PAD config macro to add lock support Use PAD config macro to add lock support for all the gpios used in CB:58352 CB:58353. BUG=b:211573253 TEST=Boot to OS, issue warm reboot and see no issue with any IP enumeration Signed-off-by: Meera Ravindranath <meera.ravindranath(a)intel.com> Change-Id: I558bab39f935ab31a89541c6498a73af70cbf9ee --- M src/mainboard/google/brya/variants/baseboard/brya/gpio.c 1 file changed, 42 insertions(+), 42 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/60320/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/60320 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I558bab39f935ab31a89541c6498a73af70cbf9ee Gerrit-Change-Number: 60320 Gerrit-PatchSet: 7 Gerrit-Owner: Meera Ravindranath <meera.ravindranath(a)intel.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: Herobrine: TPM Config Changes
by Sudheer Amrabadi (Code Review) 05 Jan '22

05 Jan '22

Attention is currently required from: Shelley Chen. Sudheer Amrabadi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60167 ) Change subject: Herobrine: TPM Config Changes ...................................................................... Patch Set 4: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/60167/comment/4aeeb1a3_7b5ab3dd PS2, Line 7: to support audio > This doesn't have to do with audio support. This is just configuring the TPM interrupt GPIO. Ack https://review.coreboot.org/c/coreboot/+/60167/comment/576203ee_40a33b41 PS2, Line 9: Add configuration for target specific i2s ports > This is not i2s related. Ack -- To view, visit https://review.coreboot.org/c/coreboot/+/60167 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifb3452faa2c43e2303ab4b1fef193184ffe4a938 Gerrit-Change-Number: 60167 Gerrit-PatchSet: 4 Gerrit-Owner: Sudheer Amrabadi <samrabad(a)codeaurora.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Comment-Date: Wed, 05 Jan 2022 07:26:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Shelley Chen <shchen(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Herobrine: TPM Config Changes
by Sudheer Amrabadi (Code Review) 05 Jan '22

05 Jan '22

Attention is currently required from: Sudheer Amrabadi. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/60167 to look at the new patch set (#4). Change subject: Herobrine: TPM Config Changes ...................................................................... Herobrine: TPM Config Changes BUG=b:182963902 TEST=Validated on qualcomm sc7280 developement board Signed-off-by: Srinivasa Rao Mandadapu <srivasam(a)codeaurora.org> Change-Id: Ifb3452faa2c43e2303ab4b1fef193184ffe4a938 --- M src/mainboard/google/herobrine/chromeos.c 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/60167/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/60167 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifb3452faa2c43e2303ab4b1fef193184ffe4a938 Gerrit-Change-Number: 60167 Gerrit-PatchSet: 4 Gerrit-Owner: Sudheer Amrabadi <samrabad(a)codeaurora.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Sudheer Amrabadi <samrabad(a)codeaurora.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/herobrine: Initialize `pins` to fix the compilation issue
by Subrata Banik (Code Review) 05 Jan '22

05 Jan '22

Subrata Banik has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/60784 ) Change subject: mb/google/herobrine: Initialize `pins` to fix the compilation issue ...................................................................... mb/google/herobrine: Initialize `pins` to fix the compilation issue Fix compilation issue introduced with commit 8b63dac0 (google/herobrine: configure gpio to detect board ID) by initialising the gpio pins. Signed-off-by: Subrata Banik <subratabanik(a)google.com> Change-Id: I084fec777b56f402efb3b04a1d358cd5b0891846 --- M src/mainboard/google/herobrine/boardid.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/60784/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60784 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I084fec777b56f402efb3b04a1d358cd5b0891846 Gerrit-Change-Number: 60784 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2022