coreboot-gerrit January 2022

coreboot-gerrit@coreboot.org

1 participants
6716 discussions

Change in coreboot[master]: soc/intel/ehl: Replace dt `HeciEnabled` by `CSE disable` config
by Angel Pons (Code Review) 05 Jan '22

05 Jan '22

Attention is currently required from: Felix Singer, Subrata Banik, Tim Wawrzynczak, Werner Zeh, Patrick Rudolph, EricR Lai. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60727 ) Change subject: soc/intel/ehl: Replace dt `HeciEnabled` by `CSE disable` config ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/60727 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I76c625e6221fdef1343599e7dbc7739caa91bf98 Gerrit-Change-Number: 60727 Gerrit-PatchSet: 3 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Comment-Date: Wed, 05 Jan 2022 12:53:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/skl: Replace dt `HeciEnabled` by `CSE disable` config
by Angel Pons (Code Review) 05 Jan '22

05 Jan '22

Attention is currently required from: Felix Singer, Erik van den Bogaert, Michał Żygowski, Subrata Banik, Frans Hendriks, Tim Wawrzynczak, Michael Niewöhner, Patrick Rudolph, Piotr Król. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60722 ) Change subject: soc/intel/skl: Replace dt `HeciEnabled` by `CSE disable` config ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: Note that the following boards don't specify `HeciEnabled` in the devicetree, so this patch would change the behavior for them (HECI would no longer be hidden): kontron/bsl6 system76/kbl-u hp/280_g2 intel/saddlebrook supermicro/x11-lga1151-series For now, I'd have these boards select the "hide HECI" Kconfig option so that this change doesn't change the code behavior, and adjust individual boards in follow-up commits if needed. -- To view, visit https://review.coreboot.org/c/coreboot/+/60722 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5c13fe4a78be44403a81c28b1676aecc26c58607 Gerrit-Change-Number: 60722 Gerrit-PatchSet: 3 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Erik van den Bogaert <ebogaert(a)eltan.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Erik van den Bogaert <ebogaert(a)eltan.com> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Comment-Date: Wed, 05 Jan 2022 12:52:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/ipmi: Change type of custom_count from int to size_t
by Paul Menzel (Code Review) 05 Jan '22

05 Jan '22

Paul Menzel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60790 ) Change subject: drivers/ipmi: Change type of custom_count from int to size_t ...................................................................... drivers/ipmi: Change type of custom_count from int to size_t The variable `custom_count` is the number of custom fields, so only holds non-negative values, so change the struct member type from int to size_t. Change-Id: Ic35aafefc870092298523ba2e10adf4fcb687a01 Signed-off-by: Paul Menzel <pmenzel(a)molgen.mpg.de> --- M src/drivers/ipmi/ipmi_ops.h 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/60790/1 diff --git a/src/drivers/ipmi/ipmi_ops.h b/src/drivers/ipmi/ipmi_ops.h index 60983b4..3f15a24 100644 --- a/src/drivers/ipmi/ipmi_ops.h +++ b/src/drivers/ipmi/ipmi_ops.h @@ -111,7 +111,7 @@ char *asset_tag; char *fru_file_id; char **product_custom; - int custom_count; /* Number of custom fields */ + size_t custom_count; /* Number of custom fields */ }; struct fru_board_info { @@ -121,7 +121,7 @@ char *part_number; char *fru_file_id; char **board_custom; - int custom_count; + size_t custom_count; }; struct fru_chassis_info { @@ -129,7 +129,7 @@ char *chassis_partnumber; char *serial_number; char **chassis_custom; - int custom_count; + unsigned int custom_count; }; struct fru_info_str { -- To view, visit https://review.coreboot.org/c/coreboot/+/60790 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic35aafefc870092298523ba2e10adf4fcb687a01 Gerrit-Change-Number: 60790 Gerrit-PatchSet: 1 Gerrit-Owner: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: soc/intel/skl: Replace dt `HeciEnabled` by `CSE disable` config
by Angel Pons (Code Review) 05 Jan '22

05 Jan '22

Attention is currently required from: Felix Singer, Erik van den Bogaert, Michał Żygowski, Subrata Banik, Frans Hendriks, Tim Wawrzynczak, Michael Niewöhner, Patrick Rudolph, Piotr Król. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60722 ) Change subject: soc/intel/skl: Replace dt `HeciEnabled` by `CSE disable` config ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/60722/comment/13b9fdaa_01e61d0d PS3, Line 9: Lists nit: List -- To view, visit https://review.coreboot.org/c/coreboot/+/60722 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5c13fe4a78be44403a81c28b1676aecc26c58607 Gerrit-Change-Number: 60722 Gerrit-PatchSet: 3 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Erik van den Bogaert <ebogaert(a)eltan.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Erik van den Bogaert <ebogaert(a)eltan.com> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Comment-Date: Wed, 05 Jan 2022 12:46:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/common/cse: Add config to disable CSE at pre-boot
by Subrata Banik (Code Review) 05 Jan '22

05 Jan '22

Attention is currently required from: Felix Singer, Nico Huber, Tim Wawrzynczak, Angel Pons, Patrick Rudolph, EricR Lai. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60721 ) Change subject: soc/intel/common/cse: Add config to disable CSE at pre-boot ...................................................................... Patch Set 2: (1 comment) File src/soc/intel/common/block/cse/Kconfig: https://review.coreboot.org/c/coreboot/+/60721/comment/14ecac92_bd8daef2 PS2, Line 13: This config decides the state of CSE/Heci1 device at the end of boot. > How about renaming this to `DISABLE_HECI_AT_PRE_BOOT`? Sure, then DISABLE_HECI1_AT_PRE_BOOT? to make sure we are trying to disable HECI1(CSE) -- To view, visit https://review.coreboot.org/c/coreboot/+/60721 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7e127816c506df3ac0cf973b69021d02d05bef4a Gerrit-Change-Number: 60721 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Comment-Date: Wed, 05 Jan 2022 12:45:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/skl: Replace dt `HeciEnabled` by `CSE disable` config
by Angel Pons (Code Review) 05 Jan '22

05 Jan '22

Attention is currently required from: Felix Singer, Erik van den Bogaert, Michał Żygowski, Subrata Banik, Frans Hendriks, Tim Wawrzynczak, Michael Niewöhner, Patrick Rudolph, Piotr Król. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60722 ) Change subject: soc/intel/skl: Replace dt `HeciEnabled` by `CSE disable` config ...................................................................... Patch Set 3: Code-Review+1 (2 comments) File src/mainboard/asrock/h110m/Kconfig: https://review.coreboot.org/c/coreboot/+/60722/comment/09e6b74d_b41cc516 PS3, Line 6: select DISABLE_CSE_AT_PRE_BOOT I think this board as well as some others doesn't require this, but I'll take care of them in follow-ups. File src/soc/intel/skylake/finalize.c: https://review.coreboot.org/c/coreboot/+/60722/comment/77c49b79_5dfd2c5a PS3, Line 54: config = config_of(dev); This is no longer used -- To view, visit https://review.coreboot.org/c/coreboot/+/60722 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5c13fe4a78be44403a81c28b1676aecc26c58607 Gerrit-Change-Number: 60722 Gerrit-PatchSet: 3 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Erik van den Bogaert <ebogaert(a)eltan.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Erik van den Bogaert <ebogaert(a)eltan.com> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Comment-Date: Wed, 05 Jan 2022 12:43:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/ipmi: Use correct unsigned int length modifier
by Paul Menzel (Code Review) 05 Jan '22

05 Jan '22

Attention is currently required from: Patrick Rudolph, Angel Pons, Felix Held. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59055 ) Change subject: drivers/ipmi: Use correct unsigned int length modifier ...................................................................... Patch Set 4: (1 comment) Patchset: PS1: > since the custom count should never be negative and from a brief look at the code it's either zero o […] But it’s still not going to fix the issue, and is unrelated to this patch, isn’t it? -- To view, visit https://review.coreboot.org/c/coreboot/+/59055 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If0c4266b19d56fa88abc397f305154d473ae1a93 Gerrit-Change-Number: 59055 Gerrit-PatchSet: 4 Gerrit-Owner: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 05 Jan 2022 12:41:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/cnl: Replace `dt CSE dev state` by `CSE disable` config
by Angel Pons (Code Review) 05 Jan '22

05 Jan '22

Attention is currently required from: Felix Singer, Subrata Banik, Tim Wawrzynczak, Patrick Rudolph, EricR Lai. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60726 ) Change subject: soc/intel/cnl: Replace `dt CSE dev state` by `CSE disable` config ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/60726 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I195390b0af0f69bdb085e9ee2a4a8c3e29fd5a67 Gerrit-Change-Number: 60726 Gerrit-PatchSet: 3 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Comment-Date: Wed, 05 Jan 2022 12:40:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/{drallion, hatch. sarien}: Rework CSE dt policy
by Angel Pons (Code Review) 05 Jan '22

05 Jan '22

Attention is currently required from: Felix Singer, Subrata Banik, Tim Wawrzynczak, EricR Lai. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60725 ) Change subject: mb/google/{drallion, hatch. sarien}: Rework CSE dt policy ...................................................................... Patch Set 3: Code-Review+1 (5 comments) File src/mainboard/google/drallion/variants/drallion/devicetree.cb: https://review.coreboot.org/c/coreboot/+/60725/comment/4d44501b_1df7b496 PS3, Line 414: nit: add another space to preserve alignment File src/mainboard/google/hatch/Kconfig: https://review.coreboot.org/c/coreboot/+/60725/comment/35393707_0daf43b5 PS3, Line 32: select DISABLE_CSE_AT_PRE_BOOT Hatch and Puff use the same devicetree, shouldn't this be selected from `BOARD_GOOGLE_HATCH_COMMON`? File src/mainboard/google/hatch/variants/baseboard/devicetree.cb: https://review.coreboot.org/c/coreboot/+/60725/comment/f49bd67f_89996460 PS3, Line 299: nit: add another space to preserve alignment File src/mainboard/google/sarien/variants/arcada/devicetree.cb: https://review.coreboot.org/c/coreboot/+/60725/comment/bdc5efa3_2f23e53e PS3, Line 345: nit: add another space to preserve alignment File src/mainboard/google/sarien/variants/sarien/devicetree.cb: https://review.coreboot.org/c/coreboot/+/60725/comment/d7405d36_7b732c0d PS3, Line 366: nit: add another space to preserve alignment -- To view, visit https://review.coreboot.org/c/coreboot/+/60725 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idd57d2713fe83de5fb93e399734414ca99977d0c Gerrit-Change-Number: 60725 Gerrit-PatchSet: 3 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Comment-Date: Wed, 05 Jan 2022 12:39:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/herobrine : Add support for audio
by Sudheer Amrabadi (Code Review) 05 Jan '22

05 Jan '22

Attention is currently required from: Ravi kumar, Sudheer Amrabadi. Sudheer Amrabadi has uploaded a new patch set (#32) to the change originally created by Ravi kumar. ( https://review.coreboot.org/c/coreboot/+/57449 ) Change subject: mb/google/herobrine : Add support for audio ...................................................................... mb/google/herobrine : Add support for audio Add GPIO configuration for target specific i2s ports. BUG=b:182963902 TEST=Validated on qualcomm sc7280 developement board Signed-off-by: Srinivasa Rao Mandadapu <srivasam(a)codeaurora.org> Change-Id: I2ce95332f892d5d4acb2755307df84d37feb8002 --- M src/mainboard/google/herobrine/board.h M src/mainboard/google/herobrine/chromeos.c M src/mainboard/google/herobrine/mainboard.c 3 files changed, 28 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/57449/32 -- To view, visit https://review.coreboot.org/c/coreboot/+/57449 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2ce95332f892d5d4acb2755307df84d37feb8002 Gerrit-Change-Number: 57449 Gerrit-PatchSet: 32 Gerrit-Owner: Ravi kumar <rbokka(a)codeaurora.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Ravi Kumar Bokka <c_rbokka(a)qualcomm.corp-partner.google.com> Gerrit-CC: Shelley Chen <shchen(a)google.com> Gerrit-CC: Sudheer Amrabadi <samrabad(a)codeaurora.org> Gerrit-Attention: Ravi kumar <rbokka(a)codeaurora.org> Gerrit-Attention: Sudheer Amrabadi <samrabad(a)codeaurora.org> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2022