coreboot-gerrit January 2022

coreboot-gerrit@coreboot.org

1 participants
6716 discussions

Change in coreboot[master]: soc/intel/alderlake: Fix GPIO reset mapping as per GPIO BWG
by Angel Pons (Code Review) 05 Jan '22

05 Jan '22

Attention is currently required from: Subrata Banik, Tim Wawrzynczak, Patrick Rudolph. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60789 ) Change subject: soc/intel/alderlake: Fix GPIO reset mapping as per GPIO BWG ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/60789 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4b8742c7a0cc1dc420e3e22e34a16355294ed61b Gerrit-Change-Number: 60789 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Wed, 05 Jan 2022 15:50:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/ipmi: Change type of custom_count from int to size_t
by Angel Pons (Code Review) 05 Jan '22

05 Jan '22

Attention is currently required from: Paul Menzel. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60790 ) Change subject: drivers/ipmi: Change type of custom_count from int to size_t ...................................................................... Patch Set 2: (1 comment) File src/drivers/ipmi/ipmi_ops.h: https://review.coreboot.org/c/coreboot/+/60790/comment/4852a6e1_266d574d PS2, Line 132: unsigned int Why not `size_t` here? -- To view, visit https://review.coreboot.org/c/coreboot/+/60790 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic35aafefc870092298523ba2e10adf4fcb687a01 Gerrit-Change-Number: 60790 Gerrit-PatchSet: 2 Gerrit-Owner: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Wed, 05 Jan 2022 15:47:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/ipmi: Use correct unsigned int length modifier
by Angel Pons (Code Review) 05 Jan '22

05 Jan '22

Attention is currently required from: Patrick Rudolph, Paul Menzel, Felix Held. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59055 ) Change subject: drivers/ipmi: Use correct unsigned int length modifier ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/59055 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If0c4266b19d56fa88abc397f305154d473ae1a93 Gerrit-Change-Number: 59055 Gerrit-PatchSet: 4 Gerrit-Owner: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 05 Jan 2022 15:47:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/ifdtool: Add support for Denverton platforms
by Angel Pons (Code Review) 05 Jan '22

05 Jan '22

Attention is currently required from: Jeff Daly, Paul Menzel, Stefan Reinauer. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60737 ) Change subject: util/ifdtool: Add support for Denverton platforms ...................................................................... Patch Set 3: (1 comment) File util/ifdtool/ifdtool.c: https://review.coreboot.org/c/coreboot/+/60737/comment/937c4c44_57c3f16b PS3, Line 88: "Denverton", Hmmm, looks like this commit isn't rebased properly atop the latest patchset of CB:60736 -- To view, visit https://review.coreboot.org/c/coreboot/+/60737 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie85b071201fb3f88e2c780cfb8d6a52629aa0ced Gerrit-Change-Number: 60737 Gerrit-PatchSet: 3 Gerrit-Owner: Jeff Daly <jeffd(a)silicom-usa.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jeff Daly <jeffd(a)silicom-usa.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Wed, 05 Jan 2022 15:45:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/ifdtool: Add additional regions for platforms that support them
by Angel Pons (Code Review) 05 Jan '22

05 Jan '22

Attention is currently required from: Jeff Daly, Paul Menzel, Stefan Reinauer, Kyösti Mälkki. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60736 ) Change subject: util/ifdtool: Add additional regions for platforms that support them ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: > completely updated by patchset 4. still learning gerrit vs github. […] No worries. Although https://doc.coreboot.org/getting_started/gerrit_guidelines.html describes our Gerrit guidelines, I don't think we have any introduction to Gerrit in our documentation. https://doc.coreboot.org/tutorial/part2.html covers the basics of uploading patches for review and how to update a change after it has been pushed for review, but that's it. Here are some nuggets of information that may be useful: We don't use merges with Gerrit. I recommend enabling the `pull.rebase` Git option for the coreboot repository (as well as any other repo on Gerrit). Gerrit has the concept of "change", which is not the same as a Git commit. A change contains a list of commits (called patchsets) and comments (for example, what you're reading right now is a comment). The patchsets in a change are like "versions" of the original commit, with the latest patchset being the most recent version. Gerrit associates commits with a specific change using the `Change-Id` tag in the commit message. A change can be referenced by its Change-Id, and also by its "change number" (for example, CB:60736 aka https://review.coreboot.org/60736 refers to this change). When pushing commits (to `HEAD:refs/for/<branch>`), Gerrit uses the Change-Id tag in the commit message to decide what to do: if a change with the same Change-Id already exists, the pushed commit is treated as an update (a new patchset) of the existing change; otherwise, a new change is created for the Change-Id. It is possible to give scores to the latest patchset of a change (voting on an older patchset has no effect). Here, we have three different scores: Verified, Code-Review and All-Comments-Resolved. Verified is given by the build bot (Jenkins) after build-testing a change. Code-Review scores are given by people as part of the review process (one can still review and comment on a change without voting). All-Comments-Resolved merely reflects whether all comments have been resolved, to hopefully avoid submitting a change with unresolved comments (i.e. open discussions). Code-Review scores are preserved after a commit message update or a rebase (but not if both things are done at the same time). A Code-Review -2 score prevents a change from being submitted and persists across patchsets. Because of this, only people in the Core Developers group can give Code-Review -2 scores, and rarely used. For example, CB:56065 got a Code-Review -2 from me because that change is fundamentally incorrect and there's nothing that can be done to fix it. When an approved change (Verified +1, Code-Review +2, All-Comments-Resolved 👍️) is submitted, the latest patchset is cherry-picked into the corresponding branch (e.g. master). It's not possible to submit a change if the cherry-pick operation conflicts (e.g. because another commit that changes nearby areas got merged in the meantime). Because of this, approved changes might need to be manually rebased (i.e. fix the conflicts and upload a new patchset) and re-approved. Only people in the Core Developers group are allowed to submit changes, because it's easy to accidentally "break the tree" (the master branch no longer passes the build tests) by submitting a stale change. For example, CB:58392 was made before CB:44138 got submitted, but CB:58392 was submitted after CB:44138 and required the "emergency fix" CB:58458 to unbreak the tree. When handling patch trains (for example, your CB:60736 and CB:60737 are a patch train of two changes), I prefer to always update all changes together. Otherwise, the relation chain gets messy: the latest patchset of some changes can have an older patchset of the preceding change as parent commit. If this happens, Gerrit would show "Indirect ancestor" or "Not current" in the "Relation chain" section (top of the page, right of the box with the commit message). -- To view, visit https://review.coreboot.org/c/coreboot/+/60736 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I64cc1d787f15a01dff7db89218410228fd0082a6 Gerrit-Change-Number: 60736 Gerrit-PatchSet: 4 Gerrit-Owner: Jeff Daly <jeffd(a)silicom-usa.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jeff Daly <jeffd(a)silicom-usa.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Comment-Date: Wed, 05 Jan 2022 15:42:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jeff Daly <jeffd(a)silicom-usa.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: src/drivers/wifi/generic/smbios.c: Remove unused <string.h>
by Felix Held (Code Review) 05 Jan '22

05 Jan '22

Attention is currently required from: Patrick Rudolph, HAOUAS Elyes. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60552 ) Change subject: src/drivers/wifi/generic/smbios.c: Remove unused <string.h> ...................................................................... Patch Set 8: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60552 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2a6c5b67af1d2544159e92d4b8c06cc1f5504bd2 Gerrit-Change-Number: 60552 Gerrit-PatchSet: 8 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Comment-Date: Wed, 05 Jan 2022 15:32:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: payloads/tianocore: Don't specify default values
by Sean Rhodes (Code Review) 05 Jan '22

05 Jan '22

Sean Rhodes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60794 ) Change subject: payloads/tianocore: Don't specify default values ...................................................................... payloads/tianocore: Don't specify default values The default value for ABOVE_4G_MEMORY is TRUE, so there is no need to specify it until it's being changed. Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Change-Id: I8f1d9312b2501c06f7d6028dfd3a8dceb08fdc01 --- M payloads/external/tianocore/Makefile 1 file changed, 1 insertion(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/60794/1 diff --git a/payloads/external/tianocore/Makefile b/payloads/external/tianocore/Makefile index 33b2a27..e45455d 100644 --- a/payloads/external/tianocore/Makefile +++ b/payloads/external/tianocore/Makefile @@ -40,9 +40,7 @@ CBMEM=-D USE_CBMEM_FOR_CONSOLE=TRUE endif -ifeq ($(CONFIG_TIANOCORE_ABOVE_4G_MEMORY),y) -4G=-D ABOVE_4G_MEMORY=TRUE -else +ifneq ($(CONFIG_TIANOCORE_ABOVE_4G_MEMORY),y) 4G=-D ABOVE_4G_MEMORY=FALSE endif -- To view, visit https://review.coreboot.org/c/coreboot/+/60794 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8f1d9312b2501c06f7d6028dfd3a8dceb08fdc01 Gerrit-Change-Number: 60794 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: payloads/tianocore: Add option to disable EFI Shell
by Sean Rhodes (Code Review) 05 Jan '22

05 Jan '22

Sean Rhodes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60793 ) Change subject: payloads/tianocore: Add option to disable EFI Shell ...................................................................... payloads/tianocore: Add option to disable EFI Shell Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Change-Id: Icd68aa3183692f0607db9253cde4d41d2e03be41 --- M payloads/external/Makefile.inc M payloads/external/tianocore/Kconfig M payloads/external/tianocore/Makefile 3 files changed, 11 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/60793/1 diff --git a/payloads/external/Makefile.inc b/payloads/external/Makefile.inc index 0feb20a..a6c7305 100644 --- a/payloads/external/Makefile.inc +++ b/payloads/external/Makefile.inc @@ -153,6 +153,7 @@ CONFIG_TIANOCORE_CBMEM_LOGGING=$(CONFIG_TIANOCORE_CBMEM_LOGGING) \ CONFIG_TIANOCORE_COREBOOTPAYLOAD=$(CONFIG_TIANOCORE_COREBOOTPAYLOAD) \ CONFIG_TIANOCORE_FOLLOW_BGRT_SPEC=$(CONFIG_TIANOCORE_FOLLOW_BGRT_SPEC) \ + CONFIG_TIANOCORE_HAVE_EFI_SHELL=$(CONFIG_TIANOCORE_HAVE_EFI_SHELL) \ CONFIG_TIANOCORE_SECUREBOOT=$(CONFIG_TIANOCORE_SECUREBOOT) \ CONFIG_TIANOCORE_USE_8254_TIMER=$(CONFIG_TIANOCORE_USE_8254_TIMER) \ GCC_CC_x86_32=$(GCC_CC_x86_32) \ diff --git a/payloads/external/tianocore/Kconfig b/payloads/external/tianocore/Kconfig index fd406b7..67f1437 100644 --- a/payloads/external/tianocore/Kconfig +++ b/payloads/external/tianocore/Kconfig @@ -130,6 +130,12 @@ Follow the BGRT Specification implemented by Microsoft and centre the Boot Logo 38.2% from the top of screen. +config TIANOCORE_HAVE_EFI_SHELL + bool "Include EFI Shell" + default y + help + Include the EFI shell Binary + endif if TIANOCORE_COREBOOTPAYLOAD diff --git a/payloads/external/tianocore/Makefile b/payloads/external/tianocore/Makefile index 4231c90..33b2a27 100644 --- a/payloads/external/tianocore/Makefile +++ b/payloads/external/tianocore/Makefile @@ -50,6 +50,10 @@ KEY=-D BOOT_MANAGER_F7=TRUE endif +ifneq ($(CONFIG_TIANOCORE_HAVE_EFI_SHELL),y) +SHELL=-D SHELL_TYPE=N +endif + ifeq ($(CONFIG_TIANOCORE_SECUREBOOT),y) SB=-D SECURE_BOOT_ENABLE=TRUE endif -- To view, visit https://review.coreboot.org/c/coreboot/+/60793 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icd68aa3183692f0607db9253cde4d41d2e03be41 Gerrit-Change-Number: 60793 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: drivers/ipmi: Use correct unsigned int length modifier
by Paul Menzel (Code Review) 05 Jan '22

05 Jan '22

Attention is currently required from: Patrick Rudolph, Angel Pons, Felix Held. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59055 ) Change subject: drivers/ipmi: Use correct unsigned int length modifier ...................................................................... Patch Set 4: (1 comment) Patchset: PS1: > haven't tried, but i'd assume that this is the case. […] Ack Done in change-set Ic35aafefc870092298523ba2e10adf4fcb687a01 [1]. [1]: https://review.coreboot.org/c/coreboot/+/60790 -- To view, visit https://review.coreboot.org/c/coreboot/+/59055 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If0c4266b19d56fa88abc397f305154d473ae1a93 Gerrit-Change-Number: 59055 Gerrit-PatchSet: 4 Gerrit-Owner: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 05 Jan 2022 14:23:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/ipmi: Use correct unsigned int length modifier
by Felix Held (Code Review) 05 Jan '22

05 Jan '22

Attention is currently required from: Patrick Rudolph, Paul Menzel, Angel Pons. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59055 ) Change subject: drivers/ipmi: Use correct unsigned int length modifier ...................................................................... Patch Set 4: Code-Review+1 (1 comment) Patchset: PS1: > But it’s still not going to fix the issue, and is unrelated to this patch, isn’t it? haven't tried, but i'd assume that this is the case. feel free to ack this one; would be good if you could push a patch that changes the type of the custom_count struct elements -- To view, visit https://review.coreboot.org/c/coreboot/+/59055 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If0c4266b19d56fa88abc397f305154d473ae1a93 Gerrit-Change-Number: 59055 Gerrit-PatchSet: 4 Gerrit-Owner: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Wed, 05 Jan 2022 14:17:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2022