coreboot-gerrit January 2022

coreboot-gerrit@coreboot.org

1 participants
6716 discussions

Change in coreboot[master]: util/ifdtool: Add additional regions for platforms that support them
by Jeff Daly (Code Review) 05 Jan '22

05 Jan '22

Attention is currently required from: Paul Menzel, Stefan Reinauer, Angel Pons, Kyösti Mälkki. Jeff Daly has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60736 ) Change subject: util/ifdtool: Add additional regions for platforms that support them ...................................................................... Patch Set 4: (4 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/60736/comment/2f92f464_8c920c99 PS4, Line 9: > nit: trailing space Ack https://review.coreboot.org/c/coreboot/+/60736/comment/2f1a2979_14a4a62e PS4, Line 10: FW > I'd spell out `firmware` here for consistency with `Innovation Engine firmware` Ack File util/ifdtool/ifdtool.c: https://review.coreboot.org/c/coreboot/+/60736/comment/7f9500ae_673b4eb5 PS4, Line 43: SI_DEV_EXP1 > These are the names for the corresponding FMAP (.fmd files in the coreboot tree) regions. […] can do. https://review.coreboot.org/c/coreboot/+/60736/comment/ec2a8850_ddb177c4 PS4, Line 43: Expansion1 > Are there more "Device Expansion" regions? If not, I'd remove the `1` from here. yes, LBG has Device Expansion 2 in flash region 9. Which I can add. -- To view, visit https://review.coreboot.org/c/coreboot/+/60736 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I64cc1d787f15a01dff7db89218410228fd0082a6 Gerrit-Change-Number: 60736 Gerrit-PatchSet: 4 Gerrit-Owner: Jeff Daly <jeffd(a)silicom-usa.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Comment-Date: Wed, 05 Jan 2022 16:32:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/ifdtool: Add additional regions for platforms that support them
by Jeff Daly (Code Review) 05 Jan '22

05 Jan '22

Attention is currently required from: Paul Menzel, Stefan Reinauer, Angel Pons, Kyösti Mälkki. Jeff Daly has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60736 ) Change subject: util/ifdtool: Add additional regions for platforms that support them ...................................................................... Patch Set 4: (1 comment) File util/ifdtool/ifdtool.c: https://review.coreboot.org/c/coreboot/+/60736/comment/63b20f7d_033bdd2d PS4, Line 50: { "10GbB", "10gbb", "flashregion_12_10gbeB.bin", "SI_10GBB" }, > Hmmm, just learned that this region is "Option ROM" for Lewisburg. No idea what it is used for. I *believe* that this is for when LBG is used in Endpoint-Only Mode. Basically it can be 4 port ethernet MAC on it's own as an adapter card. This flash region would be where the link equalization parameters are stored. I don't think that this is applicable in a coreboot-usage case. HTH. -- To view, visit https://review.coreboot.org/c/coreboot/+/60736 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I64cc1d787f15a01dff7db89218410228fd0082a6 Gerrit-Change-Number: 60736 Gerrit-PatchSet: 4 Gerrit-Owner: Jeff Daly <jeffd(a)silicom-usa.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Comment-Date: Wed, 05 Jan 2022 16:29:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/ipmi: Change type of custom_count from int to size_t
by Angel Pons (Code Review) 05 Jan '22

05 Jan '22

Attention is currently required from: Paul Menzel, Felix Held. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60790 ) Change subject: drivers/ipmi: Change type of custom_count from int to size_t ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60790 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic35aafefc870092298523ba2e10adf4fcb687a01 Gerrit-Change-Number: 60790 Gerrit-PatchSet: 3 Gerrit-Owner: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 05 Jan 2022 16:24:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/herobrine: Ensure board ID GPIOs are set
by Angel Pons (Code Review) 05 Jan '22

05 Jan '22

Attention is currently required from: Shelley Chen, Hung-Te Lin, Julius Werner. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60795 ) Change subject: mb/google/herobrine: Ensure board ID GPIOs are set ...................................................................... Patch Set 1: (1 comment) File src/mainboard/google/herobrine/boardid.c: https://review.coreboot.org/c/coreboot/+/60795/comment/48c7e0b1_4807c8d5 PS1, Line 25: dead_code(); This is reached for `BOARD_GOOGLE_HEROBRINE_REV0`, which seems to be deprecated. How to proceed? -- To view, visit https://review.coreboot.org/c/coreboot/+/60795 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I863cd7acc31442333d8f73d1bd3a77f5c9978020 Gerrit-Change-Number: 60795 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Wed, 05 Jan 2022 16:24:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/herobrine: Ensure board ID GPIOs are set
by Paul Menzel (Code Review) 05 Jan '22

05 Jan '22

Attention is currently required from: Hung-Te Lin, Angel Pons. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60795 ) Change subject: mb/google/herobrine: Ensure board ID GPIOs are set ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/60795 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I863cd7acc31442333d8f73d1bd3a77f5c9978020 Gerrit-Change-Number: 60795 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Wed, 05 Jan 2022 16:22:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/ipmi: Change type of custom_count from int to size_t
by Paul Menzel (Code Review) 05 Jan '22

05 Jan '22

Attention is currently required from: Angel Pons. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60790 ) Change subject: drivers/ipmi: Change type of custom_count from int to size_t ...................................................................... Patch Set 3: (1 comment) File src/drivers/ipmi/ipmi_ops.h: https://review.coreboot.org/c/coreboot/+/60790/comment/db5f2791_b3595a3e PS2, Line 132: unsigned int > Why not `size_t` here? Sorry, was just a leftover from a test. -- To view, visit https://review.coreboot.org/c/coreboot/+/60790 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic35aafefc870092298523ba2e10adf4fcb687a01 Gerrit-Change-Number: 60790 Gerrit-PatchSet: 3 Gerrit-Owner: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Wed, 05 Jan 2022 16:21:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/herobrine: Ensure board ID GPIOs are set
by Angel Pons (Code Review) 05 Jan '22

05 Jan '22

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60795 ) Change subject: mb/google/herobrine: Ensure board ID GPIOs are set ...................................................................... mb/google/herobrine: Ensure board ID GPIOs are set If a new variant is added without updating the `board_id()` function, invalid GPIOs would be used to determine the board ID. To avoid this, use the `dead_code()` macro to force a build-time error. Change-Id: I863cd7acc31442333d8f73d1bd3a77f5c9978020 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M src/mainboard/google/herobrine/boardid.c 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/60795/1 diff --git a/src/mainboard/google/herobrine/boardid.c b/src/mainboard/google/herobrine/boardid.c index 07ea362..9d5a37e 100644 --- a/src/mainboard/google/herobrine/boardid.c +++ b/src/mainboard/google/herobrine/boardid.c @@ -1,5 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ +#include <assert.h> #include <boardid.h> #include <ec/google/chromeec/ec.h> #include "board.h" @@ -20,6 +21,8 @@ pins[2] = GPIO(50); pins[1] = GPIO(49); pins[0] = GPIO(48); + } else { + dead_code(); } if (id == UNDEFINED_STRAPPING_ID) -- To view, visit https://review.coreboot.org/c/coreboot/+/60795 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I863cd7acc31442333d8f73d1bd3a77f5c9978020 Gerrit-Change-Number: 60795 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/google/brya/var/agah: Add new memory support
by Tim Wawrzynczak (Code Review) 05 Jan '22

05 Jan '22

Attention is currently required from: Tony Huang, Wisley Chen. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60787 ) Change subject: mb/google/brya/var/agah: Add new memory support ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: Same thing here, rebase both of these patches on top of master and you'll get Verified+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/60787 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iaeea12a9dd8110a499b5df4de89dc1f74b88a580 Gerrit-Change-Number: 60787 Gerrit-PatchSet: 1 Gerrit-Owner: Tony Huang <tony-huang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tony Huang <tony-huang(a)quanta.corp-partner.google.com> Gerrit-Attention: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Wed, 05 Jan 2022 16:20:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/ipmi: Change type of custom_count from int to size_t
by Paul Menzel (Code Review) 05 Jan '22

05 Jan '22

Attention is currently required from: Paul Menzel. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/60790 to look at the new patch set (#3). Change subject: drivers/ipmi: Change type of custom_count from int to size_t ...................................................................... drivers/ipmi: Change type of custom_count from int to size_t The variable `custom_count` is the number of custom fields, so only holds non-negative values, so change the struct member type from int to size_t. Change-Id: Ic35aafefc870092298523ba2e10adf4fcb687a01 Signed-off-by: Paul Menzel <pmenzel(a)molgen.mpg.de> --- M src/drivers/ipmi/ipmi_ops.h 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/60790/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/60790 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic35aafefc870092298523ba2e10adf4fcb687a01 Gerrit-Change-Number: 60790 Gerrit-PatchSet: 3 Gerrit-Owner: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: util/ifdtool: Add additional regions for platforms that support them
by Angel Pons (Code Review) 05 Jan '22

05 Jan '22

Attention is currently required from: Jeff Daly, Paul Menzel, Stefan Reinauer, Kyösti Mälkki. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60736 ) Change subject: util/ifdtool: Add additional regions for platforms that support them ...................................................................... Patch Set 4: (1 comment) File util/ifdtool/ifdtool.c: https://review.coreboot.org/c/coreboot/+/60736/comment/faa0f27e_bf1c5f5a PS4, Line 50: { "10GbB", "10gbb", "flashregion_12_10gbeB.bin", "SI_10GBB" }, Hmmm, just learned that this region is "Option ROM" for Lewisburg. No idea what it is used for. -- To view, visit https://review.coreboot.org/c/coreboot/+/60736 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I64cc1d787f15a01dff7db89218410228fd0082a6 Gerrit-Change-Number: 60736 Gerrit-PatchSet: 4 Gerrit-Owner: Jeff Daly <jeffd(a)silicom-usa.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jeff Daly <jeffd(a)silicom-usa.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Comment-Date: Wed, 05 Jan 2022 16:13:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2022