coreboot-gerrit January 2022

coreboot-gerrit@coreboot.org

1 participants
6716 discussions

Change in coreboot[master]: mb/google/sarien/Kconfig: Remove blank line at beginning
by Tim Wawrzynczak (Code Review) 05 Jan '22

05 Jan '22

Tim Wawrzynczak has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60767 ) Change subject: mb/google/sarien/Kconfig: Remove blank line at beginning ...................................................................... mb/google/sarien/Kconfig: Remove blank line at beginning Change-Id: I0410be48f360bdd00e4ed7599cbee405915344b9 Signed-off-by: Paul Menzel <pmenzel(a)molgen.mpg.de> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60767 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> --- M src/mainboard/google/sarien/Kconfig 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved diff --git a/src/mainboard/google/sarien/Kconfig b/src/mainboard/google/sarien/Kconfig index 11f7ac0..42c3aba 100644 --- a/src/mainboard/google/sarien/Kconfig +++ b/src/mainboard/google/sarien/Kconfig @@ -1,4 +1,3 @@ - config BOARD_GOOGLE_BASEBOARD_SARIEN def_bool n select BOARD_ROMSIZE_KB_32768 -- To view, visit https://review.coreboot.org/c/coreboot/+/60767 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0410be48f360bdd00e4ed7599cbee405915344b9 Gerrit-Change-Number: 60767 Gerrit-PatchSet: 2 Gerrit-Owner: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: Revert "libpayload/libc/fmap: Implement new FlashMap API"
by Sudheer Amrabadi (Code Review) 05 Jan '22

05 Jan '22

Attention is currently required from: Jakub Czapiga. Sudheer Amrabadi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60797 ) Change subject: Revert "libpayload/libc/fmap: Implement new FlashMap API" ...................................................................... Revert "libpayload/libc/fmap: Implement new FlashMap API" This reverts commit 8fac662f308cdfbeec3f71d4728f71ad79c06925. Change-Id: Ieccf2d709206e1cb53fec00d0fafb3748b9dedb6 --- D payloads/libpayload/include/fmap.h A payloads/libpayload/include/fmap_serialized.h M payloads/libpayload/include/libpayload.h M payloads/libpayload/libc/fmap.c D payloads/libpayload/tests/libc/Makefile.inc D payloads/libpayload/tests/libc/fmap_locate_area-test.c 6 files changed, 76 insertions(+), 180 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/60797/1 diff --git a/payloads/libpayload/include/fmap.h b/payloads/libpayload/include/fmap.h deleted file mode 100644 index 53ebe23..0000000 --- a/payloads/libpayload/include/fmap.h +++ /dev/null @@ -1,12 +0,0 @@ -/* SPDX_License-Identifier: BSD-3-Clause */ - -#ifndef _FMAP_H -#define _FMAP_H - -#include <commonlib/bsd/cb_err.h> -#include <stddef.h> - -/* Looks for area with |name| in FlashMap. Requires lib_sysinfo.fmap_cache. */ -cb_err_t fmap_locate_area(const char *name, size_t *offset, size_t *size); - -#endif /* _FMAP_H */ diff --git a/payloads/libpayload/include/fmap_serialized.h b/payloads/libpayload/include/fmap_serialized.h new file mode 100644 index 0000000..53a09af --- /dev/null +++ b/payloads/libpayload/include/fmap_serialized.h @@ -0,0 +1,74 @@ +/* + * Copyright 2010, Google Inc. + * All rights reserved. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions are + * met: + * + * * Redistributions of source code must retain the above copyright + * notice, this list of conditions and the following disclaimer. + * * Redistributions in binary form must reproduce the above + * copyright notice, this list of conditions and the following disclaimer + * in the documentation and/or other materials provided with the + * distribution. + * * Neither the name of Google Inc. nor the names of its + * contributors may be used to endorse or promote products derived from + * this software without specific prior written permission. + * + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS + * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT + * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR + * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT + * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, + * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT + * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, + * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY + * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT + * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE + * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + * + * Alternatively, this software may be distributed under the terms of the + * GNU General Public License ("GPL") version 2 as published by the Free + * Software Foundation. + */ + +#ifndef FLASHMAP_SERIALIZED_H__ +#define FLASHMAP_SERIALIZED_H__ + +#include <stdint.h> + +#define FMAP_SIGNATURE "__FMAP__" +#define FMAP_VER_MAJOR 1 /* this header's FMAP minor version */ +#define FMAP_VER_MINOR 1 /* this header's FMAP minor version */ +#define FMAP_STRLEN 32 /* maximum length for strings, */ + /* including null-terminator */ + +enum fmap_flags { + FMAP_AREA_STATIC = 1 << 0, + FMAP_AREA_COMPRESSED = 1 << 1, + FMAP_AREA_RO = 1 << 2, + FMAP_AREA_PRESERVE = 1 << 3, +}; + +/* Mapping of volatile and static regions in firmware binary */ +struct fmap_area { + uint32_t offset; /* offset relative to base */ + uint32_t size; /* size in bytes */ + uint8_t name[FMAP_STRLEN]; /* descriptive name */ + uint16_t flags; /* flags for this area */ +} __packed; + +struct fmap { + uint8_t signature[8]; /* "__FMAP__" (0x5F5F464D41505F5F) */ + uint8_t ver_major; /* major version */ + uint8_t ver_minor; /* minor version */ + uint64_t base; /* address of the firmware binary */ + uint32_t size; /* size of firmware binary in bytes */ + uint8_t name[FMAP_STRLEN]; /* name of this firmware binary */ + uint16_t nareas; /* number of areas described by + fmap_areas[] below */ + struct fmap_area areas[]; +} __packed; + +#endif /* FLASHMAP_SERIALIZED_H__ */ diff --git a/payloads/libpayload/include/libpayload.h b/payloads/libpayload/include/libpayload.h index 250ba05..a318d16 100644 --- a/payloads/libpayload/include/libpayload.h +++ b/payloads/libpayload/include/libpayload.h @@ -45,11 +45,10 @@ #include <stdbool.h> #include <libpayload-config.h> #include <cbgfx.h> -#include <commonlib/bsd/fmap_serialized.h> #include <ctype.h> #include <die.h> #include <endian.h> -#include <fmap.h> +#include <fmap_serialized.h> #include <ipchksum.h> #include <kconfig.h> #include <stddef.h> diff --git a/payloads/libpayload/libc/fmap.c b/payloads/libpayload/libc/fmap.c index 2d185a7..b7d6491 100644 --- a/payloads/libpayload/libc/fmap.c +++ b/payloads/libpayload/libc/fmap.c @@ -28,60 +28,10 @@ #include <libpayload-config.h> #include <libpayload.h> -#include <commonlib/bsd/fmap_serialized.h> #include <coreboot_tables.h> #include <cbfs.h> -#include <boot_device.h> +#include <fmap_serialized.h> #include <stdint.h> -#include <arch/virtual.h> - -/* Private fmap cache. */ -static struct fmap *_fmap_cache; - -static cb_err_t fmap_find_area(struct fmap *fmap, const char *name, size_t *offset, - size_t *size) -{ - for (size_t i = 0; i < le32toh(fmap->nareas); ++i) { - if (strncmp((const char *)fmap->areas[i].name, name, FMAP_STRLEN) != 0) - continue; - if (offset) - *offset = le32toh(fmap->areas[i].offset); - if (size) - *size = le32toh(fmap->areas[i].size); - return CB_SUCCESS; - } - - return CB_ERR; -} - -static bool fmap_is_signature_valid(struct fmap *fmap) -{ - return memcmp(fmap->signature, FMAP_SIGNATURE, sizeof(fmap->signature)) == 0; -} - -static bool fmap_setup_cache(void) -{ - /* Use FMAP cache if available */ - if (lib_sysinfo.fmap_cache - && fmap_is_signature_valid((struct fmap *)phys_to_virt(lib_sysinfo.fmap_cache))) { - _fmap_cache = (struct fmap *)phys_to_virt(lib_sysinfo.fmap_cache); - return true; - } - - return false; -} - -cb_err_t fmap_locate_area(const char *name, size_t *offset, size_t *size) -{ - if (!_fmap_cache && !fmap_setup_cache()) - return CB_ERR; - - return fmap_find_area(_fmap_cache, name, offset, size); -} - -/*********************************************************************************************** - * LEGACY CODE * - **********************************************************************************************/ int fmap_region_by_name(const uint32_t fmap_offset, const char * const name, uint32_t * const offset, uint32_t * const size) diff --git a/payloads/libpayload/tests/libc/Makefile.inc b/payloads/libpayload/tests/libc/Makefile.inc deleted file mode 100644 index 5f92bdf..0000000 --- a/payloads/libpayload/tests/libc/Makefile.inc +++ /dev/null @@ -1,3 +0,0 @@ -tests-y += fmap_locate_area-test - -fmap_locate_area-test-srcs += tests/libc/fmap_locate_area-test.c diff --git a/payloads/libpayload/tests/libc/fmap_locate_area-test.c b/payloads/libpayload/tests/libc/fmap_locate_area-test.c deleted file mode 100644 index ce7c36b..0000000 --- a/payloads/libpayload/tests/libc/fmap_locate_area-test.c +++ /dev/null @@ -1,112 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -#include "../libc/fmap.c" - -#include <libpayload.h> -#include <tests/test.h> - - -/* Mocks */ -struct sysinfo_t lib_sysinfo; -unsigned long virtual_offset = 0; - -static void reset_fmap_cache(void) -{ - _fmap_cache = NULL; -} - -static int setup_fmap_test(void **state) -{ - reset_fmap_cache(); - lib_sysinfo.fmap_cache = 0; - return 0; -} - -static void test_fmap_locate_area_no_fmap_available(void **state) -{ - size_t offset = 0; - size_t size = 0; - - assert_int_equal(-1, fmap_locate_area("COREBOOT", &offset, &size)); -} - -static void test_fmap_locate_area_incorrect_signature(void **state) -{ - size_t offset = 0; - size_t size = 0; - struct fmap mock_fmap = { - .signature = "NOT_MAP", - }; - lib_sysinfo.fmap_cache = (uintptr_t)&mock_fmap; - - assert_int_equal(-1, fmap_locate_area("COREBOOT", &offset, &size)); -} - -static void test_fmap_locate_area_success(void **state) -{ - size_t offset = 0; - size_t size = 0; - struct fmap mock_fmap = { - .signature = FMAP_SIGNATURE, - .ver_major = 1, - .ver_minor = 1, - .base = 0xAABB, - .size = 0x10000, - .nareas = 3, - }; - struct fmap_area area_1 = { - .size = 0x1100, - .offset = 0x11, - .name = {'F', 'I', 'R', 'S', 'T', '_', 'A', 'R', 'E', 'A', 0}, - .flags = 0, - }; - struct fmap_area area_2 = { - .size = 0x2200, - .offset = 0x1111, - .name = {'S', 'E', 'C', 'O', 'N', 'D', '_', 'A', 'R', 'E', 'A', 0}, - .flags = 0, - }; - struct fmap_area area_3 = { - .size = 0x100, - .offset = 0x3311, - .name = {'T', 'H', 'I', 'R', 'D', '_', 'A', 'R', 'E', 'A', 0}, - .flags = 0, - }; - u8 fmap_buffer[sizeof(struct fmap) + 3 * sizeof(struct fmap_area)]; - memcpy(fmap_buffer, &mock_fmap, sizeof(mock_fmap)); - memcpy(&fmap_buffer[sizeof(mock_fmap)], &area_1, sizeof(area_1)); - memcpy(&fmap_buffer[sizeof(mock_fmap) + sizeof(area_1)], &area_2, sizeof(area_2)); - memcpy(&fmap_buffer[sizeof(mock_fmap) + sizeof(area_1) + sizeof(area_2)], &area_3, - sizeof(area_3)); - - /* Cache only */ - reset_fmap_cache(); - lib_sysinfo.fmap_cache = (uintptr_t)fmap_buffer; - - assert_int_equal(0, fmap_locate_area("FIRST_AREA", &offset, &size)); - assert_int_equal(area_1.offset, offset); - assert_int_equal(area_1.size, size); - - assert_int_equal(0, fmap_locate_area("THIRD_AREA", &offset, &size)); - assert_int_equal(area_3.offset, offset); - assert_int_equal(area_3.size, size); - - assert_int_equal(0, fmap_locate_area("SECOND_AREA", &offset, &size)); - assert_int_equal(area_2.offset, offset); - assert_int_equal(area_2.size, size); - - reset_fmap_cache(); -} - -#define FMAP_LOCATE_AREA_TEST(fn) cmocka_unit_test_setup(fn, setup_fmap_test) - -int main(void) -{ - const struct CMUnitTest tests[] = { - FMAP_LOCATE_AREA_TEST(test_fmap_locate_area_no_fmap_available), - FMAP_LOCATE_AREA_TEST(test_fmap_locate_area_incorrect_signature), - FMAP_LOCATE_AREA_TEST(test_fmap_locate_area_success), - }; - - return lp_run_group_tests(tests, NULL, NULL); -} -- To view, visit https://review.coreboot.org/c/coreboot/+/60797 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieccf2d709206e1cb53fec00d0fafb3748b9dedb6 Gerrit-Change-Number: 60797 Gerrit-PatchSet: 1 Gerrit-Owner: Sudheer Amrabadi <samrabad(a)codeaurora.org> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: HACK Remove herobrine dependency code HACK
by Sudheer Amrabadi (Code Review) 05 Jan '22

05 Jan '22

Attention is currently required from: Ravi kumar. Hello Ravi kumar, I'd like you to do a code review. Please visit https://review.coreboot.org/c/coreboot/+/60796 to review the following change. Change subject: HACK Remove herobrine dependency code HACK ...................................................................... HACK Remove herobrine dependency code HACK Change-Id: I7dd0ab9ef91c107ac5571ba877c3f9294475cb9f Signed-off-by: Ravi Kumar Bokka <rbokka(a)codeaurora.org> --- M src/soc/qualcomm/common/qclib.c 1 file changed, 0 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/60796/1 diff --git a/src/soc/qualcomm/common/qclib.c b/src/soc/qualcomm/common/qclib.c index 597d46b..85821fd 100644 --- a/src/soc/qualcomm/common/qclib.c +++ b/src/soc/qualcomm/common/qclib.c @@ -141,7 +141,6 @@ __weak int qclib_soc_blob_load(void) { return 0; } -void mainboard_blob_fix(void); void qclib_load_and_run(void) { int i; @@ -250,9 +249,6 @@ mmu_disable(); mmu_restore_context(&pre_qclib_mmu_context); mmu_enable(); -#if CONFIG(BOARD_GOOGLE_HEROBRINE) - mainboard_blob_fix(); -#endif /* step through I/F table, handling return values */ for (i = 0; i < qclib_cb_if_table.num_entries; i++) -- To view, visit https://review.coreboot.org/c/coreboot/+/60796 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7dd0ab9ef91c107ac5571ba877c3f9294475cb9f Gerrit-Change-Number: 60796 Gerrit-PatchSet: 1 Gerrit-Owner: Sudheer Amrabadi <samrabad(a)codeaurora.org> Gerrit-Reviewer: Ravi kumar <rbokka(a)codeaurora.org> Gerrit-Attention: Ravi kumar <rbokka(a)codeaurora.org> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: HACK sc7280: QSIP SPI NOR addressing mode for SKU1 and SKU2 HACK
by Sudheer Amrabadi (Code Review) 05 Jan '22

05 Jan '22

Attention is currently required from: Shelley Chen, Ravi kumar, Sudheer Amrabadi, mturney mturney. Sudheer Amrabadi has uploaded a new patch set (#102) to the change originally created by Ravi kumar. ( https://review.coreboot.org/c/coreboot/+/50586 ) Change subject: HACK sc7280: QSIP SPI NOR addressing mode for SKU1 and SKU2 HACK ...................................................................... HACK sc7280: QSIP SPI NOR addressing mode for SKU1 and SKU2 HACK Change Addressing mode of SPI nor from 4-bytes to 3-bytes As 4-bytes not supporting in coreboot. BUG=b:182963902 TEST=Validated on qualcomm sc7280 developement board Change-Id: Ied5b647d0fcc8e3effff3bb7c8680ed5a0c1f3d4 Signed-off-by: Veerabhadrarao Badiganti <vbadigan(a)codeaurora.org> Signed-off-by: Shaik Sajida Bhanu <sbhanu(a)codeaurora.org> --- M src/drivers/spi/spi_flash.c M src/mainboard/google/herobrine/Kconfig M src/soc/qualcomm/common/qclib.c 3 files changed, 48 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/50586/102 -- To view, visit https://review.coreboot.org/c/coreboot/+/50586 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ied5b647d0fcc8e3effff3bb7c8680ed5a0c1f3d4 Gerrit-Change-Number: 50586 Gerrit-PatchSet: 102 Gerrit-Owner: Ravi kumar <rbokka(a)codeaurora.org> Gerrit-Reviewer: Sajida Bhanu <quic_c_sbhanu(a)quicinc.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Ravi kumar <rbokka(a)codeaurora.org> Gerrit-Attention: Sudheer Amrabadi <samrabad(a)codeaurora.org> Gerrit-Attention: mturney mturney <quic_mturney(a)quicinc.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: Herobrine: TPM Config Changes to support audio
by Sudheer Amrabadi (Code Review) 05 Jan '22

05 Jan '22

Attention is currently required from: Shelley Chen. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/60167 to look at the new patch set (#5). Change subject: Herobrine: TPM Config Changes to support audio ...................................................................... Herobrine: TPM Config Changes to support audio Add configuration for target specific i2s ports BUG=b:182963902 TEST=Validated on qualcomm sc7280 developement board Signed-off-by: Srinivasa Rao Mandadapu <srivasam(a)codeaurora.org> Change-Id: Ifb3452faa2c43e2303ab4b1fef193184ffe4a938 --- M src/mainboard/google/herobrine/chromeos.c 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/60167/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/60167 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifb3452faa2c43e2303ab4b1fef193184ffe4a938 Gerrit-Change-Number: 60167 Gerrit-PatchSet: 5 Gerrit-Owner: Sudheer Amrabadi <samrabad(a)codeaurora.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: Herobrine: sc7280: Add support for audio
by Sudheer Amrabadi (Code Review) 05 Jan '22

05 Jan '22

Attention is currently required from: Ravi kumar, Sudheer Amrabadi. Sudheer Amrabadi has uploaded a new patch set (#33) to the change originally created by Ravi kumar. ( https://review.coreboot.org/c/coreboot/+/57449 ) Change subject: Herobrine: sc7280: Add support for audio ...................................................................... Herobrine: sc7280: Add support for audio Add gpio configuration for target specific i2s ports BUG=b:182963902 TEST=Validated on qualcomm sc7280 developement board Signed-off-by: Srinivasa Rao Mandadapu <srivasam(a)codeaurora.org> Change-Id: I2ce95332f892d5d4acb2755307df84d37feb8002 --- M src/mainboard/google/herobrine/board.h M src/mainboard/google/herobrine/chromeos.c M src/mainboard/google/herobrine/mainboard.c 3 files changed, 27 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/57449/33 -- To view, visit https://review.coreboot.org/c/coreboot/+/57449 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2ce95332f892d5d4acb2755307df84d37feb8002 Gerrit-Change-Number: 57449 Gerrit-PatchSet: 33 Gerrit-Owner: Ravi kumar <rbokka(a)codeaurora.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Ravi Kumar Bokka <c_rbokka(a)qualcomm.corp-partner.google.com> Gerrit-CC: Shelley Chen <shchen(a)google.com> Gerrit-CC: Sudheer Amrabadi <samrabad(a)codeaurora.org> Gerrit-Attention: Ravi kumar <rbokka(a)codeaurora.org> Gerrit-Attention: Sudheer Amrabadi <samrabad(a)codeaurora.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/starlabs/labtop: Remove display from devicetree
by Felix Held (Code Review) 05 Jan '22

05 Jan '22

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/59258 ) Change subject: mb/starlabs/labtop: Remove display from devicetree ...................................................................... mb/starlabs/labtop: Remove display from devicetree Remove display from devicetree as Intel's brightness controls are not used on this platform. This solves the below errors appearing in dmesg: No Local Variables are initialized for Method [_BCL] No Arguments are initialized for method [_BCL] Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Change-Id: Icf2f2fa33abd11952c888c9502d1d5ef1ad6544f Reviewed-on: https://review.coreboot.org/c/coreboot/+/59258 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Nico Huber <nico.h(a)gmx.de> --- M src/mainboard/starlabs/labtop/variants/tgl/devicetree.cb 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved diff --git a/src/mainboard/starlabs/labtop/variants/tgl/devicetree.cb b/src/mainboard/starlabs/labtop/variants/tgl/devicetree.cb index 0b78914..6bfe208 100644 --- a/src/mainboard/starlabs/labtop/variants/tgl/devicetree.cb +++ b/src/mainboard/starlabs/labtop/variants/tgl/devicetree.cb @@ -4,8 +4,6 @@ register "eist_enable" = "1" # Graphics - # IGD Displays - register "gfx" = "GMA_STATIC_DISPLAYS(0)" # Not used but timings left for reference # register "panel_cfg" = "{ # .up_delay_ms = 2000, // T3 9 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://review.coreboot.org/c/coreboot/+/59258 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icf2f2fa33abd11952c888c9502d1d5ef1ad6544f Gerrit-Change-Number: 59258 Gerrit-PatchSet: 11 Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: src/northbridge: Remove unused <delay.h>
by Felix Held (Code Review) 05 Jan '22

05 Jan '22

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60606 ) Change subject: src/northbridge: Remove unused <delay.h> ...................................................................... src/northbridge: Remove unused <delay.h> Change-Id: I5449feeb65c49c79bc7657a1c3777a0f128a13b1 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60606 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> --- M src/northbridge/intel/sandybridge/raminit_iosav.c 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved diff --git a/src/northbridge/intel/sandybridge/raminit_iosav.c b/src/northbridge/intel/sandybridge/raminit_iosav.c index e337c40..12a3be6 100644 --- a/src/northbridge/intel/sandybridge/raminit_iosav.c +++ b/src/northbridge/intel/sandybridge/raminit_iosav.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <commonlib/helpers.h> -#include <delay.h> #include <types.h> #include "raminit_native.h" 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://review.coreboot.org/c/coreboot/+/60606 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5449feeb65c49c79bc7657a1c3777a0f128a13b1 Gerrit-Change-Number: 60606 Gerrit-PatchSet: 3 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: src/soc/amd: Remove unused <delay.h>
by Felix Held (Code Review) 05 Jan '22

05 Jan '22

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60605 ) Change subject: src/soc/amd: Remove unused <delay.h> ...................................................................... src/soc/amd: Remove unused <delay.h> Found using: diff <(git grep -l '#include <delay.h>' -- src/) <(git grep -l 'get_timer_fsb(\|init_timer(\|udelay(\|mdelay(\|delay(' -- src/) |grep "<" Change-Id: Iefb37d28c7f13563fa652cd6b2f661f462a3a32e Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60605 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Felix Held <felix-coreboot(a)felixheld.de> --- M src/soc/amd/common/block/apob/apob_cache.c 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, approved diff --git a/src/soc/amd/common/block/apob/apob_cache.c b/src/soc/amd/common/block/apob/apob_cache.c index f61785d..c696497 100644 --- a/src/soc/amd/common/block/apob/apob_cache.c +++ b/src/soc/amd/common/block/apob/apob_cache.c @@ -8,7 +8,6 @@ #include <commonlib/helpers.h> #include <commonlib/region.h> #include <console/console.h> -#include <delay.h> #include <fmap.h> #include <spi_flash.h> #include <stdint.h> -- To view, visit https://review.coreboot.org/c/coreboot/+/60605 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iefb37d28c7f13563fa652cd6b2f661f462a3a32e Gerrit-Change-Number: 60605 Gerrit-PatchSet: 4 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: src/soc/intel: Remove unused <delay.h>
by Felix Held (Code Review) 05 Jan '22

05 Jan '22

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60604 ) Change subject: src/soc/intel: Remove unused <delay.h> ...................................................................... src/soc/intel: Remove unused <delay.h> Change-Id: Id8e6221a9801d5198171dc9cd564000d19720a42 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60604 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Tim Wawrzynczak <twawrzynczak(a)chromium.org> --- M src/soc/intel/alderlake/crashlog.c M src/soc/intel/tigerlake/crashlog_lib.c 2 files changed, 0 insertions(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified Tim Wawrzynczak: Looks good to me, approved diff --git a/src/soc/intel/alderlake/crashlog.c b/src/soc/intel/alderlake/crashlog.c index 3a857c1..ee66730 100644 --- a/src/soc/intel/alderlake/crashlog.c +++ b/src/soc/intel/alderlake/crashlog.c @@ -2,7 +2,6 @@ #include <console/console.h> #include <cbmem.h> -#include <delay.h> #include <intelblocks/crashlog.h> #include <string.h> #include <soc/crashlog.h> diff --git a/src/soc/intel/tigerlake/crashlog_lib.c b/src/soc/intel/tigerlake/crashlog_lib.c index 93baf04..aec4aef 100644 --- a/src/soc/intel/tigerlake/crashlog_lib.c +++ b/src/soc/intel/tigerlake/crashlog_lib.c @@ -2,7 +2,6 @@ #include <console/console.h> #include <cbmem.h> -#include <delay.h> #include <intelblocks/crashlog.h> #include <string.h> #include <soc/crashlog.h> 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://review.coreboot.org/c/coreboot/+/60604 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id8e6221a9801d5198171dc9cd564000d19720a42 Gerrit-Change-Number: 60604 Gerrit-PatchSet: 3 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2022