coreboot-gerrit August 2021

coreboot-gerrit@coreboot.org

1 participants
4520 discussions

Change in coreboot[master]: Revert "src/soc/intel/cannonlake: Update C-state latency control limits"
by Vaibhav Shankar (Code Review) 02 Aug '21

02 Aug '21

Attention is currently required from: Bora Guvendik, Felix Singer, Lijian Zhao, Shaunak Saha, Nico Huber, Martin Roth, Tim Wawrzynczak, Aaron Durbin, Patrick Rudolph. Vaibhav Shankar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56662 ) Change subject: Revert "src/soc/intel/cannonlake: Update C-state latency control limits" ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: The original patch is not a hack. The IRTL values are based out of extensive silicon testing for S0ix on Cannon lake platfrom(initial 10nm). Please note the current IRTL limits are for 14nm process and does not work on 10nm proess. -- To view, visit https://review.coreboot.org/c/coreboot/+/56662 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iea56c6a29ca4b34c9852393fed2e3be4de128ec6 Gerrit-Change-Number: 56662 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Reviewer: Vaibhav Shankar <vaibhav.shankar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Attention: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Attention: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Mon, 02 Aug 2021 17:10:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/amd/bilby: Add support for HDMI display
by Felix Held (Code Review) 02 Aug '21

02 Aug '21

Attention is currently required from: ritul guru, Aamir Bohra. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56756 ) Change subject: mb/amd/bilby: Add support for HDMI display ...................................................................... Patch Set 2: (1 comment) File src/mainboard/amd/bilby/mainboard.c: https://review.coreboot.org/c/coreboot/+/56756/comment/773a4d29_1e10a3d6 PS2, Line 96: gpio_output(display_sel[idx], 0); GPIO 31 gets configured as input here https://review.coreboot.org/plugins/gitiles/coreboot/+/refs/heads/master/sr… and GPIO 29 doesn't get configured at all, so i'd configure the GPIOs here in both cases and also remove the GPIO setting in the file linked above -- To view, visit https://review.coreboot.org/c/coreboot/+/56756 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9697211c556f12d1fc0d49418b227fbe6b342673 Gerrit-Change-Number: 56756 Gerrit-PatchSet: 2 Gerrit-Owner: Aamir Bohra <aamirbohra(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ritul guru <ritul.bits(a)gmail.com> Gerrit-Attention: ritul guru <ritul.bits(a)gmail.com> Gerrit-Attention: Aamir Bohra <aamirbohra(a)gmail.com> Gerrit-Comment-Date: Mon, 02 Aug 2021 17:03:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/cannonlake: Disable `TccOffsetClamp` if no offset is given
by Michael Niewöhner (Code Review) 02 Aug '21

02 Aug '21

Attention is currently required from: Felix Singer, Nico Huber, Patrick Rudolph. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56660 ) Change subject: soc/intel/cannonlake: Disable `TccOffsetClamp` if no offset is given ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/56660 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4f9b62fd944d8a91d53bc584c88797f23de1e5ca Gerrit-Change-Number: 56660 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Mon, 02 Aug 2021 16:52:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Revert "src/soc/intel/cannonlake: Update C-state latency control limits"
by Michael Niewöhner (Code Review) 02 Aug '21

02 Aug '21

Attention is currently required from: Bora Guvendik, Felix Singer, Lijian Zhao, Shaunak Saha, Nico Huber, Martin Roth, Tim Wawrzynczak, Aaron Durbin, Vaibhav Shankar, Patrick Rudolph. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56662 ) Change subject: Revert "src/soc/intel/cannonlake: Update C-state latency control limits" ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Added Author and reviewers of the reverted commit -- To view, visit https://review.coreboot.org/c/coreboot/+/56662 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iea56c6a29ca4b34c9852393fed2e3be4de128ec6 Gerrit-Change-Number: 56662 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Reviewer: Vaibhav Shankar <vaibhav.shankar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Attention: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Attention: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Attention: Vaibhav Shankar <vaibhav.shankar(a)intel.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Mon, 02 Aug 2021 16:50:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/broadwell: Replace soc/intel/common include
by Felix Held (Code Review) 02 Aug '21

02 Aug '21

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55797 ) Change subject: soc/intel/broadwell: Replace soc/intel/common include ...................................................................... Patch Set 6: (1 comment) Patchset: PS5: > Ideally, everyone would use the code in `device/azalia_device`. […] ok -- To view, visit https://review.coreboot.org/c/coreboot/+/55797 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9b8ca91bed67be9c6850bd51f4c81e002a0f5aef Gerrit-Change-Number: 55797 Gerrit-PatchSet: 6 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Mon, 02 Aug 2021 16:28:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/amd/bilby: Enable DP2 and DP3 enumeration
by Felix Held (Code Review) 02 Aug '21

02 Aug '21

Attention is currently required from: Aamir Bohra. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56755 ) Change subject: mb/amd/bilby: Enable DP2 and DP3 enumeration ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/56755 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If0c8dfbb47175789bb27d4506c1e8b45c425c76a Gerrit-Change-Number: 56755 Gerrit-PatchSet: 2 Gerrit-Owner: Aamir Bohra <aamirbohra(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ritul guru <ritul.bits(a)gmail.com> Gerrit-Attention: Aamir Bohra <aamirbohra(a)gmail.com> Gerrit-Comment-Date: Mon, 02 Aug 2021 16:26:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: [TESTME] mb/google/auron: Refactor memory-down SPD handling
by build bot (Jenkins) (Code Review) 02 Aug '21

02 Aug '21

Attention is currently required from: Nico Huber, Matt DeVillier, Arthur Heymans, Patrick Rudolph. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55803 ) Change subject: [TESTME] mb/google/auron: Refactor memory-down SPD handling ...................................................................... Patch Set 5: (3 comments) File src/mainboard/google/auron/variants/lulu/spd/spd.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125546): https://review.coreboot.org/c/coreboot/+/55803/comment/9e05abca_28092c12 PS5, Line 27: return !((spd_index == 0b0000) || (spd_index == 0b0011) || (spd_index == 0b1010)); Avoid gcc v4.3+ binary constant extension: <0b0000> Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125546): https://review.coreboot.org/c/coreboot/+/55803/comment/d5ef31ce_fdd51c07 PS5, Line 27: return !((spd_index == 0b0000) || (spd_index == 0b0011) || (spd_index == 0b1010)); Avoid gcc v4.3+ binary constant extension: <0b0011> Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125546): https://review.coreboot.org/c/coreboot/+/55803/comment/a46279b9_2a126dec PS5, Line 27: return !((spd_index == 0b0000) || (spd_index == 0b0011) || (spd_index == 0b1010)); Avoid gcc v4.3+ binary constant extension: <0b1010> -- To view, visit https://review.coreboot.org/c/coreboot/+/55803 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9bc4527057d4a771883c8cc60da2501516d6fb94 Gerrit-Change-Number: 55803 Gerrit-PatchSet: 5 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Mon, 02 Aug 2021 16:25:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: libpayload: Mark Intel 300 series AHCI as tested
by Angel Pons (Code Review) 02 Aug '21

02 Aug '21

Attention is currently required from: Felix Singer, Nico Huber. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56666 ) Change subject: libpayload: Mark Intel 300 series AHCI as tested ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/56666 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia5f868d3a9cead0a872e6d3e9fdacd6eeb7f158b Gerrit-Change-Number: 56666 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Mon, 02 Aug 2021 16:18:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: console/hw-debug_sink: Update for fast/slow console distinction
by Angel Pons (Code Review) 02 Aug '21

02 Aug '21

Attention is currently required from: Felix Singer, Nico Huber. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56665 ) Change subject: console/hw-debug_sink: Update for fast/slow console distinction ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/56665 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9ac110c7b812f912f0f87cbe4aa218d4a78e6aaf Gerrit-Change-Number: 56665 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Mon, 02 Aug 2021 16:17:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/cannonlake: Allow to configure maximum package C state
by Angel Pons (Code Review) 02 Aug '21

02 Aug '21

Attention is currently required from: Felix Singer, Nico Huber, Patrick Rudolph. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56661 ) Change subject: soc/intel/cannonlake: Allow to configure maximum package C state ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: I don't really like the magic 0xf mask -- To view, visit https://review.coreboot.org/c/coreboot/+/56661 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0dc254d34f46de4c65cb85cc92e4b7f26618888d Gerrit-Change-Number: 56661 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Mon, 02 Aug 2021 16:09:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2021