coreboot-gerrit August 2021

coreboot-gerrit@coreboot.org

1 participants
4520 discussions

Change in coreboot[master]: Move elog_internal.h to commonlib/bsd/include
by Ricardo Quesada (Code Review) 03 Aug '21

03 Aug '21

Attention is currently required from: Furquan Shaikh, Ricardo Quesada. Hello build bot (Jenkins), Tim Wawrzynczak, Jack Rosenthal, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/56404 to look at the new patch set (#5). Change subject: Move elog_internal.h to commonlib/bsd/include ...................................................................... Move elog_internal.h to commonlib/bsd/include Move elog_internal.h to commonlib/bsd/include/bsd/. And rename it from elog_internal.h to elog.h. Since this file will be included from util/ it also converts the "uNN" types into "uintNN_t" types. The two defines that are not used by util/ are moved to drivers/elog/elog.c, the only file that includes them. Move also the function elog_verify_header() from drivers/elog/, to commonlib/bsd/elog.c since this function will be called from util/ as well. The rationale behind moving elog's defines & structs to commonlib/bsd/include is to make them available to util/ tools and/or payloads (should it be needed in the future). The files that are being relicensed to BSD were coded by Duncan Laurie, and he is Ok with the relicense. BUG=b:172210863 Signed-off-by: Ricardo Quesada <ricardoq(a)google.com> Change-Id: Ia1aefea705ddd417a1d9e978bb18ab6d9a60cad6 --- M src/commonlib/Makefile.inc A src/commonlib/bsd/elog.c A src/commonlib/bsd/include/commonlib/bsd/elog.h M src/drivers/elog/elog.c D src/drivers/elog/elog_internal.h 5 files changed, 78 insertions(+), 58 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/56404/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/56404 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia1aefea705ddd417a1d9e978bb18ab6d9a60cad6 Gerrit-Change-Number: 56404 Gerrit-PatchSet: 5 Gerrit-Owner: Ricardo Quesada <ricardoq(a)google.com> Gerrit-Reviewer: Jack Rosenthal <jrosenth(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Furquan Shaikh <furquan(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Ricardo Quesada <ricardoq(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: Move post_codes.h to commonlib/console/
by Ricardo Quesada (Code Review) 03 Aug '21

03 Aug '21

Attention is currently required from: Patrick Rudolph. Ricardo Quesada has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56403 ) Change subject: Move post_codes.h to commonlib/console/ ...................................................................... Patch Set 4: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/56403/comment/5d4898f4_7e83d3df PS3, Line 17: > BUG=b:172210863 Done Patchset: PS4: Thanks. fixed. -- To view, visit https://review.coreboot.org/c/coreboot/+/56403 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie48c4b1d01474237d007c47832613cf1d4a86ae1 Gerrit-Change-Number: 56403 Gerrit-PatchSet: 4 Gerrit-Owner: Ricardo Quesada <ricardoq(a)google.com> Gerrit-Reviewer: Jack Rosenthal <jrosenth(a)chromium.org> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Mon, 02 Aug 2021 22:21:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Move post_codes.h to commonlib/console/
by Ricardo Quesada (Code Review) 03 Aug '21

03 Aug '21

Attention is currently required from: Ricardo Quesada, Patrick Rudolph. Hello build bot (Jenkins), Tim Wawrzynczak, Paul Menzel, Jack Rosenthal, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/56403 to look at the new patch set (#4). Change subject: Move post_codes.h to commonlib/console/ ...................................................................... Move post_codes.h to commonlib/console/ Move post_codes.h from include/console to commonlib/include/commonlib/console. This is because post_codes.h is needed by code from util/ (util/ code in different commit). Also, it sorts the #include statements in the files that were modified. BUG=b:172210863 Signed-off-by: Ricardo Quesada <ricardoq(a)google.com> Change-Id: Ie48c4b1d01474237d007c47832613cf1d4a86ae1 --- R src/commonlib/include/commonlib/console/post_codes.h M src/include/console/console.h M src/include/cpu/x86/post_code.h M src/lib/hardwaremain.c M src/soc/intel/alderlake/finalize.c M src/soc/intel/broadwell/finalize.c M src/soc/intel/cannonlake/finalize.c M src/soc/intel/common/acpi/platform.asl M src/soc/intel/elkhartlake/bootblock/pch.c M src/soc/intel/elkhartlake/finalize.c M src/soc/intel/icelake/finalize.c M src/soc/intel/jasperlake/bootblock/pch.c M src/soc/intel/jasperlake/finalize.c M src/soc/intel/skylake/finalize.c M src/soc/intel/tigerlake/bootblock/pch.c M src/soc/intel/tigerlake/finalize.c 16 files changed, 39 insertions(+), 39 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/56403/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/56403 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie48c4b1d01474237d007c47832613cf1d4a86ae1 Gerrit-Change-Number: 56403 Gerrit-PatchSet: 4 Gerrit-Owner: Ricardo Quesada <ricardoq(a)google.com> Gerrit-Reviewer: Jack Rosenthal <jrosenth(a)chromium.org> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Ricardo Quesada <ricardoq(a)google.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: src: Add new Kconfig DEBUG_SOC_HOOKS
by Tim Wawrzynczak (Code Review) 03 Aug '21

03 Aug '21

Attention is currently required from: Julius Werner. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56726 ) Change subject: src: Add new Kconfig DEBUG_SOC_HOOKS ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Does this need to be toplevel? I don't really understand what this debug_hooks thing is supposed to […] Intel has a feature called crashlog which collects some internal state. I was planning to add a USE flag to our build system which appends this Kconfig to the config file when it's USEd. -- To view, visit https://review.coreboot.org/c/coreboot/+/56726 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If0e7f076bb7e3b630c3ab9d28071312d3e21e927 Gerrit-Change-Number: 56726 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Mon, 02 Aug 2021 22:19:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Revert "src/soc/intel/cannonlake: Update C-state latency control limits"
by Vaibhav Shankar (Code Review) 02 Aug '21

02 Aug '21

Attention is currently required from: Bora Guvendik, Felix Singer, Lijian Zhao, Shaunak Saha, Nico Huber, Martin Roth, Michael Niewöhner, Tim Wawrzynczak, Aaron Durbin, Patrick Rudolph. Vaibhav Shankar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56662 ) Change subject: Revert "src/soc/intel/cannonlake: Update C-state latency control limits" ...................................................................... Patch Set 1: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/56662/comment/8313eb9c_9943c8d1 PS1, Line 14: > How was this tested? Does S0ix still work? S0ix is enabled by default on all recent chromeOs platfroms. You can check the S0ix entry and exit counts from sysfs- PMC core driver Patchset: PS1: > So, the previous values were for Cannon Lake, while the previous ones are Coffee Lake. […] The cannon lake support was dropped. If you are using Coffe lake, then you might have to use board- skylake values becaue its based out of 14nm. reference to previous IRTL values(14nm)- https://github.com/coreboot/coreboot/blob/master/src/soc/intel/skylake/cpu.c Why are we modfying cannonlake values ? -- To view, visit https://review.coreboot.org/c/coreboot/+/56662 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iea56c6a29ca4b34c9852393fed2e3be4de128ec6 Gerrit-Change-Number: 56662 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Reviewer: Vaibhav Shankar <vaibhav.shankar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Attention: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Attention: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Mon, 02 Aug 2021 21:06:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Comment-In-Reply-To: Vaibhav Shankar <vaibhav.shankar(a)intel.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Revert "src/soc/intel/cannonlake: Update C-state latency control limits"
by Michael Niewöhner (Code Review) 02 Aug '21

02 Aug '21

Attention is currently required from: Bora Guvendik, Felix Singer, Lijian Zhao, Shaunak Saha, Nico Huber, Martin Roth, Tim Wawrzynczak, Vaibhav Shankar, Aaron Durbin, Patrick Rudolph. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56662 ) Change subject: Revert "src/soc/intel/cannonlake: Update C-state latency control limits" ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > The original patch is not a hack. […] So, the previous values were for Cannon Lake, while the previous ones are Coffee Lake. IOW the revert is right, since we dropped Cannon Lake support? -- To view, visit https://review.coreboot.org/c/coreboot/+/56662 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iea56c6a29ca4b34c9852393fed2e3be4de128ec6 Gerrit-Change-Number: 56662 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Reviewer: Vaibhav Shankar <vaibhav.shankar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Attention: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Attention: Vaibhav Shankar <vaibhav.shankar(a)intel.com> Gerrit-Attention: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Mon, 02 Aug 2021 20:45:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Vaibhav Shankar <vaibhav.shankar(a)intel.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/kconfig: detect ncurses on FreeBSD
by Martin Roth (Code Review) 02 Aug '21

02 Aug '21

Attention is currently required from: Idwer Vollering, Paul Menzel. Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56677 ) Change subject: util/kconfig: detect ncurses on FreeBSD ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/56677 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4344ba2116c0b8618357db4248d993509cbb666e Gerrit-Change-Number: 56677 Gerrit-PatchSet: 5 Gerrit-Owner: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Mon, 02 Aug 2021 20:37:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/dedede: Create bugzzy variant
by Karthik Ramasubramanian (Code Review) 02 Aug '21

02 Aug '21

Attention is currently required from: Henry Sun, Raymond Chung, SH Kim, Edward Doan. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56762 ) Change subject: mb/google/dedede: Create bugzzy variant ...................................................................... Patch Set 1: (1 comment) File src/mainboard/google/dedede/variants/bugzzy/overridetree.cb: https://review.coreboot.org/c/coreboot/+/56762/comment/d35dc05b_b03d17b9 PS1, Line 44: .scl_lcnt = 176, : .scl_hcnt = 95, : .sda_hold = 36, > This CL is used to create new variants. It will be configured after measurement in hardware. I understand that. But there is a good chance that everything works well, this is forgotten and linger around. Hence I would recommend to remove it and add the right configuration later. -- To view, visit https://review.coreboot.org/c/coreboot/+/56762 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I851b9a75c387586d2fb84b762788e962f33472b5 Gerrit-Change-Number: 56762 Gerrit-PatchSet: 1 Gerrit-Owner: Raymond Chung <raymondchung(a)ami.corp-partner.google.com> Gerrit-Reviewer: Edward Doan <edoan(a)google.com> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Raymond Chung <raymondchung(a)ami.corp-partner.google.com> Gerrit-Reviewer: SH Kim <sh_.kim(a)samsung.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kervin Kang <kervinkang(a)ami.corp-partner.google.com> Gerrit-Attention: Henry Sun <henrysun(a)google.com> Gerrit-Attention: Raymond Chung <raymondchung(a)ami.corp-partner.google.com> Gerrit-Attention: SH Kim <sh_.kim(a)samsung.corp-partner.google.com> Gerrit-Attention: Edward Doan <edoan(a)google.com> Gerrit-Comment-Date: Mon, 02 Aug 2021 20:17:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Raymond Chung <raymondchung(a)ami.corp-partner.google.com> Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/dedede: Create bugzzy variant
by Raymond Chung (Code Review) 02 Aug '21

02 Aug '21

Attention is currently required from: Henry Sun, SH Kim, Edward Doan, Karthik Ramasubramanian. Raymond Chung has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56762 ) Change subject: mb/google/dedede: Create bugzzy variant ...................................................................... Patch Set 1: (1 comment) File src/mainboard/google/dedede/variants/bugzzy/overridetree.cb: https://review.coreboot.org/c/coreboot/+/56762/comment/3d0177b7_a4baadc6 PS1, Line 44: .scl_lcnt = 176, : .scl_hcnt = 95, : .sda_hold = 36, > Recommendation is to configure the rise_time_ns/fall_time_ns instead of lcnt/hcnt. […] This CL is used to create new variants. It will be configured after measurement in hardware. -- To view, visit https://review.coreboot.org/c/coreboot/+/56762 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I851b9a75c387586d2fb84b762788e962f33472b5 Gerrit-Change-Number: 56762 Gerrit-PatchSet: 1 Gerrit-Owner: Raymond Chung <raymondchung(a)ami.corp-partner.google.com> Gerrit-Reviewer: Edward Doan <edoan(a)google.com> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Raymond Chung <raymondchung(a)ami.corp-partner.google.com> Gerrit-Reviewer: SH Kim <sh_.kim(a)samsung.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kervin Kang <kervinkang(a)ami.corp-partner.google.com> Gerrit-Attention: Henry Sun <henrysun(a)google.com> Gerrit-Attention: SH Kim <sh_.kim(a)samsung.corp-partner.google.com> Gerrit-Attention: Edward Doan <edoan(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Mon, 02 Aug 2021 20:09:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya: Add RTD3 for WWAN
by Bora Guvendik (Code Review) 02 Aug '21

02 Aug '21

Attention is currently required from: Furquan Shaikh, Chiranjeevi Rapolu, Selma Bensaid, Balaji Manigandan, Thejaswani Putta. Bora Guvendik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56722 ) Change subject: mb/google/brya: Add RTD3 for WWAN ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/56722 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie9d1ce55cc1297ea0e1069979bbecfaac8f8de05 Gerrit-Change-Number: 56722 Gerrit-PatchSet: 1 Gerrit-Owner: Thejaswani Putta <thejaswani.putta(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Chiranjeevi Rapolu <chiranjeevi.rapolu(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Reviewer: Thejaswani Putta <thejaswani.putta(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Chiranjeevi Rapolu <chiranjeevi.rapolu(a)intel.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Chiranjeevi Rapolu <chiranjeevi.rapolu(a)intel.com> Gerrit-Attention: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Attention: Chiranjeevi Rapolu <chiranjeevi.rapolu(a)intel.corp-partner.google.com> Gerrit-Attention: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Attention: Thejaswani Putta <thejaswani.putta(a)intel.com> Gerrit-Comment-Date: Mon, 02 Aug 2021 20:01:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2021