coreboot-gerrit August 2021

coreboot-gerrit@coreboot.org

1 participants
4520 discussions

Change in coreboot[master]: mb/google/dedede/var/magolor: Modify SSFC for camera and touchscreen
by Ren Kuo (Code Review) 03 Aug '21

03 Aug '21

Attention is currently required from: Furquan Shaikh, Ren Kuo, Shou-Chieh Hsu. Hello build bot (Jenkins), David Wu, Furquan Shaikh, Evan Green, Tyler Wang, Shou-Chieh Hsu, Karthik Ramasubramanian, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/56685 to look at the new patch set (#21). Change subject: mb/google/dedede/var/magolor: Modify SSFC for camera and touchscreen ...................................................................... mb/google/dedede/var/magolor: Modify SSFC for camera and touchscreen The all shipped magolor and maglia has SSFC= 0x840. The value is defined as 5M MIPI camera.But the value:0x840 will conflict with the updated touchscreen field. It will cause some touchscreen no function if make auto-update new firmware.The CL would correct the field error. The original fields: CAMERA_WFC 38 40 TS_SOURCE 41 44 Correct fields: MIPI Cam CAMERA_WFC 38 40 CAMERA_UFC 41 42 CAMERA_VCM 43 44 Touch-screen TS_SOURCE 45 48 The SSFC value of Magolor: CAMERA_OVTI5675 5M AF (SSFC = 0x840) CAMERA_OVTI8856 8M AF (SSFC = 0x880) BUG=b:194639170 TEST=Build firmware and verify on camera and touch-screen devices Change-Id: I13d76ce8b932f483e20ca5388f1c67eb39ba12a1 Signed-off-by: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> --- M src/mainboard/google/dedede/variants/magolor/overridetree.cb 1 file changed, 12 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/56685/21 -- To view, visit https://review.coreboot.org/c/coreboot/+/56685 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I13d76ce8b932f483e20ca5388f1c67eb39ba12a1 Gerrit-Change-Number: 56685 Gerrit-PatchSet: 21 Gerrit-Owner: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Evan Green <evgreen(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Henry Sun <henrysun(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/intel/common: Calculate and configure SF Mask 2
by Tim Wawrzynczak (Code Review) 03 Aug '21

03 Aug '21

1 0

Change in coreboot[master]: soc/intel/common: Calculate and configure SF Mask 2
by Tim Wawrzynczak (Code Review) 03 Aug '21

03 Aug '21

Attention is currently required from: Furquan Shaikh, Subrata Banik, Arthur Heymans, Patrick Rudolph. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56717 ) Change subject: soc/intel/common: Calculate and configure SF Mask 2 ...................................................................... Patch Set 2: (2 comments) File src/soc/intel/common/block/cpu/car/cache_as_ram.S: https://review.coreboot.org/c/coreboot/+/56717/comment/89d2d578_111ddd00 PS2, Line 522: #if CONFIG(SF_MASK_2BITS_PER_WAY) : mov %edx, %ebx /* back up data_ways in ebx */ : #endif : #if CONFIG(CAR_HAS_SF_MASKS) : /* : * Calculate SF masks: : * if CONFIG_SF_MASK_2BITS_PER_WAY: data_ways = data_ways / 2 : * Program MSR 0x1892 Non-Eviction Mask #2 : * IA32_CR_SF_QOS_MASK_2 = ((1 << data_ways) - 1) : */ : #if CONFIG(SF_MASK_2BITS_PER_WAY) : movl $0x01, %ecx : shr %cl, %ebx : mov %ebx, %ecx : movl $0x01, %ebx : shl %cl, %ebx : subl $0x01, %ebx : #else : mov %esi, %ebx : #endif : mov %ebx, %eax /* restore data_ways in eax */ 1) What if %ebx (# of data ways to protect) is 1 on line 534? 2) I think I have a simplification (if we need to skip the division by 2 I referenced in #1 above, then there are some lines below which are marked as 'for #1') ``` set_eviction_mask: mov %ebx, %edi /* back up *TOTAL* number of ways */ mov %eax, %esi /* back up the non-eviction mask */ ...NEW CODE STARTS HERE mov %edx, %eax /* protected data ways --> eax */ #if CONFIG(CAR_HAS_SF_MASKS) #if CONFIG(SF_MASK_2BITS_PER_WAY) movl $0x01, %ecx #cmp $0x01, %eax // for #1 #jz program_sf2 // for #1 shr %cl, %eax #endif mov %eax, %ecx movl %0x01, %eax shl %cl, %eax subl %0x01, %eax program_sf2: // for #1 xorl %edx, %edx mov $IA32_CR_SF_QOS_MASK_2, %ecx wrmsr ``` https://review.coreboot.org/c/coreboot/+/56717/comment/934451c7_a1ad0ee1 PS2, Line 548: * SF mask is programmed with the double number of bits than : * the number of ways fix this comment? -- To view, visit https://review.coreboot.org/c/coreboot/+/56717 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I442bed75f13d26f357cfb32c54c5fe9efa4b474b Gerrit-Change-Number: 56717 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Tue, 03 Aug 2021 01:17:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/elogtool: add tool to print elog events
by Ricardo Quesada (Code Review) 03 Aug '21

03 Aug '21

Attention is currently required from: Tim Wawrzynczak, Paul Menzel. Ricardo Quesada has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56406 ) Change subject: util/elogtool: add tool to print elog events ...................................................................... Patch Set 6: (18 comments) Patchset: PS6: Thanks for the review. Fixed. could you PTALA? ty! File util/cbfstool/elogtool.c: https://review.coreboot.org/c/coreboot/+/56406/comment/1931bac2_81c5fa6a PS4, Line 54: > from Not sure I got the comment, but I noticed a typo: EW_ELOG -> RW_ELOG and added more info the error message. https://review.coreboot.org/c/coreboot/+/56406/comment/d117ad0d_5fa82468 PS4, Line 64: return 0; > nit: blank line after `}` Done https://review.coreboot.org/c/coreboot/+/56406/comment/9235a9d2_e828a41b PS4, Line 72: int > nit: `unsigned int` Done https://review.coreboot.org/c/coreboot/+/56406/comment/9a91f6a3_c0bd3f5a PS4, Line 141: input_file = optarg; > nit: blank line after `}` Done File util/cbfstool/eventlog.c: https://review.coreboot.org/c/coreboot/+/56406/comment/1b293d80_5f7d9ee6 PS4, Line 48: /* make certain _all_ members of tm get initialized */ > is this comment required? probably not, fixed. https://review.coreboot.org/c/coreboot/+/56406/comment/9efbc9b0_6d9e77e9 PS4, Line 190: uint8_t > `const uint8_t` Done https://review.coreboot.org/c/coreboot/+/56406/comment/46bd1cac_08352639 PS4, Line 203: (extra >> 8) & 0xff, (extra >> 3) & 0x1f, : (extra & 0x3)); > suggestion: […] Done https://review.coreboot.org/c/coreboot/+/56406/comment/7d0bfeb3_a28799fd PS4, Line 208: 8 > PATH_I2C_MODE10BIT_SHIFT Done https://review.coreboot.org/c/coreboot/+/56406/comment/8edadbd4_8b11f006 PS4, Line 208: 0xff > PATH_I2C_MODE10BIT_MASK Done https://review.coreboot.org/c/coreboot/+/56406/comment/191a6a4a_77cfa148 PS4, Line 208: 0xff > PATH_I2C_ADDRESS_MASK Done https://review.coreboot.org/c/coreboot/+/56406/comment/5299b4b6_e8b128b6 PS4, Line 451: {POST_PRE_HARDWAREMAIN, "Before Hardware Main"}, : {POST_ENTRY_HARDWAREMAIN, "First call in Hardware Main"}, : {POST_CONSOLE_READY, "Console is ready"}, I sorted the entries by value of #define (easy to find missing entries) https://review.coreboot.org/c/coreboot/+/56406/comment/2d56be85_9427525a PS4, Line 589: return 0; > nit: `break;` good catch. https://review.coreboot.org/c/coreboot/+/56406/comment/08040bfa_a242ef7b PS4, Line 602: /* print the timestamp */ > is this comment required? Done https://review.coreboot.org/c/coreboot/+/56406/comment/7e9274b4_8689ff37 PS4, Line 605: /* print event type */ > is this comment required? Done https://review.coreboot.org/c/coreboot/+/56406/comment/b442f639_c4af9db1 PS4, Line 608: /* print custom data */ > is this comment required? Done File util/cbfstool/eventlog.c: https://review.coreboot.org/c/coreboot/+/56406/comment/08415d79_f08e3e08 PS6, Line 189: ELOG_DEV_PATH_TYPE_NONE, "None"}, : {ELOG_DEV_PATH_TYPE_ROOT, "Root"}, added missing entries https://review.coreboot.org/c/coreboot/+/56406/comment/d9520b1c_9d10b54a PS6, Line 498: {POST_FSP_MULTI_PHASE_SI_INIT_ENTRY, "FSP-S Init Enter"}, : {POST_FSP_MULTI_PHASE_SI_INIT_EXIT, "FPS-S Init Exit"}, : {POST_FSP_NOTIFY_AFTER_ENUMERATE, "FSP Notify After Enumerate"}, : {POST_FSP_NOTIFY_AFTER_FINALIZE, "FSP Notify After Finalize"}, : {POST_INVALID_ROM, "Invalid ROM"}, : {POST_INVALID_CBFS, "Invalid CBFS"}, : {POST_INVALID_VENDOR_BINARY, "Invalid Vendor Binary"}, : {POST_RAM_FAILURE, "RAM Failure"}, : {POST_HW_INIT_FAILURE, "Hardware Init Failure"}, : {POST_VIDEO_FAILURE, "Video Failure"}, : {POST_TPM_FAILURE, "TPM Failure"}, : {POST_DEAD_CODE, "Dead Code"}, : {POST_RESUME_FAILURE, "Resume Failure"}, : {POST_JUMPING_TO_PAYLOAD, "Before Jump to Payload"}, : {POST_ENTER_ELF_BOOT, "Before ELF Boot"}, : {POST_OS_RESUME, "Before OS Resume"}, : {POST_OS_BOOT, "Before OS Boot"}, : {POST_DIE, "coreboot Dead"}, added missing entries -- To view, visit https://review.coreboot.org/c/coreboot/+/56406 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia1fe1c9ed3c4c6bda846055d4b10943b54463935 Gerrit-Change-Number: 56406 Gerrit-PatchSet: 6 Gerrit-Owner: Ricardo Quesada <ricardoq(a)google.com> Gerrit-Reviewer: Jack Rosenthal <jrosenth(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Tue, 03 Aug 2021 00:55:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/elogtool: add tool to print elog events
by Ricardo Quesada (Code Review) 03 Aug '21

03 Aug '21

Attention is currently required from: Ricardo Quesada, Paul Menzel. Hello build bot (Jenkins), Tim Wawrzynczak, Jack Rosenthal, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/56406 to look at the new patch set (#6). Change subject: util/elogtool: add tool to print elog events ...................................................................... util/elogtool: add tool to print elog events Add a new tool that that prints elog events. The tool, as input, accepts either a file with the RW_ELOG contents, or if the file is not provided it reads the contents of RW_ELOG by calling the "flashrom" tool. The tool is based on "mosys eventlog list"[1]. For the moment it only supports "list", but future commits will add additional functionality. This commit also adds missing ELOG defines needed for the tool. These defines are added with the rest of the ELOG defines, in include/commonlib/bsd/elog.h The tool is placed inside util/cbfstool. The rationale behind the decision, is that this tool shares a lot in common with the other tools located in cbfstool: vboot dependency, shared files like common.o and valstr.o, and in spirit is similar to some of the tools located in cbfstool/. As an example, you call the tool like the following: $ elogtool list -f rw_elog_dump.bin [1]: https://chromium.googlesource.com/chromiumos/platform/mosys/+/refs/heads/ma… BUG=b:172210863 Signed-off-by: Ricardo Quesada <ricardoq(a)google.com> Change-Id: Ia1fe1c9ed3c4c6bda846055d4b10943b54463935 --- M src/commonlib/bsd/elog.c M src/commonlib/bsd/include/commonlib/bsd/elog.h M util/cbfstool/Makefile M util/cbfstool/Makefile.inc A util/cbfstool/elogtool.c A util/cbfstool/eventlog.c A util/cbfstool/eventlog.h 7 files changed, 924 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/56406/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/56406 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia1fe1c9ed3c4c6bda846055d4b10943b54463935 Gerrit-Change-Number: 56406 Gerrit-PatchSet: 6 Gerrit-Owner: Ricardo Quesada <ricardoq(a)google.com> Gerrit-Reviewer: Jack Rosenthal <jrosenth(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Ricardo Quesada <ricardoq(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/brya/variants/gimble: add TcssAuxOri
by Scott Chao (Code Review) 03 Aug '21

03 Aug '21

Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak. Scott Chao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56715 ) Change subject: mb/google/brya/variants/gimble: add TcssAuxOri ...................................................................... Patch Set 3: (1 comment) File src/mainboard/google/brya/variants/baseboard/brya/devicetree.cb: https://review.coreboot.org/c/coreboot/+/56715/comment/001a2cf7_9cc1fc5d PS2, Line 6: register "typec_aux_bias_pads[0]" = "{.pad_auxp_dc = GPP_E22, .pad_auxn_dc = GPP_E23}" > This goes into gimble/overridetree. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/56715 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I057048c14110bb81bf5b5fd0e3151deb031ca5d4 Gerrit-Change-Number: 56715 Gerrit-PatchSet: 3 Gerrit-Owner: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anfernee Chen <anfernee_chen(a)wistron.corp-partner.google.com> Gerrit-CC: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Comment-Date: Tue, 03 Aug 2021 00:28:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya/variants/gimble: add TcssAuxOri
by Scott Chao (Code Review) 03 Aug '21

03 Aug '21

Attention is currently required from: Furquan Shaikh, Scott Chao. Hello build bot (Jenkins), Furquan Shaikh, Tim Wawrzynczak, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/56715 to look at the new patch set (#3). Change subject: mb/google/brya/variants/gimble: add TcssAuxOri ...................................................................... mb/google/brya/variants/gimble: add TcssAuxOri Gimble don't have retimer on port0, the port need to be configured for the SOC to handle Aux orientation flipping. Also add "typec_aux_bias_pads" lets the SoC IOM firmware control the Aux DC bias voltages. BUG=b:195087071 BRANCH=none TEST=check both orientation can output display on type-c monitor. Signed-off-by: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> Change-Id: I057048c14110bb81bf5b5fd0e3151deb031ca5d4 --- M src/mainboard/google/brya/variants/baseboard/brya/devicetree.cb M src/mainboard/google/brya/variants/gimble/overridetree.cb 2 files changed, 4 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/56715/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/56715 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I057048c14110bb81bf5b5fd0e3151deb031ca5d4 Gerrit-Change-Number: 56715 Gerrit-PatchSet: 3 Gerrit-Owner: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anfernee Chen <anfernee_chen(a)wistron.corp-partner.google.com> Gerrit-CC: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: Move ELOG defines/struct to commonib/bsd/elog.h
by Ricardo Quesada (Code Review) 03 Aug '21

03 Aug '21

Ricardo Quesada has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56405 ) Change subject: Move ELOG defines/struct to commonib/bsd/elog.h ...................................................................... Patch Set 5: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/56405/comment/551d201a_c43e3ebc PS3, Line 17: > BUG=b:172210863 Done Patchset: PS5: Thanks. fixed. -- To view, visit https://review.coreboot.org/c/coreboot/+/56405 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4f307f599a311810df2367b7c888f650cff1214a Gerrit-Change-Number: 56405 Gerrit-PatchSet: 5 Gerrit-Owner: Ricardo Quesada <ricardoq(a)google.com> Gerrit-Reviewer: Jack Rosenthal <jrosenth(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Mon, 02 Aug 2021 22:23:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Move ELOG defines/struct to commonib/bsd/elog.h
by Ricardo Quesada (Code Review) 03 Aug '21

03 Aug '21

Attention is currently required from: Ricardo Quesada. Hello build bot (Jenkins), Tim Wawrzynczak, Jack Rosenthal, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/56405 to look at the new patch set (#5). Change subject: Move ELOG defines/struct to commonib/bsd/elog.h ...................................................................... Move ELOG defines/struct to commonib/bsd/elog.h Move ELOG defines and structs from include/elog.h to include/comonlib/bsd/elog.h. This is needed because the will be used from util/ (in a future commit). It also replaces uNN types with uintNN_t types, for the reason described above. BUG=b:172210863 Signed-off-by: Ricardo Quesada <ricardoq(a)google.com> Change-Id: I4f307f599a311810df2367b7c888f650cff1214a --- M src/commonlib/bsd/include/commonlib/bsd/elog.h M src/include/elog.h 2 files changed, 207 insertions(+), 205 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/56405/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/56405 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4f307f599a311810df2367b7c888f650cff1214a Gerrit-Change-Number: 56405 Gerrit-PatchSet: 5 Gerrit-Owner: Ricardo Quesada <ricardoq(a)google.com> Gerrit-Reviewer: Jack Rosenthal <jrosenth(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Ricardo Quesada <ricardoq(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: Move elog_internal.h to commonlib/bsd/include
by Ricardo Quesada (Code Review) 03 Aug '21

03 Aug '21

Attention is currently required from: Furquan Shaikh. Ricardo Quesada has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56404 ) Change subject: Move elog_internal.h to commonlib/bsd/include ...................................................................... Patch Set 6: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/56404/comment/4c79d897_de5859f8 PS4, Line 28: > BUG=b:172210863 Done Patchset: PS6: Thanks. fixed. -- To view, visit https://review.coreboot.org/c/coreboot/+/56404 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia1aefea705ddd417a1d9e978bb18ab6d9a60cad6 Gerrit-Change-Number: 56404 Gerrit-PatchSet: 6 Gerrit-Owner: Ricardo Quesada <ricardoq(a)google.com> Gerrit-Reviewer: Jack Rosenthal <jrosenth(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Furquan Shaikh <furquan(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Comment-Date: Mon, 02 Aug 2021 22:22:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2021