Attention is currently required from: Furquan Shaikh, Kane Chen.
Jamie Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55153 )
Change subject: soc/intel/apollolake: add 4Gb and 6Gb dram density
......................................................................
Patch Set 3:
This change is ready for review.
--
To view, visit https://review.coreboot.org/c/coreboot/+/55153
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic0d5d14f26a30da7a9caf4ef43d7fac88a4d2bf1
Gerrit-Change-Number: 55153
Gerrit-PatchSet: 3
Gerrit-Owner: Jamie Chen <jamie.chen(a)intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Jamie Chen <jamie.chen(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Kane Chen <kane.chen(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Sheng-Liang Pan <sheng-liang.pan(a)quanta.corp-partner.google.com>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Kane Chen <kane.chen(a)intel.com>
Gerrit-Comment-Date: Tue, 03 Aug 2021 07:18:38 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Hung-Te Lin, Rex-BC Chen.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56764 )
Change subject: soc/mediatek/mt8195: Add devapc basic drivers
......................................................................
Patch Set 3:
(8 comments)
File src/soc/mediatek/mt8195/include/soc/devapc.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125577):
https://review.coreboot.org/c/coreboot/+/56764/comment/17535748_82f6eb31
PS3, Line 72: #define DAPC_PERM_ATTR_4(DEV_NAME, PERM_ATTR0, PERM_ATTR1, \
Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125577):
https://review.coreboot.org/c/coreboot/+/56764/comment/f5da19d7_848b5c47
PS3, Line 77: #define DAPC_PERM_ATTR_8(DEV_NAME, PERM_ATTR0, PERM_ATTR1, \
Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125577):
https://review.coreboot.org/c/coreboot/+/56764/comment/a5b6f821_cdb091be
PS3, Line 85: #define DAPC_PERM_ATTR_16(DEV_NAME, PERM_ATTR0, PERM_ATTR1, \
Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125577):
https://review.coreboot.org/c/coreboot/+/56764/comment/80e79198_9d98a019
PS3, Line 99: #define FORBIDDEN3 FORBIDDEN, FORBIDDEN, FORBIDDEN
Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125577):
https://review.coreboot.org/c/coreboot/+/56764/comment/87c566e8_9179ff24
PS3, Line 100: #define FORBIDDEN7 FORBIDDEN, FORBIDDEN, FORBIDDEN, FORBIDDEN, FORBIDDEN, \
Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125577):
https://review.coreboot.org/c/coreboot/+/56764/comment/fdb50af5_152b351a
PS3, Line 102: #define FORBIDDEN12 FORBIDDEN, FORBIDDEN, FORBIDDEN, FORBIDDEN, FORBIDDEN, \
Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125577):
https://review.coreboot.org/c/coreboot/+/56764/comment/a39d0f6d_3f5a19b4
PS3, Line 105: #define FORBIDDEN13 FORBIDDEN, FORBIDDEN, FORBIDDEN, FORBIDDEN, FORBIDDEN, \
Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125577):
https://review.coreboot.org/c/coreboot/+/56764/comment/ef72a70c_92e0f013
PS3, Line 108: #define FORBIDDEN15 FORBIDDEN, FORBIDDEN, FORBIDDEN, FORBIDDEN, FORBIDDEN, \
Macros with complex values should be enclosed in parentheses
--
To view, visit https://review.coreboot.org/c/coreboot/+/56764
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3677657a117caed0d73526f78b0ebe8180148335
Gerrit-Change-Number: 56764
Gerrit-PatchSet: 3
Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com>
Gerrit-Comment-Date: Tue, 03 Aug 2021 05:26:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Hung-Te Lin, Rex-BC Chen.
Hello Hung-Te Lin, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/56764
to look at the new patch set (#3).
Change subject: soc/mediatek/mt8195: Add devapc basic drivers
......................................................................
soc/mediatek/mt8195: Add devapc basic drivers
Add basic devapc (device access permission control) drivers.
DAPC driver is used to set up bus fabric security and data protection
among hardwares. DAPC driver groups the master hardwares into different
domains and gives secure and non-secure property. The slave hardware can
configure different access permissions for different domains via DAPC
driver.
1. Initialize devapc.
2. Set master domain and secure side band.
3. Set domain remap.
4. Set default permission.
Change-Id: I3677657a117caed0d73526f78b0ebe8180148335
Signed-off-by: Nina Wu <nina-cm.wu(a)mediatek.com>
---
M src/soc/mediatek/mt8195/Makefile.inc
A src/soc/mediatek/mt8195/devapc.c
A src/soc/mediatek/mt8195/include/soc/devapc.h
M src/soc/mediatek/mt8195/soc.c
4 files changed, 2,068 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/56764/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/56764
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3677657a117caed0d73526f78b0ebe8180148335
Gerrit-Change-Number: 56764
Gerrit-PatchSet: 3
Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Hung-Te Lin.
Hello Hung-Te Lin,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/56764
to look at the new patch set (#2).
Change subject: soc/mediatek/mt8195: Add devapc basic drivers
......................................................................
soc/mediatek/mt8195: Add devapc basic drivers
Add basic devapc (device access permission control) drivers.
DAPC driver is used to set up bus fabric security and data protection
among hardwares. DAPC driver groups the master hardwares into different
domains and gives secure and non-secure property. The slave hardware can
configure different access permissions for different domains via DAPC
driver.
1. Initialize devapc.
2. Set master domain and secure side band.
3. Set domain remap.
4. Set default permission.
Change-Id: I3677657a117caed0d73526f78b0ebe8180148335
Signed-off-by: Nina Wu <nina-cm.wu(a)mediatek.com>
---
M src/soc/mediatek/mt8195/Makefile.inc
A src/soc/mediatek/mt8195/devapc.c
A src/soc/mediatek/mt8195/include/soc/devapc.h
M src/soc/mediatek/mt8195/soc.c
4 files changed, 2,052 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/56764/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/56764
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3677657a117caed0d73526f78b0ebe8180148335
Gerrit-Change-Number: 56764
Gerrit-PatchSet: 2
Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Henry Sun, SH Kim, Edward Doan, Karthik Ramasubramanian.
Raymond Chung has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56762 )
Change subject: mb/google/dedede: Create bugzzy variant
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File src/mainboard/google/dedede/variants/bugzzy/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/56762/comment/00c979aa_8fc4da92
PS1, Line 44: .scl_lcnt = 176,
: .scl_hcnt = 95,
: .sda_hold = 36,
> I understand that. […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/56762
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I851b9a75c387586d2fb84b762788e962f33472b5
Gerrit-Change-Number: 56762
Gerrit-PatchSet: 2
Gerrit-Owner: Raymond Chung <raymondchung(a)ami.corp-partner.google.com>
Gerrit-Reviewer: Edward Doan <edoan(a)google.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Raymond Chung <raymondchung(a)ami.corp-partner.google.com>
Gerrit-Reviewer: SH Kim <sh_.kim(a)samsung.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Kervin Kang <kervinkang(a)ami.corp-partner.google.com>
Gerrit-Attention: Henry Sun <henrysun(a)google.com>
Gerrit-Attention: SH Kim <sh_.kim(a)samsung.corp-partner.google.com>
Gerrit-Attention: Edward Doan <edoan(a)google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Tue, 03 Aug 2021 03:50:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Raymond Chung <raymondchung(a)ami.corp-partner.google.com>
Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-MessageType: comment