coreboot-gerrit August 2021

coreboot-gerrit@coreboot.org

1 participants
4520 discussions

Change in coreboot[master]: arch/x86/acpi: rename KEY_KBDILLUMTOGGLE to KEY_KBD_BKLIGHT_TOGGLE
by Paul Menzel (Code Review) 03 Aug '21

03 Aug '21

Attention is currently required from: Lance Zhao, Tim Wawrzynczak, Scott Chao. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56763 ) Change subject: arch/x86/acpi: rename KEY_KBDILLUMTOGGLE to KEY_KBD_BKLIGHT_TOGGLE ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/56763/comment/67fefaa4_7fb497c5 PS2, Line 9: Also change scan code from e02b to e01e Why? Are you sure, that is compatible wtih all devices? -- To view, visit https://review.coreboot.org/c/coreboot/+/56763 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I402192ff354f30da35aec43202df9f1407911d34 Gerrit-Change-Number: 56763 Gerrit-PatchSet: 2 Gerrit-Owner: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Lance Zhao Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Lance Zhao Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> Gerrit-Comment-Date: Tue, 03 Aug 2021 13:04:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/apollolake: add 4Gb and 6Gb dram density
by Paul Menzel (Code Review) 03 Aug '21

03 Aug '21

Attention is currently required from: Jamie Chen, Furquan Shaikh, Kane Chen, Andrey Petrov, Patrick Rudolph. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55153 ) Change subject: soc/intel/apollolake: add 4Gb and 6Gb dram density ...................................................................... Patch Set 5: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/55153/comment/841b897b_29e3b5eb PS5, Line 9: This patch adds 4gb and 6gb dram density support to APL and GLK. … by adding the appropriate macros. https://review.coreboot.org/c/coreboot/+/55153/comment/ad5e0b60_e420b1f2 PS5, Line 10: Because ch0_density = 0 is not appropriate to determine whether : the channel is disabled or not, so ch0_enable and ch1_enable are : provided to turn on/off channel respectively. Please do that in a separate commit (ordering it before this one). File src/soc/intel/apollolake/include/soc/meminit.h: https://review.coreboot.org/c/coreboot/+/55153/comment/dff7bcdf_532d949b PS5, Line 54: LP4_4Gb_DENSITY, : LP4_6Gb_DENSITY, : LP4_8Gb_DENSITY, : LP4_12Gb_DENSITY, : LP4_16Gb_DENSITY, Unrelated, why not assign the integers to the enums here directly to get rid of the switch statement? -- To view, visit https://review.coreboot.org/c/coreboot/+/55153 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic0d5d14f26a30da7a9caf4ef43d7fac88a4d2bf1 Gerrit-Change-Number: 55153 Gerrit-PatchSet: 5 Gerrit-Owner: Jamie Chen <jamie.chen(a)intel.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Jamie Chen <jamie.chen(a)intel.corp-partner.google.com> Gerrit-Reviewer: Kane Chen <kane.chen(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Sheng-Liang Pan <sheng-liang.pan(a)quanta.corp-partner.google.com> Gerrit-Attention: Jamie Chen <jamie.chen(a)intel.com> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Kane Chen <kane.chen(a)intel.com> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Tue, 03 Aug 2021 13:03:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya/variants/taeko: Configure GPIOs according to schematics
by Paul Menzel (Code Review) 03 Aug '21

03 Aug '21

Attention is currently required from: Joey Peng, Tim Wawrzynczak. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56754 ) Change subject: mb/google/brya/variants/taeko: Configure GPIOs according to schematics ...................................................................... Patch Set 9: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/56754/comment/e3ba225b_8f1331e7 PS9, Line 2: joey.peng Please use Joey Peng. https://review.coreboot.org/c/coreboot/+/56754/comment/a464e2c3_86490369 PS9, Line 15: joey.peng Ditto. -- To view, visit https://review.coreboot.org/c/coreboot/+/56754 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ida1edbf874c93f6efac45c276920ead9311ac6f2 Gerrit-Change-Number: 56754 Gerrit-PatchSet: 9 Gerrit-Owner: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com> Gerrit-Reviewer: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: YH Lin <yueherngl(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jerry2 Huang <jerry2.huang(a)lcfc.corp-partner.google.com> Gerrit-CC: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com> Gerrit-CC: Melo Chuang <melo.chuang(a)lcfc.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Rasheed Hsueh <rasheed.hsueh(a)lcfc.corp-partner.google.com> Gerrit-CC: Stanley Wu <stanley1.wu(a)lcfc.corp-partner.google.com> Gerrit-CC: Sunshine Chao <sunshine.chao(a)lcfc.corp-partner.google.com> Gerrit-Attention: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Comment-Date: Tue, 03 Aug 2021 12:59:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: payloads/external/depthcharge:Add option to skip repo fetch
by Balaji Manigandan (Code Review) 03 Aug '21

03 Aug '21

Balaji Manigandan has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/56307 ) Change subject: payloads/external/depthcharge:Add option to skip repo fetch ...................................................................... Abandoned Will use - DEPTHCHARGE_REVISION -- To view, visit https://review.coreboot.org/c/coreboot/+/56307 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5f0be607504af87a8634c6cbd97888b72f8ba41b Gerrit-Change-Number: 56307 Gerrit-PatchSet: 4 Gerrit-Owner: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Georgi <pgeorgi(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-MessageType: abandon

1 0

Change in coreboot[master]: mb/google/brya/variants/primus: Remove DPTF fan control
by Scott Chao (Code Review) 03 Aug '21

03 Aug '21

Scott Chao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56768 ) Change subject: mb/google/brya/variants/primus: Remove DPTF fan control ...................................................................... Patch Set 1: Code-Review+1 This change is ready for review. -- To view, visit https://review.coreboot.org/c/coreboot/+/56768 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I84c020e470194072bb796f75f8a1304832504469 Gerrit-Change-Number: 56768 Gerrit-PatchSet: 1 Gerrit-Owner: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anfernee Chen <anfernee_chen(a)wistron.corp-partner.google.com> Gerrit-CC: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com> Gerrit-Comment-Date: Tue, 03 Aug 2021 11:49:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/amd/bilby: Add support for HDMI display
by Aamir Bohra (Code Review) 03 Aug '21

03 Aug '21

Attention is currently required from: ritul guru, Felix Held. Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56756 ) Change subject: mb/amd/bilby: Add support for HDMI display ...................................................................... Patch Set 3: (1 comment) File src/mainboard/amd/bilby/mainboard.c: https://review.coreboot.org/c/coreboot/+/56756/comment/98a1e37c_20d716b7 PS2, Line 96: gpio_output(display_sel[idx], 0); > GPIO 31 gets configured as input here https://review.coreboot. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/56756 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9697211c556f12d1fc0d49418b227fbe6b342673 Gerrit-Change-Number: 56756 Gerrit-PatchSet: 3 Gerrit-Owner: Aamir Bohra <aamirbohra(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ritul guru <ritul.bits(a)gmail.com> Gerrit-Attention: ritul guru <ritul.bits(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 03 Aug 2021 11:49:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/amd/bilby: Add support for HDMI display
by Aamir Bohra (Code Review) 03 Aug '21

03 Aug '21

Attention is currently required from: ritul guru, Aamir Bohra. Hello build bot (Jenkins), ritul guru, Felix Held, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/56756 to look at the new patch set (#3). Change subject: mb/amd/bilby: Add support for HDMI display ...................................................................... mb/amd/bilby: Add support for HDMI display DDI 0/1 ports are shared for DP and HDMI. This implementation adds support for HDMI display when HDMI is set as connector type in ddi descriptors. TEST=verify display over HDMI(0 and 1) in OS. Signed-off-by: Aamir Bohra <aamirbohra(a)gmail.com> Change-Id: I9697211c556f12d1fc0d49418b227fbe6b342673 --- M src/mainboard/amd/bilby/Kconfig M src/mainboard/amd/bilby/gpio.c M src/mainboard/amd/bilby/mainboard.c A src/mainboard/amd/bilby/mainboard.h M src/mainboard/amd/bilby/port_descriptors.c 5 files changed, 66 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/56756/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/56756 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9697211c556f12d1fc0d49418b227fbe6b342673 Gerrit-Change-Number: 56756 Gerrit-PatchSet: 3 Gerrit-Owner: Aamir Bohra <aamirbohra(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ritul guru <ritul.bits(a)gmail.com> Gerrit-Attention: ritul guru <ritul.bits(a)gmail.com> Gerrit-Attention: Aamir Bohra <aamirbohra(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: [WIP]amdfwtool: add support for A/B recovery
by build bot (Jenkins) (Code Review) 03 Aug '21

03 Aug '21

Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Zheng Bao, Felix Held. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56773 ) Change subject: [WIP]amdfwtool: add support for A/B recovery ...................................................................... Patch Set 1: (4 comments) File util/amdfwtool/amdfwtool.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125599): https://review.coreboot.org/c/coreboot/+/56773/comment/22396f7c_f3c72bbf PS1, Line 650: ish->checksum = fletcher32(&ish->boot_priority, sizeof(ish_directory_table) - sizeof(uint32_t)); line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125599): https://review.coreboot.org/c/coreboot/+/56773/comment/6937f98b_d236acfd PS1, Line 662: count ++; space prohibited before that '++' (ctx:WxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125599): https://review.coreboot.org/c/coreboot/+/56773/comment/78b36a9c_c2164f98 PS1, Line 663: pspdir->header.num_entries ++; space prohibited before that '++' (ctx:WxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125599): https://review.coreboot.org/c/coreboot/+/56773/comment/dd182679_bf62ec37 PS1, Line 808: count ++; space prohibited before that '++' (ctx:WxO) -- To view, visit https://review.coreboot.org/c/coreboot/+/56773 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I27f5d3476f648fcecafb8d258ccb6cfad4f50036 Gerrit-Change-Number: 56773 Gerrit-PatchSet: 1 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Zheng Bao Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Zheng Bao Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 03 Aug 2021 11:39:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: [WIP]amdfwtool: add support for A/B recovery
by Bao Zheng (Code Review) 03 Aug '21

03 Aug '21

Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Zheng Bao, Felix Held. Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56773 ) Change subject: [WIP]amdfwtool: add support for A/B recovery ...................................................................... Patch Set 1: (6 comments) File util/amdfwtool/amdfwtool.c: https://review.coreboot.org/c/coreboot/+/56773/comment/6f2d7530_27c19957 PS1, Line 1270: PLATFORM_MENDOCINO, another patch. https://review.coreboot.org/c/coreboot/+/56773/comment/fea3a337_54081f9d PS1, Line 1308: case PLATFORM_MENDOCINO: another patch https://review.coreboot.org/c/coreboot/+/56773/comment/a201450c_34ab7f9e PS1, Line 1345: else if (!strcasecmp(soc_name, "Mendocino")) : return PLATFORM_MENDOCINO; Another patch. https://review.coreboot.org/c/coreboot/+/56773/comment/06a6b4d1_a88a554f PS1, Line 1701: 0 NULL. Add below. https://review.coreboot.org/c/coreboot/+/56773/comment/fc6b411b_6b68cf09 PS1, Line 1760: add_psp_firmware_entry Change to a more understanding name. add_biosl2_to_pspl2_table https://review.coreboot.org/c/coreboot/+/56773/comment/75cc7aba_e5caefc7 PS1, Line 1780: case PLATFORM_MENDOCINO: Move to new patch -- To view, visit https://review.coreboot.org/c/coreboot/+/56773 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I27f5d3476f648fcecafb8d258ccb6cfad4f50036 Gerrit-Change-Number: 56773 Gerrit-PatchSet: 1 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Zheng Bao Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Zheng Bao Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 03 Aug 2021 11:24:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/amd/cezanne/fsp_m_params:Configure the iommu_support UPD
by Jason Glenesk (Code Review) 03 Aug '21

03 Aug '21

Attention is currently required from: Matt Papageorge, Karthik Ramasubramanian, Felix Held. Jason Glenesk has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56770 ) Change subject: soc/amd/cezanne/fsp_m_params:Configure the iommu_support UPD ...................................................................... Patch Set 1: This change is ready for review. -- To view, visit https://review.coreboot.org/c/coreboot/+/56770 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I56b433cdc1ca5459c51b4b764e22292bd27b8892 Gerrit-Change-Number: 56770 Gerrit-PatchSet: 1 Gerrit-Owner: Jason Glenesk <jason.glenesk(a)amd.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Matt Papageorge <matthewpapa07(a)gmail.com> Gerrit-Attention: Matt Papageorge <matthewpapa07(a)gmail.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 03 Aug 2021 11:21:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2021