coreboot-gerrit

Download

coreboot-gerrit@coreboot.org

June 2021

1 participants
7132 discussions

Change in coreboot[master]: soc/amd/stoneyridge: Set missing RTC offsets for day alarm and century
by Anand Mistry (Code Review) May 31, 2021

May 31, 2021

Attention is currently required from: Martin Roth, Paul Menzel. Anand Mistry has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55001 ) Change subject: soc/amd/stoneyridge: Set missing RTC offsets for day alarm and century ...................................................................... Patch Set 3: (5 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/55001/comment/1bf84634_2f3e6772 PS2, Line 8: > Please describe the problem (summarize the bug report). […] Added a short generic description. A little extra detail. On Chrome OS, in certain cases, we use alarms >24 hours. Linux will then refuse to enter suspend with the dmesg error: [ 159.041047] rtc_cmos 00:01: Alarms can be up to one day in the future A device (laptop) that can't enter suspend will either drain the battery, or on Chrome OS, shut down the system after a certain number of retries. https://review.coreboot.org/c/coreboot/+/55001/comment/9352028a_afa532c3 PS2, Line 12: This is a mirror of commit 041fcf59025bb1801828441e09b2f56b48e12fdc made > Please abbreviate the commit hash and add the summary: […] Done Patchset: PS3: Also, the test I ran successfully woke up the device after sleeping for 48 hours: [ 565.025215] ACPI: Preparing to enter system sleep state S3 ... [ 565.037262] PM: Timekeeping suspended for 172799.695 seconds ... [ 565.042405] ACPI: Waking up from system sleep state S3 File src/soc/amd/stoneyridge/acpi.c: https://review.coreboot.org/c/coreboot/+/55001/comment/83920599_b7949d83 PS2, Line 86: fadt->mon_alrm = 0; > Excuse my ignorance, but is `mon_alrm` not needed, or at offset 0? It's looks like this is not supported on the HW, hence remains 0 (read: doesn't exist). https://review.coreboot.org/c/coreboot/+/55001/comment/08e8db98_00282fe6 PS2, Line 85: fadt->day_alrm = 0x0d; : fadt->mon_alrm = 0; : > For amd/cezanne defines are used (Ib6c3a01084a0de33894885b47c637a292d252ed4 [1]). […] Will do as a follow-up. I thought about just doing it here, but I need to merge this into our release branch and the changes to acpi.h will cause merge conflicts. -- To view, visit https://review.coreboot.org/c/coreboot/+/55001 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I10831b982662e680fa71aa81d02935e1b7e7a7a1 Gerrit-Change-Number: 55001 Gerrit-PatchSet: 3 Gerrit-Owner: Anand Mistry <amistry(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Daniel Kurtz <djkurtz(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Tue, 01 Jun 2021 01:05:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/amd/stoneyridge: Set missing RTC offsets for day alarm and century
by Anand Mistry (Code Review) May 31, 2021

May 31, 2021

Attention is currently required from: Martin Roth, Anand Mistry. Hello build bot (Jenkins), Raul Rangel, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/55001 to look at the new patch set (#3). Change subject: soc/amd/stoneyridge: Set missing RTC offsets for day alarm and century ...................................................................... soc/amd/stoneyridge: Set missing RTC offsets for day alarm and century On Linux, in order to set wake alarms >24 hours, the RTC Date Alarm field must be set to a valid non-zero value. If not, there are two consequences: 1. Alarms >24 hours don't work 2. The kernel will refuse to enter suspend because it can't resume as expected to service the alarm. Since the RTC Date Alarm and RTC AltCentury fields are supported on Stoneyridge, set them. This is a mirror of commit 041fcf5902 ("soc/amd/picasso/acpi: Set missing RTC offsets") for picasso. BUG=b:187516317 TEST=On a Chrome OS 'grunt' device, run `time powerd_dbus_suspend --suspend_for_sec=172800` and verify the system suspended and woke up after 48 hours BRANCH=grunt Signed-off-by: Anand K Mistry <amistry(a)google.com> Change-Id: I10831b982662e680fa71aa81d02935e1b7e7a7a1 --- M src/soc/amd/stoneyridge/acpi.c 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/55001/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/55001 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I10831b982662e680fa71aa81d02935e1b7e7a7a1 Gerrit-Change-Number: 55001 Gerrit-PatchSet: 3 Gerrit-Owner: Anand Mistry <amistry(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Daniel Kurtz <djkurtz(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Anand Mistry <amistry(a)google.com> Gerrit-MessageType: newpatchset

1 0

Jump to page: