coreboot-gerrit March 2021

coreboot-gerrit@coreboot.org

1 participants
7266 discussions

Change in coreboot[master]: mb/google/brya: Fix a few mistakes in brya0 overridetree
by EricR Lai (Code Review) 01 Mar '21

01 Mar '21

Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak. EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51145 ) Change subject: mb/google/brya: Fix a few mistakes in brya0 overridetree ...................................................................... Patch Set 1: (1 comment) File src/mainboard/google/brya/variants/brya0/overridetree.cb: https://review.coreboot.org/c/coreboot/+/51145/comment/d5a41e7e_1a738c8e PS1, Line 186: device generic 0 on end weird, why builedbot no compliant before :p -- To view, visit https://review.coreboot.org/c/coreboot/+/51145 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icf586229532819a7779652cbee73755b036dfbdc Gerrit-Change-Number: 51145 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Comment-Date: Mon, 01 Mar 2021 16:06:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/chromeos: Use the same inventory each time and verify checksums
by Leah Rowe (Code Review) 01 Mar '21

01 Mar '21

Attention is currently required from: Paul Menzel, Leah Rowe. Leah Rowe has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51144 ) Change subject: util/chromeos: Use the same inventory each time and verify checksums ...................................................................... Patch Set 5: (1 comment) Patchset: PS5: I have fixed the indentation issues. My vimrc was converting tabs to spaces, but other parts of the file were using tabs. -- To view, visit https://review.coreboot.org/c/coreboot/+/51144 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If0166518d252a36d8f9a9c17d375fbdd9e3116f6 Gerrit-Change-Number: 51144 Gerrit-PatchSet: 5 Gerrit-Owner: Leah Rowe <leahleahrowerowe(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Leah Rowe <leahleahrowerowe(a)gmail.com> Gerrit-Comment-Date: Mon, 01 Mar 2021 15:59:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/chromeos: Use the same inventory each time and verify checksums
by Arthur Heymans (Code Review) 01 Mar '21

01 Mar '21

Attention is currently required from: Paul Menzel, Leah Rowe. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51144 ) Change subject: util/chromeos: Use the same inventory each time and verify checksums ...................................................................... Patch Set 4: (4 comments) Patchset: PS4: Try to do one change per commit. File util/chromeos/crosfirmware.sh: https://review.coreboot.org/c/coreboot/+/51144/comment/95fb197c_b377096d PS4, Line 34: https://web.archive.org/web/20210211071412/ I don't think this is a good idea. You generally want the latest version for your board. Also this would break any new board, not yet in that file. https://review.coreboot.org/c/coreboot/+/51144/comment/1f241b58_6ae7b522 PS4, Line 45: use tabs for indentation. https://review.coreboot.org/c/coreboot/+/51144/comment/381e9fd1_172512a0 PS4, Line 142: echo "acaf7450481136e72a1ee6c4fe3a2dea992d028f ${CONF}" > "${CONF_SHA1_FILE}" what is this? -- To view, visit https://review.coreboot.org/c/coreboot/+/51144 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If0166518d252a36d8f9a9c17d375fbdd9e3116f6 Gerrit-Change-Number: 51144 Gerrit-PatchSet: 4 Gerrit-Owner: Leah Rowe <leahleahrowerowe(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Leah Rowe <leahleahrowerowe(a)gmail.com> Gerrit-Comment-Date: Mon, 01 Mar 2021 15:59:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: sconfig: Ensure at least one `device` node below each `chip`
by Tim Wawrzynczak (Code Review) 01 Mar '21

01 Mar '21

Attention is currently required from: Nico Huber, Martin Roth, Arthur Heymans, Kevin Keijzer. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51119 ) Change subject: sconfig: Ensure at least one `device` node below each `chip` ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/51119 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I54830bc1fc7d00a0605f3fe4d36a83ef57ef3312 Gerrit-Change-Number: 51119 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Kevin Keijzer <kevin(a)quietlife.nl> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Kevin Keijzer <kevin(a)quietlife.nl> Gerrit-Comment-Date: Mon, 01 Mar 2021 15:58:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/chromeos: Use the same inventory each time and verify checksums
by Leah Rowe (Code Review) 01 Mar '21

01 Mar '21

Attention is currently required from: Paul Menzel. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/51144 to look at the new patch set (#5). Change subject: util/chromeos: Use the same inventory each time and verify checksums ...................................................................... util/chromeos: Use the same inventory each time and verify checksums coreboot wasn't doing any integrity checks. Furthermore, the latest inventory file from Google was always being used, which meant that it was not certain which version would be used. This commit uses a version of the inventory from archive.org, verifies its checksum and then, using sha1 checksums defined inside the inventory file, verifies the checksums of recovery images. This is obviously a huge boon to security and reliability. Change-Id: If0166518d252a36d8f9a9c17d375fbdd9e3116f6 Signed-off-by: Leah Rowe <leah(a)retroboot.org> --- M util/chromeos/crosfirmware.sh 1 file changed, 50 insertions(+), 22 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/51144/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/51144 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If0166518d252a36d8f9a9c17d375fbdd9e3116f6 Gerrit-Change-Number: 51144 Gerrit-PatchSet: 5 Gerrit-Owner: Leah Rowe <leahleahrowerowe(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/brya: Fix a few mistakes in brya0 overridetree
by EricR Lai (Code Review) 01 Mar '21

01 Mar '21

Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak. EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51145 ) Change subject: mb/google/brya: Fix a few mistakes in brya0 overridetree ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: whoops, not select max98357 as well. BTW, there is no sar sensor sx9324 in kernel 5.10? -- To view, visit https://review.coreboot.org/c/coreboot/+/51145 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icf586229532819a7779652cbee73755b036dfbdc Gerrit-Change-Number: 51145 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Comment-Date: Mon, 01 Mar 2021 15:56:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/chromeos: Use the same inventory each time and verify checksums
by Leah Rowe (Code Review) 01 Mar '21

01 Mar '21

Attention is currently required from: Paul Menzel. Leah Rowe has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51144 ) Change subject: util/chromeos: Use the same inventory each time and verify checksums ...................................................................... Patch Set 4: (2 comments) Patchset: PS1: > Please sign off the commit. Thanks, I've added sign off by Patchset: PS4: I changed the archive.org link to https. Fixed commit message to say coreboot in all lowercase -- To view, visit https://review.coreboot.org/c/coreboot/+/51144 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If0166518d252a36d8f9a9c17d375fbdd9e3116f6 Gerrit-Change-Number: 51144 Gerrit-PatchSet: 4 Gerrit-Owner: Leah Rowe <leahleahrowerowe(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Mon, 01 Mar 2021 15:49:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/chromeos: Use the same inventory each time and verify checksums
by Leah Rowe (Code Review) 01 Mar '21

01 Mar '21

Attention is currently required from: Leah Rowe. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/51144 to look at the new patch set (#4). Change subject: util/chromeos: Use the same inventory each time and verify checksums ...................................................................... util/chromeos: Use the same inventory each time and verify checksums coreboot wasn't doing any integrity checks. Furthermore, the latest inventory file from Google was always being used, which meant that it was not certain which version would be used. This commit uses a version of the inventory from archive.org, verifies its checksum and then, using sha1 checksums defined inside the inventory file, verifies the checksums of recovery images. This is obviously a huge boon to security and reliability. Change-Id: If0166518d252a36d8f9a9c17d375fbdd9e3116f6 Signed-off-by: Leah Rowe <leah(a)retroboot.org> --- M util/chromeos/crosfirmware.sh 1 file changed, 50 insertions(+), 22 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/51144/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/51144 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If0166518d252a36d8f9a9c17d375fbdd9e3116f6 Gerrit-Change-Number: 51144 Gerrit-PatchSet: 4 Gerrit-Owner: Leah Rowe <leahleahrowerowe(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Leah Rowe <leahleahrowerowe(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: util/chromeos: Use the same inventory each time and verify checksums
by Leah Rowe (Code Review) 01 Mar '21

01 Mar '21

Attention is currently required from: Leah Rowe. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/51144 to look at the new patch set (#3). Change subject: util/chromeos: Use the same inventory each time and verify checksums ...................................................................... util/chromeos: Use the same inventory each time and verify checksums coreboot wasn't doing any integrity checks. Furthermore, the latest inventory file from Google was always being used, which meant that it was not certain which version would be used. This commit uses a version of the inventory from archive.org, verifies its checksum and then, using sha1 checksums defined inside the inventory file, verifies the checksums of recovery images. This is obviously a huge boon to security and reliability. Change-Id: If0166518d252a36d8f9a9c17d375fbdd9e3116f6 Signed-off-by: Leah Rowe <leah(a)retroboot.org> --- M util/chromeos/crosfirmware.sh 1 file changed, 50 insertions(+), 22 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/51144/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/51144 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If0166518d252a36d8f9a9c17d375fbdd9e3116f6 Gerrit-Change-Number: 51144 Gerrit-PatchSet: 3 Gerrit-Owner: Leah Rowe <leahleahrowerowe(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Leah Rowe <leahleahrowerowe(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: util/chromeos: Use the same inventory each time and verify checksums
by Leah Rowe (Code Review) 01 Mar '21

01 Mar '21

Attention is currently required from: Leah Rowe. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/51144 to look at the new patch set (#2). Change subject: util/chromeos: Use the same inventory each time and verify checksums ...................................................................... util/chromeos: Use the same inventory each time and verify checksums Coreboot wasn't doing any integrity checks. Furthermore, the latest inventory file from Google was always being used, which meant that it was not certain which version would be used. This commit uses a version of the inventory from archive.org, verifies its checksum and then, using sha1 checksums defined inside the inventory file, verifies the checksums of recovery images. This is obviously a huge boon to security and reliability. Change-Id: If0166518d252a36d8f9a9c17d375fbdd9e3116f6 Signed-off-by: Leah Rowe <leah(a)retroboot.org> --- M util/chromeos/crosfirmware.sh 1 file changed, 50 insertions(+), 22 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/51144/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/51144 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If0166518d252a36d8f9a9c17d375fbdd9e3116f6 Gerrit-Change-Number: 51144 Gerrit-PatchSet: 2 Gerrit-Owner: Leah Rowe <leahleahrowerowe(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Leah Rowe <leahleahrowerowe(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2021