coreboot-gerrit March 2021

coreboot-gerrit@coreboot.org

1 participants
7266 discussions

Change in coreboot[master]: soc/intel: Backport SMRR locking support
by Angel Pons (Code Review) 01 Mar '21

01 Mar '21

Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Subrata Banik, Michael Niewöhner, Patrick Rudolph. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50936 ) Change subject: soc/intel: Backport SMRR locking support ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/50936/comment/a1d577e4_5fabd661 PS2, Line 14: > > Not yet, but I expect this to work. […] Tested on Librem Mini WHL-U, still boots and SMRR MSRs are consistent across all cores/threads. -- To view, visit https://review.coreboot.org/c/coreboot/+/50936 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icbee0985b04418e83cbf41b81f00934f5a663e30 Gerrit-Change-Number: 50936 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Mon, 01 Mar 2021 16:39:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/gigabyte: Add GA-D510UD
by Angel Pons (Code Review) 01 Mar '21

01 Mar '21

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40465 ) Change subject: mb/gigabyte: Add GA-D510UD ...................................................................... Patch Set 7: (1 comment) File src/mainboard/gigabyte/ga-d510ud/devicetree.cb: https://review.coreboot.org/c/coreboot/+/40465/comment/9c2e9b83_f608c1d9 PS7, Line 13: device pci 0.0 on end # Host Bridge > Looks like there is no handling of this in code but for completeness add "device pci 1. […] Pineview does not have PEG... -- To view, visit https://review.coreboot.org/c/coreboot/+/40465 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2126c7d31e0d8a8f80df69fdcdcd202b87f219a4 Gerrit-Change-Number: 40465 Gerrit-PatchSet: 7 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Daniel Maslowski <info(a)orangecms.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Mon, 01 Mar 2021 16:35:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/gigabyte: Add GA-D510UD
by Arthur Heymans (Code Review) 01 Mar '21

01 Mar '21

Attention is currently required from: Angel Pons. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40465 ) Change subject: mb/gigabyte: Add GA-D510UD ...................................................................... Patch Set 7: Code-Review+2 (1 comment) File src/mainboard/gigabyte/ga-d510ud/devicetree.cb: https://review.coreboot.org/c/coreboot/+/40465/comment/f11d58d4_825c25db PS7, Line 13: device pci 0.0 on end # Host Bridge Looks like there is no handling of this in code but for completeness add "device pci 1.0 off end # PEG" in case someone add PEG support in the future. -- To view, visit https://review.coreboot.org/c/coreboot/+/40465 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2126c7d31e0d8a8f80df69fdcdcd202b87f219a4 Gerrit-Change-Number: 40465 Gerrit-PatchSet: 7 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Daniel Maslowski <info(a)orangecms.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Mon, 01 Mar 2021 16:29:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya: Fix a few mistakes in brya0 overridetree
by Angel Pons (Code Review) 01 Mar '21

01 Mar '21

Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, EricR Lai. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51145 ) Change subject: mb/google/brya: Fix a few mistakes in brya0 overridetree ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/51145 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icf586229532819a7779652cbee73755b036dfbdc Gerrit-Change-Number: 51145 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Comment-Date: Mon, 01 Mar 2021 16:27:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/chromeos: Use the same inventory each time and verify checksums
by Arthur Heymans (Code Review) 01 Mar '21

01 Mar '21

Attention is currently required from: Paul Menzel, Leah Rowe. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51144 ) Change subject: util/chromeos: Use the same inventory each time and verify checksums ...................................................................... Patch Set 5: (2 comments) File util/chromeos/crosfirmware.sh: https://review.coreboot.org/c/coreboot/+/51144/comment/2ae52087_2a45ad15 PS4, Line 34: https://web.archive.org/web/20210211071412/ > However, you also want consistency and to make sure that the files aren't corrupted. Perhaps coreboot could host its own version of that inventory file? I could put it in the repo The recovery.conf has md5 and sha1 hashes so I doubt that corruption would be an issue. > EDIT: my logic here is that the inventory file contains data that is likely non-copyrightable anyway. then, every now and then, the files can be updated to whatever the newest version is from google > The one from google is certain to have proper links. I don't see why coreboot would have to maintain its own. https://review.coreboot.org/c/coreboot/+/51144/comment/4ecef0e7_627631c5 PS4, Line 45: > already sorted, in patch set 5 Ack -- To view, visit https://review.coreboot.org/c/coreboot/+/51144 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If0166518d252a36d8f9a9c17d375fbdd9e3116f6 Gerrit-Change-Number: 51144 Gerrit-PatchSet: 5 Gerrit-Owner: Leah Rowe <leahleahrowerowe(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Leah Rowe <leahleahrowerowe(a)gmail.com> Gerrit-Comment-Date: Mon, 01 Mar 2021 16:24:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Comment-In-Reply-To: Leah Rowe <leahleahrowerowe(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya: Fix a few mistakes in brya0 overridetree
by Tim Wawrzynczak (Code Review) 01 Mar '21

01 Mar '21

Attention is currently required from: Furquan Shaikh, EricR Lai. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51145 ) Change subject: mb/google/brya: Fix a few mistakes in brya0 overridetree ...................................................................... Patch Set 1: (2 comments) Patchset: PS1: > whoops, not select max98357 as well. BTW, there is no sar sensor sx9324 in kernel 5. […] +1, will add. Filed a bug with Alex to see about the driver File src/mainboard/google/brya/variants/brya0/overridetree.cb: https://review.coreboot.org/c/coreboot/+/51145/comment/8c969b89_565050bf PS1, Line 186: device generic 0 on end > weird, why builedbot no compliant before :p Need to select the MAX98357A driver 😊 -- To view, visit https://review.coreboot.org/c/coreboot/+/51145 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icf586229532819a7779652cbee73755b036dfbdc Gerrit-Change-Number: 51145 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Comment-Date: Mon, 01 Mar 2021 16:20:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya: Fix a few mistakes in brya0 overridetree
by Tim Wawrzynczak (Code Review) 01 Mar '21

01 Mar '21

Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak. Hello build bot (Jenkins), Furquan Shaikh, EricR Lai, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/51145 to look at the new patch set (#2). Change subject: mb/google/brya: Fix a few mistakes in brya0 overridetree ...................................................................... mb/google/brya: Fix a few mistakes in brya0 overridetree 1) Both SAR sensors had a UID of `2`, making them indistinguishable 2) No `device` underneath max98357a `chip` Change-Id: Icf586229532819a7779652cbee73755b036dfbdc Signed-off-by: Tim Wawrzynczak <twawrzynczak(a)chromium.org> --- M src/mainboard/google/brya/Kconfig M src/mainboard/google/brya/variants/brya0/overridetree.cb 2 files changed, 3 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/51145/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/51145 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icf586229532819a7779652cbee73755b036dfbdc Gerrit-Change-Number: 51145 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: util/chromeos: Use the same inventory each time and verify checksums
by Leah Rowe (Code Review) 01 Mar '21

01 Mar '21

Attention is currently required from: Paul Menzel, Arthur Heymans. Leah Rowe has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51144 ) Change subject: util/chromeos: Use the same inventory each time and verify checksums ...................................................................... Patch Set 5: (3 comments) File util/chromeos/crosfirmware.sh: https://review.coreboot.org/c/coreboot/+/51144/comment/1636a9cc_85c535dd PS4, Line 34: https://web.archive.org/web/20210211071412/ > I don't think this is a good idea. You generally want the latest version for your board. […] However, you also want consistency and to make sure that the files aren't corrupted. Perhaps coreboot could host its own version of that inventory file? I could put it in the repo EDIT: my logic here is that the inventory file contains data that is likely non-copyrightable anyway. then, every now and then, the files can be updated to whatever the newest version is from google EDIT2: also, you can always just update the file https://review.coreboot.org/c/coreboot/+/51144/comment/ab068cb1_dc180985 PS4, Line 45: > use tabs for indentation. already sorted, in patch set 5 https://review.coreboot.org/c/coreboot/+/51144/comment/02582159_3eac7fc9 PS4, Line 142: echo "acaf7450481136e72a1ee6c4fe3a2dea992d028f ${CONF}" > "${CONF_SHA1_FILE}" > what is this? This is the sha1sum of the inventory file on that archive link. It is put into a temporary file to then be used with sha1sum -c commad -- To view, visit https://review.coreboot.org/c/coreboot/+/51144 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If0166518d252a36d8f9a9c17d375fbdd9e3116f6 Gerrit-Change-Number: 51144 Gerrit-PatchSet: 5 Gerrit-Owner: Leah Rowe <leahleahrowerowe(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Mon, 01 Mar 2021 16:16:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: [DO NOT SUBMIT] 3rdparty/libgfxinit: Update submodule pointer
by Angel Pons (Code Review) 01 Mar '21

01 Mar '21

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/51147 ) Change subject: [DO NOT SUBMIT] 3rdparty/libgfxinit: Update submodule pointer ...................................................................... [DO NOT SUBMIT] 3rdparty/libgfxinit: Update submodule pointer Change-Id: I35cefa2aa8107b7841d7cf7a7bb61d4b591d14ae Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M 3rdparty/libgfxinit 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/51147/1 diff --git a/3rdparty/libgfxinit b/3rdparty/libgfxinit index bc0588e..6b3d2ba 160000 --- a/3rdparty/libgfxinit +++ b/3rdparty/libgfxinit @@ -1 +1 @@ -Subproject commit bc0588e482b1320d5739900b00a45033f5b587f4 +Subproject commit 6b3d2bac8a1d4c4b0f2dfb3f1c99866c33cef57f -- To view, visit https://review.coreboot.org/c/coreboot/+/51147 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I35cefa2aa8107b7841d7cf7a7bb61d4b591d14ae Gerrit-Change-Number: 51147 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: drivers/intel/gma/gma.ads: Uniformize casing
by Angel Pons (Code Review) 01 Mar '21

01 Mar '21

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/51146 ) Change subject: drivers/intel/gma/gma.ads: Uniformize casing ...................................................................... drivers/intel/gma/gma.ads: Uniformize casing Use lowercase `port` in both the spec and the body. Change-Id: I3d1e2abe03eedcaf57716af444a3e3b8a61b60d4 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M src/drivers/intel/gma/gma.ads 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/51146/1 diff --git a/src/drivers/intel/gma/gma.ads b/src/drivers/intel/gma/gma.ads index e83fff4..d264960 100644 --- a/src/drivers/intel/gma/gma.ads +++ b/src/drivers/intel/gma/gma.ads @@ -8,7 +8,7 @@ function read_edid (raw_edid : out HW.GFX.EDID.Raw_EDID_Data; - Port : in Interfaces.C.int) + port : in Interfaces.C.int) return Interfaces.C.int with Export, Convention => C, External_Name => "gma_read_edid"; -- To view, visit https://review.coreboot.org/c/coreboot/+/51146 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3d1e2abe03eedcaf57716af444a3e3b8a61b60d4 Gerrit-Change-Number: 51146 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newchange

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2021