coreboot-gerrit March 2021

coreboot-gerrit@coreboot.org

1 participants
7266 discussions

Change in coreboot[master]: mb/{intel/d510mo,foxconn/d14s}/devicetree.cb: Remove PEG device
by Angel Pons (Code Review) 01 Mar '21

01 Mar '21

Attention is currently required from: Damien Zammit, Arthur Heymans. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51150 ) Change subject: mb/{intel/d510mo,foxconn/d14s}/devicetree.cb: Remove PEG device ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/51150/comment/0081aac0_9f3168f5 PS2, Line 7: d14s > ? Says d*14*s, but should be d*41*s (1 and 4 are backwards) -- To view, visit https://review.coreboot.org/c/coreboot/+/51150 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib0006dbd54e6f2031b97ed11ce61407ffcfa6244 Gerrit-Change-Number: 51150 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Damien Zammit Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Damien Zammit Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Mon, 01 Mar 2021 17:38:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/intel/d510/devicetree.cb: Indent with tabs
by Arthur Heymans (Code Review) 01 Mar '21

01 Mar '21

Attention is currently required from: Damien Zammit. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51149 ) Change subject: mb/intel/d510/devicetree.cb: Indent with tabs ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/51149/comment/14b34820_9f6fbc35 PS2, Line 7: mb/intel/d510: Fix spaces to tabs > mb/intel/d510mo/devicetree. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/51149 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic90e5584938592f1c2ab41edfcc773702822070d Gerrit-Change-Number: 51149 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Damien Zammit Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Damien Zammit Gerrit-Comment-Date: Mon, 01 Mar 2021 17:36:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/{intel/d510mo,foxconn/d14s}/devicetree.cb: Remove PEG device
by Arthur Heymans (Code Review) 01 Mar '21

01 Mar '21

Attention is currently required from: Damien Zammit, Angel Pons. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51150 ) Change subject: mb/{intel/d510mo,foxconn/d14s}/devicetree.cb: Remove PEG device ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/51150/comment/97107135_acb0ed2c PS2, Line 7: d14s > d41s ? -- To view, visit https://review.coreboot.org/c/coreboot/+/51150 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib0006dbd54e6f2031b97ed11ce61407ffcfa6244 Gerrit-Change-Number: 51150 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Damien Zammit Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Damien Zammit Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Mon, 01 Mar 2021 17:36:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/{intel/d510mo,foxconn/d14s}/devicetree.cb: Remove PEG device
by Arthur Heymans (Code Review) 01 Mar '21

01 Mar '21

Attention is currently required from: Damien Zammit. Hello Damien Zammit, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/51150 to look at the new patch set (#3). Change subject: mb/{intel/d510mo,foxconn/d14s}/devicetree.cb: Remove PEG device ...................................................................... mb/{intel/d510mo,foxconn/d14s}/devicetree.cb: Remove PEG device Pineview does not support PEG. Change-Id: Ib0006dbd54e6f2031b97ed11ce61407ffcfa6244 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/mainboard/foxconn/d41s/devicetree.cb M src/mainboard/intel/d510mo/devicetree.cb 2 files changed, 0 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/51150/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/51150 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib0006dbd54e6f2031b97ed11ce61407ffcfa6244 Gerrit-Change-Number: 51150 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Damien Zammit Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Damien Zammit Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/intel/d510/devicetree.cb: Indent with tabs
by Arthur Heymans (Code Review) 01 Mar '21

01 Mar '21

Attention is currently required from: Damien Zammit, Arthur Heymans. Hello Damien Zammit, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/51149 to look at the new patch set (#3). Change subject: mb/intel/d510/devicetree.cb: Indent with tabs ...................................................................... mb/intel/d510/devicetree.cb: Indent with tabs This is a cosmetic change. Make the formatting consistent with the rest of the tree. Change-Id: Ic90e5584938592f1c2ab41edfcc773702822070d Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/mainboard/intel/d510mo/devicetree.cb 1 file changed, 94 insertions(+), 94 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/51149/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/51149 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic90e5584938592f1c2ab41edfcc773702822070d Gerrit-Change-Number: 51149 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Damien Zammit Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Damien Zammit Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newpatchset

1 0

Change in libgfxinit[master]: Add support to switch LSPCON modes
by Angel Pons (Code Review) 01 Mar '21

01 Mar '21

Attention is currently required from: Nico Huber, Martin Roth. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/51133 ) Change subject: Add support to switch LSPCON modes ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/libgfxinit/+/51133 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-Change-Id: Idfa9bdff47a6591000cd5092d64a4cd4f8dbdc8d Gerrit-Change-Number: 51133 Gerrit-PatchSet: 7 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Comment-Date: Mon, 01 Mar 2021 17:33:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/{intel/d510mo,foxconn/d14s}: Remove PEG device from DT
by Angel Pons (Code Review) 01 Mar '21

01 Mar '21

Attention is currently required from: Damien Zammit, Arthur Heymans. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51150 ) Change subject: mb/{intel/d510mo,foxconn/d14s}: Remove PEG device from DT ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/51150/comment/c0424fba_c9480742 PS2, Line 7: d14s d41s -- To view, visit https://review.coreboot.org/c/coreboot/+/51150 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib0006dbd54e6f2031b97ed11ce61407ffcfa6244 Gerrit-Change-Number: 51150 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Damien Zammit Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Damien Zammit Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Mon, 01 Mar 2021 17:31:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/intel/d510: Fix spaces to tabs
by Angel Pons (Code Review) 01 Mar '21

01 Mar '21

Attention is currently required from: Damien Zammit, Arthur Heymans. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51149 ) Change subject: mb/intel/d510: Fix spaces to tabs ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/51149/comment/9e64ae8d_f23b54dc PS2, Line 7: mb/intel/d510: Fix spaces to tabs mb/intel/d510mo/devicetree.cb: Indent with tabs -- To view, visit https://review.coreboot.org/c/coreboot/+/51149 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic90e5584938592f1c2ab41edfcc773702822070d Gerrit-Change-Number: 51149 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Damien Zammit Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Damien Zammit Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Mon, 01 Mar 2021 17:31:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/amd/cezanne: Fill out pci devices in chipset.cb
by Felix Held (Code Review) 01 Mar '21

01 Mar '21

Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Mathew King, Angel Pons. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51045 ) Change subject: soc/amd/cezanne: Fill out pci devices in chipset.cb ...................................................................... Patch Set 9: Code-Review+2 (1 comment) Patchset: PS9: > The PPR shows […] from chapter 1 (processor overview) of the ppr: "Two SATA controllers supporting x2 lanes of SATA Gen1/Gen2/Gen3". i'm ok with doing that in a separate patch, since it's not used at the moment anyway -- To view, visit https://review.coreboot.org/c/coreboot/+/51045 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iecc75afd7a914651ca15b811163d3559bf73ac9b Gerrit-Change-Number: 51045 Gerrit-PatchSet: 9 Gerrit-Owner: Mathew King <mathewk(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Mathew King <mathewk(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Mon, 01 Mar 2021 17:31:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Mathew King <mathewk(a)chromium.org> Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/{intel/d510mo,foxconn/d14s}: Remove PEG device from DT
by Arthur Heymans (Code Review) 01 Mar '21

01 Mar '21

Attention is currently required from: Damien Zammit. Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/51150 ) Change subject: mb/{intel/d510mo,foxconn/d14s}: Remove PEG device from DT ...................................................................... mb/{intel/d510mo,foxconn/d14s}: Remove PEG device from DT Pineview does not support PEG. Change-Id: Ib0006dbd54e6f2031b97ed11ce61407ffcfa6244 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/mainboard/foxconn/d41s/devicetree.cb M src/mainboard/intel/d510mo/devicetree.cb 2 files changed, 0 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/51150/1 diff --git a/src/mainboard/foxconn/d41s/devicetree.cb b/src/mainboard/foxconn/d41s/devicetree.cb index 4c5c2fa..766d68f 100644 --- a/src/mainboard/foxconn/d41s/devicetree.cb +++ b/src/mainboard/foxconn/d41s/devicetree.cb @@ -13,7 +13,6 @@ device domain 0 on # PCI domain subsystemid 0x105b 0x0d55 inherit device pci 0.0 on end # Host Bridge - device pci 1.0 off end # PEG device pci 2.0 on end # Integrated graphics controller device pci 2.1 off end # Integrated graphics controller 2 diff --git a/src/mainboard/intel/d510mo/devicetree.cb b/src/mainboard/intel/d510mo/devicetree.cb index 22e67e7..4b5449f 100644 --- a/src/mainboard/intel/d510mo/devicetree.cb +++ b/src/mainboard/intel/d510mo/devicetree.cb @@ -12,7 +12,6 @@ end device domain 0 on # PCI domain device pci 0.0 on end # Host Bridge - device pci 1.0 off end # PEG device pci 2.0 on end # Integrated graphics controller device pci 2.1 on end # Integrated graphics controller 2 chip southbridge/intel/i82801gx # Southbridge -- To view, visit https://review.coreboot.org/c/coreboot/+/51150 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib0006dbd54e6f2031b97ed11ce61407ffcfa6244 Gerrit-Change-Number: 51150 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Damien Zammit Gerrit-Attention: Damien Zammit Gerrit-MessageType: newchange

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2021