coreboot-gerrit March 2021

coreboot-gerrit@coreboot.org

1 participants
7266 discussions

Change in coreboot[master]: sb/intel/common/pciehp: Replace HP dummy device with common code
by Arthur Heymans (Code Review) 01 Mar '21

01 Mar '21

Attention is currently required from: Arthur Heymans, Patrick Rudolph. Hello build bot (Jenkins), Paul Menzel, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/51068 to look at the new patch set (#2). Change subject: sb/intel/common/pciehp: Replace HP dummy device with common code ...................................................................... sb/intel/common/pciehp: Replace HP dummy device with common code Use the common PCIEXP_HOTPLUG code to generate a dummy device for PCIe ports supporting hotplug. This allows to have control over how much resources are allocated to hotplug ports. Tested on thinkpad X220: now hotplugging a dGPU via the expresscard slot sometimes works. Change-Id: I3eec5214c9d200ef97d1ccfdc00e8ea0ee7cfbc6 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/southbridge/intel/bd82x6x/Kconfig M src/southbridge/intel/bd82x6x/pcie.c M src/southbridge/intel/common/pciehp.c M src/southbridge/intel/i82801ix/Kconfig M src/southbridge/intel/i82801ix/pcie.c M src/southbridge/intel/i82801jx/Kconfig M src/southbridge/intel/i82801jx/pcie.c 7 files changed, 24 insertions(+), 54 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/51068/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/51068 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3eec5214c9d200ef97d1ccfdc00e8ea0ee7cfbc6 Gerrit-Change-Number: 51068 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: util/chromeos: Use the same inventory each time and verify checksums
by Arthur Heymans (Code Review) 01 Mar '21

01 Mar '21

Attention is currently required from: Paul Menzel, Leah Rowe. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51144 ) Change subject: util/chromeos: Use the same inventory each time and verify checksums ...................................................................... Patch Set 5: (1 comment) Patchset: PS4: > In what way do you think I should split up this commit? Split up checking the checksum against the recovery.conf file, adding a checksum check for the recovery.conf file itself and the url change to archive.org. -- To view, visit https://review.coreboot.org/c/coreboot/+/51144 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If0166518d252a36d8f9a9c17d375fbdd9e3116f6 Gerrit-Change-Number: 51144 Gerrit-PatchSet: 5 Gerrit-Owner: Leah Rowe <leahleahrowerowe(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Leah Rowe <leahleahrowerowe(a)gmail.com> Gerrit-Comment-Date: Mon, 01 Mar 2021 17:53:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Comment-In-Reply-To: Leah Rowe <leahleahrowerowe(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: elog: Support logging CSE Lite info in elog
by Krishna P Bhat D (Code Review) 01 Mar '21

01 Mar '21

Attention is currently required from: Martin Roth, Furquan Shaikh, Jamie Ryu, Tim Wawrzynczak, Rizwan Qureshi, Sridhar Siricilla, Krishna P Bhat D, Patrick Rudolph, Karthik Ramasubramanian. Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Furquan Shaikh, Jamie Ryu, Tim Wawrzynczak, Rizwan Qureshi, Sridhar Siricilla, Patrick Rudolph, Karthik Ramasubramanian, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/50472 to look at the new patch set (#5). Change subject: elog: Support logging CSE Lite info in elog ...................................................................... elog: Support logging CSE Lite info in elog This patch adds the following updates, 1. Add support for new elog event type to log CSE Lite information in elog. 2. Add helper functions to get cse firmware sku, manfacturing mode info in cse lib. 3. Add elog event in cse lite driver to log cse info in elog. BUG=b:174121840 BRANCH=None TEST=Build, boot image and check for elog entry in logs. localhost ~ # cbmem -c | grep -i "elog" ... ELOG: Event(B6) added with size 32 at 2021-01-17 16:01:57 UTC localhost ~ # mosys eventlog list ... 3 | 2021-01-17 08:01:57 | CSE Info | Lite | 13.50.0.1269 | 13.50.0.1269 | YES | 0x5 | 0x0 | RW Change-Id: Ib183941d1fa0a9971e30b4092ea3d23daaa29334 Signed-off-by: Krishna Prasad Bhat <krishna.p.bhat.d(a)intel.com> --- M src/include/elog.h M src/soc/intel/alderlake/Makefile.inc M src/soc/intel/alderlake/me.c M src/soc/intel/cannonlake/Makefile.inc M src/soc/intel/cannonlake/me.c M src/soc/intel/common/block/cse/cse.c M src/soc/intel/common/block/cse/cse_lite.c M src/soc/intel/common/block/include/intelblocks/cse.h M src/soc/intel/jasperlake/Makefile.inc M src/soc/intel/jasperlake/me.c M src/soc/intel/tigerlake/Makefile.inc M src/soc/intel/tigerlake/me.c 12 files changed, 113 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/50472/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/50472 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib183941d1fa0a9971e30b4092ea3d23daaa29334 Gerrit-Change-Number: 50472 Gerrit-PatchSet: 5 Gerrit-Owner: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Attention: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/{intel/d510mo,foxconn/d41s}/devicetree.cb: Remove PEG device
by Arthur Heymans (Code Review) 01 Mar '21

01 Mar '21

Attention is currently required from: Damien Zammit, Angel Pons. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51150 ) Change subject: mb/{intel/d510mo,foxconn/d41s}/devicetree.cb: Remove PEG device ...................................................................... Patch Set 4: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/51150/comment/7d7ec170_6465cb31 PS2, Line 7: d14s > > Says d*14*s, but should be d*41*s (1 and 4 are backwards) […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/51150 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib0006dbd54e6f2031b97ed11ce61407ffcfa6244 Gerrit-Change-Number: 51150 Gerrit-PatchSet: 4 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Damien Zammit Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Damien Zammit Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Mon, 01 Mar 2021 17:49:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/intel/d510mo/devicetree.cb: Indent with tabs
by Arthur Heymans (Code Review) 01 Mar '21

01 Mar '21

Attention is currently required from: Damien Zammit. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51149 ) Change subject: mb/intel/d510mo/devicetree.cb: Indent with tabs ...................................................................... Patch Set 4: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/51149/comment/88caa557_6b6bf4f8 PS3, Line 7: d510 > Sorry for being nitpicky: d510*mo* Done -- To view, visit https://review.coreboot.org/c/coreboot/+/51149 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic90e5584938592f1c2ab41edfcc773702822070d Gerrit-Change-Number: 51149 Gerrit-PatchSet: 4 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Damien Zammit Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Damien Zammit Gerrit-Comment-Date: Mon, 01 Mar 2021 17:49:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/{intel/d510mo,foxconn/d41s}/devicetree.cb: Remove PEG device
by Arthur Heymans (Code Review) 01 Mar '21

01 Mar '21

Attention is currently required from: Damien Zammit, Angel Pons. Hello build bot (Jenkins), Damien Zammit, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/51150 to look at the new patch set (#4). Change subject: mb/{intel/d510mo,foxconn/d41s}/devicetree.cb: Remove PEG device ...................................................................... mb/{intel/d510mo,foxconn/d41s}/devicetree.cb: Remove PEG device Pineview does not support PEG. Change-Id: Ib0006dbd54e6f2031b97ed11ce61407ffcfa6244 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/mainboard/foxconn/d41s/devicetree.cb M src/mainboard/intel/d510mo/devicetree.cb 2 files changed, 0 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/51150/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/51150 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib0006dbd54e6f2031b97ed11ce61407ffcfa6244 Gerrit-Change-Number: 51150 Gerrit-PatchSet: 4 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Damien Zammit Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Damien Zammit Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/intel/d510mo/devicetree.cb: Indent with tabs
by Arthur Heymans (Code Review) 01 Mar '21

01 Mar '21

Attention is currently required from: Damien Zammit, Arthur Heymans. Hello build bot (Jenkins), Damien Zammit, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/51149 to look at the new patch set (#4). Change subject: mb/intel/d510mo/devicetree.cb: Indent with tabs ...................................................................... mb/intel/d510mo/devicetree.cb: Indent with tabs This is a cosmetic change. Make the formatting consistent with the rest of the tree. Change-Id: Ic90e5584938592f1c2ab41edfcc773702822070d Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/mainboard/intel/d510mo/devicetree.cb 1 file changed, 94 insertions(+), 94 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/51149/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/51149 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic90e5584938592f1c2ab41edfcc773702822070d Gerrit-Change-Number: 51149 Gerrit-PatchSet: 4 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Damien Zammit Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Damien Zammit Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/{intel/d510mo,foxconn/d14s}/devicetree.cb: Remove PEG device
by Arthur Heymans (Code Review) 01 Mar '21

01 Mar '21

Attention is currently required from: Damien Zammit, Angel Pons. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51150 ) Change subject: mb/{intel/d510mo,foxconn/d14s}/devicetree.cb: Remove PEG device ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/51150/comment/c447a486_76aaef67 PS2, Line 7: d14s > Says d*14*s, but should be d*41*s (1 and 4 are backwards) Oh looks my mind read the same twice ^^ My bad. -- To view, visit https://review.coreboot.org/c/coreboot/+/51150 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib0006dbd54e6f2031b97ed11ce61407ffcfa6244 Gerrit-Change-Number: 51150 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Damien Zammit Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Damien Zammit Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Mon, 01 Mar 2021 17:48:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/volteer: Fix FPMCU pwr/rst gpio handling
by Nick Vaccaro (Code Review) 01 Mar '21

01 Mar '21

Attention is currently required from: Tim Wawrzynczak, Duncan Laurie, Craig Hesling. Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50828 ) Change subject: mb/google/volteer: Fix FPMCU pwr/rst gpio handling ...................................................................... Patch Set 9: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/50828/comment/a3c93649_096174aa PS8, Line 10: 2. Disable power and assert reset in ramstage gpio > If so, I would remove the assert of FPMCU reset just prior to the enabling of power in ramstage. […] Duncan, any chance to test this yet? -- To view, visit https://review.coreboot.org/c/coreboot/+/50828 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib51815349cea299907c10d6c56c27bd239e499e7 Gerrit-Change-Number: 50828 Gerrit-PatchSet: 9 Gerrit-Owner: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Craig Hesling <hesling(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Attention: Craig Hesling <hesling(a)chromium.org> Gerrit-Comment-Date: Mon, 01 Mar 2021 17:41:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Comment-In-Reply-To: Duncan Laurie <dlaurie(a)chromium.org> Comment-In-Reply-To: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/intel/d510/devicetree.cb: Indent with tabs
by Angel Pons (Code Review) 01 Mar '21

01 Mar '21

Attention is currently required from: Damien Zammit, Arthur Heymans. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51149 ) Change subject: mb/intel/d510/devicetree.cb: Indent with tabs ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/51149/comment/84108f3f_a1c9e141 PS3, Line 7: d510 Sorry for being nitpicky: d510*mo* -- To view, visit https://review.coreboot.org/c/coreboot/+/51149 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic90e5584938592f1c2ab41edfcc773702822070d Gerrit-Change-Number: 51149 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Damien Zammit Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Damien Zammit Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Mon, 01 Mar 2021 17:39:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2021