coreboot-gerrit February 2021

coreboot-gerrit@coreboot.org

1 participants
7192 discussions

Change in coreboot[master]: soc/intel: Drop CID1 from GNVS
by Angel Pons (Code Review) 07 Feb '21

07 Feb '21

Attention is currently required from: Lance Zhao, Furquan Shaikh, Subrata Banik, Kyösti Mälkki, Patrick Rudolph. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50297 ) Change subject: soc/intel: Drop CID1 from GNVS ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/50297 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I09ea756fb3743e33d1e221f0a0df3a6fdc3fc3ba Gerrit-Change-Number: 50297 Gerrit-PatchSet: 2 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Lance Zhao Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Lance Zhao Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Sun, 07 Feb 2021 14:22:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: payloads/external/tianocore/Kconfig: elaborate help for TIANOCORE_BOO...
by Nico Huber (Code Review) 07 Feb '21

07 Feb '21

Attention is currently required from: Felix Friedlander, Martin Roth, Matt DeVillier, Paul Menzel, Stefan Reinauer. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49233 ) Change subject: payloads/external/tianocore/Kconfig: elaborate help for TIANOCORE_BOOTSPLASH_FILE ...................................................................... Patch Set 1: Code-Review+1 (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/49233/comment/3ad041d9_032ac50e PS1, Line 7: payloads/external/tianocore/Kconfig: elaborate help for TIANOCORE_BOOTSPLASH_FILE > tianocore/Kconfig: Extend help for bootspash file […] Ack File payloads/external/tianocore/Kconfig: https://review.coreboot.org/c/coreboot/+/49233/comment/d37c0d49_1048203b PS1, Line 100: and will be displayed slightly above the centre of : the screen, > From Microsoft's documentation on "boot screen components" (https://docs.microsoft. […] That's also what I recall. However confusing reality might seem, the new text seems to reflect it. https://review.coreboot.org/c/coreboot/+/49233/comment/a298a422_c1e15d3e PS1, Line 102: than your display. > Happy to - unfortunately, the actual ACPI specification is a PDF, so I can't hyperlink directly to t […] URLs will break anyway, same applies to section numbers, so please mention the title of the section, e.g.: See ACPI spec 6.3, 5.2.22 Boot Graphics Resource Table (BGRT). -- To view, visit https://review.coreboot.org/c/coreboot/+/49233 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib4c6666bb0e49369fe8fe2ae3dc12c023f668da0 Gerrit-Change-Number: 49233 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Friedlander <felix(a)ffetc.net> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Friedlander <felix(a)ffetc.net> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Sun, 07 Feb 2021 13:10:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Felix Friedlander <felix(a)ffetc.net> Comment-In-Reply-To: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: sb/intel/*/Kconfig: Order options selections alphabetically
by Nico Huber (Code Review) 07 Feb '21

07 Feb '21

Attention is currently required from: Patrick Rudolph, HAOUAS Elyes. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50363 ) Change subject: sb/intel/*/Kconfig: Order options selections alphabetically ...................................................................... Patch Set 4: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/50363/comment/a95f39c7_e9ba5787 PS4, Line 7: sb/intel/*/Kconfig: Order options selections alphabetically Why? https://review.coreboot.org/c/coreboot/+/50363/comment/807c0bf1_17789009 PS4, Line 9: Also add "config SOUTH_BRIDGE_OPTIONS". Why? File src/southbridge/intel/i82801ix/Kconfig: https://review.coreboot.org/c/coreboot/+/50363/comment/8de4a98e_8b797922 PS4, Line 18: select SOUTHBRIDGE_INTEL_COMMON_SMBUS : select SOUTHBRIDGE_INTEL_COMMON_EARLY_SMBUS Looks better ordered to me. -- To view, visit https://review.coreboot.org/c/coreboot/+/50363 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6ae6e2a893372e124a6594852e436c18e30b36e1 Gerrit-Change-Number: 50363 Gerrit-PatchSet: 4 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Comment-Date: Sun, 07 Feb 2021 12:20:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: cbfstool: Remove location pointer from parse_elf_to_stage()
by Angel Pons (Code Review) 07 Feb '21

07 Feb '21

Attention is currently required from: Furquan Shaikh, Julius Werner, Aaron Durbin. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49369 ) Change subject: cbfstool: Remove location pointer from parse_elf_to_stage() ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/49369 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia7f850c0edd7536ed3bef643efaae7271599313d Gerrit-Change-Number: 49369 Gerrit-PatchSet: 4 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Comment-Date: Sun, 07 Feb 2021 10:18:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: coreboot_table: Use precision when printing lb_gpio name
by Angel Pons (Code Review) 07 Feb '21

07 Feb '21

Attention is currently required from: Julius Werner. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49496 ) Change subject: coreboot_table: Use precision when printing lb_gpio name ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/49496 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifd7beef00d828f9dc2faa4747eace6ac4ca41899 Gerrit-Change-Number: 49496 Gerrit-PatchSet: 1 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Sun, 07 Feb 2021 10:16:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: sb/intel: Extract `set_global_reset` function
by Evgeny Zinoviev (Code Review) 07 Feb '21

07 Feb '21

Attention is currently required from: Nico Huber, Martin Roth, Angel Pons, Arthur Heymans, Patrick Rudolph. Evgeny Zinoviev has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50362 ) Change subject: sb/intel: Extract `set_global_reset` function ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/50362 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I64c59a01ca153770481c28ae404a5dfe8c5382d2 Gerrit-Change-Number: 50362 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Sun, 07 Feb 2021 10:14:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: (test) Kconfig: Reorder sources
by HAOUAS Elyes (Code Review) 07 Feb '21

07 Feb '21

Attention is currently required from: Nico Huber, HAOUAS Elyes. Hello build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/50367 to look at the new patch set (#3). Change subject: (test) Kconfig: Reorder sources ...................................................................... (test) Kconfig: Reorder sources Change-Id: Ib853f679a2faaa61adca25721c7f48b705999a2d Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/Kconfig M src/cpu/x86/Kconfig M src/soc/intel/baytrail/Kconfig M src/soc/intel/xeon_sp/cpx/Kconfig M src/soc/intel/xeon_sp/skx/Kconfig 5 files changed, 12 insertions(+), 17 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/50367/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/50367 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib853f679a2faaa61adca25721c7f48b705999a2d Gerrit-Change-Number: 50367 Gerrit-PatchSet: 3 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: (test) Kconfig: Reorder sources
by HAOUAS Elyes (Code Review) 07 Feb '21

07 Feb '21

Attention is currently required from: Nico Huber, HAOUAS Elyes. Hello build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/50367 to look at the new patch set (#2). Change subject: (test) Kconfig: Reorder sources ...................................................................... (test) Kconfig: Reorder sources Change-Id: Ib853f679a2faaa61adca25721c7f48b705999a2d Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/Kconfig M src/cpu/x86/Kconfig 2 files changed, 12 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/50367/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/50367 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib853f679a2faaa61adca25721c7f48b705999a2d Gerrit-Change-Number: 50367 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: (test) Kconfig: Reorder sources
by HAOUAS Elyes (Code Review) 07 Feb '21

07 Feb '21

Attention is currently required from: Nico Huber. HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50367 ) Change subject: (test) Kconfig: Reorder sources ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Hi, maybe this is wrong, but the idea is to make some "logic" 😊 I mean, it makes sens to source "arch" before "cpu" for example -- To view, visit https://review.coreboot.org/c/coreboot/+/50367 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib853f679a2faaa61adca25721c7f48b705999a2d Gerrit-Change-Number: 50367 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Sun, 07 Feb 2021 09:25:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: (test) Kconfig: Reorder sources
by HAOUAS Elyes (Code Review) 07 Feb '21

07 Feb '21

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/50367 ) Change subject: (test) Kconfig: Reorder sources ...................................................................... (test) Kconfig: Reorder sources Change-Id: Ib853f679a2faaa61adca25721c7f48b705999a2d Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/Kconfig M src/cpu/x86/Kconfig 2 files changed, 15 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/50367/1 diff --git a/src/Kconfig b/src/Kconfig index 33065cb..b17674a 100644 --- a/src/Kconfig +++ b/src/Kconfig @@ -517,25 +517,33 @@ menu "Chipset" -comment "SoC" -source "src/soc/*/Kconfig" +source "src/arch/*/Kconfig" + comment "CPU" source "src/cpu/Kconfig" + +comment "SoC" +source "src/soc/*/Kconfig" + +comment "Device" +source "src/device/Kconfig" + comment "Northbridge" source "src/northbridge/*/*/Kconfig" + comment "Southbridge" source "src/southbridge/*/*/Kconfig" +source "src/southbridge/intel/common/firmware/Kconfig" + comment "Super I/O" source "src/superio/*/*/Kconfig" + comment "Embedded Controllers" source "src/ec/acpi/Kconfig" source "src/ec/*/*/Kconfig" -source "src/southbridge/intel/common/firmware/Kconfig" source "src/vendorcode/*/Kconfig" -source "src/arch/*/Kconfig" - config CHIPSET_DEVICETREE string default "" @@ -549,8 +557,6 @@ endmenu -source "src/device/Kconfig" - menu "Generic Drivers" source "src/drivers/*/Kconfig" source "src/drivers/*/*/Kconfig" diff --git a/src/cpu/x86/Kconfig b/src/cpu/x86/Kconfig index b3a16bc..ed963b4 100644 --- a/src/cpu/x86/Kconfig +++ b/src/cpu/x86/Kconfig @@ -71,6 +71,8 @@ config CPU_ADDR_BITS int + default 48 if (SOC_AMD_CEZANNE || SOC_AMD_PICASSO || SOC_AMD_STONEYRIDGE) + default 46 if (SOC_INTEL_SKYLAKE_SP || SOC_INTEL_COOPERLAKE_SP) default 36 config LOGICAL_CPUS -- To view, visit https://review.coreboot.org/c/coreboot/+/50367 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib853f679a2faaa61adca25721c7f48b705999a2d Gerrit-Change-Number: 50367 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2021