coreboot-gerrit November 2021

coreboot-gerrit@coreboot.org

1 participants
6394 discussions

Change in edk2[master]: UefiPayloadPkg: Allow below 4GB memory
by Matt DeVillier (Code Review) 02 Nov '21

02 Nov '21

Attention is currently required from: Sean Rhodes. Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/edk2/+/58802 ) Change subject: UefiPayloadPkg: Allow below 4GB memory ...................................................................... Patch Set 1: (1 comment) File UefiPayloadPkg/UefiPayloadPkg.dec: https://review.coreboot.org/c/edk2/+/58802/comment/14096320_ef6285cc PS1, Line 80: 0x00000018 this will create a conflict with the Pcd defined below; bump to 19, reorder 😊 -- To view, visit https://review.coreboot.org/c/edk2/+/58802 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: edk2 Gerrit-Branch: master Gerrit-Change-Id: Ic600e08c9d46d0a291b8b119a3c268e432267cdf Gerrit-Change-Number: 58802 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Comment-Date: Mon, 01 Nov 2021 23:59:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Add console deinit API, use in SMM handler
by Johnny Lin (Code Review) 02 Nov '21

02 Nov '21

Attention is currently required from: Nico Huber, Paul Menzel, Rocky Phagura, Christian Walter, Angel Pons, Arthur Heymans, Kyösti Mälkki, Peter Tsung Ho Wu, Deomid "rojer" Ryabkov, Ron Minnich. Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56386 ) Change subject: Add console deinit API, use in SMM handler ...................................................................... Patch Set 11: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/56386/comment/4c26c6a5_373508ba PS11, Line 14: on an OCP Delta Lake server: uart8250_init disables interrupts because it > uart8250_init should only be called in the first SMM call (that prints something), no? That's normal […] yes in coreboot stage it's fine, but this change is for entering and exiting smm while printing smm log under Linux, so it's in runtime OS stage. -- To view, visit https://review.coreboot.org/c/coreboot/+/56386 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia5e51f385f83cb998c244ca1d1ffc10339d3a714 Gerrit-Change-Number: 56386 Gerrit-PatchSet: 11 Gerrit-Owner: Deomid "rojer" Ryabkov <rojer9(a)fb.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Peter Tsung Ho Wu <tsung(a)amazon.com> Gerrit-Reviewer: Rocky Phagura Gerrit-Reviewer: Rocky Phagura <rphagura(a)fb.com> Gerrit-Reviewer: Ron Minnich <rminnich(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Georgi <pgeorgi(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Rocky Phagura <rphagura(a)fb.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Attention: Peter Tsung Ho Wu <tsung(a)amazon.com> Gerrit-Attention: Deomid "rojer" Ryabkov <rojer9(a)fb.com> Gerrit-Attention: Ron Minnich <rminnich(a)gmail.com> Gerrit-Comment-Date: Mon, 01 Nov 2021 23:44:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Georgi <pgeorgi(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/intel/adlrvp_m: Configure parameters for VR domains
by Bora Guvendik (Code Review) 02 Nov '21

02 Nov '21

Bora Guvendik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/58808 ) Change subject: mb/intel/adlrvp_m: Configure parameters for VR domains ...................................................................... mb/intel/adlrvp_m: Configure parameters for VR domains Add power delivery parameters for the VR domains. TEST=Boot to OS Signed-off-by: Bora Guvendik <bora.guvendik(a)intel.com> Change-Id: I388af3197f8d1a983e2eb157de45a715534b4418 --- M src/mainboard/intel/adlrvp/devicetree_m.cb 1 file changed, 13 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/58808/1 diff --git a/src/mainboard/intel/adlrvp/devicetree_m.cb b/src/mainboard/intel/adlrvp/devicetree_m.cb index b73ded1..8091272 100644 --- a/src/mainboard/intel/adlrvp/devicetree_m.cb +++ b/src/mainboard/intel/adlrvp/devicetree_m.cb @@ -168,6 +168,19 @@ }, }" + register "domain_vr_config[VR_DOMAIN_IA]" = "{ + .vr_config_enable = 1, + .icc_max = VR_CFG_AMP(50), + .tdc_timewindow = 32000, + .tdc_currentlimit = VR_CFG_TDC_AMP(15), + }" + register "domain_vr_config[VR_DOMAIN_GT]" = "{ + .vr_config_enable = 1, + .icc_max = VR_CFG_AMP(25), + .tdc_timewindow = 32000, + .tdc_currentlimit = VR_CFG_TDC_AMP(15), + }" + device domain 0 on device ref pcie5 on end device ref igpu on end -- To view, visit https://review.coreboot.org/c/coreboot/+/58808 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I388af3197f8d1a983e2eb157de45a715534b4418 Gerrit-Change-Number: 58808 Gerrit-PatchSet: 1 Gerrit-Owner: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: soc/intel/alderlake: Allow devicetree override to leave some VR setti...
by Bora Guvendik (Code Review) 02 Nov '21

02 Nov '21

Bora Guvendik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/58807 ) Change subject: soc/intel/alderlake: Allow devicetree override to leave some VR settings as default ...................................................................... soc/intel/alderlake: Allow devicetree override to leave some VR settings as default Allow devicetree override to leave ac_loadline, dc_loadline and icc_max as default. Test=Boot to OS Signed-off-by: Bora Guvendik <bora.guvendik(a)intel.com> Change-Id: I715345d5ea83aed9ee929b2a4e13921c9d8895b1 --- M src/soc/intel/alderlake/vr_config.c 1 file changed, 6 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/58807/1 diff --git a/src/soc/intel/alderlake/vr_config.c b/src/soc/intel/alderlake/vr_config.c index 2180fc5..99caacb 100644 --- a/src/soc/intel/alderlake/vr_config.c +++ b/src/soc/intel/alderlake/vr_config.c @@ -87,9 +87,12 @@ if (chip_cfg->vr_config_enable) { cfg = chip_cfg; - s_cfg->AcLoadline[domain] = cfg->ac_loadline; - s_cfg->DcLoadline[domain] = cfg->dc_loadline; - s_cfg->IccMax[domain] = cfg->icc_max; + if (cfg->ac_loadline) + s_cfg->AcLoadline[domain] = cfg->ac_loadline; + if (cfg->dc_loadline) + s_cfg->DcLoadline[domain] = cfg->dc_loadline; + if (cfg->icc_max) + s_cfg->IccMax[domain] = cfg->icc_max; s_cfg->TdcTimeWindow[domain] = cfg->tdc_timewindow; s_cfg->TdcCurrentLimit[domain] = cfg->tdc_currentlimit; } else { -- To view, visit https://review.coreboot.org/c/coreboot/+/58807 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I715345d5ea83aed9ee929b2a4e13921c9d8895b1 Gerrit-Change-Number: 58807 Gerrit-PatchSet: 1 Gerrit-Owner: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-MessageType: newchange

1 0

Change in edk2[coreboot-stable202108]: UefiPayloadPkg: Add build option to disable Above 4G Decode
by Matt DeVillier (Code Review) 02 Nov '21

02 Nov '21

Attention is currently required from: Sean Rhodes. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/edk2/+/58801 to look at the new patch set (#2). Change subject: UefiPayloadPkg: Add build option to disable Above 4G Decode ...................................................................... UefiPayloadPkg: Add build option to disable Above 4G Decode Dovetails with coreboot commit 766e481a: "payloads/external/tianocore: Add build argument for 4G Decode" Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Change-Id: I50e9d9052b344519f46419a01b27b2ca43047943 --- M UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.c M UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.inf M UefiPayloadPkg/UefiPayloadPkg.dec M UefiPayloadPkg/UefiPayloadPkg.dsc 4 files changed, 52 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/edk2 refs/changes/01/58801/2 -- To view, visit https://review.coreboot.org/c/edk2/+/58801 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: edk2 Gerrit-Branch: coreboot-stable202108 Gerrit-Change-Id: I50e9d9052b344519f46419a01b27b2ca43047943 Gerrit-Change-Number: 58801 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Attention: Sean Rhodes <admin(a)starlabs.systems> Gerrit-MessageType: newpatchset

1 0

Change in edk2[coreboot-stable202108]: UefiPayloadPkg: Add build option to disable Above 4G Decode
by Matt DeVillier (Code Review) 02 Nov '21

02 Nov '21

Attention is currently required from: Sean Rhodes. Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/edk2/+/58801 ) Change subject: UefiPayloadPkg: Add build option to disable Above 4G Decode ...................................................................... Patch Set 1: (1 comment) File UefiPayloadPkg/UefiPayloadPkg.dsc: https://review.coreboot.org/c/edk2/+/58801/comment/53ad37a4_c8ab3e88 PS1, Line 327: DECODE > MEMORY that's what I get for pulling it directly from your repo and not mine =P -- To view, visit https://review.coreboot.org/c/edk2/+/58801 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: edk2 Gerrit-Branch: coreboot-stable202108 Gerrit-Change-Id: I50e9d9052b344519f46419a01b27b2ca43047943 Gerrit-Change-Number: 58801 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Attention: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Comment-Date: Mon, 01 Nov 2021 23:30:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Sean Rhodes <admin(a)starlabs.systems> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: src/vendorcode/amd : Zork, MI: Bug in AGESA FabricResourceManagerUnbL...
by Marshall Dawson (Code Review) 02 Nov '21

02 Nov '21

Attention is currently required from: Bao Zheng, Jason Glenesk, Jason Nein, Matt Papageorge, Felix Held. Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58803 ) Change subject: src/vendorcode/amd : Zork, MI: Bug in AGESA FabricResourceManagerUnbLib.c ...................................................................... Patch Set 1: (5 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/58803/comment/8ac1b980_76f35ee9 PS1, Line 7: src/vendorcode/amd : Zork, MI: Bug in AGESA FabricResourceManagerUnbLib.c coreboot has a couple of references for how to write a good commit message although none are really excellent. But you can make sure you follow https://www.coreboot.org/Git#Commit_messages or https://doc.coreboot.org/tutorial/part2.html#step-4a-use-the-command-line-t…. Specifically, you'll often be asked to shorten the subject line: * the subject needs to give some hint of what you're doing * no need to use src in the path * you can substitute vc for vendorcode * no space before a colon * this patch doesn't apply to Zork nor to MI * I often feel there's no reason to identify the filename as it's already pretty evident So the subject line might be "vc/amd/agesa: fix out of bounds read". https://review.coreboot.org/c/coreboot/+/58803/comment/744a0d42_2f83f9bd PS1, Line 9: Fixing coverity issues: Out-of-bounds read Make sure you use complete sentences and that your verbs are imperative, e.g. "Fix out-of-bounds read issue found by coverity". And it doesn't hurt to put the coverity error into the commit message too. 235 MmioRange[MmioPair].Modified = TRUE; >>> CID 1376956: Memory - illegal accesses (OVERRUN) >>> Overrunning array "MmioRange" of 12 20-byte elements at element index 12 (byte offset 240) using index "MmioPair + i" (which evaluates to 12). 236 for (i = 1; NewMmioRange.Limit >= MmioRange[MmioPair + i].Base; i++) { https://review.coreboot.org/c/coreboot/+/58803/comment/1b23749e_e465fae4 PS1, Line 11: BUG=b:147411796 This doesn't really apply for Trinity and Kabini changes. You could omit it. https://review.coreboot.org/c/coreboot/+/58803/comment/22b68957_16e38f99 PS1, Line 12: Build pass and run the normal boot on Guybrush Guybrush doesn't use this code. Since you don't have HW to test with, and Jenkins has built it, I'd be fine with simply saying TEST=none. File src/vendorcode/amd/agesa/f15tn/Proc/CPU/Family/0x15/cpuF15MmioMap.c: https://review.coreboot.org/c/coreboot/+/58803/comment/9ead3bfc_6fc213d9 PS1, Line 232: 12 Is there a defined value somewhere that can be used instead of 12? -- To view, visit https://review.coreboot.org/c/coreboot/+/58803 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I01e134cb6b025bf7cb5030cd9378297d7f6df509 Gerrit-Change-Number: 58803 Gerrit-PatchSet: 1 Gerrit-Owner: Jason Nein <finaljason(a)gmail.com> Gerrit-Reviewer: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Matt Papageorge <matthewpapa07(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Jason Nein <finaljason(a)gmail.com> Gerrit-Attention: Matt Papageorge <matthewpapa07(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 01 Nov 2021 23:26:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: psp_verstage: convert relative address in EFS2
by Kangheui Won (Code Review) 02 Nov '21

02 Nov '21

Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Paul Menzel, Karthik Ramasubramanian. Kangheui Won has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58316 ) Change subject: psp_verstage: convert relative address in EFS2 ...................................................................... Patch Set 6: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/58316/comment/b797527c_27b95da3 PS5, Line 9: is > are relative addresses Done -- To view, visit https://review.coreboot.org/c/coreboot/+/58316 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I95813beba7278480e6640599fcf7445923259361 Gerrit-Change-Number: 58316 Gerrit-PatchSet: 6 Gerrit-Owner: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Mon, 01 Nov 2021 23:17:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: psp_verstage: convert relative address in EFS2
by Kangheui Won (Code Review) 02 Nov '21

02 Nov '21

Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Kangheui Won, Paul Menzel, Karthik Ramasubramanian. Hello build bot (Jenkins), Jason Glenesk, Raul Rangel, Marshall Dawson, Karthik Ramasubramanian, Felix Held, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/58316 to look at the new patch set (#6). Change subject: psp_verstage: convert relative address in EFS2 ...................................................................... psp_verstage: convert relative address in EFS2 Addresses in AMD fw table with EFS gen2 are relative addresses, but PSP doesn't accept relative addresses in update_psp_bios_dir(). Check for EFS gen2 and convert them as needed. BUG=b:194263115 TEST=build and boot on guybrush and shuboz Signed-off-by: Kangheui Won <khwon(a)chromium.org> Change-Id: I95813beba7278480e6640599fcf7445923259361 --- M src/soc/amd/cezanne/include/soc/iomap.h M src/soc/amd/common/block/include/amdblocks/psp_efs.h M src/soc/amd/common/psp_verstage/psp_verstage.c M src/soc/amd/picasso/include/soc/iomap.h 4 files changed, 13 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/58316/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/58316 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I95813beba7278480e6640599fcf7445923259361 Gerrit-Change-Number: 58316 Gerrit-PatchSet: 6 Gerrit-Owner: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Kangheui Won <khwon(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/intel/common: add generic gpio lock mechanism
by Tim Wawrzynczak (Code Review) 01 Nov '21

01 Nov '21

Attention is currently required from: Furquan Shaikh, Nick Vaccaro, Patrick Rudolph, Karthik Ramasubramanian. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58351 ) Change subject: soc/intel/common: add generic gpio lock mechanism ...................................................................... Patch Set 4: (1 comment) File src/soc/intel/common/block/smm/smihandler.c: https://review.coreboot.org/c/coreboot/+/58351/comment/2fc7874d_53c30152 PS1, Line 348: gpio_lock_pad > I implemented Karthik's suggestion in the latest patchset, let me know if this is what you had in mi […] I think you may also need `HAVE_DEBUG_GPIO` ? -- To view, visit https://review.coreboot.org/c/coreboot/+/58351 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I42979fb89567d8bcd9392da4fb8c4113ef427b14 Gerrit-Change-Number: 58351 Gerrit-PatchSet: 4 Gerrit-Owner: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Furquan Shaikh <furquan.m.shaikh(a)gmail.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Furquan Shaikh <furquan.m.shaikh(a)gmail.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Mon, 01 Nov 2021 22:59:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Comment-In-Reply-To: Nick Vaccaro <nvaccaro(a)google.com> Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2021