coreboot-gerrit November 2021

coreboot-gerrit@coreboot.org

1 participants
6394 discussions

Change in coreboot[master]: util/spd_tools: Add LP5 support for ADL
by Karthik Ramasubramanian (Code Review) 02 Nov '21

02 Nov '21

Attention is currently required from: Reka Norman, Sridhar Siricilla, Nick Vaccaro, Balaji Manigandan, Krishna P Bhat D. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58679 ) Change subject: util/spd_tools: Add LP5 support for ADL ...................................................................... Patch Set 5: (1 comment) File util/spd_tools/src/spd_gen/lp5.go: https://review.coreboot.org/c/coreboot/+/58679/comment/8a8cc9b2_81867801 PS5, Line 18: DensityPerDieGb int Does LP5 support only one channel always? -- To view, visit https://review.coreboot.org/c/coreboot/+/58679 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic1e68d44f7c0ad64aa9904b7e1297d24bd5db56e Gerrit-Change-Number: 58679 Gerrit-PatchSet: 5 Gerrit-Owner: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org> Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Attention: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Comment-Date: Tue, 02 Nov 2021 00:21:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: arch/x86/Makefile: Align VGA_BIOS to 64 bytes when using AMD LPC SPI DMA
by Julius Werner (Code Review) 02 Nov '21

02 Nov '21

Attention is currently required from: Raul Rangel, Furquan Shaikh, Paul Menzel, Angel Pons, Karthik Ramasubramanian. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56579 ) Change subject: arch/x86/Makefile: Align VGA_BIOS to 64 bytes when using AMD LPC SPI DMA ...................................................................... Patch Set 10: Code-Review+2 (1 comment) File src/arch/x86/Makefile.inc: https://review.coreboot.org/c/coreboot/+/56579/comment/ea53d488_469f4afd PS7, Line 47: ifeq ($(CONFIG_SOC_AMD_COMMON_BLOCK_LPC_SPI_DMA),y) > See the reply here: https://review.coreboot.org/c/coreboot/+/56579/3..7/src/arch/x86/Makefile. […] Ack -- To view, visit https://review.coreboot.org/c/coreboot/+/56579 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I842c85288acd8f7ac99b127c94b1cf235e264ea2 Gerrit-Change-Number: 56579 Gerrit-PatchSet: 10 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan.m.shaikh(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Furquan Shaikh <furquan.m.shaikh(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Tue, 02 Nov 2021 00:21:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Raul Rangel <rrangel(a)chromium.org> Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/spd_tools: Add LP5 support for ADL
by Karthik Ramasubramanian (Code Review) 02 Nov '21

02 Nov '21

Attention is currently required from: Reka Norman, Sridhar Siricilla, Nick Vaccaro, Balaji Manigandan, Krishna P Bhat D. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58679 ) Change subject: util/spd_tools: Add LP5 support for ADL ...................................................................... Patch Set 5: (1 comment) File util/spd_tools/src/spd_gen/lp5.go: https://review.coreboot.org/c/coreboot/+/58679/comment/ab815862_a3ef25e1 PS5, Line 221: TCKMinPs: Is this the clock period in the command & address clock(CK) or the data clock(WCK)? I believe it is the former based on your math. -- To view, visit https://review.coreboot.org/c/coreboot/+/58679 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic1e68d44f7c0ad64aa9904b7e1297d24bd5db56e Gerrit-Change-Number: 58679 Gerrit-PatchSet: 5 Gerrit-Owner: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org> Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Attention: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Comment-Date: Tue, 02 Nov 2021 00:18:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in edk2[coreboot-stable202108]: MdeModulePkg: load boot logo into BGRT table
by Matt DeVillier (Code Review) 02 Nov '21

02 Nov '21

Attention is currently required from: Matt DeVillier. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/edk2/+/58786 to look at the new patch set (#4). Change subject: MdeModulePkg: load boot logo into BGRT table ...................................................................... MdeModulePkg: load boot logo into BGRT table This is a shoehorned-in implementation of an ACPI BGRT table, ported pretty much directly from the version used under CorebootPayloadPkg, which itself was adapted from an older version of HackBGRT[1]. EDK2 provides a facility to do this already, but it assumes the ACPI tables already exist as EFI structures, so would need to write code to populate those using the tables already in RAM created by coreboot. This seemed like the easier option ATM. [1] https://github.com/Metabolix/HackBGRT Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> Change-Id: I726fd7a9deb9ba5f8e351ce24834fc627acc4542 --- M MdeModulePkg/Include/Library/BootLogoLib.h A MdeModulePkg/Library/BootLogoLib/Bgrt.c M MdeModulePkg/Library/BootLogoLib/BootLogoLib.inf M MdeModulePkg/MdeModulePkg.dec M UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManager.c M UefiPayloadPkg/UefiPayloadPkg.fdf 6 files changed, 313 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/edk2 refs/changes/86/58786/4 -- To view, visit https://review.coreboot.org/c/edk2/+/58786 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: edk2 Gerrit-Branch: coreboot-stable202108 Gerrit-Change-Id: I726fd7a9deb9ba5f8e351ce24834fc627acc4542 Gerrit-Change-Number: 58786 Gerrit-PatchSet: 4 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/trogdor: Add kingoftown to support Parade ps8640
by Julius Werner (Code Review) 02 Nov '21

02 Nov '21

Attention is currently required from: Kevin Chiu, Philip Chen, Douglas Anderson. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58789 ) Change subject: mb/google/trogdor: Add kingoftown to support Parade ps8640 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/58789 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie13ddfef6adfd53adb0a0d3a98995fb00b8a45e6 Gerrit-Change-Number: 58789 Gerrit-PatchSet: 1 Gerrit-Owner: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Reviewer: Douglas Anderson <dianders(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Philip Chen <philipchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Attention: Philip Chen <philipchen(a)google.com> Gerrit-Attention: Douglas Anderson <dianders(a)chromium.org> Gerrit-Comment-Date: Tue, 02 Nov 2021 00:16:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in edk2[coreboot-stable202108]: MdeModulePkg: load boot logo into BGRT table
by Matt DeVillier (Code Review) 02 Nov '21

02 Nov '21

Attention is currently required from: Matt DeVillier. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/edk2/+/58786 to look at the new patch set (#3). Change subject: MdeModulePkg: load boot logo into BGRT table ...................................................................... MdeModulePkg: load boot logo into BGRT table This is a shoehorned-in implementation of an ACPI BGRT table, ported pretty much directly from the version used under CorebootPayloadPkg, which itself was adapted from an older version of HackBGRT[1]. EDK2 provides a facility to do this already, but it assumes the ACPI tables already exist as EFI structures, so would need to write code to populate those using the tables already in RAM created by coreboot. This seemed like the easier option ATM. [1] https://github.com/Metabolix/HackBGRT Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> Change-Id: I726fd7a9deb9ba5f8e351ce24834fc627acc4542 --- M MdeModulePkg/Include/Library/BootLogoLib.h A MdeModulePkg/Library/BootLogoLib/Bgrt.c M MdeModulePkg/Library/BootLogoLib/BootLogoLib.inf M MdeModulePkg/MdeModulePkg.dec M UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManager.c M UefiPayloadPkg/UefiPayloadPkg.fdf 6 files changed, 311 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/edk2 refs/changes/86/58786/3 -- To view, visit https://review.coreboot.org/c/edk2/+/58786 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: edk2 Gerrit-Branch: coreboot-stable202108 Gerrit-Change-Id: I726fd7a9deb9ba5f8e351ce24834fc627acc4542 Gerrit-Change-Number: 58786 Gerrit-PatchSet: 3 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in edk2[coreboot-stable202108]: BmpSupportLib: fix BMP validation
by Matt DeVillier (Code Review) 02 Nov '21

02 Nov '21

Attention is currently required from: Matt DeVillier. Hello build bot (Jenkins), Patrick Georgi, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/edk2/+/58785 to look at the new patch set (#3). Change subject: BmpSupportLib: fix BMP validation ...................................................................... BmpSupportLib: fix BMP validation BMP files by tools other than MS paint can have a variable number of padding bytes, which results in the DataSize being less than (ImageSize - HeaderSize). Fix the check to be less stringent. Test: use BMP created by/saved by Photoshop Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> Change-Id: I97d2e90aef7043a28b3bdda2eab52cb19e086930 --- M MdeModulePkg/Library/BaseBmpSupportLib/BmpSupportLib.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/edk2 refs/changes/85/58785/3 -- To view, visit https://review.coreboot.org/c/edk2/+/58785 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: edk2 Gerrit-Branch: coreboot-stable202108 Gerrit-Change-Id: I97d2e90aef7043a28b3bdda2eab52cb19e086930 Gerrit-Change-Number: 58785 Gerrit-PatchSet: 3 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in edk2[coreboot-stable202108]: MdeModulePkg/BootLogoLib: Center logo 38.2% from top of screen
by Matt DeVillier (Code Review) 02 Nov '21

02 Nov '21

Attention is currently required from: Matt DeVillier. Hello build bot (Jenkins), Patrick Georgi, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/edk2/+/58784 to look at the new patch set (#3). Change subject: MdeModulePkg/BootLogoLib: Center logo 38.2% from top of screen ...................................................................... MdeModulePkg/BootLogoLib: Center logo 38.2% from top of screen Use Microsoft's recommended positioning [1] for the boot logo. > We recommend that the logo is placed with its center at 38.2% from the > screen's top edge. This positioning is based on the golden ratio's > visual aesthetics and matches the Windows 10 design proportions. [1]: https://docs.microsoft.com/en-us/windows-hardware/drivers/bringup/boot-scre… Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> Change-Id: Ia357e59626dc8bec0827763e803ac0c8939f0acf --- M MdeModulePkg/Library/BootLogoLib/BootLogoLib.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/edk2 refs/changes/84/58784/3 -- To view, visit https://review.coreboot.org/c/edk2/+/58784 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: edk2 Gerrit-Branch: coreboot-stable202108 Gerrit-Change-Id: Ia357e59626dc8bec0827763e803ac0c8939f0acf Gerrit-Change-Number: 58784 Gerrit-PatchSet: 3 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Tim Crawford <tcrawford(a)system76.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in edk2[coreboot-stable202108]: MdeModulePkg: Use coreboot logo as boot splash
by Matt DeVillier (Code Review) 02 Nov '21

02 Nov '21

Attention is currently required from: Matt DeVillier. Hello build bot (Jenkins), Patrick Georgi, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/edk2/+/58783 to look at the new patch set (#3). Change subject: MdeModulePkg: Use coreboot logo as boot splash ...................................................................... MdeModulePkg: Use coreboot logo as boot splash Use coreboot logo vs edk2 logo as default boot splash. Can be overriden by user selection via coreboot Kconfig. Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> Change-Id: Icf3c61938ae9aeec55889c969bcbc4b3e943a870 --- M MdeModulePkg/Logo/Logo.bmp 1 file changed, 0 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/edk2 refs/changes/83/58783/3 -- To view, visit https://review.coreboot.org/c/edk2/+/58783 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: edk2 Gerrit-Branch: coreboot-stable202108 Gerrit-Change-Id: Icf3c61938ae9aeec55889c969bcbc4b3e943a870 Gerrit-Change-Number: 58783 Gerrit-PatchSet: 3 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: google/trogdor: Add backlight support for Parade ps8640
by Julius Werner (Code Review) 02 Nov '21

02 Nov '21

Attention is currently required from: Philip Chen, Douglas Anderson, Xuxin Xiong. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58624 ) Change subject: google/trogdor: Add backlight support for Parade ps8640 ...................................................................... Patch Set 8: Code-Review+2 (1 comment) File src/drivers/parade/ps8640/ps8640.c: https://review.coreboot.org/c/coreboot/+/58624/comment/02c92b16_069f894f PS7, Line 159: } > For with ps8640 bridge, we didn't need to operate more than 16 bytes, so we didn't test this. […] Hmmm... yeah, you're right. Strange. I don't really understand how that works. Okay, better not touch it. -- To view, visit https://review.coreboot.org/c/coreboot/+/58624 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ief1bf56c89c8215427dcbddfc67e8bcd4c3607d2 Gerrit-Change-Number: 58624 Gerrit-PatchSet: 8 Gerrit-Owner: Xuxin Xiong <xuxinxiong(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Douglas Anderson <dianders(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Philip Chen <philipchen(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Philip Chen <philipchen(a)google.com> Gerrit-Attention: Philip Chen <philipchen(a)google.com> Gerrit-Attention: Douglas Anderson <dianders(a)chromium.org> Gerrit-Attention: Philip Chen <philipchen(a)chromium.org> Gerrit-Attention: Xuxin Xiong <xuxinxiong(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Tue, 02 Nov 2021 00:16:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Comment-In-Reply-To: Xuxin Xiong <xuxinxiong(a)huaqin.corp-partner.google.com> Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2021