coreboot-gerrit November 2021

coreboot-gerrit@coreboot.org

1 participants
6394 discussions

Change in coreboot[master]: device/pci_rom: Add vga_oprom_preload
by Julius Werner (Code Review) 02 Nov '21

02 Nov '21

Attention is currently required from: Raul Rangel, Furquan Shaikh, Karthik Ramasubramanian. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56581 ) Change subject: device/pci_rom: Add vga_oprom_preload ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/56581 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icb54fe3a942e9507ff6f1173ba5620a8f4ce6549 Gerrit-Change-Number: 56581 Gerrit-PatchSet: 5 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan.m.shaikh(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Furquan Shaikh <furquan.m.shaikh(a)gmail.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Tue, 02 Nov 2021 01:40:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: lib/cbfs: Add cbfs_preload()
by Julius Werner (Code Review) 02 Nov '21

02 Nov '21

Attention is currently required from: Jason Glenesk, Raul Rangel, Furquan Shaikh, Marshall Dawson, Karthik Ramasubramanian, Felix Held. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56491 ) Change subject: lib/cbfs: Add cbfs_preload() ...................................................................... Patch Set 11: Code-Review+2 (3 comments) Patchset: PS11: LGTM after one nit File src/lib/Kconfig: https://review.coreboot.org/c/coreboot/+/56491/comment/b3dbae96_aff6a5ff PS7, Line 108: config CBFS_PRELOAD > The reason I want the Kconfig is that `cbfs_preload` should only try to preload the file when SOC_AM […] Well, it shouldn't really make a practical difference if the controller uses PIO, it'll just not give you a speed-up. The order in which threads are processed is not meant to be predictable anyway. If spending all the time on SPI read first would cause actual issues, that's a problem with the design in general. But I guess it still makes sense to save all the overhead in those cases, so okay, let's have a Kconfig. File src/lib/cbfs.c: https://review.coreboot.org/c/coreboot/+/56491/comment/722bebdc_fcabbcbc PS11, Line 511: cbfs_unmap(rdev_mmap_full(&rdev)); Rather than duplicating everything in the error path I think it would be better to just merge them, e.g. void *loc = NULL; ...<if anything goes wrong just `goto out`>... if (!size) loc = NULL; out: if (preload_successful) cbfs_unmap(...); return loc; -- To view, visit https://review.coreboot.org/c/coreboot/+/56491 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I879fc1316f97417a4b82483d353abdbd02b98a31 Gerrit-Change-Number: 56491 Gerrit-PatchSet: 11 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Furquan Shaikh <furquan.m.shaikh(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Furquan Shaikh <furquan.m.shaikh(a)gmail.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 02 Nov 2021 01:35:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Raul Rangel <rrangel(a)chromium.org> Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: lib/list: Add list_append
by Julius Werner (Code Review) 02 Nov '21

02 Nov '21

Attention is currently required from: Raul Rangel, Jakub Czapiga, Karthik Ramasubramanian. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58805 ) Change subject: lib/list: Add list_append ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: I mean, there's nothing wrong with adding this, but why not just add new elements in your cbfs_preload use case to the front of the list (with list_insert_after(&list_head))? Should come out to roughly the same in the end. -- To view, visit https://review.coreboot.org/c/coreboot/+/58805 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1792e40f789e3ef16ceca65ce4cae946e08583d1 Gerrit-Change-Number: 58805 Gerrit-PatchSet: 1 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Tue, 02 Nov 2021 01:09:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: vc/amd/agesa: fix out-of-bounds read
by Jason Nein (Code Review) 02 Nov '21

02 Nov '21

Attention is currently required from: Bao Zheng, Jason Glenesk, Marshall Dawson, Matt Papageorge, Felix Held. Jason Nein has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58803 ) Change subject: vc/amd/agesa: fix out-of-bounds read ...................................................................... Patch Set 3: (5 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/58803/comment/ea9546b6_858c9069 PS1, Line 7: src/vendorcode/amd : Zork, MI: Bug in AGESA FabricResourceManagerUnbLib.c > coreboot has a couple of references for how to write a good commit message although none are really […] Done https://review.coreboot.org/c/coreboot/+/58803/comment/64d4bf99_89d3186b PS1, Line 9: Fixing coverity issues: Out-of-bounds read > Make sure you use complete sentences and that your verbs are imperative, e.g. […] Done https://review.coreboot.org/c/coreboot/+/58803/comment/63d6daf5_191cc73a PS1, Line 11: BUG=b:147411796 > This doesn't really apply for Trinity and Kabini changes. You could omit it. Done https://review.coreboot.org/c/coreboot/+/58803/comment/c6f42925_1897ae77 PS1, Line 12: Build pass and run the normal boot on Guybrush > Guybrush doesn't use this code. […] Done File src/vendorcode/amd/agesa/f15tn/Proc/CPU/Family/0x15/cpuF15MmioMap.c: https://review.coreboot.org/c/coreboot/+/58803/comment/94520295_1febd711 PS1, Line 232: 12 > Is there a defined value somewhere that can be used instead of 12? Done -- To view, visit https://review.coreboot.org/c/coreboot/+/58803 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I01e134cb6b025bf7cb5030cd9378297d7f6df509 Gerrit-Change-Number: 58803 Gerrit-PatchSet: 3 Gerrit-Owner: Jason Nein <finaljason(a)gmail.com> Gerrit-Reviewer: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Matt Papageorge <matthewpapa07(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Matt Papageorge <matthewpapa07(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 02 Nov 2021 00:56:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/trogdor: Add kingoftown to support Parade ps8640
by Philip Chen (Code Review) 02 Nov '21

02 Nov '21

Attention is currently required from: Kevin Chiu, Douglas Anderson. Philip Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58789 ) Change subject: mb/google/trogdor: Add kingoftown to support Parade ps8640 ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: LGTM, but please address Paul's concern. -- To view, visit https://review.coreboot.org/c/coreboot/+/58789 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie13ddfef6adfd53adb0a0d3a98995fb00b8a45e6 Gerrit-Change-Number: 58789 Gerrit-PatchSet: 1 Gerrit-Owner: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Reviewer: Douglas Anderson <dianders(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Philip Chen <philipchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Attention: Douglas Anderson <dianders(a)chromium.org> Gerrit-Comment-Date: Tue, 02 Nov 2021 00:45:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/trogdor: Add kingoftown to support Parade ps8640
by Philip Chen (Code Review) 02 Nov '21

02 Nov '21

Attention is currently required from: Kevin Chiu, Douglas Anderson. Philip Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58789 ) Change subject: mb/google/trogdor: Add kingoftown to support Parade ps8640 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/58789 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie13ddfef6adfd53adb0a0d3a98995fb00b8a45e6 Gerrit-Change-Number: 58789 Gerrit-PatchSet: 1 Gerrit-Owner: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Reviewer: Douglas Anderson <dianders(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Philip Chen <philipchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Attention: Douglas Anderson <dianders(a)chromium.org> Gerrit-Comment-Date: Tue, 02 Nov 2021 00:40:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: lib: Add lib.c to all stages
by Julius Werner (Code Review) 02 Nov '21

02 Nov '21

Attention is currently required from: Raul Rangel, Karthik Ramasubramanian. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58804 ) Change subject: lib: Add lib.c to all stages ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/58804/comment/a96a77be_1d5a5ad7 PS1, Line 7: lib typo -- To view, visit https://review.coreboot.org/c/coreboot/+/58804 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0713ae766c0ac9e43de702690ad0ba961d636d18 Gerrit-Change-Number: 58804 Gerrit-PatchSet: 1 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Tue, 02 Nov 2021 00:35:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: lib/cbfs: Add CBFS_CACHE_ALIGN Kconfig option
by Julius Werner (Code Review) 02 Nov '21

02 Nov '21

Attention is currently required from: Raul Rangel. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58706 ) Change subject: lib/cbfs: Add CBFS_CACHE_ALIGN Kconfig option ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/58706 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I74598d4bcbca9a01cc8c65012d7e4ae341d052b1 Gerrit-Change-Number: 58706 Gerrit-PatchSet: 6 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Comment-Date: Tue, 02 Nov 2021 00:35:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/amd/common/block/lpc: Set CBFS_CACHE_ALIGN to 64 when using SPI DMA
by Julius Werner (Code Review) 02 Nov '21

02 Nov '21

Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Felix Held. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58707 ) Change subject: soc/amd/common/block/lpc: Set CBFS_CACHE_ALIGN to 64 when using SPI DMA ...................................................................... Patch Set 7: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/58707 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I228372ff19f958c8e9cf5e51dcc3d37d9f92abec Gerrit-Change-Number: 58707 Gerrit-PatchSet: 7 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 02 Nov 2021 00:34:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: commonlib/mem_pool: Allow configuring the alignment
by Julius Werner (Code Review) 02 Nov '21

02 Nov '21

Attention is currently required from: Raul Rangel, Furquan Shaikh, Angel Pons, Karthik Ramasubramanian. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56580 ) Change subject: commonlib/mem_pool: Allow configuring the alignment ...................................................................... Patch Set 9: Code-Review+2 (2 comments) File src/commonlib/include/commonlib/mem_pool.h: https://review.coreboot.org/c/coreboot/+/56580/comment/b78cf124_7fc49b86 PS7, Line 59: mp->alignment = alignment; > assert is a coreboot thing isn't it? No, I'd say it's a libc thing and you can expect it to be available here (from <assert.h>). We have other assert()s in commonlib already. https://review.coreboot.org/c/coreboot/+/56580/comment/db6d0287_3c649fe4 PS7, Line 65: 0 > Done. I just added a parameter and updated the callers. commonlib isn't really meant to be used by out-of-tree sources, I don't think you need to care about that. It's just for sharing code between coreboot, all the stuff in the util/ directory, and hopefully soon libpayload. -- To view, visit https://review.coreboot.org/c/coreboot/+/56580 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8d77ffe4411f86c54450305320c9f52ab41a3075 Gerrit-Change-Number: 56580 Gerrit-PatchSet: 9 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan.m.shaikh(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Furquan Shaikh <furquan.m.shaikh(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Tue, 02 Nov 2021 00:33:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Raul Rangel <rrangel(a)chromium.org> Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2021