Thomas Heijligen has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/32191 )
Change subject: [WIP] Client5: copy coffeelake_rvp to siemens_field_pg_m6
......................................................................
Abandoned
--
To view, visit https://review.coreboot.org/c/coreboot/+/32191
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3d7d5b0b8626e6c85574bcbdcb6a89a1d2374f24
Gerrit-Change-Number: 32191
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-MessageType: abandon
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29470 )
Change subject: mainboard/portwell/m107: Do initial mainboard commit
......................................................................
Patch Set 16: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/29470
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7d3173fdcf881f894a75cd9798ba173b425d4e62
Gerrit-Change-Number: 29470
Gerrit-PatchSet: 16
Gerrit-Owner: Frans Hendriks <fhendriks(a)eltan.com>
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Tue, 09 Jul 2019 10:10:46 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Frank Chu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33954 )
Change subject: mb/google/hatch/variants: Fix nonworking touch pad
......................................................................
Patch Set 7:
> Patch Set 5:
>
> > Patch Set 5:
> >
> > > Patch Set 5:
> > >
> > > > Patch Set 5:
> > > >
> > > > (1 comment)
> > >
> > > Correct the CL link .
> > > https://review.coreboot.org/c/coreboot/+/33820
> >
> > That change affects the overridetree for hatch only. You still need to update override tree for helios here.
>
> Ping. Any update on this?
ok,I have update related GPP_A21 to helios tree
--
To view, visit https://review.coreboot.org/c/coreboot/+/33954
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I60816a4652fa39ab2a91034b268efe8f84a13e17
Gerrit-Change-Number: 33954
Gerrit-PatchSet: 7
Gerrit-Owner: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Paul Fagerburg <pfagerburg(a)chromium.org>
Gerrit-Reviewer: Philip Chen <philipchen(a)google.com>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Aamir Bohra <aamir.bohra(a)intel.com>
Gerrit-CC: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-CC: Kane Chen <kane_chen(a)pegatron.corp-partner.google.com>
Gerrit-CC: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Comment-Date: Tue, 09 Jul 2019 09:09:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Frank Chu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33826 )
Change subject: mb/google/hatch/variants/helios: Update GPIO table for proto stage
......................................................................
Patch Set 6:
> Patch Set 3:
>
> (4 comments)
it's done,remove GPP_C11 and GPP_D9
--
To view, visit https://review.coreboot.org/c/coreboot/+/33826
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I257a90a97e11651cdf5f85ca743e530ef5e61e56
Gerrit-Change-Number: 33826
Gerrit-PatchSet: 6
Gerrit-Owner: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Paul Fagerburg <pfagerburg(a)chromium.org>
Gerrit-Reviewer: Philip Chen <philipchen(a)google.com>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Kane Chen <kane_chen(a)pegatron.corp-partner.google.com>
Gerrit-CC: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Comment-Date: Tue, 09 Jul 2019 08:45:38 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Hello Paul Fagerburg, Philip Chen, Tim Wawrzynczak, Shelley Chen, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33954
to look at the new patch set (#6).
Change subject: mb/google/hatch/variants: Fix nonworking touch pad
......................................................................
mb/google/hatch/variants: Fix nonworking touch pad
Modify GPP_A21 to interrupt and disable all GPIO PM config.
BUG=b:135507215
BRANCH=none
TEST=emerge-hatch coreboot chromeos-ec chromeos-bootimage
Signed-off-by: Frank_Chu <frank_chu(a)pegatron.corp-partner.google.com>
Change-Id: I60816a4652fa39ab2a91034b268efe8f84a13e17
---
M src/mainboard/google/hatch/variants/helios/gpio.c
M src/mainboard/google/hatch/variants/helios/overridetree.cb
2 files changed, 13 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/33954/6
--
To view, visit https://review.coreboot.org/c/coreboot/+/33954
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I60816a4652fa39ab2a91034b268efe8f84a13e17
Gerrit-Change-Number: 33954
Gerrit-PatchSet: 6
Gerrit-Owner: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Paul Fagerburg <pfagerburg(a)chromium.org>
Gerrit-Reviewer: Philip Chen <philipchen(a)google.com>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Aamir Bohra <aamir.bohra(a)intel.com>
Gerrit-CC: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-CC: Kane Chen <kane_chen(a)pegatron.corp-partner.google.com>
Gerrit-CC: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-MessageType: newpatchset
Frank Chu has restored this change. ( https://review.coreboot.org/c/coreboot/+/33954 )
Change subject: mb/google/hatch/variants: Fix nonworking touch pad
......................................................................
Restored
--
To view, visit https://review.coreboot.org/c/coreboot/+/33954
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I60816a4652fa39ab2a91034b268efe8f84a13e17
Gerrit-Change-Number: 33954
Gerrit-PatchSet: 5
Gerrit-Owner: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Paul Fagerburg <pfagerburg(a)chromium.org>
Gerrit-Reviewer: Philip Chen <philipchen(a)google.com>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Aamir Bohra <aamir.bohra(a)intel.com>
Gerrit-CC: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-CC: Kane Chen <kane_chen(a)pegatron.corp-partner.google.com>
Gerrit-CC: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-MessageType: restore