HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34440 )
Change subject: arch/x86: Fix naked reference to CONFIG_NO_CAR_GLOBAL_MIGRATION
......................................................................
arch/x86: Fix naked reference to CONFIG_NO_CAR_GLOBAL_MIGRATION
Found-by: util/lint/kconfig_lint
Change-Id: I43408ddd31d7da8fde3253c56053170e01a7fd22
Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr>
---
M src/arch/x86/car.ld
M src/arch/x86/include/arch/early_variables.h
2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/34440/1
diff --git a/src/arch/x86/car.ld b/src/arch/x86/car.ld
index 5802b02..ab03da4 100644
--- a/src/arch/x86/car.ld
+++ b/src/arch/x86/car.ld
@@ -84,7 +84,7 @@
*(.sbss.*)
#else
/* .car.global_data objects only around when
- * !CONFIG_NO_CAR_GLOBAL_MIGRATION is employed. */
+ * !CONFIG(NO_CAR_GLOBAL_MIGRATION) is true. */
*(.car.global_data);
#endif
. = ALIGN(ARCH_POINTER_ALIGN_SIZE);
diff --git a/src/arch/x86/include/arch/early_variables.h b/src/arch/x86/include/arch/early_variables.h
index a69c230..ca343e7 100644
--- a/src/arch/x86/include/arch/early_variables.h
+++ b/src/arch/x86/include/arch/early_variables.h
@@ -83,7 +83,7 @@
/*
* We might end up here if:
* 1. ENV_CACHE_AS_RAM is not set for the stage or
- * 2. ENV_CACHE_AS_RAM is set for the stage but CONFIG_NO_CAR_GLOBAL_MIGRATION
+ * 2. ENV_CACHE_AS_RAM is set for the stage but CONFIG(NO_CAR_GLOBAL_MIGRATION) is true
* is also set. In this case, there is no need to migrate CAR global
* variables. But, since we might still be running out of CAR, car_active needs
* to return 1 if ENV_CACHE_AS_RAM is set.
--
To view, visit https://review.coreboot.org/c/coreboot/+/34440
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I43408ddd31d7da8fde3253c56053170e01a7fd22
Gerrit-Change-Number: 34440
Gerrit-PatchSet: 1
Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-MessageType: newchange
HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34439 )
Change subject: device: Fix naked reference to CONFIG_DEBUG_RAM_SETUP
......................................................................
device: Fix naked reference to CONFIG_DEBUG_RAM_SETUP
Found-by: util/lint/kconfig_lint
Change-Id: I360c4f563c2aa2acc740eac6c4e0145bda18edb7
Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr>
---
M src/device/dram/ddr2.c
M src/device/dram/ddr3.c
M src/include/device/dram/common.h
M src/include/device/dram/ddr3.h
4 files changed, 8 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/34439/1
diff --git a/src/device/dram/ddr2.c b/src/device/dram/ddr2.c
index 60588b8..eec2d74 100644
--- a/src/device/dram/ddr2.c
+++ b/src/device/dram/ddr2.c
@@ -668,8 +668,8 @@
/**
* \brief Print the info in DIMM
*
-* Print info about the DIMM. Useful to use when CONFIG_DEBUG_RAM_SETUP is
-* selected, or for a purely informative output.
+* Print info about the DIMM. Useful to use when CONFIG(DEBUG_RAM_SETUP) is
+* true, or for a purely informative output.
*
* @param dimm pointer to already decoded @ref dimm_attr structure
*/
diff --git a/src/device/dram/ddr3.c b/src/device/dram/ddr3.c
index 834dc83..8d79710 100644
--- a/src/device/dram/ddr3.c
+++ b/src/device/dram/ddr3.c
@@ -624,8 +624,8 @@
/**
* \brief Print the info in DIMM
*
-* Print info about the DIMM. Useful to use when CONFIG_DEBUG_RAM_SETUP is
-* selected, or for a purely informative output.
+* Print info about the DIMM. Useful to use when CONFIG(DEBUG_RAM_SETUP) is
+* true, or for a purely informative output.
*
* @param dimm pointer to already decoded @ref dimm_attr structure
*/
diff --git a/src/include/device/dram/common.h b/src/include/device/dram/common.h
index b1677c8..7be58ab 100644
--- a/src/include/device/dram/common.h
+++ b/src/include/device/dram/common.h
@@ -45,10 +45,10 @@
/** @} */
/**
- * \brief Convenience macro for enabling printk with CONFIG_DEBUG_RAM_SETUP
+ * \brief Convenience macro for enabling printk with CONFIG(DEBUG_RAM_SETUP)
*
* Use this macro instead of printk(); for verbose RAM initialization messages.
- * When CONFIG_DEBUG_RAM_SETUP is not selected, these messages are automatically
+ * When CONFIG(DEBUG_RAM_SETUP) is not selected, these messages are automatically
* disabled.
* @{
*/
diff --git a/src/include/device/dram/ddr3.h b/src/include/device/dram/ddr3.h
index 0f9373e..19bce96 100644
--- a/src/include/device/dram/ddr3.h
+++ b/src/include/device/dram/ddr3.h
@@ -49,10 +49,10 @@
/** @} */
/**
- * \brief Convenience macro for enabling printk with CONFIG_DEBUG_RAM_SETUP
+ * \brief Convenience macro for enabling printk with CONFIG(DEBUG_RAM_SETUP)
*
* Use this macro instead of printk(); for verbose RAM initialization messages.
- * When CONFIG_DEBUG_RAM_SETUP is not selected, these messages are automatically
+ * When CONFIG(DEBUG_RAM_SETUP) is false, these messages are automatically
* disabled.
* @{
*/
--
To view, visit https://review.coreboot.org/c/coreboot/+/34439
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I360c4f563c2aa2acc740eac6c4e0145bda18edb7
Gerrit-Change-Number: 34439
Gerrit-PatchSet: 1
Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-MessageType: newchange