coreboot-gerrit August 2018

coreboot-gerrit@coreboot.org

1 participants
1120 discussions

Change in coreboot[master]: google/grunt: Reset BayHub EMMC freq to SD base CLK 50MHz
by Kevin Chiu (Code Review) 27 Aug '18

27 Aug '18

Kevin Chiu has uploaded this change for review. ( https://review.coreboot.org/28353 Change subject: google/grunt: Reset BayHub EMMC freq to SD base CLK 50MHz ...................................................................... google/grunt: Reset BayHub EMMC freq to SD base CLK 50MHz Bayhub eMMC controller default runs SD base 50MHz at the first power on. After boot into OS, mmc kernel driver will config controller to HS200/208MHz and send MMC CMD21 (tuning block). But Bayhub PCR register 0x3E4[22] (eMMC MODE select) is not clear after system warn reset. So eMMC will still run 208Mhz but there is no block tuning cmd in depthcharge. It will cause two Sandisk eMMC (SDINBDA4-64G-V/SDINBDA4-32G-V) failing to load kernel and trap in 0x5B error (No bootable kernel found on disk). BUG=b:111964336 BRANCH=master TEST=emerge-grunt coreboot Change-Id: Ic080682e67323577c7f0ba4ed08f8adafca620cc Signed-off-by: Kevin Chiu <Kevin.Chiu(a)quantatw.com> --- M src/drivers/generic/bayhub/bh720.c M src/drivers/generic/bayhub/bh720.h M src/mainboard/google/kahlee/variants/baseboard/mainboard.c 3 files changed, 43 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/28353/1 diff --git a/src/drivers/generic/bayhub/bh720.c b/src/drivers/generic/bayhub/bh720.c index b689b67..0441683 100644 --- a/src/drivers/generic/bayhub/bh720.c +++ b/src/drivers/generic/bayhub/bh720.c @@ -23,7 +23,7 @@ #include "chip.h" #include "bh720.h" -__attribute__((weak)) void bh720_driving_strength(struct device *dev) +__attribute__((weak)) void board_bh720(struct device *dev) { } @@ -55,7 +55,7 @@ pci_read_config32(dev, BH720_LINK_CTRL)); } - bh720_driving_strength(dev); + board_bh720(dev); } static struct pci_operations pci_ops = { diff --git a/src/drivers/generic/bayhub/bh720.h b/src/drivers/generic/bayhub/bh720.h index b6fd273..3a4b3b6 100644 --- a/src/drivers/generic/bayhub/bh720.h +++ b/src/drivers/generic/bayhub/bh720.h @@ -35,13 +35,20 @@ BH720_MEM_RW_DATA = 0x200, BH720_MEM_RW_ADR = 0x204, + BH720_MEM_RW_READ = BIT(30), + BH720_MEM_RW_WRITE = BIT(31), BH720_MEM_ACCESS_EN = 0x208, - BH720_PCR = 0x304, + BH720_PCR_DrvStrength_PLL = 0x304, BH720_PCR_DATA_CMD_DRV_MAX = 7, BH720_PCR_CLK_DRV_MAX = 7, + BH720_PCR_EMMC_SETTING = 0x308, + BH720_PCR_EMMC_SETTING_1_8V = BIT(4), BH720_RTD3_L1 = 0x3e0, BH720_RTD3_L1_DISABLE_L1 = BIT(28), + + BH720_PCR_CSR = 0x3e4, + BH720_PCR_CSR_EMMC_MODE_SEL = BIT(22), }; -void bh720_driving_strength(struct device *dev); +void board_bh720(struct device *dev); diff --git a/src/mainboard/google/kahlee/variants/baseboard/mainboard.c b/src/mainboard/google/kahlee/variants/baseboard/mainboard.c index cf38b99..252829e 100644 --- a/src/mainboard/google/kahlee/variants/baseboard/mainboard.c +++ b/src/mainboard/google/kahlee/variants/baseboard/mainboard.c @@ -17,6 +17,8 @@ #include <baseboard/variants.h> #include <gpio.h> #include <variant/gpio.h> +#include <device/pci.h> +#include <drivers/generic/bayhub/bh720.h> uint8_t variant_board_sku(void) { @@ -35,3 +37,33 @@ gpio_set(GPIO_133, 0); } #endif + +void board_bh720(struct device *dev) +{ + u32 sdbar; + u32 bh720_pcr_data; + + sdbar = pci_read_config32(dev, PCI_BASE_ADDRESS_1); + + /* Enable Memory Access Function */ + write32((void *)(sdbar + BH720_MEM_ACCESS_EN), 0x40000000); + write32((void *)(sdbar + BH720_MEM_RW_DATA), 0x80000000); + write32((void *)(sdbar + BH720_MEM_RW_ADR), 0x800000D0); + + // Set EMMC VCCQ 1.8V PCR 0x308[4] + write32((void *)(sdbar + BH720_MEM_RW_ADR), BH720_MEM_RW_READ | BH720_PCR_EMMC_SETTING); + bh720_pcr_data = read32((void *)(sdbar + BH720_MEM_RW_DATA)); + write32((void *)(sdbar + BH720_MEM_RW_DATA), bh720_pcr_data | BH720_PCR_EMMC_SETTING_1_8V); + write32((void *)(sdbar + BH720_MEM_RW_ADR), BH720_MEM_RW_WRITE | BH720_PCR_EMMC_SETTING); + + // Set Bayhub SD base CLK 50MHz: case#1 PCR 0x3E4[22] = 0 + write32((void *)(sdbar + BH720_MEM_RW_ADR), BH720_MEM_RW_READ | BH720_PCR_CSR); + bh720_pcr_data = read32((void *)(sdbar + BH720_MEM_RW_DATA)); + write32((void *)(sdbar + BH720_MEM_RW_DATA), bh720_pcr_data & ~BH720_PCR_CSR_EMMC_MODE_SEL); + write32((void *)(sdbar + BH720_MEM_RW_ADR), BH720_MEM_RW_WRITE | BH720_PCR_CSR); + + /* Disable Memroy Access */ + write32((void *)(sdbar + BH720_MEM_RW_DATA), 0x80000001); + write32((void *)(sdbar + BH720_MEM_RW_ADR), 0x800000D0); + write32((void *)(sdbar + BH720_MEM_ACCESS_EN), 0x80000000); +} -- To view, visit https://review.coreboot.org/28353 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ic080682e67323577c7f0ba4ed08f8adafca620cc Gerrit-Change-Number: 28353 Gerrit-PatchSet: 1 Gerrit-Owner: Kevin Chiu <Kevin.Chiu(a)quantatw.com>

1 0

Change in coreboot[master]: mb/google/octopus: add Digitizer and Synaptics Touchpad for bobba
by Furquan Shaikh (Code Review) 27 Aug '18

27 Aug '18

Furquan Shaikh has submitted this change and it was merged. ( https://review.coreboot.org/28332 ) Change subject: mb/google/octopus: add Digitizer and Synaptics Touchpad for bobba ...................................................................... mb/google/octopus: add Digitizer and Synaptics Touchpad for bobba add device "WCOM Digitizer" and "Synaptics Touchpad" for bobba BUG=none BRANCH=master TEST=emerge-octopus coreboot Change-Id: Ie0bf8ebab6d9cb9c8fe42a500efaa3d11ae359db Signed-off-by: Pan Sheng-Liang <sheng-liang.pan(a)quanta.corp-partner.google.com> Reviewed-on: https://review.coreboot.org/28332 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Justin TerAvest <teravest(a)chromium.org> Reviewed-by: Furquan Shaikh <furquan(a)google.com> --- M src/mainboard/google/octopus/variants/bobba/overridetree.cb 1 file changed, 20 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved Justin TerAvest: Looks good to me, approved Sheng-Liang Pan: Looks good to me, but someone else must approve diff --git a/src/mainboard/google/octopus/variants/bobba/overridetree.cb b/src/mainboard/google/octopus/variants/bobba/overridetree.cb index 6726b41..acb1d50 100644 --- a/src/mainboard/google/octopus/variants/bobba/overridetree.cb +++ b/src/mainboard/google/octopus/variants/bobba/overridetree.cb @@ -1,6 +1,17 @@ chip soc/intel/apollolake device domain 0 on + device pci 16.0 on + chip drivers/i2c/hid + register "generic.hid" = ""WCOM50C1"" + register "generic.desc" = ""WCOM Digitizer"" + register "generic.irq" = "ACPI_IRQ_LEVEL_LOW(GPIO_139_IRQ)" + register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_140)" + register "generic.has_power_resource" = "1" + register "hid_desc_reg_offset" = "0x1" + device i2c 0x9 on end + end + end # - I2C 0 device pci 17.1 on chip drivers/i2c/da7219 register "irq" = "ACPI_IRQ_LEVEL_LOW(GPIO_137_IRQ)" @@ -29,6 +40,15 @@ register "probed" = "1" device i2c 15 on end end + chip drivers/i2c/hid + register "generic.hid" = ""PNP0C50"" + register "generic.desc" = ""Synaptics Touchpad"" + register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPIO_135_IRQ)" + register "generic.wake" = "GPE0_DW2_02" + register "generic.probed" = "1" + register "hid_desc_reg_offset" = "0x20" + device i2c 0x2c on end + end end # - I2C 6 device pci 17.3 on chip drivers/i2c/generic -- To view, visit https://review.coreboot.org/28332 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ie0bf8ebab6d9cb9c8fe42a500efaa3d11ae359db Gerrit-Change-Number: 28332 Gerrit-PatchSet: 2 Gerrit-Owner: Pan Sheng-Liang <sl.pan.quantw(a)gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Justin TerAvest <teravest(a)chromium.org> Gerrit-Reviewer: Sheng-Liang Pan <sheng-liang.pan(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: mb/google/octopus: add Digitizer and Synaptics Touchpad for bobba
by Sheng-Liang Pan (Code Review) 27 Aug '18

27 Aug '18

Sheng-Liang Pan has posted comments on this change. ( https://review.coreboot.org/28332 ) Change subject: mb/google/octopus: add Digitizer and Synaptics Touchpad for bobba ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/28332 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie0bf8ebab6d9cb9c8fe42a500efaa3d11ae359db Gerrit-Change-Number: 28332 Gerrit-PatchSet: 1 Gerrit-Owner: Pan Sheng-Liang <sl.pan.quantw(a)gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Justin TerAvest <teravest(a)chromium.org> Gerrit-Reviewer: Sheng-Liang Pan <sheng-liang.pan(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 27 Aug 2018 02:29:47 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: drivers/intel/wifi: Make WIFI_SAR_CBFS user visible
by Furquan Shaikh (Code Review) 27 Aug '18

27 Aug '18

Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/28352 Change subject: drivers/intel/wifi: Make WIFI_SAR_CBFS user visible ...................................................................... drivers/intel/wifi: Make WIFI_SAR_CBFS user visible This change makes WIFI_SAR_CBFS user selectable option so that it can be enabled/disabled from menuconfig along with the SAR filepath. BUG=b:112425861 Change-Id: Idf6feaefe68e7ebf6786c2c36e92a054fba4483c Signed-off-by: Furquan Shaikh <furquan(a)google.com> --- M src/drivers/intel/wifi/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/28352/1 diff --git a/src/drivers/intel/wifi/Kconfig b/src/drivers/intel/wifi/Kconfig index 3cf0446..4dc4d7f 100644 --- a/src/drivers/intel/wifi/Kconfig +++ b/src/drivers/intel/wifi/Kconfig @@ -31,7 +31,7 @@ depends on USE_SAR config WIFI_SAR_CBFS - bool + bool "Enable SAR table addition to CBFS" default n depends on USE_SAR help -- To view, visit https://review.coreboot.org/28352 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Idf6feaefe68e7ebf6786c2c36e92a054fba4483c Gerrit-Change-Number: 28352 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com>

1 0

Change in coreboot[master]: mainboard/opencellular/elgon: Add mainboard support
by build bot (Jenkins) (Code Review) 27 Aug '18

27 Aug '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28024 ) Change subject: mainboard/opencellular/elgon: Add mainboard support ...................................................................... Patch Set 13: (25 comments) https://review.coreboot.org/#/c/28024/13/src/mainboard/opencellular/elgon/g… File src/mainboard/opencellular/elgon/gbcv2.dts: https://review.coreboot.org/#/c/28024/13/src/mainboard/opencellular/elgon/g… PS13, Line 215: reg = <0x8440 0xa0000 0x0 0x1000 0x8440 0xb0000 0x0 0x1000>; line over 80 characters https://review.coreboot.org/#/c/28024/13/src/mainboard/opencellular/elgon/g… PS13, Line 223: interrupts = <0x0 0x44 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4>; line over 80 characters https://review.coreboot.org/#/c/28024/13/src/mainboard/opencellular/elgon/g… PS13, Line 238: ranges = <0x3000000 0x8010 0x0 0x8010 0x0 0x80 0x0 0x3000000 0x8100 0x0 0x8100 0x0 0x80 0x0 0x3000000 0x8680 0x0 0x8680 0x0 0x160 0x28000000 0x3000000 0x87e0 0x2c000000 0x87e0 0x2c000000 0x0 0x94000000 0x3000000 0x8400 0x0 0x8400 0x0 0x10 0x0 0x3000000 0x8430 0x0 0x8430 0x0 0x2 0x0 0x3000000 0x87e0 0xc6000000 0x87e0 0xc6000000 0x1f 0x3a000000>; line over 80 characters https://review.coreboot.org/#/c/28024/13/src/mainboard/opencellular/elgon/g… PS13, Line 243: compatible = "pci-bridge", "cavium,thunder-8890-mrml-bridge"; line over 80 characters https://review.coreboot.org/#/c/28024/13/src/mainboard/opencellular/elgon/g… PS13, Line 246: ranges = <0x3000000 0x87e0 0x0 0x3000000 0x87e0 0x0 0x10 0x0>; line over 80 characters https://review.coreboot.org/#/c/28024/13/src/mainboard/opencellular/elgon/g… PS13, Line 251: compatible = "cavium,thunder-8890-mdio-nexus"; line over 80 characters https://review.coreboot.org/#/c/28024/13/src/mainboard/opencellular/elgon/g… PS13, Line 255: assigned-addresses = <0x3000000 0x87e0 0x5000000 0x0 0x800000>; line over 80 characters https://review.coreboot.org/#/c/28024/13/src/mainboard/opencellular/elgon/g… PS13, Line 256: ranges = <0x87e0 0x5000000 0x3000000 0x87e0 0x5000000 0x0 0x800000>; line over 80 characters https://review.coreboot.org/#/c/28024/13/src/mainboard/opencellular/elgon/g… PS13, Line 259: compatible = "cavium,thunder-8890-mdio"; line over 80 characters https://review.coreboot.org/#/c/28024/13/src/mainboard/opencellular/elgon/g… PS13, Line 262: reg = <0x87e0 0x5003800 0x0 0x30>; line over 80 characters https://review.coreboot.org/#/c/28024/13/src/mainboard/opencellular/elgon/g… PS13, Line 266: compatible = "cavium,thunder-8890-mdio"; line over 80 characters https://review.coreboot.org/#/c/28024/13/src/mainboard/opencellular/elgon/g… PS13, Line 269: reg = <0x87e0 0x5003880 0x0 0x30>; line over 80 characters https://review.coreboot.org/#/c/28024/13/src/mainboard/opencellular/elgon/g… PS13, Line 332: compatible = "infineon,slb9645tt"; line over 80 characters https://review.coreboot.org/#/c/28024/13/src/mainboard/opencellular/elgon/g… PS13, Line 345: local-mac-address = [00 00 00 00 00 00]; line over 80 characters https://review.coreboot.org/#/c/28024/13/src/mainboard/opencellular/elgon/g… PS13, Line 358: local-mac-address = [00 00 00 00 00 00]; line over 80 characters https://review.coreboot.org/#/c/28024/13/src/mainboard/opencellular/elgon/g… PS13, Line 379: compatible = "winbond,w25q128", "jedec,spi-nor"; line over 80 characters https://review.coreboot.org/#/c/28024/13/src/mainboard/opencellular/elgon/g… PS13, Line 415: reg = <0x8800 0x1f000000 0x0 0x39000000 0x87e0 0xc0000000 0x0 0x1000000>; line over 80 characters https://review.coreboot.org/#/c/28024/13/src/mainboard/opencellular/elgon/g… PS13, Line 416: ranges = <0x1000000 0x0 0x0 0x8830 0x0 0x0 0x10000 0x3000000 0x0 0x10000000 0x8810 0x10000000 0xf 0xf0000000 0x43000000 0x10 0x0 0x8820 0x0 0x10 0x0 0x3000000 0x87e0 0xc0000000 0x87e0 0xc0000000 0x0 0x1000000>; line over 80 characters https://review.coreboot.org/#/c/28024/13/src/mainboard/opencellular/elgon/g… PS13, Line 419: interrupt-map = <0x0 0x0 0x0 0x1 0x1 0x0 0x0 0x0 0x10 0x4 0x0 0x0 0x0 0x2 0x1 0x0 0x0 0x0 0x11 0x4 0x0 0x0 0x0 0x3 0x1 0x0 0x0 0x0 0x12 0x4 0x0 0x0 0x0 0x4 0x1 0x0 0x0 0x0 0x13 0x4>; line over 80 characters https://review.coreboot.org/#/c/28024/13/src/mainboard/opencellular/elgon/g… PS13, Line 434: reg = <0x8840 0x57000000 0x0 0x39000000 0x87e0 0xc1000000 0x0 0x1000000>; line over 80 characters https://review.coreboot.org/#/c/28024/13/src/mainboard/opencellular/elgon/g… PS13, Line 435: ranges = <0x1000000 0x0 0x10000 0x8870 0x10000 0x0 0x10000 0x3000000 0x0 0x10000000 0x8850 0x10000000 0xf 0xf0000000 0x43000000 0x10 0x0 0x8860 0x0 0x10 0x0 0x3000000 0x87e0 0xc1000000 0x87e0 0xc1000000 0x0 0x1000000>; line over 80 characters https://review.coreboot.org/#/c/28024/13/src/mainboard/opencellular/elgon/g… PS13, Line 438: interrupt-map = <0x0 0x0 0x0 0x1 0x1 0x0 0x0 0x0 0x14 0x4 0x0 0x0 0x0 0x2 0x1 0x0 0x0 0x0 0x15 0x4 0x0 0x0 0x0 0x3 0x1 0x0 0x0 0x0 0x16 0x4 0x0 0x0 0x0 0x4 0x1 0x0 0x0 0x0 0x17 0x4>; line over 80 characters https://review.coreboot.org/#/c/28024/13/src/mainboard/opencellular/elgon/g… PS13, Line 453: reg = <0x8880 0x8f000000 0x0 0x39000000 0x87e0 0xc2000000 0x0 0x1000000>; line over 80 characters https://review.coreboot.org/#/c/28024/13/src/mainboard/opencellular/elgon/g… PS13, Line 454: ranges = <0x1000000 0x0 0x20000 0x88b0 0x20000 0x0 0x10000 0x3000000 0x0 0x10000000 0x8890 0x10000000 0xf 0xf0000000 0x43000000 0x10 0x0 0x88a0 0x0 0x10 0x0 0x3000000 0x87e0 0xc2000000 0x87e0 0xc2000000 0x0 0x1000000>; line over 80 characters https://review.coreboot.org/#/c/28024/13/src/mainboard/opencellular/elgon/g… PS13, Line 457: interrupt-map = <0x0 0x0 0x0 0x1 0x1 0x0 0x0 0x0 0x18 0x4 0x0 0x0 0x0 0x2 0x1 0x0 0x0 0x0 0x19 0x4 0x0 0x0 0x0 0x3 0x1 0x0 0x0 0x0 0x1a 0x4 0x0 0x0 0x0 0x4 0x1 0x0 0x0 0x0 0x1b 0x4>; line over 80 characters -- To view, visit https://review.coreboot.org/28024 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9b809306cc48facbade5dc63846c4532b397e0b5 Gerrit-Change-Number: 28024 Gerrit-PatchSet: 13 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Mon, 27 Aug 2018 00:25:49 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mainboard/opencellular/elgon: Add mainboard support
by build bot (Jenkins) (Code Review) 26 Aug '18

26 Aug '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28024 ) Change subject: mainboard/opencellular/elgon: Add mainboard support ...................................................................... Patch Set 12: (25 comments) https://review.coreboot.org/#/c/28024/12/src/mainboard/opencellular/elgon/g… File src/mainboard/opencellular/elgon/gbcv2.dts: https://review.coreboot.org/#/c/28024/12/src/mainboard/opencellular/elgon/g… PS12, Line 215: reg = <0x8440 0xa0000 0x0 0x1000 0x8440 0xb0000 0x0 0x1000>; line over 80 characters https://review.coreboot.org/#/c/28024/12/src/mainboard/opencellular/elgon/g… PS12, Line 223: interrupts = <0x0 0x44 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4>; line over 80 characters https://review.coreboot.org/#/c/28024/12/src/mainboard/opencellular/elgon/g… PS12, Line 238: ranges = <0x3000000 0x8010 0x0 0x8010 0x0 0x80 0x0 0x3000000 0x8100 0x0 0x8100 0x0 0x80 0x0 0x3000000 0x8680 0x0 0x8680 0x0 0x160 0x28000000 0x3000000 0x87e0 0x2c000000 0x87e0 0x2c000000 0x0 0x94000000 0x3000000 0x8400 0x0 0x8400 0x0 0x10 0x0 0x3000000 0x8430 0x0 0x8430 0x0 0x2 0x0 0x3000000 0x87e0 0xc6000000 0x87e0 0xc6000000 0x1f 0x3a000000>; line over 80 characters https://review.coreboot.org/#/c/28024/12/src/mainboard/opencellular/elgon/g… PS12, Line 243: compatible = "pci-bridge", "cavium,thunder-8890-mrml-bridge"; line over 80 characters https://review.coreboot.org/#/c/28024/12/src/mainboard/opencellular/elgon/g… PS12, Line 246: ranges = <0x3000000 0x87e0 0x0 0x3000000 0x87e0 0x0 0x10 0x0>; line over 80 characters https://review.coreboot.org/#/c/28024/12/src/mainboard/opencellular/elgon/g… PS12, Line 251: compatible = "cavium,thunder-8890-mdio-nexus"; line over 80 characters https://review.coreboot.org/#/c/28024/12/src/mainboard/opencellular/elgon/g… PS12, Line 255: assigned-addresses = <0x3000000 0x87e0 0x5000000 0x0 0x800000>; line over 80 characters https://review.coreboot.org/#/c/28024/12/src/mainboard/opencellular/elgon/g… PS12, Line 256: ranges = <0x87e0 0x5000000 0x3000000 0x87e0 0x5000000 0x0 0x800000>; line over 80 characters https://review.coreboot.org/#/c/28024/12/src/mainboard/opencellular/elgon/g… PS12, Line 259: compatible = "cavium,thunder-8890-mdio"; line over 80 characters https://review.coreboot.org/#/c/28024/12/src/mainboard/opencellular/elgon/g… PS12, Line 262: reg = <0x87e0 0x5003800 0x0 0x30>; line over 80 characters https://review.coreboot.org/#/c/28024/12/src/mainboard/opencellular/elgon/g… PS12, Line 266: compatible = "cavium,thunder-8890-mdio"; line over 80 characters https://review.coreboot.org/#/c/28024/12/src/mainboard/opencellular/elgon/g… PS12, Line 269: reg = <0x87e0 0x5003880 0x0 0x30>; line over 80 characters https://review.coreboot.org/#/c/28024/12/src/mainboard/opencellular/elgon/g… PS12, Line 332: compatible = "infineon,slb9645tt"; line over 80 characters https://review.coreboot.org/#/c/28024/12/src/mainboard/opencellular/elgon/g… PS12, Line 345: local-mac-address = [00 00 00 00 00 00]; line over 80 characters https://review.coreboot.org/#/c/28024/12/src/mainboard/opencellular/elgon/g… PS12, Line 358: local-mac-address = [00 00 00 00 00 00]; line over 80 characters https://review.coreboot.org/#/c/28024/12/src/mainboard/opencellular/elgon/g… PS12, Line 379: compatible = "winbond,w25q128", "jedec,spi-nor"; line over 80 characters https://review.coreboot.org/#/c/28024/12/src/mainboard/opencellular/elgon/g… PS12, Line 415: reg = <0x8800 0x1f000000 0x0 0x39000000 0x87e0 0xc0000000 0x0 0x1000000>; line over 80 characters https://review.coreboot.org/#/c/28024/12/src/mainboard/opencellular/elgon/g… PS12, Line 416: ranges = <0x1000000 0x0 0x0 0x8830 0x0 0x0 0x10000 0x3000000 0x0 0x10000000 0x8810 0x10000000 0xf 0xf0000000 0x43000000 0x10 0x0 0x8820 0x0 0x10 0x0 0x3000000 0x87e0 0xc0000000 0x87e0 0xc0000000 0x0 0x1000000>; line over 80 characters https://review.coreboot.org/#/c/28024/12/src/mainboard/opencellular/elgon/g… PS12, Line 419: interrupt-map = <0x0 0x0 0x0 0x1 0x1 0x0 0x0 0x0 0x10 0x4 0x0 0x0 0x0 0x2 0x1 0x0 0x0 0x0 0x11 0x4 0x0 0x0 0x0 0x3 0x1 0x0 0x0 0x0 0x12 0x4 0x0 0x0 0x0 0x4 0x1 0x0 0x0 0x0 0x13 0x4>; line over 80 characters https://review.coreboot.org/#/c/28024/12/src/mainboard/opencellular/elgon/g… PS12, Line 434: reg = <0x8840 0x57000000 0x0 0x39000000 0x87e0 0xc1000000 0x0 0x1000000>; line over 80 characters https://review.coreboot.org/#/c/28024/12/src/mainboard/opencellular/elgon/g… PS12, Line 435: ranges = <0x1000000 0x0 0x10000 0x8870 0x10000 0x0 0x10000 0x3000000 0x0 0x10000000 0x8850 0x10000000 0xf 0xf0000000 0x43000000 0x10 0x0 0x8860 0x0 0x10 0x0 0x3000000 0x87e0 0xc1000000 0x87e0 0xc1000000 0x0 0x1000000>; line over 80 characters https://review.coreboot.org/#/c/28024/12/src/mainboard/opencellular/elgon/g… PS12, Line 438: interrupt-map = <0x0 0x0 0x0 0x1 0x1 0x0 0x0 0x0 0x14 0x4 0x0 0x0 0x0 0x2 0x1 0x0 0x0 0x0 0x15 0x4 0x0 0x0 0x0 0x3 0x1 0x0 0x0 0x0 0x16 0x4 0x0 0x0 0x0 0x4 0x1 0x0 0x0 0x0 0x17 0x4>; line over 80 characters https://review.coreboot.org/#/c/28024/12/src/mainboard/opencellular/elgon/g… PS12, Line 453: reg = <0x8880 0x8f000000 0x0 0x39000000 0x87e0 0xc2000000 0x0 0x1000000>; line over 80 characters https://review.coreboot.org/#/c/28024/12/src/mainboard/opencellular/elgon/g… PS12, Line 454: ranges = <0x1000000 0x0 0x20000 0x88b0 0x20000 0x0 0x10000 0x3000000 0x0 0x10000000 0x8890 0x10000000 0xf 0xf0000000 0x43000000 0x10 0x0 0x88a0 0x0 0x10 0x0 0x3000000 0x87e0 0xc2000000 0x87e0 0xc2000000 0x0 0x1000000>; line over 80 characters https://review.coreboot.org/#/c/28024/12/src/mainboard/opencellular/elgon/g… PS12, Line 457: interrupt-map = <0x0 0x0 0x0 0x1 0x1 0x0 0x0 0x0 0x18 0x4 0x0 0x0 0x0 0x2 0x1 0x0 0x0 0x0 0x19 0x4 0x0 0x0 0x0 0x3 0x1 0x0 0x0 0x0 0x1a 0x4 0x0 0x0 0x0 0x4 0x1 0x0 0x0 0x0 0x1b 0x4>; line over 80 characters -- To view, visit https://review.coreboot.org/28024 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9b809306cc48facbade5dc63846c4532b397e0b5 Gerrit-Change-Number: 28024 Gerrit-PatchSet: 12 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Sun, 26 Aug 2018 18:06:40 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: vendorcode/facebook: Add vendorcode
by Philipp Deppenwiese (Code Review) 26 Aug '18

26 Aug '18

Philipp Deppenwiese has uploaded this change for review. ( https://review.coreboot.org/28351 Change subject: vendorcode/facebook: Add vendorcode ...................................................................... vendorcode/facebook: Add vendorcode * Add Open Cellular extensions for TIVA communication and reset. Change-Id: I761ac3d1dcbab9dceb7a4c4f835ca8363680eb03 Signed-off-by: Philipp Deppenwiese <zaolin(a)das-labor.org> --- M src/vendorcode/Makefile.inc A src/vendorcode/facebook/Kconfig A src/vendorcode/facebook/Makefile.inc A src/vendorcode/facebook/opencellular/reset.c 4 files changed, 78 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/28351/1 diff --git a/src/vendorcode/Makefile.inc b/src/vendorcode/Makefile.inc index 522d415..c4dbb67 100644 --- a/src/vendorcode/Makefile.inc +++ b/src/vendorcode/Makefile.inc @@ -3,3 +3,4 @@ subdirs-y += intel subdirs-y += siemens subdirs-y += cavium +subdirs-y += facebook diff --git a/src/vendorcode/facebook/Kconfig b/src/vendorcode/facebook/Kconfig new file mode 100644 index 0000000..f512145 --- /dev/null +++ b/src/vendorcode/facebook/Kconfig @@ -0,0 +1,33 @@ +## +## This file is part of the coreboot project. +## +## Copyright 2018-present Facebook, Inc. +## +## This program is free software; you can redistribute it and/or modify +## it under the terms of the GNU General Public License as published by +## the Free Software Foundation; version 2 of the License. +## +## This program is distributed in the hope that it will be useful, +## but WITHOUT ANY WARRANTY; without even the implied warranty of +## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +## GNU General Public License for more details. +## + +config FACEBOOK_OPENCELLULAR + def_bool n + select HAVE_HARD_RESET + help + Build Facebook OC extensions + +if FACEBOOK_OPENCELLULAR + +menu "Open Celluar" + +config FACEBOOK_OPENCELLULAR_TIVA_RESET + bool "Enables TIVA hard reset feature" + default n + depends on FACEBOOK_OPENCELLULAR + +endmenu + +endif diff --git a/src/vendorcode/facebook/Makefile.inc b/src/vendorcode/facebook/Makefile.inc new file mode 100644 index 0000000..ec01240 --- /dev/null +++ b/src/vendorcode/facebook/Makefile.inc @@ -0,0 +1,22 @@ +## +## This file is part of the coreboot project. +## +## Copyright 2018-present Facebook, Inc. +## +## This program is free software; you can redistribute it and/or modify +## it under the terms of the GNU General Public License as published by +## the Free Software Foundation; version 2 of the License. +## +## This program is distributed in the hope that it will be useful, +## but WITHOUT ANY WARRANTY; without even the implied warranty of +## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +## GNU General Public License for more details. +## + +ifeq ($(CONFIG_FACEBOOK_OPENCELLULAR),y) + +verstage-$(CONFIG_FACEBOOK_OPENCELLULAR_TIVA_RESET) += opencellular/reset.c +romstage-$(CONFIG_FACEBOOK_OPENCELLULAR_TIVA_RESET) += opencellular/reset.c +ramstage-$(CONFIG_FACEBOOK_OPENCELLULAR_TIVA_RESET) += opencellular/reset.c + +endif diff --git a/src/vendorcode/facebook/opencellular/reset.c b/src/vendorcode/facebook/opencellular/reset.c new file mode 100644 index 0000000..fbba43c --- /dev/null +++ b/src/vendorcode/facebook/opencellular/reset.c @@ -0,0 +1,22 @@ +/* + * This file is part of the coreboot project. + * + * Copyright 2018-present Facebook, Inc. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * Derived from Cavium's BSD-3 Clause OCTEONTX-SDK-6.2.0. + */ + +#include <reset.h> + +void do_hard_reset(void) +{ +} -- To view, visit https://review.coreboot.org/28351 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I761ac3d1dcbab9dceb7a4c4f835ca8363680eb03 Gerrit-Change-Number: 28351 Gerrit-PatchSet: 1 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>

1 0

Change in coreboot[master]: mainboard/opencellular/elgon: Add mainboard support
by build bot (Jenkins) (Code Review) 26 Aug '18

26 Aug '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28024 ) Change subject: mainboard/opencellular/elgon: Add mainboard support ...................................................................... Patch Set 11: (25 comments) https://review.coreboot.org/#/c/28024/11/src/mainboard/opencellular/elgon/g… File src/mainboard/opencellular/elgon/gbcv2.dts: https://review.coreboot.org/#/c/28024/11/src/mainboard/opencellular/elgon/g… PS11, Line 215: reg = <0x8440 0xa0000 0x0 0x1000 0x8440 0xb0000 0x0 0x1000>; line over 80 characters https://review.coreboot.org/#/c/28024/11/src/mainboard/opencellular/elgon/g… PS11, Line 223: interrupts = <0x0 0x44 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4>; line over 80 characters https://review.coreboot.org/#/c/28024/11/src/mainboard/opencellular/elgon/g… PS11, Line 238: ranges = <0x3000000 0x8010 0x0 0x8010 0x0 0x80 0x0 0x3000000 0x8100 0x0 0x8100 0x0 0x80 0x0 0x3000000 0x8680 0x0 0x8680 0x0 0x160 0x28000000 0x3000000 0x87e0 0x2c000000 0x87e0 0x2c000000 0x0 0x94000000 0x3000000 0x8400 0x0 0x8400 0x0 0x10 0x0 0x3000000 0x8430 0x0 0x8430 0x0 0x2 0x0 0x3000000 0x87e0 0xc6000000 0x87e0 0xc6000000 0x1f 0x3a000000>; line over 80 characters https://review.coreboot.org/#/c/28024/11/src/mainboard/opencellular/elgon/g… PS11, Line 243: compatible = "pci-bridge", "cavium,thunder-8890-mrml-bridge"; line over 80 characters https://review.coreboot.org/#/c/28024/11/src/mainboard/opencellular/elgon/g… PS11, Line 246: ranges = <0x3000000 0x87e0 0x0 0x3000000 0x87e0 0x0 0x10 0x0>; line over 80 characters https://review.coreboot.org/#/c/28024/11/src/mainboard/opencellular/elgon/g… PS11, Line 251: compatible = "cavium,thunder-8890-mdio-nexus"; line over 80 characters https://review.coreboot.org/#/c/28024/11/src/mainboard/opencellular/elgon/g… PS11, Line 255: assigned-addresses = <0x3000000 0x87e0 0x5000000 0x0 0x800000>; line over 80 characters https://review.coreboot.org/#/c/28024/11/src/mainboard/opencellular/elgon/g… PS11, Line 256: ranges = <0x87e0 0x5000000 0x3000000 0x87e0 0x5000000 0x0 0x800000>; line over 80 characters https://review.coreboot.org/#/c/28024/11/src/mainboard/opencellular/elgon/g… PS11, Line 259: compatible = "cavium,thunder-8890-mdio"; line over 80 characters https://review.coreboot.org/#/c/28024/11/src/mainboard/opencellular/elgon/g… PS11, Line 262: reg = <0x87e0 0x5003800 0x0 0x30>; line over 80 characters https://review.coreboot.org/#/c/28024/11/src/mainboard/opencellular/elgon/g… PS11, Line 266: compatible = "cavium,thunder-8890-mdio"; line over 80 characters https://review.coreboot.org/#/c/28024/11/src/mainboard/opencellular/elgon/g… PS11, Line 269: reg = <0x87e0 0x5003880 0x0 0x30>; line over 80 characters https://review.coreboot.org/#/c/28024/11/src/mainboard/opencellular/elgon/g… PS11, Line 332: compatible = "infineon,slb9645tt"; line over 80 characters https://review.coreboot.org/#/c/28024/11/src/mainboard/opencellular/elgon/g… PS11, Line 345: local-mac-address = [00 00 00 00 00 00]; line over 80 characters https://review.coreboot.org/#/c/28024/11/src/mainboard/opencellular/elgon/g… PS11, Line 358: local-mac-address = [00 00 00 00 00 00]; line over 80 characters https://review.coreboot.org/#/c/28024/11/src/mainboard/opencellular/elgon/g… PS11, Line 379: compatible = "winbond,w25q128", "jedec,spi-nor"; line over 80 characters https://review.coreboot.org/#/c/28024/11/src/mainboard/opencellular/elgon/g… PS11, Line 415: reg = <0x8800 0x1f000000 0x0 0x39000000 0x87e0 0xc0000000 0x0 0x1000000>; line over 80 characters https://review.coreboot.org/#/c/28024/11/src/mainboard/opencellular/elgon/g… PS11, Line 416: ranges = <0x1000000 0x0 0x0 0x8830 0x0 0x0 0x10000 0x3000000 0x0 0x10000000 0x8810 0x10000000 0xf 0xf0000000 0x43000000 0x10 0x0 0x8820 0x0 0x10 0x0 0x3000000 0x87e0 0xc0000000 0x87e0 0xc0000000 0x0 0x1000000>; line over 80 characters https://review.coreboot.org/#/c/28024/11/src/mainboard/opencellular/elgon/g… PS11, Line 419: interrupt-map = <0x0 0x0 0x0 0x1 0x1 0x0 0x0 0x0 0x10 0x4 0x0 0x0 0x0 0x2 0x1 0x0 0x0 0x0 0x11 0x4 0x0 0x0 0x0 0x3 0x1 0x0 0x0 0x0 0x12 0x4 0x0 0x0 0x0 0x4 0x1 0x0 0x0 0x0 0x13 0x4>; line over 80 characters https://review.coreboot.org/#/c/28024/11/src/mainboard/opencellular/elgon/g… PS11, Line 434: reg = <0x8840 0x57000000 0x0 0x39000000 0x87e0 0xc1000000 0x0 0x1000000>; line over 80 characters https://review.coreboot.org/#/c/28024/11/src/mainboard/opencellular/elgon/g… PS11, Line 435: ranges = <0x1000000 0x0 0x10000 0x8870 0x10000 0x0 0x10000 0x3000000 0x0 0x10000000 0x8850 0x10000000 0xf 0xf0000000 0x43000000 0x10 0x0 0x8860 0x0 0x10 0x0 0x3000000 0x87e0 0xc1000000 0x87e0 0xc1000000 0x0 0x1000000>; line over 80 characters https://review.coreboot.org/#/c/28024/11/src/mainboard/opencellular/elgon/g… PS11, Line 438: interrupt-map = <0x0 0x0 0x0 0x1 0x1 0x0 0x0 0x0 0x14 0x4 0x0 0x0 0x0 0x2 0x1 0x0 0x0 0x0 0x15 0x4 0x0 0x0 0x0 0x3 0x1 0x0 0x0 0x0 0x16 0x4 0x0 0x0 0x0 0x4 0x1 0x0 0x0 0x0 0x17 0x4>; line over 80 characters https://review.coreboot.org/#/c/28024/11/src/mainboard/opencellular/elgon/g… PS11, Line 453: reg = <0x8880 0x8f000000 0x0 0x39000000 0x87e0 0xc2000000 0x0 0x1000000>; line over 80 characters https://review.coreboot.org/#/c/28024/11/src/mainboard/opencellular/elgon/g… PS11, Line 454: ranges = <0x1000000 0x0 0x20000 0x88b0 0x20000 0x0 0x10000 0x3000000 0x0 0x10000000 0x8890 0x10000000 0xf 0xf0000000 0x43000000 0x10 0x0 0x88a0 0x0 0x10 0x0 0x3000000 0x87e0 0xc2000000 0x87e0 0xc2000000 0x0 0x1000000>; line over 80 characters https://review.coreboot.org/#/c/28024/11/src/mainboard/opencellular/elgon/g… PS11, Line 457: interrupt-map = <0x0 0x0 0x0 0x1 0x1 0x0 0x0 0x0 0x18 0x4 0x0 0x0 0x0 0x2 0x1 0x0 0x0 0x0 0x19 0x4 0x0 0x0 0x0 0x3 0x1 0x0 0x0 0x0 0x1a 0x4 0x0 0x0 0x0 0x4 0x1 0x0 0x0 0x0 0x1b 0x4>; line over 80 characters -- To view, visit https://review.coreboot.org/28024 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9b809306cc48facbade5dc63846c4532b397e0b5 Gerrit-Change-Number: 28024 Gerrit-PatchSet: 11 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Sun, 26 Aug 2018 17:37:21 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: src/drivers/pc80/pc: Remove unneeded include
by Felix Held (Code Review) 26 Aug '18

26 Aug '18

Felix Held has posted comments on this change. ( https://review.coreboot.org/28348 ) Change subject: src/drivers/pc80/pc: Remove unneeded include ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/28348 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic238181d5c26ab8cf549137824a7c5e6c6d80ab1 Gerrit-Change-Number: 28348 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 26 Aug 2018 16:08:28 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mainboard/opencellular/elgon: Add mainboard support
by build bot (Jenkins) (Code Review) 26 Aug '18

26 Aug '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28024 ) Change subject: mainboard/opencellular/elgon: Add mainboard support ...................................................................... Patch Set 10: (25 comments) https://review.coreboot.org/#/c/28024/10/src/mainboard/opencellular/elgon/g… File src/mainboard/opencellular/elgon/gbcv2.dts: https://review.coreboot.org/#/c/28024/10/src/mainboard/opencellular/elgon/g… PS10, Line 215: reg = <0x8440 0xa0000 0x0 0x1000 0x8440 0xb0000 0x0 0x1000>; line over 80 characters https://review.coreboot.org/#/c/28024/10/src/mainboard/opencellular/elgon/g… PS10, Line 223: interrupts = <0x0 0x44 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4 0x0 0x45 0x4>; line over 80 characters https://review.coreboot.org/#/c/28024/10/src/mainboard/opencellular/elgon/g… PS10, Line 238: ranges = <0x3000000 0x8010 0x0 0x8010 0x0 0x80 0x0 0x3000000 0x8100 0x0 0x8100 0x0 0x80 0x0 0x3000000 0x8680 0x0 0x8680 0x0 0x160 0x28000000 0x3000000 0x87e0 0x2c000000 0x87e0 0x2c000000 0x0 0x94000000 0x3000000 0x8400 0x0 0x8400 0x0 0x10 0x0 0x3000000 0x8430 0x0 0x8430 0x0 0x2 0x0 0x3000000 0x87e0 0xc6000000 0x87e0 0xc6000000 0x1f 0x3a000000>; line over 80 characters https://review.coreboot.org/#/c/28024/10/src/mainboard/opencellular/elgon/g… PS10, Line 243: compatible = "pci-bridge", "cavium,thunder-8890-mrml-bridge"; line over 80 characters https://review.coreboot.org/#/c/28024/10/src/mainboard/opencellular/elgon/g… PS10, Line 246: ranges = <0x3000000 0x87e0 0x0 0x3000000 0x87e0 0x0 0x10 0x0>; line over 80 characters https://review.coreboot.org/#/c/28024/10/src/mainboard/opencellular/elgon/g… PS10, Line 251: compatible = "cavium,thunder-8890-mdio-nexus"; line over 80 characters https://review.coreboot.org/#/c/28024/10/src/mainboard/opencellular/elgon/g… PS10, Line 255: assigned-addresses = <0x3000000 0x87e0 0x5000000 0x0 0x800000>; line over 80 characters https://review.coreboot.org/#/c/28024/10/src/mainboard/opencellular/elgon/g… PS10, Line 256: ranges = <0x87e0 0x5000000 0x3000000 0x87e0 0x5000000 0x0 0x800000>; line over 80 characters https://review.coreboot.org/#/c/28024/10/src/mainboard/opencellular/elgon/g… PS10, Line 259: compatible = "cavium,thunder-8890-mdio"; line over 80 characters https://review.coreboot.org/#/c/28024/10/src/mainboard/opencellular/elgon/g… PS10, Line 262: reg = <0x87e0 0x5003800 0x0 0x30>; line over 80 characters https://review.coreboot.org/#/c/28024/10/src/mainboard/opencellular/elgon/g… PS10, Line 266: compatible = "cavium,thunder-8890-mdio"; line over 80 characters https://review.coreboot.org/#/c/28024/10/src/mainboard/opencellular/elgon/g… PS10, Line 269: reg = <0x87e0 0x5003880 0x0 0x30>; line over 80 characters https://review.coreboot.org/#/c/28024/10/src/mainboard/opencellular/elgon/g… PS10, Line 332: compatible = "infineon,slb9645tt"; line over 80 characters https://review.coreboot.org/#/c/28024/10/src/mainboard/opencellular/elgon/g… PS10, Line 345: local-mac-address = [00 00 00 00 00 00]; line over 80 characters https://review.coreboot.org/#/c/28024/10/src/mainboard/opencellular/elgon/g… PS10, Line 358: local-mac-address = [00 00 00 00 00 00]; line over 80 characters https://review.coreboot.org/#/c/28024/10/src/mainboard/opencellular/elgon/g… PS10, Line 379: compatible = "winbond,w25q128", "jedec,spi-nor"; line over 80 characters https://review.coreboot.org/#/c/28024/10/src/mainboard/opencellular/elgon/g… PS10, Line 415: reg = <0x8800 0x1f000000 0x0 0x39000000 0x87e0 0xc0000000 0x0 0x1000000>; line over 80 characters https://review.coreboot.org/#/c/28024/10/src/mainboard/opencellular/elgon/g… PS10, Line 416: ranges = <0x1000000 0x0 0x0 0x8830 0x0 0x0 0x10000 0x3000000 0x0 0x10000000 0x8810 0x10000000 0xf 0xf0000000 0x43000000 0x10 0x0 0x8820 0x0 0x10 0x0 0x3000000 0x87e0 0xc0000000 0x87e0 0xc0000000 0x0 0x1000000>; line over 80 characters https://review.coreboot.org/#/c/28024/10/src/mainboard/opencellular/elgon/g… PS10, Line 419: interrupt-map = <0x0 0x0 0x0 0x1 0x1 0x0 0x0 0x0 0x10 0x4 0x0 0x0 0x0 0x2 0x1 0x0 0x0 0x0 0x11 0x4 0x0 0x0 0x0 0x3 0x1 0x0 0x0 0x0 0x12 0x4 0x0 0x0 0x0 0x4 0x1 0x0 0x0 0x0 0x13 0x4>; line over 80 characters https://review.coreboot.org/#/c/28024/10/src/mainboard/opencellular/elgon/g… PS10, Line 434: reg = <0x8840 0x57000000 0x0 0x39000000 0x87e0 0xc1000000 0x0 0x1000000>; line over 80 characters https://review.coreboot.org/#/c/28024/10/src/mainboard/opencellular/elgon/g… PS10, Line 435: ranges = <0x1000000 0x0 0x10000 0x8870 0x10000 0x0 0x10000 0x3000000 0x0 0x10000000 0x8850 0x10000000 0xf 0xf0000000 0x43000000 0x10 0x0 0x8860 0x0 0x10 0x0 0x3000000 0x87e0 0xc1000000 0x87e0 0xc1000000 0x0 0x1000000>; line over 80 characters https://review.coreboot.org/#/c/28024/10/src/mainboard/opencellular/elgon/g… PS10, Line 438: interrupt-map = <0x0 0x0 0x0 0x1 0x1 0x0 0x0 0x0 0x14 0x4 0x0 0x0 0x0 0x2 0x1 0x0 0x0 0x0 0x15 0x4 0x0 0x0 0x0 0x3 0x1 0x0 0x0 0x0 0x16 0x4 0x0 0x0 0x0 0x4 0x1 0x0 0x0 0x0 0x17 0x4>; line over 80 characters https://review.coreboot.org/#/c/28024/10/src/mainboard/opencellular/elgon/g… PS10, Line 453: reg = <0x8880 0x8f000000 0x0 0x39000000 0x87e0 0xc2000000 0x0 0x1000000>; line over 80 characters https://review.coreboot.org/#/c/28024/10/src/mainboard/opencellular/elgon/g… PS10, Line 454: ranges = <0x1000000 0x0 0x20000 0x88b0 0x20000 0x0 0x10000 0x3000000 0x0 0x10000000 0x8890 0x10000000 0xf 0xf0000000 0x43000000 0x10 0x0 0x88a0 0x0 0x10 0x0 0x3000000 0x87e0 0xc2000000 0x87e0 0xc2000000 0x0 0x1000000>; line over 80 characters https://review.coreboot.org/#/c/28024/10/src/mainboard/opencellular/elgon/g… PS10, Line 457: interrupt-map = <0x0 0x0 0x0 0x1 0x1 0x0 0x0 0x0 0x18 0x4 0x0 0x0 0x0 0x2 0x1 0x0 0x0 0x0 0x19 0x4 0x0 0x0 0x0 0x3 0x1 0x0 0x0 0x0 0x1a 0x4 0x0 0x0 0x0 0x4 0x1 0x0 0x0 0x0 0x1b 0x4>; line over 80 characters -- To view, visit https://review.coreboot.org/28024 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9b809306cc48facbade5dc63846c4532b397e0b5 Gerrit-Change-Number: 28024 Gerrit-PatchSet: 10 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Sun, 26 Aug 2018 15:46:06 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2018