coreboot-gerrit May 2018

coreboot-gerrit@coreboot.org

1 participants
3692 discussions

Change in coreboot[master]: mainboard/winent: Remove unnecessary braces {}
by build bot (Jenkins) (Code Review) 02 May '18

02 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23524 ) Change subject: mainboard/winent: Remove unnecessary braces {} ...................................................................... Patch Set 5: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/71226/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/25399/ : SUCCESS -- To view, visit https://review.coreboot.org/23524 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I48a7bd4bd98d1a9d7b0ce4c12e09284fa4be6c7a Gerrit-Change-Number: 23524 Gerrit-PatchSet: 5 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 02 May 2018 17:50:01 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mainboard/google/kahlee: Update grunt touchscreen in devicetree
by build bot (Jenkins) (Code Review) 02 May '18

02 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25998 ) Change subject: mainboard/google/kahlee: Update grunt touchscreen in devicetree ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/71224/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/25397/ : SUCCESS -- To view, visit https://review.coreboot.org/25998 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3bd9912a4b1edc7bf1075cb649afa3eab5dca458 Gerrit-Change-Number: 25998 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 02 May 2018 17:36:49 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: ec/google/chromeec: Update Tablet event call
by Sumeet R Pawnikar (Code Review) 02 May '18

02 May '18

Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/25983 ) Change subject: ec/google/chromeec: Update Tablet event call ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/25983 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8bee069fc95637446593dfaaae1254e931421517 Gerrit-Change-Number: 25983 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 02 May 2018 17:36:00 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: amd/mct/ddr3: Correctly configure CsMux67
by build bot (Jenkins) (Code Review) 02 May '18

02 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25994 ) Change subject: amd/mct/ddr3: Correctly configure CsMux67 ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/71220/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/25393/ : SUCCESS -- To view, visit https://review.coreboot.org/25994 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib97ca89535b8291397d42eca69e217c21a9dd937 Gerrit-Change-Number: 25994 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 02 May 2018 17:16:13 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: ec/google/chromeec: Update Tablet event call
by Duncan Laurie (Code Review) 02 May '18

02 May '18

Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/25983 ) Change subject: ec/google/chromeec: Update Tablet event call ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/25983 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8bee069fc95637446593dfaaae1254e931421517 Gerrit-Change-Number: 25983 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 02 May 2018 17:15:07 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: ec/google/chromeec: add config for wake event types
by build bot (Jenkins) (Code Review) 02 May '18

02 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25992 ) Change subject: ec/google/chromeec: add config for wake event types ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/71219/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/25392/ : SUCCESS -- To view, visit https://review.coreboot.org/25992 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia49a782ba6729c740e3b91c500120132983f6b3c Gerrit-Change-Number: 25992 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Aseda Aboagye <aaboagye(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 02 May 2018 17:13:33 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mainboard/hp/dl145_g1: Fix coding style
by build bot (Jenkins) (Code Review) 02 May '18

02 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23531 ) Change subject: mainboard/hp/dl145_g1: Fix coding style ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/71214/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/25387/ : SUCCESS -- To view, visit https://review.coreboot.org/23531 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8cfddbf49b3042d46956985425990360f0903b1f Gerrit-Change-Number: 23531 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 02 May 2018 17:13:19 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: vendorcode/amd: Expand PStateStruct by one element
by build bot (Jenkins) (Code Review) 02 May '18

02 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25993 ) Change subject: vendorcode/amd: Expand PStateStruct by one element ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/71218/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/25391/ : SUCCESS -- To view, visit https://review.coreboot.org/25993 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I414ac87a6dfce2dca62555854b590b5e94218faa Gerrit-Change-Number: 25993 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 02 May 2018 17:11:22 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: [WIP]acpigen: Always return buffer with requested size
by Patrick Rudolph (Code Review) 02 May '18

02 May '18

Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/25999 Change subject: [WIP]acpigen: Always return buffer with requested size ...................................................................... [WIP]acpigen: Always return buffer with requested size Pad a buffer with zero bytes to return the exact requested size. Might be requied for nouveau. Needs test on real hardware. Change-Id: I3f0ecc42a21945f66eb67f73e511bd516acf0fa9 Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> --- M src/arch/x86/acpigen.c 1 file changed, 10 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/25999/1 diff --git a/src/arch/x86/acpigen.c b/src/arch/x86/acpigen.c index fc6cc66..d73f03a 100644 --- a/src/arch/x86/acpigen.c +++ b/src/arch/x86/acpigen.c @@ -1340,6 +1340,8 @@ * Store (0x1000, Local1) * } * + * Store (Local1, Local3) + * * If (LGreater (Local0, 0x10000)) * { * Return(Buffer(Local1){0}) @@ -1354,7 +1356,7 @@ * } * } * - * Name (ROM1, Buffer (Local1) {0}) + * Name (ROM1, Buffer (Local3) {0}) * * Multiply (Local0, 0x08, Local0) * Multiply (Local1, 0x08, Local1) @@ -1416,6 +1418,11 @@ /* Pop if */ acpigen_pop_len(); + /* Store (Local1, Local3) */ + acpigen_write_store(); + acpigen_emit_byte(LOCAL1_OP); + acpigen_emit_byte(LOCAL3_OP); + /* If (LGreater (Local0, length)) */ acpigen_write_if(); acpigen_emit_byte(LGREATER_OP); @@ -1462,11 +1469,11 @@ /* Pop if */ acpigen_pop_len(); - /* Name (ROM1, Buffer (Local1) {0}) */ + /* Name (ROM1, Buffer (Local3) {0}) */ acpigen_write_name("ROM1"); acpigen_emit_byte(BUFFER_OP); acpigen_write_len_f(); - acpigen_emit_byte(LOCAL1_OP); + acpigen_emit_byte(LOCAL3_OP); acpigen_emit_byte(0); acpigen_pop_len(); -- To view, visit https://review.coreboot.org/25999 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I3f0ecc42a21945f66eb67f73e511bd516acf0fa9 Gerrit-Change-Number: 25999 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org>

1 0

Change in coreboot[master]: mainboard/hp/dl145_g1: Remove commented code
by build bot (Jenkins) (Code Review) 02 May '18

02 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25990 ) Change subject: mainboard/hp/dl145_g1: Remove commented code ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/71216/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/25389/ : SUCCESS -- To view, visit https://review.coreboot.org/25990 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4528eb064e8b9c5ebb235ca16e13582df9efd4cd Gerrit-Change-Number: 25990 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 02 May 2018 17:07:35 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2018