coreboot-gerrit May 2018

coreboot-gerrit@coreboot.org

1 participants
3692 discussions

Change in coreboot[master]: device/pcix_device.c: Get rid of device_t
by build bot (Jenkins) (Code Review) 02 May '18

02 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26006 ) Change subject: device/pcix_device.c: Get rid of device_t ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/71238/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/25410/ : SUCCESS -- To view, visit https://review.coreboot.org/26006 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I14c0db71ffa5faa8321c88c9c75c0c18a70910e8 Gerrit-Change-Number: 26006 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 02 May 2018 19:38:41 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: device/root_device.c: Get rid of device_t
by Elyes HAOUAS (Code Review) 02 May '18

02 May '18

Elyes HAOUAS has uploaded this change for review. ( https://review.coreboot.org/26008 Change subject: device/root_device.c: Get rid of device_t ...................................................................... device/root_device.c: Get rid of device_t Use of `device_t` has been abandoned in ramstage. Change-Id: Ia25c5097d4cfa979c18a855e656ad794c2f0260c Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/device/root_device.c 1 file changed, 7 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/26008/1 diff --git a/src/device/root_device.c b/src/device/root_device.c index 8e98593..a19028d 100644 --- a/src/device/root_device.c +++ b/src/device/root_device.c @@ -43,9 +43,9 @@ * @param bus Pointer to the device to which the static buses are attached to. */ -void scan_static_bus(device_t bus) +void scan_static_bus(struct device *bus) { - device_t child; + struct device *child; struct bus *link; for (link = bus->link_list; link; link = link->next) { @@ -63,7 +63,7 @@ } } -void scan_lpc_bus(device_t bus) +void scan_lpc_bus(struct device *bus) { printk(BIOS_SPEW, "%s for %s\n", __func__, dev_path(bus)); @@ -72,9 +72,9 @@ printk(BIOS_SPEW, "%s for %s done\n", __func__, dev_path(bus)); } -void scan_generic_bus(device_t bus) +void scan_generic_bus(struct device *bus) { - device_t child; + struct device *child; struct bus *link; static int bus_max = 0; @@ -103,7 +103,7 @@ printk(BIOS_SPEW, "%s for %s done\n", __func__, dev_path(bus)); } -void scan_smbus(device_t bus) +void scan_smbus(struct device *bus) { scan_generic_bus(bus); } @@ -115,7 +115,7 @@ * * @param root The root device structure. */ -static void root_dev_scan_bus(device_t bus) +static void root_dev_scan_bus(struct device *bus) { struct bus *link; -- To view, visit https://review.coreboot.org/26008 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ia25c5097d4cfa979c18a855e656ad794c2f0260c Gerrit-Change-Number: 26008 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>

1 0

Change in coreboot[master]: device/pci_class.c: Get rid of device_t
by Elyes HAOUAS (Code Review) 02 May '18

02 May '18

Elyes HAOUAS has uploaded this change for review. ( https://review.coreboot.org/26007 Change subject: device/pci_class.c: Get rid of device_t ...................................................................... device/pci_class.c: Get rid of device_t Use of `device_t` has been abandoned in ramstage. Change-Id: I839533a33aa54df4efed3f372c6f88e79b0b559b Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/device/pci_class.c 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/26007/1 diff --git a/src/device/pci_class.c b/src/device/pci_class.c index 6dbe23e..b2f5ff7 100644 --- a/src/device/pci_class.c +++ b/src/device/pci_class.c @@ -220,7 +220,7 @@ }; static const unsigned int class_entries = ARRAY_SIZE(class_list); -static const PCI_CLASS *get_pci_class_entry(device_t dev) +static const PCI_CLASS *get_pci_class_entry(struct device *dev) { unsigned char class; const PCI_CLASS *class_entry; @@ -240,7 +240,7 @@ return NULL; } -const char *get_pci_class_name(device_t dev) +const char *get_pci_class_name(struct device *dev) { const PCI_CLASS *class_entry; @@ -248,7 +248,7 @@ return class_entry ? class_entry->class_name : "???"; } -const char *get_pci_subclass_name(device_t dev) +const char *get_pci_subclass_name(struct device *dev) { const PCI_CLASS *class_entry; unsigned char subclass; -- To view, visit https://review.coreboot.org/26007 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I839533a33aa54df4efed3f372c6f88e79b0b559b Gerrit-Change-Number: 26007 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>

1 0

Change in coreboot[master]: src/device/pnp_device.c: Get rid of device_t
by build bot (Jenkins) (Code Review) 02 May '18

02 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26002 ) Change subject: src/device/pnp_device.c: Get rid of device_t ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/71234/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/25406/ : SUCCESS -- To view, visit https://review.coreboot.org/26002 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic25d1eb3c7f0ed5b65aa1cf9e16c39415b7cd3c7 Gerrit-Change-Number: 26002 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 02 May 2018 19:32:08 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: device/pcix_device.c: Get rid of device_t
by Elyes HAOUAS (Code Review) 02 May '18

02 May '18

Elyes HAOUAS has uploaded this change for review. ( https://review.coreboot.org/26006 Change subject: device/pcix_device.c: Get rid of device_t ...................................................................... device/pcix_device.c: Get rid of device_t Use of `device_t` has been abandoned in ramstage. Change-Id: I14c0db71ffa5faa8321c88c9c75c0c18a70910e8 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/device/pcix_device.c 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/26006/1 diff --git a/src/device/pcix_device.c b/src/device/pcix_device.c index 214e1f8..31b74e5 100644 --- a/src/device/pcix_device.c +++ b/src/device/pcix_device.c @@ -20,7 +20,7 @@ #include <device/pci_ids.h> #include <device/pcix.h> -static void pcix_tune_dev(device_t dev) +static void pcix_tune_dev(struct device *dev) { u32 status; u16 orig_cmd, cmd; @@ -61,7 +61,7 @@ static void pcix_tune_bus(struct bus *bus) { - device_t child; + struct device *child; for (child = bus->children; child; child = child->sibling) pcix_tune_dev(child); @@ -108,7 +108,7 @@ return result; } -void pcix_scan_bridge(device_t dev) +void pcix_scan_bridge(struct device *dev) { unsigned int pos; u16 sstatus; -- To view, visit https://review.coreboot.org/26006 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I14c0db71ffa5faa8321c88c9c75c0c18a70910e8 Gerrit-Change-Number: 26006 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>

1 0

Change in coreboot[master]: src/device/cardbus_device.c: Get rid of device_t
by build bot (Jenkins) (Code Review) 02 May '18

02 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26004 ) Change subject: src/device/cardbus_device.c: Get rid of device_t ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/71236/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/25408/ : SUCCESS -- To view, visit https://review.coreboot.org/26004 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6f3efd8c9be7f9fb83b373fbee311b06cde54181 Gerrit-Change-Number: 26004 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 02 May 2018 19:29:46 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: device/smbus_ops.c: Get rid of device_t
by Elyes HAOUAS (Code Review) 02 May '18

02 May '18

Elyes HAOUAS has uploaded this change for review. ( https://review.coreboot.org/26005 Change subject: device/smbus_ops.c: Get rid of device_t ...................................................................... device/smbus_ops.c: Get rid of device_t Use of `device_t` has been abandoned in ramstage. Change-Id: I5eb858df7b69a7177564c883b81177ffadc63691 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/device/smbus_ops.c 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/26005/1 diff --git a/src/device/smbus_ops.c b/src/device/smbus_ops.c index 2a86702..c91f415 100644 --- a/src/device/smbus_ops.c +++ b/src/device/smbus_ops.c @@ -20,7 +20,7 @@ #include <device/device.h> #include <device/smbus.h> -struct bus *get_pbus_smbus(device_t dev) +struct bus *get_pbus_smbus(struct device *dev) { struct bus *const pbus = i2c_link(dev); if (!pbus->dev->ops->ops_smbus_bus) { @@ -40,7 +40,7 @@ * * @param dev TODO. */ -int smbus_set_link(device_t dev) +int smbus_set_link(struct device *dev) { struct bus *pbus_a[4]; // 4 level mux only. Enough? struct bus *pbus = dev->bus; @@ -75,7 +75,7 @@ return -1; \ } -int smbus_block_read(device_t dev, u8 cmd, u8 bytes, u8 *buffer) +int smbus_block_read(struct device *dev, u8 cmd, u8 bytes, u8 *buffer) { CHECK_PRESENCE(block_read); @@ -83,7 +83,7 @@ bytes, buffer); } -int smbus_block_write(device_t dev, u8 cmd, u8 bytes, const u8 *buffer) +int smbus_block_write(struct device *dev, u8 cmd, u8 bytes, const u8 *buffer) { CHECK_PRESENCE(block_write); -- To view, visit https://review.coreboot.org/26005 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I5eb858df7b69a7177564c883b81177ffadc63691 Gerrit-Change-Number: 26005 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>

1 0

Change in coreboot[master]: src/device/pciexp_device.c: Get rid of device_t
by build bot (Jenkins) (Code Review) 02 May '18

02 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26003 ) Change subject: src/device/pciexp_device.c: Get rid of device_t ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/71235/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/25407/ : SUCCESS -- To view, visit https://review.coreboot.org/26003 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I82b73e1698d8d44e32ad9f21e575a7fce35baa1c Gerrit-Change-Number: 26003 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 02 May 2018 19:24:49 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: src/device/cardbus_device.c: Get rid of device_t
by Elyes HAOUAS (Code Review) 02 May '18

02 May '18

Elyes HAOUAS has uploaded this change for review. ( https://review.coreboot.org/26004 Change subject: src/device/cardbus_device.c: Get rid of device_t ...................................................................... src/device/cardbus_device.c: Get rid of device_t Use of `device_t` has been abandoned in ramstage. Change-Id: I6f3efd8c9be7f9fb83b373fbee311b06cde54181 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/device/cardbus_device.c 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/26004/1 diff --git a/src/device/cardbus_device.c b/src/device/cardbus_device.c index 19e9900..2924f89 100644 --- a/src/device/cardbus_device.c +++ b/src/device/cardbus_device.c @@ -34,7 +34,7 @@ #define CARDBUS_IO_SIZE 4096 #define CARDBUS_MEM_SIZE (32 * 1024 * 1024) -static void cardbus_record_bridge_resource(device_t dev, resource_t moving, +static void cardbus_record_bridge_resource(struct device *dev, resource_t moving, resource_t min_size, unsigned int index, unsigned long type) { struct resource *resource; @@ -66,7 +66,7 @@ resource->size = min_size; } -static void cardbus_size_bridge_resource(device_t dev, unsigned int index) +static void cardbus_size_bridge_resource(struct device *dev, unsigned int index) { struct resource *resource; resource_t min_size; @@ -83,7 +83,7 @@ } } -void cardbus_read_resources(device_t dev) +void cardbus_read_resources(struct device *dev) { resource_t moving_base, moving_limit, moving; unsigned long type; @@ -149,7 +149,7 @@ compact_resources(dev); } -void cardbus_enable_resources(device_t dev) +void cardbus_enable_resources(struct device *dev) { u16 ctrl; -- To view, visit https://review.coreboot.org/26004 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I6f3efd8c9be7f9fb83b373fbee311b06cde54181 Gerrit-Change-Number: 26004 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>

1 0

Change in coreboot[master]: src/device/pciexp_device.c: Get rid of device_t
by Elyes HAOUAS (Code Review) 02 May '18

02 May '18

Elyes HAOUAS has uploaded this change for review. ( https://review.coreboot.org/26003 Change subject: src/device/pciexp_device.c: Get rid of device_t ...................................................................... src/device/pciexp_device.c: Get rid of device_t Use of `device_t` has been abandoned in ramstage. Change-Id: I82b73e1698d8d44e32ad9f21e575a7fce35baa1c Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/device/pciexp_device.c 1 file changed, 22 insertions(+), 22 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/26003/1 diff --git a/src/device/pciexp_device.c b/src/device/pciexp_device.c index 502494d..8cd39e4 100644 --- a/src/device/pciexp_device.c +++ b/src/device/pciexp_device.c @@ -22,7 +22,7 @@ #include <device/pci_ops.h> #include <device/pciexp.h> -unsigned int pciexp_find_extended_cap(device_t dev, unsigned int cap) +unsigned int pciexp_find_extended_cap(struct device *dev, unsigned int cap) { unsigned int this_cap_offset, next_cap_offset; unsigned int this_cap, cafe; @@ -49,7 +49,7 @@ * Re-train a PCIe link */ #define PCIE_TRAIN_RETRY 10000 -static int pciexp_retrain_link(device_t dev, unsigned cap) +static int pciexp_retrain_link(struct device *dev, unsigned cap) { unsigned int try; u16 lnk; @@ -94,8 +94,8 @@ * and enable Common Clock Configuration if possible. If CCC is * enabled the link must be retrained. */ -static void pciexp_enable_common_clock(device_t root, unsigned root_cap, - device_t endp, unsigned endp_cap) +static void pciexp_enable_common_clock(struct device *root, unsigned root_cap, + struct device *endp, unsigned endp_cap) { u16 root_scc, endp_scc, lnkctl; @@ -126,7 +126,7 @@ } } -static void pciexp_enable_clock_power_pm(device_t endp, unsigned endp_cap) +static void pciexp_enable_clock_power_pm(struct device *endp, unsigned endp_cap) { /* check if per port clk req is supported in device */ u32 endp_ca; @@ -141,7 +141,7 @@ pci_write_config16(endp, endp_cap + PCI_EXP_LNKCTL, lnkctl); } -static void pciexp_config_max_latency(device_t root, device_t dev) +static void pciexp_config_max_latency(struct device *root, struct device *dev) { unsigned int cap; cap = pciexp_find_extended_cap(dev, PCIE_EXT_CAP_LTR_ID); @@ -150,7 +150,7 @@ root->ops->ops_pci->set_L1_ss_latency(dev, cap + 4); } -static bool pciexp_is_ltr_supported(device_t dev, unsigned int cap) +static bool pciexp_is_ltr_supported(struct device *dev, unsigned int cap) { unsigned int val; @@ -162,7 +162,7 @@ return false; } -static void pciexp_configure_ltr(device_t dev) +static void pciexp_configure_ltr(struct device *dev) { unsigned int cap; @@ -187,10 +187,10 @@ pciexp_config_max_latency(dev->bus->dev, dev); } -static void pciexp_enable_ltr(device_t dev) +static void pciexp_enable_ltr(struct device *dev) { struct bus *bus; - device_t child; + struct device *child; for (bus = dev->link_list ; bus ; bus = bus->next) { for (child = bus->children; child; child = child->sibling) { @@ -201,7 +201,7 @@ } } -static unsigned char pciexp_L1_substate_cal(device_t dev, unsigned int endp_cap, +static unsigned char pciexp_L1_substate_cal(struct device *dev, unsigned int endp_cap, unsigned int *data) { unsigned char mult[4] = {2, 10, 100, 0}; @@ -236,10 +236,10 @@ return 1; } -static void pciexp_L1_substate_commit(device_t root, device_t dev, +static void pciexp_L1_substate_commit(struct device *root, struct device *dev, unsigned int root_cap, unsigned int end_cap) { - device_t dev_t; + struct device *dev_t; unsigned char L1_ss_ok; unsigned int rp_L1_support = pci_read_config32(root, root_cap + 4); unsigned int L1SubStateSupport; @@ -305,7 +305,7 @@ } } -static void pciexp_config_L1_sub_state(device_t root, device_t dev) +static void pciexp_config_L1_sub_state(struct device *root, struct device *dev) { unsigned int root_cap, end_cap; @@ -332,8 +332,8 @@ * by checking both root port and endpoint and returning * the highest latency value. */ -static int pciexp_aspm_latency(device_t root, unsigned root_cap, - device_t endp, unsigned endp_cap, +static int pciexp_aspm_latency(struct device *root, unsigned root_cap, + struct device *endp, unsigned endp_cap, enum aspm_type type) { int root_lat = 0, endp_lat = 0; @@ -368,8 +368,8 @@ /* * Enable ASPM on PCIe root port and endpoint. */ -static void pciexp_enable_aspm(device_t root, unsigned root_cap, - device_t endp, unsigned endp_cap) +static void pciexp_enable_aspm(struct device *root, unsigned root_cap, + struct device *endp, unsigned endp_cap) { const char *aspm_type_str[] = { "None", "L0s", "L1", "L0s and L1" }; enum aspm_type apmc = PCIE_ASPM_NONE; @@ -412,9 +412,9 @@ printk(BIOS_INFO, "ASPM: Enabled %s\n", aspm_type_str[apmc]); } -static void pciexp_tune_dev(device_t dev) +static void pciexp_tune_dev(struct device *dev) { - device_t root = dev->bus->dev; + struct device *root = dev->bus->dev; unsigned int root_cap, cap; cap = pci_find_capability(dev, PCI_CAP_ID_PCIE); @@ -445,7 +445,7 @@ void pciexp_scan_bus(struct bus *bus, unsigned int min_devfn, unsigned int max_devfn) { - device_t child; + struct device *child; pci_scan_bus(bus, min_devfn, max_devfn); for (child = bus->children; child; child = child->sibling) { @@ -457,7 +457,7 @@ } } -void pciexp_scan_bridge(device_t dev) +void pciexp_scan_bridge(struct device *dev) { do_pci_scan_bridge(dev, pciexp_scan_bus); pciexp_enable_ltr(dev); -- To view, visit https://review.coreboot.org/26003 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I82b73e1698d8d44e32ad9f21e575a7fce35baa1c Gerrit-Change-Number: 26003 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2018