coreboot-gerrit May 2018

coreboot-gerrit@coreboot.org

1 participants
3692 discussions

Change in coreboot[master]: console/vtxprintf.c: Add required spaces around '>'
by Elyes HAOUAS (Code Review) 03 May '18

03 May '18

Elyes HAOUAS has uploaded this change for review. ( https://review.coreboot.org/26024 Change subject: console/vtxprintf.c: Add required spaces around '>' ...................................................................... console/vtxprintf.c: Add required spaces around '>' Change-Id: I2e1e494f40bf2316e02a96759a92c933ee11fbab Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/console/vtxprintf.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/26024/1 diff --git a/src/console/vtxprintf.c b/src/console/vtxprintf.c index 88295a2..63e6703 100644 --- a/src/console/vtxprintf.c +++ b/src/console/vtxprintf.c @@ -106,7 +106,7 @@ precision = i; size -= precision; if (!(type&(ZEROPAD+LEFT))) - while (size-->0) + while (size-- > 0) call_tx(' '), count++; if (sign) call_tx(sign), count++; -- To view, visit https://review.coreboot.org/26024 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I2e1e494f40bf2316e02a96759a92c933ee11fbab Gerrit-Change-Number: 26024 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>

1 0

Change in coreboot[master]: ifdtool: Add a list of known platforms that support IFD_VERSION_2
by build bot (Jenkins) (Code Review) 03 May '18

03 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26023 ) Change subject: ifdtool: Add a list of known platforms that support IFD_VERSION_2 ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/71272/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/25442/ : SUCCESS -- To view, visit https://review.coreboot.org/26023 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I36c49f4dcb480ad53b0538ad12292fb94b0e3934 Gerrit-Change-Number: 26023 Gerrit-PatchSet: 2 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 03 May 2018 06:41:52 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: ifdtool: Add a list of known platforms that support IFD_VERSION_2
by build bot (Jenkins) (Code Review) 03 May '18

03 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26023 ) Change subject: ifdtool: Add a list of known platforms that support IFD_VERSION_2 ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/71271/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/25441/ : ABORTED -- To view, visit https://review.coreboot.org/26023 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I36c49f4dcb480ad53b0538ad12292fb94b0e3934 Gerrit-Change-Number: 26023 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 03 May 2018 06:37:20 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: ifdtool: Add a list of known platforms that support IFD_VERSION_2
by Furquan Shaikh (Code Review) 03 May '18

03 May '18

Furquan Shaikh has uploaded a new patch set (#2). ( https://review.coreboot.org/26023 ) Change subject: ifdtool: Add a list of known platforms that support IFD_VERSION_2 ...................................................................... ifdtool: Add a list of known platforms that support IFD_VERSION_2 ifdtool has relied on one of the fields within FCBA(read_freq) to determine whether a platform supports IFD_VERSION_1 or IFD_VERSION_2. However, newer platforms like GLK and CNL do not have read_freq field in FCBA and so the value of these bits cannot be used as an indicator to distinguish IFD versions. In the long run, we need to re-write ifdtool to have a better mapping of SoC to IFD fields. But until that is done, this change adds a list of platforms that we know do not support read_freq field but still use IFD_VERSION_2. This change also updates GLK and CNL to pass in platform parameter to ifdtool. BUG=b:79109029, b:69270831 Change-Id: I36c49f4dcb480ad53b0538ad12292fb94b0e3934 Signed-off-by: Furquan Shaikh <furquan(a)google.com> --- M src/soc/intel/apollolake/Kconfig M src/soc/intel/cannonlake/Kconfig M util/ifdtool/ifdtool.c M util/ifdtool/ifdtool.h 4 files changed, 57 insertions(+), 11 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/26023/2 -- To view, visit https://review.coreboot.org/26023 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I36c49f4dcb480ad53b0538ad12292fb94b0e3934 Gerrit-Change-Number: 26023 Gerrit-PatchSet: 2 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com>

1 0

Change in coreboot[master]: ifdtool: Add a list of known platforms that support IFD_VERSION_2
by Furquan Shaikh (Code Review) 03 May '18

03 May '18

Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/26023 Change subject: ifdtool: Add a list of known platforms that support IFD_VERSION_2 ...................................................................... ifdtool: Add a list of known platforms that support IFD_VERSION_2 ifdtool has relied on one of the fields within FCBA(read_freq) to determine whether a platform supports IFD_VERSION_1 or IFD_VERSION_2. However, newer platforms like GLK and CNL do not have read_freq field in FCBA and so the value of these bits cannot be used as an indicator to distinguish IFD versions. In the long run, we need to re-write ifdtool to have a better mapping of SoC to IFD fields. But until that is done, this change adds a list of platforms that we know do not support read_freq field but still use IFD_VERSION_2. This change also updates GLK and CNL to pass in platform parameter to ifdtool. BUG=b:79109029, b:69270831 Change-Id: I36c49f4dcb480ad53b0538ad12292fb94b0e3934 Signed-off-by: Furquan Shaikh <furquan(a)google.com> --- M src/soc/intel/apollolake/Kconfig M src/soc/intel/cannonlake/Kconfig M util/ifdtool/ifdtool.c M util/ifdtool/ifdtool.h 4 files changed, 58 insertions(+), 11 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/26023/1 diff --git a/src/soc/intel/apollolake/Kconfig b/src/soc/intel/apollolake/Kconfig index 8cac151..0f1f121 100644 --- a/src/soc/intel/apollolake/Kconfig +++ b/src/soc/intel/apollolake/Kconfig @@ -350,6 +350,7 @@ config IFD_CHIPSET string + default "glk" if SOC_INTEL_GLK default "aplk" config CPU_BCLK_MHZ diff --git a/src/soc/intel/cannonlake/Kconfig b/src/soc/intel/cannonlake/Kconfig index 541e516..898b444 100644 --- a/src/soc/intel/cannonlake/Kconfig +++ b/src/soc/intel/cannonlake/Kconfig @@ -114,6 +114,10 @@ The amount of anticipated stack usage in CAR by bootblock and other stages. +config IFD_CHIPSET + string + default "cnl" + config IED_REGION_SIZE hex default 0x400000 diff --git a/util/ifdtool/ifdtool.c b/util/ifdtool/ifdtool.c index 12dfdd1..73fa0ff 100644 --- a/util/ifdtool/ifdtool.c +++ b/util/ifdtool/ifdtool.c @@ -126,14 +126,35 @@ } /* + * Some newer platforms have re-defined the FCBA field that was used to + * distinguish IFD v1 v/s v2. Define a list of platforms that we know do not + * have the required FCBA field, but are IFD v2 and return true if current + * platform is one of them. + */ +static int is_platform_ifd_2(void) +{ + static const int ifd_2_platforms[] = { + PLATFORM_GLK, + PLATFORM_CNL, + }; + unsigned int i; + + for (i = 0; i < ARRAY_SIZE(ifd_2_platforms); i++) { + if (platform == ifd_2_platforms[i]) + return 1; + } + + return 0; +} + +/* * There is no version field in the descriptor so to determine * if this is a new descriptor format we check the hardcoded SPI * read frequency to see if it is fixed at 20MHz or 17MHz. */ -static void check_ifd_version(char *image, int size) +static int get_ifd_version_from_fcba(char *image, int size) { int read_freq; - const fcba_t *fcba = find_fcba(image, size); if (!fcba) exit(EXIT_FAILURE); @@ -142,14 +163,10 @@ switch (read_freq) { case SPI_FREQUENCY_20MHZ: - ifd_version = IFD_VERSION_1; - max_regions = MAX_REGIONS_OLD; - break; + return IFD_VERSION_1; case SPI_FREQUENCY_17MHZ: case SPI_FREQUENCY_50MHZ_30MHZ: - ifd_version = IFD_VERSION_2; - max_regions = MAX_REGIONS; - break; + return IFD_VERSION_2; default: fprintf(stderr, "Unknown descriptor version: %d\n", read_freq); @@ -157,6 +174,20 @@ } } +static void check_ifd_version(char *image, int size) +{ + if (is_platform_ifd_2()) + ifd_version = IFD_VERSION_2; + else + ifd_version = get_ifd_version_from_fcba(image, size); + + if (ifd_version == IFD_VERSION_1) + max_regions = MAX_REGIONS_OLD; + else + max_regions = MAX_REGIONS; + +} + static region_t get_region(const frba_t *frba, unsigned int region_type) { int base_mask; @@ -816,7 +847,8 @@ } switch (platform) { - case PLATFORM_APOLLOLAKE: + case PLATFORM_APL: + case PLATFORM_GLK: /* CPU/BIOS can read descriptor and BIOS */ fmba->flmstr1 |= 0x3 << rd_shift; /* CPU/BIOS can write BIOS */ @@ -1153,6 +1185,9 @@ " -u | --unlock Unlock firmware descriptor and ME region\n" " -p | --platform Add platform-specific quirks\n" " aplk - Apollo Lake\n" + " cnl - Cannon Lake\n" + " glk - Gemini Lake\n" + " sklkbl - Skylake/Kaby Lake\n" " -v | --version: print the version\n" " -h | --help: print this help\n\n" "<region> is one of Descriptor, BIOS, ME, GbE, Platform\n" @@ -1342,13 +1377,18 @@ break; case 'p': if (!strcmp(optarg, "aplk")) { - platform = PLATFORM_APOLLOLAKE; + platform = PLATFORM_APL; + } else if (!strcmp(optarg, "cnl")) { + platform = PLATFORM_CNL; + } else if (!strcmp(optarg, "glk")) { + platform = PLATFORM_GLK; } else if (!strcmp(optarg, "sklkbl")) { platform = PLATFORM_SKLKBL; } else { fprintf(stderr, "Unknown platform: %s\n", optarg); exit(EXIT_FAILURE); } + fprintf(stderr, "Platform is: %s\n", optarg); break; case 'v': print_version(); diff --git a/util/ifdtool/ifdtool.h b/util/ifdtool/ifdtool.h index ad299a9..ef85555 100644 --- a/util/ifdtool/ifdtool.h +++ b/util/ifdtool/ifdtool.h @@ -22,7 +22,9 @@ }; enum platform { - PLATFORM_APOLLOLAKE, + PLATFORM_APL, + PLATFORM_CNL, + PLATFORM_GLK, PLATFORM_SKLKBL, }; -- To view, visit https://review.coreboot.org/26023 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I36c49f4dcb480ad53b0538ad12292fb94b0e3934 Gerrit-Change-Number: 26023 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com>

1 0

Change in coreboot[master]: mainboard/{google/intel}: Set FspSkipMpInit=0 to run CPU programming ...
by build bot (Jenkins) (Code Review) 03 May '18

03 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25923 ) Change subject: mainboard/{google/intel}: Set FspSkipMpInit=0 to run CPU programming on APs ...................................................................... Patch Set 8: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/71265/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/25436/ : SUCCESS -- To view, visit https://review.coreboot.org/25923 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5f3144213127cc3eded93445083f6eab7dc75297 Gerrit-Change-Number: 25923 Gerrit-PatchSet: 8 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 03 May 2018 04:25:20 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: cpu/x86: Add infinite timeout support into run_ap_work() function
by build bot (Jenkins) (Code Review) 03 May '18

03 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25622 ) Change subject: cpu/x86: Add infinite timeout support into run_ap_work() function ...................................................................... Patch Set 9: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/71266/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/25437/ : SUCCESS -- To view, visit https://review.coreboot.org/25622 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iacd67768c8a120f6a01baaa6817468f6b9a3b764 Gerrit-Change-Number: 25622 Gerrit-PatchSet: 9 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 03 May 2018 04:20:55 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/intel/common: Implement EFI_MP_SERVICES_PPI structure APIs
by build bot (Jenkins) (Code Review) 03 May '18

03 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25634 ) Change subject: soc/intel/common: Implement EFI_MP_SERVICES_PPI structure APIs ...................................................................... Patch Set 18: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/71263/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/25434/ : SUCCESS -- To view, visit https://review.coreboot.org/25634 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie844e3f15f759ea09a8f3fd24825ee740151c956 Gerrit-Change-Number: 25634 Gerrit-PatchSet: 18 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Ronald G. Minnich <rminnich(a)gmail.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Aaron Durbin <adurbin(a)chromium.org> Gerrit-CC: Furquan Shaikh <furquan(a)google.com> Gerrit-CC: Nathaniel L Desimone <nathaniel.l.desimone(a)intel.com> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Thu, 03 May 2018 04:18:01 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: soc/intel/cannonlake: Assign FSP upd to handle feature programming
by build bot (Jenkins) (Code Review) 03 May '18

03 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25657 ) Change subject: soc/intel/cannonlake: Assign FSP upd to handle feature programming ...................................................................... Patch Set 14: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/71264/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/25435/ : SUCCESS -- To view, visit https://review.coreboot.org/25657 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iae1984cfd81cbaecf24bb82229e48b9f36abd110 Gerrit-Change-Number: 25657 Gerrit-PatchSet: 14 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 03 May 2018 04:15:49 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: Documentation/Intel: Add MultiProcessorInit documentation
by build bot (Jenkins) (Code Review) 03 May '18

03 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25921 ) Change subject: Documentation/Intel: Add MultiProcessorInit documentation ...................................................................... Patch Set 7: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/71261/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/25432/ : SUCCESS -- To view, visit https://review.coreboot.org/25921 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5b6096ef31d8a523c00cbad39ab9d4884e735fde Gerrit-Change-Number: 25921 Gerrit-PatchSet: 7 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Comment-Date: Thu, 03 May 2018 04:13:52 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2018