coreboot-gerrit March 2018

coreboot-gerrit@coreboot.org

1 participants
1399 discussions

Change in coreboot[master]: opencellular/rotundu: Introduce variants for OC
by build bot (Jenkins) (Code Review) 05 Mar '18

05 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22924 ) Change subject: opencellular/rotundu: Introduce variants for OC ...................................................................... Patch Set 15: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/22692/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68248/ : SUCCESS -- To view, visit https://review.coreboot.org/22924 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id20e9d4ed7ac071d25a69eee63c9ec544d2ad152 Gerrit-Change-Number: 22924 Gerrit-PatchSet: 15 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 05 Mar 2018 12:28:04 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: soc/fsp_baytrail: Fix vboot and TPM support
by build bot (Jenkins) (Code Review) 05 Mar '18

05 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23798 ) Change subject: soc/fsp_baytrail: Fix vboot and TPM support ...................................................................... Patch Set 5: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/22693/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68249/ : SUCCESS -- To view, visit https://review.coreboot.org/23798 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id33b7f2b9269593cd3e62f63752a660a144600da Gerrit-Change-Number: 23798 Gerrit-PatchSet: 5 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 05 Mar 2018 12:25:52 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: opencellular/rotundu: Add LPC TPM support
by build bot (Jenkins) (Code Review) 05 Mar '18

05 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22829 ) Change subject: opencellular/rotundu: Add LPC TPM support ...................................................................... Patch Set 12: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/22691/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68247/ : SUCCESS -- To view, visit https://review.coreboot.org/22829 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4154841de553d198d5a5d113e31b7be14a12dcd0 Gerrit-Change-Number: 22829 Gerrit-PatchSet: 12 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Bernard Adongo <bernard(a)brck.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Reg Orton <reg(a)brck.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 05 Mar 2018 12:19:36 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/google/poppy/variants/nami: Add WACOM EMR support
by build bot (Jenkins) (Code Review) 05 Mar '18

05 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/24997 ) Change subject: mb/google/poppy/variants/nami: Add WACOM EMR support ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/22688/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68244/ : SUCCESS -- To view, visit https://review.coreboot.org/24997 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icbe809a48959e5749262aeb1b89b09c4bdafbbc2 Gerrit-Change-Number: 24997 Gerrit-PatchSet: 1 Gerrit-Owner: Jasper Lee <jasper_lee(a)compal.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Jasper Lee <jasper_lee(a)compal.com> Gerrit-Reviewer: Jimmy M Wang <jimmym_wang(a)compal.corp-partner.google.com> Gerrit-Reviewer: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 05 Mar 2018 12:10:32 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/poppy/variants/nami: Add WACOM EMR support
by Jasper Lee (Code Review) 05 Mar '18

05 Mar '18

Hello Jasper Lee, I'd like you to do a code review. Please visit https://review.coreboot.org/24997 to review the following change. Change subject: mb/google/poppy/variants/nami: Add WACOM EMR support ...................................................................... mb/google/poppy/variants/nami: Add WACOM EMR support Add WACOM EMR in devicetree I2C #2, modify GPP_D3 as output high in default. BUG=b:72062737 BRANCH=master TEST=Verify EMR on nami Change-Id: Icbe809a48959e5749262aeb1b89b09c4bdafbbc2 Signed-off-by: jasper lee <jasper_lee(a)compal.corp-partner.google.com> --- M src/mainboard/google/poppy/variants/nami/devicetree.cb M src/mainboard/google/poppy/variants/nami/gpio.c 2 files changed, 17 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/24997/1 diff --git a/src/mainboard/google/poppy/variants/nami/devicetree.cb b/src/mainboard/google/poppy/variants/nami/devicetree.cb index c4aabcf..603f7ac 100644 --- a/src/mainboard/google/poppy/variants/nami/devicetree.cb +++ b/src/mainboard/google/poppy/variants/nami/devicetree.cb @@ -266,7 +266,22 @@ device i2c 15 on end end end # I2C #1 - device pci 15.2 on end # I2C #2 + device pci 15.2 on + chip drivers/i2c/hid + register "generic.hid" = ""WCOM005C"" + register "generic.desc" = ""WCOM Digitizer"" + register "generic.irq" = "ACPI_IRQ_LEVEL_LOW(GPP_D1_IRQ)" + register "generic.probed" = "1" + register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D3)" + register "generic.reset_delay_ms" = "20" + register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D2)" + register "generic.enable_delay_ms" = "1" + register "generic.has_power_resource" = "1" + register "generic.disable_gpio_export_in_crs" = "1" + register "hid_desc_reg_offset" = "0x1" + device i2c 0x9 on end + end + end # I2C #2 device pci 15.3 on chip drivers/generic/max98357a register "sdmode_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_A23)" diff --git a/src/mainboard/google/poppy/variants/nami/gpio.c b/src/mainboard/google/poppy/variants/nami/gpio.c index e85d948..00b2502 100644 --- a/src/mainboard/google/poppy/variants/nami/gpio.c +++ b/src/mainboard/google/poppy/variants/nami/gpio.c @@ -167,7 +167,7 @@ /* D2 : SPI1_MISO ==> PEN_PDCT# */ PAD_CFG_GPI_APIC(GPP_D2, NONE, PLTRST), /* D3 : SPI1_MOSI ==> PEN_RST# */ - PAD_CFG_GPO(GPP_D3, 0, DEEP), + PAD_CFG_GPO(GPP_D3, 1, DEEP), /* D4 : FASHTRIG ==> NC */ PAD_CFG_NC(GPP_D4), /* D5 : ISH_I2C0_SDA ==> NC */ -- To view, visit https://review.coreboot.org/24997 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Icbe809a48959e5749262aeb1b89b09c4bdafbbc2 Gerrit-Change-Number: 24997 Gerrit-PatchSet: 1 Gerrit-Owner: Jasper Lee <jasper_lee(a)compal.com> Gerrit-Reviewer: Jasper Lee <jasper_lee(a)compal.com>

1 0

Change in coreboot[master]: security/vboot: Replace all region device and map functions
by build bot (Jenkins) (Code Review) 05 Mar '18

05 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/24995 ) Change subject: security/vboot: Replace all region device and map functions ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/22686/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68242/ : SUCCESS -- To view, visit https://review.coreboot.org/24995 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1e288c7a17cc96d7e65f914f7253aaa4b74d04e8 Gerrit-Change-Number: 24995 Gerrit-PatchSet: 2 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 05 Mar 2018 11:19:18 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/poppy : Get SKU_ID from EC for Nami/Vayne
by build bot (Jenkins) (Code Review) 05 Mar '18

05 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/24996 ) Change subject: mb/google/poppy : Get SKU_ID from EC for Nami/Vayne ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/68243/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/22687/ : SUCCESS -- To view, visit https://review.coreboot.org/24996 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42dd177de8c49cf3c122c2ebb1fcf42e5ba4cd75 Gerrit-Change-Number: 24996 Gerrit-PatchSet: 1 Gerrit-Owner: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 05 Mar 2018 11:05:05 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/poppy : Get SKU_ID from EC for Nami/Vayne
by Amanda Hwang (Code Review) 05 Mar '18

05 Mar '18

Amanda Hwang has uploaded this change for review. ( https://review.coreboot.org/24996 Change subject: mb/google/poppy : Get SKU_ID from EC for Nami/Vayne ...................................................................... mb/google/poppy : Get SKU_ID from EC for Nami/Vayne CBI abbreviates Cros Board Info. BUG=b:74177699 BRANCH=master TEST=Verify CPU log shows expected SKU ID on Nami. Change-Id: I42dd177de8c49cf3c122c2ebb1fcf42e5ba4cd75 Signed-off-by: amanda_hwang <amanda_hwang(a)compal.corp-partner.google.com> --- M src/mainboard/google/poppy/ramstage.c M src/soc/intel/skylake/chip_fsp20.c M src/soc/intel/skylake/include/fsp20/soc/ramstage.h 3 files changed, 58 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/24996/1 diff --git a/src/mainboard/google/poppy/ramstage.c b/src/mainboard/google/poppy/ramstage.c index 39df3ee..3b34a96 100644 --- a/src/mainboard/google/poppy/ramstage.c +++ b/src/mainboard/google/poppy/ramstage.c @@ -15,9 +15,59 @@ #include <baseboard/variants.h> #include <soc/ramstage.h> - +#include <ec/google/chromeec/ec.h> +#include <string.h> +#include <assert.h> #include <variant/gpio.h> +#define SKU_0_Nami 0x3A7B +#define SKU_1_Vayne 0x3A63 +#define SKU_2_Vayne 0x3A7F + + +static uint16_t board_sku_id(void) +{ + static int sku_id = -1; + + if (sku_id < 0) { + uint32_t id; + if (google_chromeec_cbi_get_sku_id(&id)) + /* TODO: Once transition completes, raise error instead + of returning gpio value which could be unintended. */ + /* Reading from EC may succeed next time but we do not + want to return different values. So, we cache the + value read from GPIOs. */ + printk(BIOS_INFO, "get sku id failed\n"); + sku_id = id; + } + + return sku_id; +} + + +void mainboard_devtree_update(struct device *dev) +{ + /* Override dev tree settings per board */ + struct soc_intel_skylake_config *cfg = dev->chip_info; + uint16_t sku_id; + sku_id = board_sku_id(); + + switch (sku_id) { + case SKU_0_Nami: + printk(BIOS_INFO, "SKU_0_Nami\n"); + cfg->usb2_ports[5].enable = 1;//rear camera + cfg->usb2_ports[6].enable = 1; //front camera + break; + case SKU_1_Vayne: + printk(BIOS_INFO, "SKU_1_Vayne\n"); + cfg->usb2_ports[5].enable = 0;//rear camera + cfg->usb2_ports[6].enable = 1; //front camera + break; + default: + break; + } +} + void mainboard_silicon_init_params(FSP_SIL_UPD *params) { const struct pad_config *pads; diff --git a/src/soc/intel/skylake/chip_fsp20.c b/src/soc/intel/skylake/chip_fsp20.c index 3bc66b2..e5ffc21 100644 --- a/src/soc/intel/skylake/chip_fsp20.c +++ b/src/soc/intel/skylake/chip_fsp20.c @@ -102,6 +102,7 @@ printk(BIOS_ERR, "BUG! Could not find SOC devicetree config\n"); return; } + mainboard_devtree_update(dev); config = dev->chip_info; mainboard_silicon_init_params(params); @@ -328,3 +329,8 @@ { printk(BIOS_DEBUG, "WEAK: %s/%s called\n", __FILE__, __func__); } + +__attribute__((weak)) void mainboard_devtree_update(struct device *dev) +{ + /* Override dev tree settings per board */ +} diff --git a/src/soc/intel/skylake/include/fsp20/soc/ramstage.h b/src/soc/intel/skylake/include/fsp20/soc/ramstage.h index 23443c3..92d7069 100644 --- a/src/soc/intel/skylake/include/fsp20/soc/ramstage.h +++ b/src/soc/intel/skylake/include/fsp20/soc/ramstage.h @@ -31,5 +31,6 @@ void soc_init_pre_device(void *chip_info); void soc_irq_settings(FSP_SIL_UPD *params); const char *soc_acpi_name(const struct device *dev); +void mainboard_devtree_update(struct device *dev); #endif -- To view, visit https://review.coreboot.org/24996 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I42dd177de8c49cf3c122c2ebb1fcf42e5ba4cd75 Gerrit-Change-Number: 24996 Gerrit-PatchSet: 1 Gerrit-Owner: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com>

1 0

Change in coreboot[master]: lib/cbfs: Remove cbfs_boot_map_optionrom from cbfs impl
by build bot (Jenkins) (Code Review) 05 Mar '18

05 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/24994 ) Change subject: lib/cbfs: Remove cbfs_boot_map_optionrom from cbfs impl ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/22685/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68241/ : SUCCESS -- To view, visit https://review.coreboot.org/24994 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I57a35d3ce95850d22f79a1045a30b7c6b011bb68 Gerrit-Change-Number: 24994 Gerrit-PatchSet: 2 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 05 Mar 2018 10:52:53 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: security/vboot: Extend measurements for all execution flows
by build bot (Jenkins) (Code Review) 05 Mar '18

05 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/24993 ) Change subject: security/vboot: Extend measurements for all execution flows ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/22684/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68240/ : SUCCESS -- To view, visit https://review.coreboot.org/24993 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3ddfeabd63aefec152a9bc439a415c37b814f94f Gerrit-Change-Number: 24993 Gerrit-PatchSet: 2 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 05 Mar 2018 10:52:53 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2018