coreboot-gerrit December 2018

coreboot-gerrit@coreboot.org

1 participants
1832 discussions

Change in ...coreboot[master]: mb/intel/kblrvp: Change HDA verb table selection logic
by Patrick Georgi (Code Review) 20 Dec '18

20 Dec '18

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/30267 ) Change subject: mb/intel/kblrvp: Change HDA verb table selection logic ...................................................................... mb/intel/kblrvp: Change HDA verb table selection logic All the kaby lake variants uses HDA verb table except RVP8, hence unselect SOC_INTEL_COMMON_BLOCK_HDA_VERB for RVP8 and enable for other variants by default. BUG=None TEST= Tested on KBL RVP11 and verified the audio functionality. Signed-off-by: Praveen hodagatta pranesh <praveenx.hodagatta.pranesh(a)intel.com> Change-Id: I64d18ab62cfc08b5560dbcf1b77e975eb68c8d30 Reviewed-on: https://review.coreboot.org/c/30267 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Subrata Banik <subrata.banik(a)intel.com> Reviewed-by: Boon Tiong Teo <boon.tiong.teo(a)intel.com> --- M src/mainboard/intel/kblrvp/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Subrata Banik: Looks good to me, approved Boon Tiong Teo: Looks good to me, but someone else must approve diff --git a/src/mainboard/intel/kblrvp/Kconfig b/src/mainboard/intel/kblrvp/Kconfig index c0d25a6..0a11dfd 100644 --- a/src/mainboard/intel/kblrvp/Kconfig +++ b/src/mainboard/intel/kblrvp/Kconfig @@ -8,7 +8,7 @@ select HAVE_ACPI_TABLES select HAVE_OPTION_TABLE select HAVE_SMI_HANDLER - select SOC_INTEL_COMMON_BLOCK_HDA_VERB if BOARD_INTEL_KBLRVP3 || BOARD_INTEL_KBLRVP7 + select SOC_INTEL_COMMON_BLOCK_HDA_VERB if !BOARD_INTEL_KBLRVP8 select SOC_INTEL_SKYLAKE select SKYLAKE_SOC_PCH_H if BOARD_INTEL_KBLRVP8 select MAINBOARD_USES_FSP2_0 -- To view, visit https://review.coreboot.org/c/coreboot/+/30267 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I64d18ab62cfc08b5560dbcf1b77e975eb68c8d30 Gerrit-Change-Number: 30267 Gerrit-PatchSet: 2 Gerrit-Owner: PraveenX Hodagatta Pranesh <praveenx.hodagatta.pranesh(a)intel.com> Gerrit-Reviewer: Boon Tiong Teo <boon.tiong.teo(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: PraveenX Hodagatta Pranesh <praveenx.hodagatta.pranesh(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in ...coreboot[master]: util/xcompile/xcompile: Enable x86_64 support
by Patrick Georgi (Code Review) 20 Dec '18

20 Dec '18

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/29877 ) Change subject: util/xcompile/xcompile: Enable x86_64 support ...................................................................... util/xcompile/xcompile: Enable x86_64 support Similar to i686 on x86_32, compile for nocona on x86_64. Nocona is the first Pentium 4 CPU that has long mode support. Required for 64bit support. Change-Id: Ied28f98f89610a748be8d66cf35814e9112a4407 Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> Reviewed-on: https://review.coreboot.org/c/29877 Reviewed-by: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M util/xcompile/xcompile 1 file changed, 7 insertions(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Philipp Deppenwiese: Looks good to me, approved diff --git a/util/xcompile/xcompile b/util/xcompile/xcompile index d416e5d..58f60f0 100755 --- a/util/xcompile/xcompile +++ b/util/xcompile/xcompile @@ -236,7 +236,13 @@ # The Quark processor doesn't support the instructions # introduced with the Pentium 6 architecture, so allow it # to use i586 instead. -if [ "${TARCH}" = "x86_64" ] || [ "${TARCH}" = "x86_32" ]; then +if [ "${TARCH}" = "x86_64" ]; then +cat <<EOF + GCC_CFLAGS_${TARCH} += -march=nocona +EOF +fi + +if [ "${TARCH}" = "x86_32" ]; then cat <<EOF ifneq (\$(CONFIG_USE_MARCH_586)\$(CONFIG_LP_USE_MARCH_586),) -- To view, visit https://review.coreboot.org/c/coreboot/+/29877 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ied28f98f89610a748be8d66cf35814e9112a4407 Gerrit-Change-Number: 29877 Gerrit-PatchSet: 8 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in ...coreboot[master]: TEST ME (for coreboot 4.9)
by Nico Huber (Code Review) 20 Dec '18

20 Dec '18

Nico Huber has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/30323 ) Change subject: TEST ME (for coreboot 4.9) ...................................................................... Abandoned release is out -- To view, visit https://review.coreboot.org/c/coreboot/+/30323 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia482d2b5f5d289bcaed7afd4f474e65a6672de0f Gerrit-Change-Number: 30323 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

Change in ...coreboot[master]: drivers/generic/bayhub: Add reset capability
by Nico Huber (Code Review) 20 Dec '18

20 Dec '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30319 ) Change subject: drivers/generic/bayhub: Add reset capability ...................................................................... Patch Set 3: (1 comment) https://review.coreboot.org/#/c/30319/2/src/drivers/generic/bayhub/bh720.c File src/drivers/generic/bayhub/bh720.c: https://review.coreboot.org/#/c/30319/2/src/drivers/generic/bayhub/bh720.c@… PS2, Line 91: static const unsigned short pci_device_ids[] = { > You were correct. Saved time barely 5 milliseconds. I'll try an experiment with code at romstage. Hmmm, that's really little. I'm confused. You can't load depthcharge in 5ms, can you? -- To view, visit https://review.coreboot.org/c/coreboot/+/30319 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic3878ee782c8da1a28c6d669dd7eceda7c8cf4e5 Gerrit-Change-Number: 30319 Gerrit-PatchSet: 3 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: Daniel Kurtz <djkurtz(a)google.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: Simon Glass <sjg(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 20 Dec 2018 21:12:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: emulattion/qemu-{i440fx, q35}: Don't migrate globals
by Arthur Heymans (Code Review) 20 Dec '18

20 Dec '18

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30346 Change subject: emulattion/qemu-{i440fx,q35}: Don't migrate globals ...................................................................... emulattion/qemu-{i440fx,q35}: Don't migrate globals Migration of globals is not needed as there is no real CAR that gets torn down. Change-Id: Id24642b49fab811e59291747eda8632cd49d83d0 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/mainboard/emulation/qemu-i440fx/Kconfig M src/mainboard/emulation/qemu-q35/Kconfig 2 files changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/30346/1 diff --git a/src/mainboard/emulation/qemu-i440fx/Kconfig b/src/mainboard/emulation/qemu-i440fx/Kconfig index 7e991b6..eb9f011 100644 --- a/src/mainboard/emulation/qemu-i440fx/Kconfig +++ b/src/mainboard/emulation/qemu-i440fx/Kconfig @@ -13,6 +13,7 @@ select MAINBOARD_HAS_NATIVE_VGA_INIT select MAINBOARD_FORCE_NATIVE_VGA_INIT select BOOTBLOCK_CONSOLE + select NO_CAR_GLOBAL_MIGRATION config MAINBOARD_DIR string diff --git a/src/mainboard/emulation/qemu-q35/Kconfig b/src/mainboard/emulation/qemu-q35/Kconfig index fdd8890..1cc7148 100644 --- a/src/mainboard/emulation/qemu-q35/Kconfig +++ b/src/mainboard/emulation/qemu-q35/Kconfig @@ -12,6 +12,7 @@ select MAINBOARD_HAS_NATIVE_VGA_INIT select MAINBOARD_FORCE_NATIVE_VGA_INIT select BOOTBLOCK_CONSOLE + select NO_CAR_GLOBAL_MIGRATION config MAINBOARD_DIR string -- To view, visit https://review.coreboot.org/c/coreboot/+/30346 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id24642b49fab811e59291747eda8632cd49d83d0 Gerrit-Change-Number: 30346 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newchange

1 0

Change in ...coreboot[master]: mb/qemu-{i440fx, q35}: Use POSTCAR stage to load the ramstage
by Arthur Heymans (Code Review) 20 Dec '18

20 Dec '18

Arthur Heymans has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/30332 ) Change subject: mb/qemu-{i440fx,q35}: Use POSTCAR stage to load the ramstage ...................................................................... Abandoned This makes no sense. there is no CAR so globals are directly accessible all the time... -- To view, visit https://review.coreboot.org/c/coreboot/+/30332 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id73632afbef1c7f0845153bc01c6c21e87386710 Gerrit-Change-Number: 30332 Gerrit-PatchSet: 4 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: abandon

1 0

Change in ...coreboot[master]: drivers/generic/bayhub: Add reset capability
by Richard Spiegel (Code Review) 20 Dec '18

20 Dec '18

Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30319 ) Change subject: drivers/generic/bayhub: Add reset capability ...................................................................... Patch Set 3: (1 comment) https://review.coreboot.org/#/c/30319/2/src/drivers/generic/bayhub/bh720.c File src/drivers/generic/bayhub/bh720.c: https://review.coreboot.org/#/c/30319/2/src/drivers/generic/bayhub/bh720.c@… PS2, Line 91: static const unsigned short pci_device_ids[] = { > I know. I would have preferred romstage. […] You were correct. Saved time barely 5 milliseconds. I'll try an experiment with code at romstage. -- To view, visit https://review.coreboot.org/c/coreboot/+/30319 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic3878ee782c8da1a28c6d669dd7eceda7c8cf4e5 Gerrit-Change-Number: 30319 Gerrit-PatchSet: 3 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: Daniel Kurtz <djkurtz(a)google.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: Simon Glass <sjg(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 20 Dec 2018 18:37:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: mb/qemu-{i440fx, q35}: Use POSTCAR stage to load the ramstage
by Arthur Heymans (Code Review) 20 Dec '18

20 Dec '18

Hello Patrick Rudolph, build bot (Jenkins), Patrick Georgi, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/30332 to look at the new patch set (#4). Change subject: mb/qemu-{i440fx,q35}: Use POSTCAR stage to load the ramstage ...................................................................... mb/qemu-{i440fx,q35}: Use POSTCAR stage to load the ramstage qemu does not have a real CAR but postcar stage is still useful to avoid unneeded romstage globals migration. Change-Id: Id73632afbef1c7f0845153bc01c6c21e87386710 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/lib/Makefile.inc M src/mainboard/emulation/qemu-i440fx/Kconfig M src/mainboard/emulation/qemu-i440fx/Makefile.inc A src/mainboard/emulation/qemu-i440fx/exit_car.S M src/mainboard/emulation/qemu-i440fx/romstage.c M src/mainboard/emulation/qemu-q35/Kconfig M src/mainboard/emulation/qemu-q35/Makefile.inc M src/mainboard/emulation/qemu-q35/romstage.c 8 files changed, 41 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/30332/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/30332 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id73632afbef1c7f0845153bc01c6c21e87386710 Gerrit-Change-Number: 30332 Gerrit-PatchSet: 4 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newpatchset

1 0

Change in ...coreboot[master]: mb/qemu-{i440fx, q35}: Use POSTCAR stage to load the ramstage
by Patrick Rudolph (Code Review) 20 Dec '18

20 Dec '18

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30332 ) Change subject: mb/qemu-{i440fx,q35}: Use POSTCAR stage to load the ramstage ...................................................................... Patch Set 3: (1 comment) https://review.coreboot.org/#/c/30332/3/src/mainboard/emulation/qemu-i440fx… File src/mainboard/emulation/qemu-i440fx/exit_car.S: https://review.coreboot.org/#/c/30332/3/src/mainboard/emulation/qemu-i440fx… PS3, Line 19: * This path for CAR teardown is taken when CONFIG_FSP_CAR is employed. CONFIG_FSP_CAR ? -- To view, visit https://review.coreboot.org/c/coreboot/+/30332 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id73632afbef1c7f0845153bc01c6c21e87386710 Gerrit-Change-Number: 30332 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Thu, 20 Dec 2018 18:10:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: mb/qemu-{i440fx, q35}: Use POSTCAR stage to load the ramstage
by Arthur Heymans (Code Review) 20 Dec '18

20 Dec '18

Hello Patrick Rudolph, build bot (Jenkins), Patrick Georgi, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/30332 to look at the new patch set (#3). Change subject: mb/qemu-{i440fx,q35}: Use POSTCAR stage to load the ramstage ...................................................................... mb/qemu-{i440fx,q35}: Use POSTCAR stage to load the ramstage qemu does not have a real CAR but postcar stage is still useful to avoid unneeded romstage globals migration. Change-Id: Id73632afbef1c7f0845153bc01c6c21e87386710 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/lib/Makefile.inc M src/mainboard/emulation/qemu-i440fx/Kconfig M src/mainboard/emulation/qemu-i440fx/Makefile.inc A src/mainboard/emulation/qemu-i440fx/exit_car.S M src/mainboard/emulation/qemu-i440fx/romstage.c M src/mainboard/emulation/qemu-q35/Kconfig M src/mainboard/emulation/qemu-q35/Makefile.inc M src/mainboard/emulation/qemu-q35/romstage.c 8 files changed, 51 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/30332/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/30332 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id73632afbef1c7f0845153bc01c6c21e87386710 Gerrit-Change-Number: 30332 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2018