coreboot-gerrit December 2018

coreboot-gerrit@coreboot.org

1 participants
1832 discussions

Change in ...coreboot[master]: mb/google/hatch: Fixes to initial hatch mainboard checkin
by Subrata Banik (Code Review) 21 Dec '18

21 Dec '18

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30296 ) Change subject: mb/google/hatch: Fixes to initial hatch mainboard checkin ...................................................................... Patch Set 8: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/30296 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4e311c68873f10f71314e44d3a714639a06dbee8 Gerrit-Change-Number: 30296 Gerrit-PatchSet: 8 Gerrit-Owner: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 21 Dec 2018 09:20:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: mb/google/hatch: Add EC trigger events and acpi configs
by Subrata Banik (Code Review) 21 Dec '18

21 Dec '18

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30281 ) Change subject: mb/google/hatch: Add EC trigger events and acpi configs ...................................................................... Patch Set 7: (1 comment) https://review.coreboot.org/#/c/30281/7/src/mainboard/google/hatch/variants… File src/mainboard/google/hatch/variants/baseboard/include/baseboard/ec.h: https://review.coreboot.org/#/c/30281/7/src/mainboard/google/hatch/variants… PS7, Line 79: SIO_EC_ENABLE_PS2K > Yes, I think this can be part of this CL since we are enabling ACPI configs for other EC ACPI device […] i'm okay, even i'm okay to add tablet related flag if this is 2-in 1 design -- To view, visit https://review.coreboot.org/c/coreboot/+/30281 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3a86f609c269cb59e546fc7ba4ba032e5ea8341a Gerrit-Change-Number: 30281 Gerrit-PatchSet: 7 Gerrit-Owner: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 21 Dec 2018 09:18:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subrata.banik(a)intel.com> Comment-In-Reply-To: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: mb/google/hatch: Fixes to initial hatch mainboard checkin
by V Sowmya (Code Review) 21 Dec '18

21 Dec '18

V Sowmya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30296 ) Change subject: mb/google/hatch: Fixes to initial hatch mainboard checkin ...................................................................... Patch Set 8: (1 comment) https://review.coreboot.org/#/c/30296/6/src/mainboard/google/hatch/Kconfig File src/mainboard/google/hatch/Kconfig: https://review.coreboot.org/#/c/30296/6/src/mainboard/google/hatch/Kconfig@… PS6, Line 16: > correction , I believe this would be needed. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/30296 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4e311c68873f10f71314e44d3a714639a06dbee8 Gerrit-Change-Number: 30296 Gerrit-PatchSet: 8 Gerrit-Owner: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 21 Dec 2018 09:14:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: mb/google/hatch: Fixes to initial hatch mainboard checkin
by V Sowmya (Code Review) 21 Dec '18

21 Dec '18

V Sowmya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30296 ) Change subject: mb/google/hatch: Fixes to initial hatch mainboard checkin ...................................................................... Patch Set 8: (3 comments) https://review.coreboot.org/#/c/30296/6/src/mainboard/google/hatch/Kconfig File src/mainboard/google/hatch/Kconfig: https://review.coreboot.org/#/c/30296/6/src/mainboard/google/hatch/Kconfig@… PS6, Line 5: : : > Need it now for Trackpad and TPM Done https://review.coreboot.org/#/c/30296/7/src/mainboard/google/hatch/chromeos… File src/mainboard/google/hatch/chromeos.fmd: https://review.coreboot.org/#/c/30296/7/src/mainboard/google/hatch/chromeos… PS7, Line 32: > please adjust the subsequent sections' base and size so as to not leave any unmapped areas Done https://review.coreboot.org/#/c/30296/7/src/mainboard/google/hatch/chromeos… PS7, Line 4: SI_ME > u can safely say to avoid having unused section there […] I have set SI_ALL=3MB and aligned the base and sizes. -- To view, visit https://review.coreboot.org/c/coreboot/+/30296 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4e311c68873f10f71314e44d3a714639a06dbee8 Gerrit-Change-Number: 30296 Gerrit-PatchSet: 8 Gerrit-Owner: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 21 Dec 2018 09:13:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subrata.banik(a)intel.com> Comment-In-Reply-To: Aamir Bohra <aamir.bohra(a)intel.com> Comment-In-Reply-To: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: mb/google/hatch: Fixes to initial hatch mainboard checkin
by V Sowmya (Code Review) 21 Dec '18

21 Dec '18

V Sowmya has uploaded a new patch set (#8) to the change originally created by Shelley Chen. ( https://review.coreboot.org/c/coreboot/+/30296 ) Change subject: mb/google/hatch: Fixes to initial hatch mainboard checkin ...................................................................... mb/google/hatch: Fixes to initial hatch mainboard checkin Incorporating some feedback to initial hatch mainboard checking (CL:30169) that came in after the CL merged. Updated the chromeos.fmd with the following, * SI_ALL = 3MB * SI_BIOS = 16MB BUG=b:20914069 BRANCH=None TEST=./util/abuild/abuild -p none -t google/hatch -x -a -v Change-Id: I4e311c68873f10f71314e44d3a714639a06dbee8 Signed-off-by: Shelley Chen <shchen(a)google.com> Signed-off-by: V Sowmya <v.sowmya(a)intel.com> --- M src/mainboard/google/hatch/Kconfig M src/mainboard/google/hatch/chromeos.c M src/mainboard/google/hatch/chromeos.fmd M src/mainboard/google/hatch/variants/baseboard/gpio.c M src/mainboard/google/hatch/variants/baseboard/include/baseboard/gpio.h D src/mainboard/google/hatch/variants/hatch/overridetree.cb 6 files changed, 29 insertions(+), 106 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/30296/8 -- To view, visit https://review.coreboot.org/c/coreboot/+/30296 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4e311c68873f10f71314e44d3a714639a06dbee8 Gerrit-Change-Number: 30296 Gerrit-PatchSet: 8 Gerrit-Owner: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in ...coreboot[master]: src: Get rid of device_t
by Patrick Rudolph (Code Review) 21 Dec '18

21 Dec '18

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30047 ) Change subject: src: Get rid of device_t ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/30047 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie05869901ac33d7089e21110f46c1241f7ee731f Gerrit-Change-Number: 30047 Gerrit-PatchSet: 3 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 21 Dec 2018 09:11:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: google/kukui: Enable cr50 over SPI
by You-Cheng Syu (Code Review) 21 Dec '18

21 Dec '18

You-Cheng Syu has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/29689 ) Change subject: google/kukui: Enable cr50 over SPI ...................................................................... Abandoned no longer needed -- To view, visit https://review.coreboot.org/c/coreboot/+/29689 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I46f730f7e02160c361bfc7f7a4e910b24349c5b7 Gerrit-Change-Number: 29689 Gerrit-PatchSet: 1 Gerrit-Owner: You-Cheng Syu <youcheng(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

Change in ...coreboot[master]: util/xcompile/xcompile: Use tab for indent
by HAOUAS Elyes (Code Review) 21 Dec '18

21 Dec '18

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30352 Change subject: util/xcompile/xcompile: Use tab for indent ...................................................................... util/xcompile/xcompile: Use tab for indent Change-Id: I9878e6d962004003e2c05a6cdb8ecb0a3a02ae66 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M util/xcompile/xcompile 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/30352/1 diff --git a/util/xcompile/xcompile b/util/xcompile/xcompile index 58f60f0..0fefff2 100755 --- a/util/xcompile/xcompile +++ b/util/xcompile/xcompile @@ -238,7 +238,7 @@ # to use i586 instead. if [ "${TARCH}" = "x86_64" ]; then cat <<EOF - GCC_CFLAGS_${TARCH} += -march=nocona + GCC_CFLAGS_${TARCH} += -march=nocona EOF fi -- To view, visit https://review.coreboot.org/c/coreboot/+/30352 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9878e6d962004003e2c05a6cdb8ecb0a3a02ae66 Gerrit-Change-Number: 30352 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

Change in ...coreboot[master]: security/vboot: Add new hook function verstage_soc_init
by You-Cheng Syu (Code Review) 21 Dec '18

21 Dec '18

You-Cheng Syu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30351 Change subject: security/vboot: Add new hook function verstage_soc_init ...................................................................... security/vboot: Add new hook function verstage_soc_init Some SoCs might have some common initialization steps need to be done. Add a new hook function verstage_soc_init so that we don't have to duplicate those code again and again for every board. BRANCH=none BUG=b:120588396 TEST=manually print some message to console in the new hook function Change-Id: I31a43ae42f828a9439c03433cba19631b96408ff Signed-off-by: You-Cheng Syu <youcheng(a)google.com> --- M src/security/vboot/vboot_common.h M src/security/vboot/verstage.c 2 files changed, 7 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/30351/1 diff --git a/src/security/vboot/vboot_common.h b/src/security/vboot/vboot_common.h index 61f5931..dc8286f 100644 --- a/src/security/vboot/vboot_common.h +++ b/src/security/vboot/vboot_common.h @@ -102,6 +102,7 @@ */ void verstage_main(void); void verstage_mainboard_init(void); +void verstage_soc_init(void); /* Check boot modes */ #if IS_ENABLED(CONFIG_VBOOT) diff --git a/src/security/vboot/verstage.c b/src/security/vboot/verstage.c index afd73f1..089ecb5 100644 --- a/src/security/vboot/verstage.c +++ b/src/security/vboot/verstage.c @@ -19,6 +19,11 @@ #include <program_loading.h> #include <security/vboot/vboot_common.h> +void __weak verstage_soc_init(void) +{ + /* Default empty implementation. */ +} + void __weak verstage_mainboard_init(void) { /* Default empty implementation. */ @@ -28,6 +33,7 @@ { console_init(); exception_init(); + verstage_soc_init(); verstage_mainboard_init(); if (IS_ENABLED(CONFIG_VBOOT_RETURN_FROM_VERSTAGE)) { -- To view, visit https://review.coreboot.org/c/coreboot/+/30351 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I31a43ae42f828a9439c03433cba19631b96408ff Gerrit-Change-Number: 30351 Gerrit-PatchSet: 1 Gerrit-Owner: You-Cheng Syu <youcheng(a)google.com> Gerrit-MessageType: newchange

1 0

Change in ...coreboot[master]: mb/google/hatch: Add EC trigger events and acpi configs
by Aamir Bohra (Code Review) 21 Dec '18

21 Dec '18

Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30281 ) Change subject: mb/google/hatch: Add EC trigger events and acpi configs ...................................................................... Patch Set 11: (1 comment) https://review.coreboot.org/#/c/30281/7/src/mainboard/google/hatch/variants… File src/mainboard/google/hatch/variants/baseboard/include/baseboard/ec.h: https://review.coreboot.org/#/c/30281/7/src/mainboard/google/hatch/variants… PS7, Line 79: * __BASEBOARD_EC_H > aamir have u added this line to enable PS2 keyboard like DE? […] Yes, I think this can be part of this CL since we are enabling ACPI configs for other EC ACPI devices(ALS, PD device) also here, I'll update the commit message to highlight the same. Thoughts? -- To view, visit https://review.coreboot.org/c/coreboot/+/30281 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3a86f609c269cb59e546fc7ba4ba032e5ea8341a Gerrit-Change-Number: 30281 Gerrit-PatchSet: 11 Gerrit-Owner: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 21 Dec 2018 08:15:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subrata.banik(a)intel.com> Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2018