coreboot-gerrit December 2018

coreboot-gerrit@coreboot.org

1 participants
1832 discussions

Change in ...coreboot[master]: util/cbfstool/cbfstool.c: Fix typo
by Frans Hendriks (Code Review) 21 Dec '18

21 Dec '18

Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30337 ) Change subject: util/cbfstool/cbfstool.c: Fix typo ...................................................................... Patch Set 2: > Patch Set 1: Code-Review+2 > > (1 comment) Corrected -- To view, visit https://review.coreboot.org/c/coreboot/+/30337 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6dc2f150d8ec245070257384b406a570498400b2 Gerrit-Change-Number: 30337 Gerrit-PatchSet: 2 Gerrit-Owner: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Tristan Corrick <tristan(a)corrick.kiwi> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 21 Dec 2018 14:41:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: util/cbfstool/cbfstool.c: Fix typo
by Frans Hendriks (Code Review) 21 Dec '18

21 Dec '18

Hello HAOUAS Elyes, Tristan Corrick, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/30337 to look at the new patch set (#2). Change subject: util/cbfstool/cbfstool.c: Fix typo ...................................................................... util/cbfstool/cbfstool.c: Fix typo Fix typo of 'top-aligned' BUG=N/A TEST=Intel CherryHill CRB Change-Id: I6dc2f150d8ec245070257384b406a570498400b2 Signed-off-by: Frans Hendriks <fhendriks(a)eltan.com> --- M util/cbfstool/cbfstool.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/30337/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/30337 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6dc2f150d8ec245070257384b406a570498400b2 Gerrit-Change-Number: 30337 Gerrit-PatchSet: 2 Gerrit-Owner: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Tristan Corrick <tristan(a)corrick.kiwi> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in ...coreboot[master]: util/cbfstool/cbfstool/cbfstool.c: Fix typo
by Tristan Corrick (Code Review) 21 Dec '18

21 Dec '18

Tristan Corrick has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30337 ) Change subject: util/cbfstool/cbfstool/cbfstool.c: Fix typo ...................................................................... Patch Set 1: Code-Review+2 (1 comment) https://review.coreboot.org/#/c/30337/1//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/30337/1//COMMIT_MSG@7 PS1, Line 7: /cbfstool One too many. -- To view, visit https://review.coreboot.org/c/coreboot/+/30337 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6dc2f150d8ec245070257384b406a570498400b2 Gerrit-Change-Number: 30337 Gerrit-PatchSet: 1 Gerrit-Owner: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Tristan Corrick <tristan(a)corrick.kiwi> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 21 Dec 2018 14:39:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: mb/google/hatch: Add HPD GPIO support for displays
by Maulik V Vaghela (Code Review) 21 Dec '18

21 Dec '18

Maulik V Vaghela has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/30363 ) Change subject: mb/google/hatch: Add HPD GPIO support for displays ...................................................................... Abandoned Rebased patch and uploaded new one based on new patches -- To view, visit https://review.coreboot.org/c/coreboot/+/30363 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie6b24535223faf37d278696a541dbf6764b2234b Gerrit-Change-Number: 30363 Gerrit-PatchSet: 1 Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

Change in ...coreboot[master]: mb/google/hatch: Enable IGD (Integrated GFX Device)
by Maulik V Vaghela (Code Review) 21 Dec '18

21 Dec '18

Maulik V Vaghela has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/30362 ) Change subject: mb/google/hatch: Enable IGD (Integrated GFX Device) ...................................................................... Abandoned Rebased patch and uploaded new one based on new patches -- To view, visit https://review.coreboot.org/c/coreboot/+/30362 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3a7d5a89a66e2fc6ea359888f9d5155fac2e718c Gerrit-Change-Number: 30362 Gerrit-PatchSet: 1 Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

Change in ...coreboot[master]: mb/google/hatch: Add HPD GPIO support for displays
by Maulik V Vaghela (Code Review) 21 Dec '18

21 Dec '18

Maulik V Vaghela has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30365 Change subject: mb/google/hatch: Add HPD GPIO support for displays ...................................................................... mb/google/hatch: Add HPD GPIO support for displays Adding hot plug detect GPIO support for external type C display in event for cable connect/disconnect. Change-Id: If9d52dc0f9916f761c8fdd88c76968aaf663e650 Signed-off-by: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> --- M src/mainboard/google/hatch/variants/baseboard/gpio.c 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/30365/1 diff --git a/src/mainboard/google/hatch/variants/baseboard/gpio.c b/src/mainboard/google/hatch/variants/baseboard/gpio.c index 69a0f37..f5e238b 100644 --- a/src/mainboard/google/hatch/variants/baseboard/gpio.c +++ b/src/mainboard/google/hatch/variants/baseboard/gpio.c @@ -33,6 +33,12 @@ PAD_CFG_GPI(GPP_C20, NONE, DEEP), /* EC_IN_RW_OD */ PAD_CFG_GPI(GPP_C22, NONE, DEEP), + /* E13 : DDPB_HPD0 ==> USB_C0_DP_HPD */ + PAD_CFG_NF(GPP_E13, NONE, DEEP, NF1), + /* E14 : DDPC_HPD1 ==> DDI2_HPD_OPL */ + PAD_CFG_NF(GPP_E14, NONE, DEEP, NF1), + /* E17 : EDP_HPD */ + PAD_CFG_NF(GPP_E17, NONE, DEEP, NF1), }; const struct pad_config *__weak variant_gpio_table(size_t *num) -- To view, visit https://review.coreboot.org/c/coreboot/+/30365 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If9d52dc0f9916f761c8fdd88c76968aaf663e650 Gerrit-Change-Number: 30365 Gerrit-PatchSet: 1 Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-MessageType: newchange

1 0

Change in ...coreboot[master]: mb/google/hatch: Enable IGD (Integrated GFX Device)
by Maulik V Vaghela (Code Review) 21 Dec '18

21 Dec '18

Maulik V Vaghela has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30364 Change subject: mb/google/hatch: Enable IGD (Integrated GFX Device) ...................................................................... mb/google/hatch: Enable IGD (Integrated GFX Device) This patch ensures following 2 features 1. Enable IGD controller in devicetree.cb 2. Pass required FSP UPD to perform internal graphics initialization Change-Id: I607199590d793a70e1e20bb3241fc34467aa829d Signed-off-by: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> --- M src/mainboard/google/hatch/variants/baseboard/devicetree.cb 1 file changed, 5 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/30364/1 diff --git a/src/mainboard/google/hatch/variants/baseboard/devicetree.cb b/src/mainboard/google/hatch/variants/baseboard/devicetree.cb index 4fe0c4c..3ecdd3c 100644 --- a/src/mainboard/google/hatch/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/hatch/variants/baseboard/devicetree.cb @@ -26,9 +26,13 @@ }, }" + # FSP configuration + register "InternalGfx" = "1" + register "SkipExtGfxScan" = "1" + device domain 0 on device pci 00.0 off end # Host Bridge - device pci 02.0 off end # Integrated Graphics Device + device pci 02.0 on end # Integrated Graphics Device device pci 04.0 off end # SA Thermal device device pci 12.0 off end # Thermal Subsystem device pci 12.5 off end # UFS SCS -- To view, visit https://review.coreboot.org/c/coreboot/+/30364 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I607199590d793a70e1e20bb3241fc34467aa829d Gerrit-Change-Number: 30364 Gerrit-PatchSet: 1 Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-MessageType: newchange

1 0

Change in ...coreboot[master]: mb/google/hatch: Fixes to initial hatch mainboard checkin
by Maulik V Vaghela (Code Review) 21 Dec '18

21 Dec '18

Maulik V Vaghela has uploaded a new patch set (#10) to the change originally created by Shelley Chen. ( https://review.coreboot.org/c/coreboot/+/30296 ) Change subject: mb/google/hatch: Fixes to initial hatch mainboard checkin ...................................................................... mb/google/hatch: Fixes to initial hatch mainboard checkin Incorporating some feedback to initial hatch mainboard checking (CL:30169) that came in after the CL merged. Updated the chromeos.fmd with the following, * SI_ALL = 3MB * SI_BIOS = 16MB BUG=b:20914069 BRANCH=None TEST=./util/abuild/abuild -p none -t google/hatch -x -a -v Change-Id: I4e311c68873f10f71314e44d3a714639a06dbee8 Signed-off-by: Shelley Chen <shchen(a)google.com> Signed-off-by: V Sowmya <v.sowmya(a)intel.com> --- M src/mainboard/google/hatch/Kconfig M src/mainboard/google/hatch/chromeos.c M src/mainboard/google/hatch/chromeos.fmd M src/mainboard/google/hatch/variants/baseboard/gpio.c M src/mainboard/google/hatch/variants/baseboard/include/baseboard/gpio.h D src/mainboard/google/hatch/variants/hatch/overridetree.cb 6 files changed, 29 insertions(+), 106 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/30296/10 -- To view, visit https://review.coreboot.org/c/coreboot/+/30296 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4e311c68873f10f71314e44d3a714639a06dbee8 Gerrit-Change-Number: 30296 Gerrit-PatchSet: 10 Gerrit-Owner: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in ...coreboot[master]: drivers/generic/bayhub: Add reset capability
by Richard Spiegel (Code Review) 21 Dec '18

21 Dec '18

Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30319 ) Change subject: drivers/generic/bayhub: Add reset capability ...................................................................... Patch Set 3: (1 comment) https://review.coreboot.org/#/c/30319/2/src/drivers/generic/bayhub/bh720.c File src/drivers/generic/bayhub/bh720.c: https://review.coreboot.org/#/c/30319/2/src/drivers/generic/bayhub/bh720.c@… PS2, Line 91: static const unsigned short pci_device_ids[] = { > Hmmm, that's really little. I'm confused. […] Depthcharge is actually fast, it's just a secure loader. What takes time is the actual loading of the OS. But obviously, once the OS starts loading, eMMC is already working. Depthcharge is loaded from the flash, selects where to load from, checks some security (not sure which, but would assume TPM related). and loads the OS (normally chrome OS). -- To view, visit https://review.coreboot.org/c/coreboot/+/30319 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic3878ee782c8da1a28c6d669dd7eceda7c8cf4e5 Gerrit-Change-Number: 30319 Gerrit-PatchSet: 3 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: Daniel Kurtz <djkurtz(a)google.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: Simon Glass <sjg(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 21 Dec 2018 14:15:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: Documentation/nb/intel: Add Haswell documentation
by Nico Huber (Code Review) 21 Dec '18

21 Dec '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30356 ) Change subject: Documentation/nb/intel: Add Haswell documentation ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/30356 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I84e8ca2543b2e19b84a24f7d7032a4aedb6e9272 Gerrit-Change-Number: 30356 Gerrit-PatchSet: 1 Gerrit-Owner: Tristan Corrick <tristan(a)corrick.kiwi> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tristan Corrick <tristan(a)corrick.kiwi> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 21 Dec 2018 13:33:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2018