coreboot-gerrit January 2018

coreboot-gerrit@coreboot.org

1 participants
2315 discussions

Change in coreboot[master]: mainboard/glkrvp: Add EC_GOOGLE_CHROMEEC_SWITCHES
by build bot (Jenkins) (Code Review) 03 Jan '18

03 Jan '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23066 ) Change subject: mainboard/glkrvp: Add EC_GOOGLE_CHROMEEC_SWITCHES ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/65191/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/19931/ : SUCCESS -- To view, visit https://review.coreboot.org/23066 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib454f10a144d600a87d2f69d80d5d46f16c407f8 Gerrit-Change-Number: 23066 Gerrit-PatchSet: 1 Gerrit-Owner: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 02 Jan 2018 23:48:57 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mainboard/glkrvp: Add EC_GOOGLE_CHROMEEC_SWITCHES
by Srinidhi N Kaushik (Code Review) 03 Jan '18

03 Jan '18

Hello Shaunak Saha, I'd like you to do a code review. Please visit https://review.coreboot.org/23066 to review the following change. Change subject: mainboard/glkrvp: Add EC_GOOGLE_CHROMEEC_SWITCHES ...................................................................... mainboard/glkrvp: Add EC_GOOGLE_CHROMEEC_SWITCHES This patch adds the EC_GOOGLE_CHROMEEC_SWITCHES option so that we use the common switch.c file Signed-off-by: Shaunak Saha <shaunak.saha(a)intel.com> Change-Id: Ib454f10a144d600a87d2f69d80d5d46f16c407f8 --- M src/mainboard/intel/glkrvp/Kconfig M src/mainboard/intel/glkrvp/chromeos.c 2 files changed, 3 insertions(+), 27 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/23066/1 diff --git a/src/mainboard/intel/glkrvp/Kconfig b/src/mainboard/intel/glkrvp/Kconfig index dfb53b8..243414b 100644 --- a/src/mainboard/intel/glkrvp/Kconfig +++ b/src/mainboard/intel/glkrvp/Kconfig @@ -43,6 +43,9 @@ select GBB_FLAG_DISABLE_EC_SOFTWARE_SYNC select VBOOT_LID_SWITCH +config VBOOT + select EC_GOOGLE_CHROMEEC_SWITCHES + config MAINBOARD_DIR string default intel/glkrvp diff --git a/src/mainboard/intel/glkrvp/chromeos.c b/src/mainboard/intel/glkrvp/chromeos.c index b7f56ec..a87ce4a 100644 --- a/src/mainboard/intel/glkrvp/chromeos.c +++ b/src/mainboard/intel/glkrvp/chromeos.c @@ -35,39 +35,12 @@ lb_add_gpios(gpios, chromeos_gpios, ARRAY_SIZE(chromeos_gpios)); } -int get_lid_switch(void) -{ - if (IS_ENABLED(CONFIG_EC_GOOGLE_CHROMEEC)) - /* Read lid switch state from the EC. */ - return !!(google_chromeec_get_switches() & EC_SWITCH_LID_OPEN); - else - return 1; -} - int get_developer_mode_switch(void) { /* No physical developer mode switch. It's virtual. */ return 0; } -int get_recovery_mode_switch(void) -{ - if (!IS_ENABLED(CONFIG_EC_GOOGLE_CHROMEEC)) - return 0; - /* Check if the EC has posted the keyboard recovery event. */ - return !!(google_chromeec_get_events_b() & - EC_HOST_EVENT_MASK(EC_HOST_EVENT_KEYBOARD_RECOVERY)); -} - -int clear_recovery_mode_switch(void) -{ - if (!IS_ENABLED(CONFIG_EC_GOOGLE_CHROMEEC)) - return 0; - /* Clear keyboard recovery event. */ - return google_chromeec_clear_events_b( - EC_HOST_EVENT_MASK(EC_HOST_EVENT_KEYBOARD_RECOVERY)); -} - int get_write_protect_state(void) { return 0; -- To view, visit https://review.coreboot.org/23066 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ib454f10a144d600a87d2f69d80d5d46f16c407f8 Gerrit-Change-Number: 23066 Gerrit-PatchSet: 1 Gerrit-Owner: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com>

1 0

Change in coreboot[master]: soc/amd/stoneyridge/southbridge.c: Create a GPIO programming function
by build bot (Jenkins) (Code Review) 03 Jan '18

03 Jan '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22986 ) Change subject: soc/amd/stoneyridge/southbridge.c: Create a GPIO programming function ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19930/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/65190/ : SUCCESS -- To view, visit https://review.coreboot.org/22986 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I88d65c78a186bed9739bc208d5711a31aa3c3bb6 Gerrit-Change-Number: 22986 Gerrit-PatchSet: 2 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 02 Jan 2018 23:46:32 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/amd/stoneyridge: Add I2C support
by build bot (Jenkins) (Code Review) 03 Jan '18

03 Jan '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22959 ) Change subject: soc/amd/stoneyridge: Add I2C support ...................................................................... Patch Set 9: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19929/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/65189/ : SUCCESS -- To view, visit https://review.coreboot.org/22959 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id940af917c9525aba7bc25eea0821f5f36a36653 Gerrit-Change-Number: 22959 Gerrit-PatchSet: 9 Gerrit-Owner: Chris Ching <chingcodes(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Chris Ching <chingcodes(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 02 Jan 2018 23:03:06 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/intel/cannonlake: Program DMI PCR settings
by build bot (Jenkins) (Code Review) 02 Jan '18

02 Jan '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22970 ) Change subject: soc/intel/cannonlake: Program DMI PCR settings ...................................................................... Patch Set 13: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19928/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/65188/ : SUCCESS -- To view, visit https://review.coreboot.org/22970 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6b8f393c92cbd0632fed86212ae384ff53c9f8c3 Gerrit-Change-Number: 22970 Gerrit-PatchSet: 13 Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: John Zhao <john.zhao(a)intel.com> Gerrit-Reviewer: Krzysztof M Sywula <krzysztof.m.sywula(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 02 Jan 2018 22:56:50 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: soc/amd/stoneyridge: Define CONSOLE_UART_BASE_ADDRESS
by build bot (Jenkins) (Code Review) 02 Jan '18

02 Jan '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23065 ) Change subject: soc/amd/stoneyridge: Define CONSOLE_UART_BASE_ADDRESS ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19927/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/65187/ : SUCCESS -- To view, visit https://review.coreboot.org/23065 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I962f750f89e0352082e0b7415ceaa9bd350fdf0b Gerrit-Change-Number: 23065 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 02 Jan 2018 22:49:55 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/amd/stoneyridge: Define CONSOLE_UART_BASE_ADDRESS
by Arthur Heymans (Code Review) 02 Jan '18

02 Jan '18

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/23065 Change subject: soc/amd/stoneyridge: Define CONSOLE_UART_BASE_ADDRESS ...................................................................... soc/amd/stoneyridge: Define CONSOLE_UART_BASE_ADDRESS The build system for the SeaBIOS payload needs this when DRIVERS_UART_8250MEM is set. Set it to the first uart controller, which the coreboot code also seems to do. Change-Id: I962f750f89e0352082e0b7415ceaa9bd350fdf0b Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/soc/amd/stoneyridge/Kconfig 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/23065/1 diff --git a/src/soc/amd/stoneyridge/Kconfig b/src/soc/amd/stoneyridge/Kconfig index 58b940d..ae8360a 100644 --- a/src/soc/amd/stoneyridge/Kconfig +++ b/src/soc/amd/stoneyridge/Kconfig @@ -283,6 +283,12 @@ to FEDC_6FFFh. UART controller 1 registers range from FEDC_8000h to FEDC_8FFFh. +config CONSOLE_UART_BASE_ADDRESS + depends on CONSOLE_SERIAL + hex + default 0xfedc6000 + + config SMM_TSEG_SIZE hex default 0x800000 if SMM_TSEG && HAVE_SMI_HANDLER -- To view, visit https://review.coreboot.org/23065 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I962f750f89e0352082e0b7415ceaa9bd350fdf0b Gerrit-Change-Number: 23065 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>

1 0

Change in coreboot[master]: soc/amd/common/block/pi: Format files to standards
by build bot (Jenkins) (Code Review) 02 Jan '18

02 Jan '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22823 ) Change subject: soc/amd/common/block/pi: Format files to standards ...................................................................... Patch Set 5: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19924/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/65184/ : SUCCESS -- To view, visit https://review.coreboot.org/22823 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iefe741cd62bc41a7975c3dd10ac9355352de3abb Gerrit-Change-Number: 22823 Gerrit-PatchSet: 5 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshall.dawson(a)se-eng.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 02 Jan 2018 19:42:12 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/amd/common/block/pi: Format files to standards
by build bot (Jenkins) (Code Review) 02 Jan '18

02 Jan '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22823 ) Change subject: soc/amd/common/block/pi: Format files to standards ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19923/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/65183/ : SUCCESS -- To view, visit https://review.coreboot.org/22823 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iefe741cd62bc41a7975c3dd10ac9355352de3abb Gerrit-Change-Number: 22823 Gerrit-PatchSet: 4 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshall.dawson(a)se-eng.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 02 Jan 2018 19:30:52 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/intel/cannonlake: Program DMI PCR settings
by build bot (Jenkins) (Code Review) 02 Jan '18

02 Jan '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22970 ) Change subject: soc/intel/cannonlake: Program DMI PCR settings ...................................................................... Patch Set 12: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19921/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/65181/ : SUCCESS -- To view, visit https://review.coreboot.org/22970 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6b8f393c92cbd0632fed86212ae384ff53c9f8c3 Gerrit-Change-Number: 22970 Gerrit-PatchSet: 12 Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: John Zhao <john.zhao(a)intel.com> Gerrit-Reviewer: Krzysztof M Sywula <krzysztof.m.sywula(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 02 Jan 2018 18:49:40 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2018